Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45041 )
Change subject: soc/intel/xeon_sp: Select CPU_INTEL_COMMON
......................................................................
Patch Set 1:
Patch Set 1:
Hi Angel, did you try this on DeltaLake EVT server?
Rocky, CPU_INTEL_COMMON_SMM is selected once CPU_INTEL_COMMON is selected.
I forgot to add it to the commit message, but both Tioga Pass and Delta Lake remain unchanged when building with BUILD_TIMELESS=1. Without adding the config into the coreboot.rom, the resulting timeless coreboot.rom before and after applying this commit are identical.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45041
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I565e75869be730e7c2fe7114b829941bc9890e6c
Gerrit-Change-Number: 45041
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rocky Phagura
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 04 Sep 2020 13:45:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment