Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33387 )
Change subject: mainboard/emulation/qemu-aarch64: Add new board for ARMv8 ......................................................................
Patch Set 20: Code-Review+2
(1 comment)
LGTM, except for the documentation. I think it's okay to get this in first and fix the docs later unless someone has a concern about that.
I'm not sure how to add DTS to a FIT image. Currently, I got a FIT kernel image by: $ make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- $ mkimage -A arm64 -O linux -T kernel -C gzip -d vmlinux uImage $ mkimage -f auto -A arm64 -O linux -T kernel -C none -a 40000000 -e 0 -c "Kernel 4.4 image for production devices" -d uImage fitImage
You need to supply an .its script that tells it where your kernel binary and the FDT file is. See u-boot/doc/uImage.FIT/howto.txt for details.
Also, linux kernel seems too big as a payload. How can I deal with that? E: Could not add [fitImage, 304985299 bytes (297837 KB)@0x0]; too big?
Yeah, 300MB is likely not going to work for multiple reasons. Do you have a giant initramfs in there? Try to cut that down to the absolute necessary (e.g. just a simple shell) and see if that works.
https://review.coreboot.org/c/coreboot/+/33387/18/src/mainboard/emulation/qe... File src/mainboard/emulation/qemu-aarch64/mmio.c:
https://review.coreboot.org/c/coreboot/+/33387/18/src/mainboard/emulation/qe... PS18, Line 14: // TODO: Return VIRT_SECURE_UART_BASE when QEMU works on a secure mode.
I can get debug messages by VIRT_UART_BASE but coreboot doesn't output anything to my console by VIR […]
Yes, unless you actually know something that needs to be done here in the future, you should probably remove the TODO.