LGTM, except for the documentation. I think it's okay to get this in first and fix the docs later unless someone has a concern about that.

I'm not sure how to add DTS to a FIT image.
Currently, I got a FIT kernel image by:
$ make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu-
$ mkimage -A arm64 -O linux -T kernel -C gzip -d vmlinux uImage
$ mkimage -f auto -A arm64 -O linux -T kernel -C none -a 40000000 -e 0 -c "Kernel 4.4 image for production devices" -d uImage fitImage

You need to supply an .its script that tells it where your kernel binary and the FDT file is. See u-boot/doc/uImage.FIT/howto.txt for details.

Also, linux kernel seems too big as a payload. How can I deal with that?
E: Could not add [fitImage, 304985299 bytes (297837 KB)@0x0]; too big?

Yeah, 300MB is likely not going to work for multiple reasons. Do you have a giant initramfs in there? Try to cut that down to the absolute necessary (e.g. just a simple shell) and see if that works.

Patch set 20:Code-Review +2

View Change

1 comment:

To view, visit change 33387. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id7c0831b1ecf08785b4ec8139d809bad9b3e1eec
Gerrit-Change-Number: 33387
Gerrit-PatchSet: 20
Gerrit-Owner: Asami Doi <d0iasm.pub@gmail.com>
Gerrit-Reviewer: Asami Doi <d0iasm.pub@gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Patrick Rudolph <siro@das-labor.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Mon, 15 Jul 2019 23:55:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Asami Doi <d0iasm.pub@gmail.com>
Comment-In-Reply-To: Julius Werner <jwerner@chromium.org>
Gerrit-MessageType: comment