Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G ......................................................................
Patch Set 173:
(5 comments)
File src/mainboard/acer/aspire_vn7_572g/gpio.c:
https://review.coreboot.org/c/coreboot/+/35523/comment/6359f49d_437d4c50 PS173, Line 68: PAD_CFG_GPI_IRQ_WAKE(GPP_B3, NONE, DEEP, LEVEL, NONE), // FIXME: Vendor configures as _GPI_APIC_HIGH. Why? line over 96 characters
https://review.coreboot.org/c/coreboot/+/35523/comment/eb7fbd9e_7c987fdf PS173, Line 238: PAD_CFG_GPI_SMI(GPP_E15, NONE, DEEP, LEVEL, INVERT), // FIXME: Vendor configures as _TERM_GPO. Why? line over 96 characters
https://review.coreboot.org/c/coreboot/+/35523/comment/d13f8455_27551dab PS173, Line 240: PAD_CFG_GPI_SCI(GPP_E16, NONE, DEEP, LEVEL, INVERT), // FIXME: Vendor configures to "PLTRST". Why? line over 96 characters
File src/mainboard/acer/aspire_vn7_572g/romstage.c:
https://review.coreboot.org/c/coreboot/+/35523/comment/0cf7e2b9_cdd91f07 PS173, Line 11: FSP_M_CONFIG *const mem_cfg = &mupd->FspmConfig; need consistent spacing around '*' (ctx:WxV)
File src/mainboard/acer/aspire_vn7_572g/smihandler.c:
https://review.coreboot.org/c/coreboot/+/35523/comment/a0d6a9d4_afd432d1 PS173, Line 83: void mainboard_smi_sleep(u8 slp_typ){} space required before the open brace '{'