Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel, Angel Pons.
5 comments:
File src/mainboard/acer/aspire_vn7_572g/gpio.c:
Patch Set #173, Line 68: PAD_CFG_GPI_IRQ_WAKE(GPP_B3, NONE, DEEP, LEVEL, NONE), // FIXME: Vendor configures as _GPI_APIC_HIGH. Why?
line over 96 characters
Patch Set #173, Line 238: PAD_CFG_GPI_SMI(GPP_E15, NONE, DEEP, LEVEL, INVERT), // FIXME: Vendor configures as _TERM_GPO. Why?
line over 96 characters
Patch Set #173, Line 240: PAD_CFG_GPI_SCI(GPP_E16, NONE, DEEP, LEVEL, INVERT), // FIXME: Vendor configures to "PLTRST". Why?
line over 96 characters
File src/mainboard/acer/aspire_vn7_572g/romstage.c:
Patch Set #173, Line 11: FSP_M_CONFIG *const mem_cfg = &mupd->FspmConfig;
need consistent spacing around '*' (ctx:WxV)
File src/mainboard/acer/aspire_vn7_572g/smihandler.c:
Patch Set #173, Line 83: void mainboard_smi_sleep(u8 slp_typ){}
space required before the open brace '{'
To view, visit change 35523. To unsubscribe, or for help writing mail filters, visit settings.