Attention is currently required from: Lance Zhao, Nico Huber, Tim Wawrzynczak. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62573 )
Change subject: coreboot_tables.c: Expose the ACPI RSDP ......................................................................
Patch Set 1:
(4 comments)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/62573/comment/6d25dff8_e706d607 PS1, Line 1591: uintptr_t coreboot_rsdp;
um, static?
Done
File src/commonlib/include/commonlib/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/62573/comment/8fec3a8e_cae1ff15 PS1, Line 586: uint64_t
Usually `lb_uint64` and no `__packed`. I don't like either way actually […]
Done
File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/62573/comment/7ef95564_1b3c54d3 PS1, Line 57: uintptr_t get_coreboot_rsdp(void);
Maybe don't mix this with #defines, or add some blank lines. Looks a bit […]
Done
File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/62573/comment/ccc8d7a0_7d9282a7 PS1, Line 537: lb_add_acpi_rsdp(head);
I guess this will need something like `if (CONFIG(ACPI))`.
Done