Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35946 )
Change subject: driver/thunderbolt: Driver for allocating hotplug resources ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35946/1/src/drivers/thunderbolt/thu... File src/drivers/thunderbolt/thunderbolt.c:
https://review.coreboot.org/c/coreboot/+/35946/1/src/drivers/thunderbolt/thu... PS1, Line 59: return PCI_SLOT(dev->path.pci.devfn) == 1; Is this defined in some standard or just happens to be the case for the JHL7540?
https://review.coreboot.org/c/coreboot/+/35946/1/src/drivers/thunderbolt/thu... PS1, Line 69: dev->hotplug_buses = 32;
I'd prefer a virtual PCI bridge instead, each having assinged one downstream device of type DEVICE_P […]
While I like this idea. The `hotplug_buses` implementation seems clean and small enough?
https://review.coreboot.org/c/coreboot/+/35946/1/src/drivers/thunderbolt/thu... PS1, Line 80: slot = alloc_dev(dev->link_list, &slot_path);
don't you need to allocate "hotplug_buses" devices, as every potential device could have two 256MiB […]
I don't follow, are you suggesting to allocate a total of 2x 8GiB? That's not even possible with non-prefetchable resources (standard bridges have only a 32-bit window, IIRC). And our allocator is also still limited to 32 bit.
Also, AIUI, 256MiB is just an arbitrary number, it's not a real limit, is it?