Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35946 ) Change subject: driver/thunderbolt: Driver for allocating hotplug resources ...................................................................... Patch Set 1: (3 comments) https://review.coreboot.org/c/coreboot/+/35946/1/src/drivers/thunderbolt/thu... File src/drivers/thunderbolt/thunderbolt.c: https://review.coreboot.org/c/coreboot/+/35946/1/src/drivers/thunderbolt/thu... PS1, Line 59: return PCI_SLOT(dev->path.pci.devfn) == 1; Is this defined in some standard or just happens to be the case for the JHL7540? https://review.coreboot.org/c/coreboot/+/35946/1/src/drivers/thunderbolt/thu... PS1, Line 69: dev->hotplug_buses = 32;
I'd prefer a virtual PCI bridge instead, each having assinged one downstream device of type DEVICE_P […] While I like this idea. The `hotplug_buses` implementation seems clean and small enough?
https://review.coreboot.org/c/coreboot/+/35946/1/src/drivers/thunderbolt/thu... PS1, Line 80: slot = alloc_dev(dev->link_list, &slot_path);
don't you need to allocate "hotplug_buses" devices, as every potential device could have two 256MiB […] I don't follow, are you suggesting to allocate a total of 2x 8GiB? That's not even possible with non-prefetchable resources (standard bridges have only a 32-bit window, IIRC). And our allocator is also still limited to 32 bit.
Also, AIUI, 256MiB is just an arbitrary number, it's not a real limit, is it? -- To view, visit https://review.coreboot.org/c/coreboot/+/35946 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I500191626584b83e6a8ae38417fd324b5e803afc Gerrit-Change-Number: 35946 Gerrit-PatchSet: 1 Gerrit-Owner: Jeremy Soller <jeremy@system76.com> Gerrit-Reviewer: Jeremy Soller <jeremy@system76.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Aaron Durbin <adurbin@chromium.org> Gerrit-CC: Duncan Laurie <dlaurie@chromium.org> Gerrit-CC: Furquan Shaikh <furquan@google.com> Gerrit-CC: Kyösti Mälkki <kyosti.malkki@gmail.com> Gerrit-CC: Matt DeVillier <matt.devillier@gmail.com> Gerrit-CC: Mimoja <coreboot@mimoja.de> Gerrit-CC: Nathaniel L Desimone <nathaniel.l.desimone@intel.com> Gerrit-CC: Nico Huber <nico.h@gmx.de> Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-CC: Subrata Banik <subrata.banik@intel.com> Gerrit-Comment-Date: Thu, 10 Oct 2019 08:00:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-MessageType: comment