Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches ......................................................................
Patch Set 37:
(1 comment)
Patch Set 37:
(1 comment)
I’d be really great, if adding the floppy images part could be integrated into the Kconfig payload section. That way, more people could use it, and your script would just select the appropriate Kconfig options.
Thank you for a great suggestion. The only thing stopping me from implementing it - is that a SeaBIOS multiple floppies patch from https://review.coreboot.org/c/coreboot/+/32351 still isn't merged yet, and without it only one floppy could be added - the others are not visible. If you're familiar with SeaBIOS code, feel free to take over my SeaBIOS patches if you'd like.
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/37/csb_patcher.sh@347 PS37, Line 347: atombios_adder
The Video BIOS option ROM contains more than just ATOMBIOS, right? Update the function name?
For the AMD cards, I think the whole ROM is occupied by AtomBIOS and its' function/data tables. Or is it wrong? I like a current name and hope its' not far from truth