build bot (Jenkins) has posted comments on this change. (
https://review.coreboot.org/c/coreboot/+/33509 )
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
......................................................................
Patch Set 25:
(69 comments)
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh
File csb_patcher.sh:
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@26
PS25, Line 26: # Asks a question '$1' and waits for Y/N user input, printing a
decision - with '$2' message if Y.
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@190
PS25, Line 190: # Downloads a file '$1' from a link '$2' using the options
'$3' and checks if this was successful.
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@214
PS25, Line 214: # Unzips the archive '$1', optional '$2' for -j path
inside the archive, and then force removes it.
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@229
PS25, Line 229: # Expands a file '$1' with zeroes using a dd to '$2' size
- e.g. to a standard floppy size 1474560.
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@242
PS25, Line 242: # Compares sha256sum of '$1.img' floppy image with '$2'
and creates a hidden '.$1' file if matches.
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@250
PS25, Line 250: printf "\n=== sha256sum should
be:\n${bold}$floppy_verifier_sha256sum_correct${bend}\n"
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@252
PS25, Line 252: printf "^^^ this is correct,
./floppies/${bold}$1.img${bend} is verified and could be added.\n\n"
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@257
PS25, Line 257: printf "${bold}^^^ ! MISMATCH for ./floppies/$1.img !
Check sha256sum manually: sha256sum ./floppies/$1.img${bend}\n"
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@269
PS25, Line 269: printf "\n${byellow}WARNING${bend}:
./floppies/${bold}$1.img${bend} - is a rolling release, its' SHA256 checksum"
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@270
PS25, Line 270: printf "\n is changing constantly and not provided by
$1 project, so not checked.\n"
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@278
PS25, Line 278: # Downloads a collection of floppies, for the purpose of adding them later
to a coreboot ROM image.
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@294
PS25, Line 294: printf "\n${byellow}WARNING${bend}: cannot get
./floppies/${bold}kolibri.img${bend} without ${bold}7za${bend}\n"
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@301
PS25, Line 301: floppy_verifier "freedos"
"de2fb84dc2f132324549e89d58c6383497ec1af538c5b0ecde389fb748b9d537"
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@304
PS25, Line 304: printf "\n${byellow}WARNING${bend}: getting
./floppies/${bold}michalos.img${bend} could take a couple of minutes...\n\n"
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@307
PS25, Line 307: floppy_verifier "michalos"
"dbce93c6ec2eca16a5a97586a905525e221fce7e7ce2e3a210b690f1408a9d9c"
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@315
PS25, Line 315: floppy_verifier "fiwix"
"6fec5d91a8a8c0d4720e2e2b7c05f94a01226e791a15b8249ee6c337c7744de6"
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@319
PS25, Line 319: floppy_verifier "memtest"
"d320f0ae56a1c65737e7bc207db22088da982f57236340abc9368860df26ea87"
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@324
PS25, Line 324: floppy_verifier "tatos"
"2c66f884498a4fe7b469bc213aebfccd84a09fd7ace1b3b4b3e747e2392c35d1"
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@330
PS25, Line 330: floppy_verifier "plop"
"f170759966ec4efe60c8531158344a234d7543c8de81e54c8c1bb9d2d69eaf27"
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@334
PS25, Line 334: floppy_verifier "floppybird"
"249f77da69ba5d3295ed0c9180e4ffc646fb24f545630448fd55d5de2aec1455"
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@346
PS25, Line 346: # Adds a './pci1002,$1.rom' to coreboot '$3' ROM using
'$2' cbfstool, printing '$4'/'$5'/'$6' info.
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@352
PS25, Line 352: printf "\n${bgreen}NOTE${bend}:
./${bold}pci1002,$1.rom${bend} for ${bold}$5 : $6${bend} is already at your $3.\n"
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@354
PS25, Line 354: if yesno "\nAdd a ./${bold}pci1002,$1.rom${bend} for
${bold}$5 : $6${bend} to your $3 now? ${bold}~$4${bend}" ", adding..." ;
then
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@358
PS25, Line 358: printf "\n${bold} $2 $3 add -f
./pci1002,$1.rom -n pci1002,$1.rom -t optionrom${bend}\n\n"
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@373
PS25, Line 373: # Adds a '$1.img' floppy image to coreboot '$3' ROM using
'$2' cbfstool, printing '$4' size info.
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@380
PS25, Line 380: printf "\n${bgreen}NOTE${bend}:
./floppies/${bold}$1.img${bend} is already at your $3.\n"
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@383
PS25, Line 383: printf "\n${byellow}WARNING${bend}:
./floppies/${bold}$1.img${bend} - is proprietary: all its' source code is closed
!"
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@384
PS25, Line 384: printf "\n Add it only if you really
need it and trust the author of $1 project.\n"
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@387
PS25, Line 387: if yesno "\nAdd a ./floppies/${bold}$1.img${bend}
to your $3 now? ${bold}~$4${bend}" ", adding..." ; then
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@388
PS25, Line 388: "$2" "$3" add -f
"./floppies/$1.img" -n "floppyimg/$1.lzma" -t raw -c lzma
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@391
PS25, Line 391: printf "\n${bold} $2 $3 add -f
./floppies/$1.img -n floppyimg/$1.lzma -t raw -c lzma${bend}\n\n"
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@396
PS25, Line 396: printf "\n${byellow}WARNING${bend}: there was a
SHA256 mismatch for ./floppies/${bold}$1.img${bend} -"
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@397
PS25, Line 397: printf "\n check sha256sum manually:
sha256sum ./floppies/${bold}$1.img${bend}\n"
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@412
PS25, Line 412: # Adds a set of AtomBIOS/floppies ('$1') to coreboot '$3'
ROM copied to '$4', using '$2' cbfstool.
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@429
PS25, Line 429: csb_patcher "atombios" "33886"
"2" "6339853"
"5c9458dbebfad86c65c93921a0b5ae52e34e0a68cb06ff655d4549cc9013b0cd"
"$1" "AMD "
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@430
PS25, Line 430: atombios_adder "990b" "$2"
"$4" "62K" "Lenovo G505S with A10-5750M" "iGPU
HD-8650G"
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@431
PS25, Line 431: atombios_adder "6663" "$2"
"$4" "33K" "Lenovo G505S with A10-5750M" "dGPU
HD-8570M"
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@432
PS25, Line 432: atombios_adder "6665" "$2"
"$4" "32K" "Lenovo G505S with A10-5750M" "dGPU
R5-M230"
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@433
PS25, Line 433: atombios_adder "9830" "$2"
"$4" "59K" "ASUS AM1I-A with Athlon-5370" "iGPU HD-8400
/ R3-Series"
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@434
PS25, Line 434: atombios_adder "990c" "$2"
"$4" "62K" "ASUS A88XM-E with A10-6700" "iGPU
HD-8670D"
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@464
PS25, Line 464: # Finds the files of '$1' extension, saves the result to
'$2' log and prints a message with '$3'.
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@469
PS25, Line 469: printf "\n${byellow}WARNING${bend}: found ${bold}*.$1${bend}
files at these locations :\n"
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@540
PS25, Line 540: printf "\n\n${byellow}WARNING${bend}: sorry, I
don't know how to configure a board of ${bold}$1${bend}\n"
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@672
PS25, Line 672: if [ "$1" = "dgpu" ] || [ "$1" =
"atombios" ] || [ "$1" = "BottomIo" ] || [ "$1" =
"xmp" ] || \
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@673
PS25, Line 673: [ "$1" = "A88XM-E" ] || [ "$1" =
"tint" ] || [ "$1" = "seabios" ] || [ "$1" =
"cfgsb" ] ; then
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@676
PS25, Line 676: printf "\n${byellow}WARNING${bend}: not sure if I am
inside the coreboot directory,"
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@677
PS25, Line 677: printf "\n trying to add a ${bold}$1${bend}
set from here - could fail.\n\n"
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@680
PS25, Line 680: printf "\n${byellow}WARNING${bend}: found a
'.$1' hidden file at the current directory,"
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@740
PS25, Line 740: printf "\n${bold}To use it, it should be copied to
'.config' of your ./coreboot directory.${bend}\n\n"
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@742
PS25, Line 742: printf "\n${byellow}WARNING${bend}: copying it to
./.config will overwrite your current '.config'\n\n"
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@757
PS25, Line 757: printf "\n${bold} cp
./configs/$csb_patcher_config_name ./.config${bend}\n"
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@759
PS25, Line 759: printf "\n${byellow}WARNING${bend}: important README at
the beginning of ./$1.diff\n"
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@765
PS25, Line 765: printf "${bold}^^^ ! MISMATCH for a $7$1 patch ! Check
sha256sum manually: sha256sum ./$1.diff${bend}\n"
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@781
PS25, Line 781: csb_patcher "dgpu" "39873"
"1" "5d02314"
"a2777ad60b3654e85f807b69cdefa34edecd83a8231e79aeb575fbb98d43876b"
"$1" "G505S "
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@786
PS25, Line 786: csb_patcher "atombios" "33886"
"2" "6339853"
"5c9458dbebfad86c65c93921a0b5ae52e34e0a68cb06ff655d4549cc9013b0cd"
"$1" "AMD "
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@791
PS25, Line 791: csb_patcher "BottomIo" "38472"
"5" "bfbf646"
"cf2b402e23bf1169c1245e05d97b14897bc8106c37d3c45577530639245593ae"
"$1" "forAMDdGPU "
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@796
PS25, Line 796: csb_patcher "xmp" "40495"
"1" "bccd9bd"
"6ee3807f08f3f904fef31b75219bca6e28f4cf5d29e79c17abe30a5b61741dc6"
"$1" "support "
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@801
PS25, Line 801: csb_patcher "A88XM-E" "30987"
"47" "e392063"
"c9cd4361e9894f1efca28fbd6848f4a913a9d24ace980bbf70d7dcd002aa4faf"
"$1" "Asus "
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@806
PS25, Line 806: csb_patcher "tint" "33887"
"3" "d11508d"
"f46f5c356e1c17f800b820fb093d844c981e7b109506472f92050ce9d15a6ef6"
"$1" ""
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@811
PS25, Line 811: csb_patcher "seabios" "32351"
"7" "ff6f8a6"
"d89128106a02c5f6ee2903ada0cd6efc2ca62871fed3d5b632e740f53425e43c"
"$1" ""
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@816
PS25, Line 816: csb_patcher "cfgsb" "39899"
"1" "39e9bde"
"16c199fb4be5299be7141f8783377de228cf76aa31d29ee9fe7098f6204feb82"
"$1" "for-configs "
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@821
PS25, Line 821: csb_patcher "config.lenovo_g505s" "32352"
"27" "702719a"
"602e2af959fc4fc8118011da015f822d652d35e3f7247bf071ad62681e8748f9"
"$1" ""
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@826
PS25, Line 826: csb_patcher "config.asus_am1i-a" "33800"
"14" "6005dc8"
"42721152756649d6f30b1e7a0e6a169a322cc2df808ea6cd8e90b53c8f46c4eb"
"$1" ""
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@831
PS25, Line 831: csb_patcher "config.asus_a88xm-e" "39900"
"1" "61c9d6d"
"e45e25227e38389bebea12b975657689b5e1cf74b5d1907d7223355d4455130b"
"$1" ""
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@838
PS25, Line 838: printf "${bold}===============${bend} ${bgreen}USAGE${bend}
${bold}================${bend}\n\n"
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@841
PS25, Line 841: printf "${bold}./csb_patcher.sh${bend} ${byellow}help${bend}
${bold}|${bend} ${byellow}usage${bend}\n"
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@894
PS25, Line 894: csb_finder "orig" "$csb_patcher_log" "applied
correctly although at slightly different lines, can ignore it."
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@895
PS25, Line 895: csb_finder "rej" "$csb_patcher_log" "perhaps
failed to apply, could result in a broken build! ${bred}Please report${bend}"
line over 96 characters
https://review.coreboot.org/c/coreboot/+/33509/25/csb_patcher.sh@917
PS25, Line 917: cbfs_mass_adder "$1" "./build/cbfstool"
"./build/coreboot.rom" "./build/coreflop.rom"
line over 96 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33509
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I66f4f2865ac63ce0f2615669c7a3abd70a397e49
Gerrit-Change-Number: 33509
Gerrit-PatchSet: 25
Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin Roth <martinroth(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Fri, 17 Apr 2020 19:30:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment