Duan huayang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37996 )
Change subject: soc/mediatek/mt8183: add TX tracking for DRAM DVFS ......................................................................
Patch Set 8:
(11 comments)
https://review.coreboot.org/c/coreboot/+/37996/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37996/5//COMMIT_MSG@9 PS5, Line 9: tracking
track
Done
https://review.coreboot.org/c/coreboot/+/37996/5//COMMIT_MSG@10 PS5, Line 10:
Please elaborate, what the problem is, and why using DQS OSC fixes this.
updated at commit msg
https://review.coreboot.org/c/coreboot/+/37996/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37996/8//COMMIT_MSG@9 PS8, Line 9: use
Use
Done
https://review.coreboot.org/c/coreboot/+/37996/8//COMMIT_MSG@9 PS8, Line 9: tracking
track
Done
https://review.coreboot.org/c/coreboot/+/37996/8//COMMIT_MSG@9 PS8, Line 9: DVFS
DVFS.
Done
https://review.coreboot.org/c/coreboot/+/37996/5/src/soc/mediatek/mt8183/Kco... File src/soc/mediatek/mt8183/Kconfig:
https://review.coreboot.org/c/coreboot/+/37996/5/src/soc/mediatek/mt8183/Kco... PS5, Line 22: default y
Unwanted?
Done
https://review.coreboot.org/c/coreboot/+/37996/8/src/soc/mediatek/mt8183/Kco... File src/soc/mediatek/mt8183/Kconfig:
https://review.coreboot.org/c/coreboot/+/37996/8/src/soc/mediatek/mt8183/Kco... PS8, Line 22: default y
I think this was changed so that Jenkins build-tests the change. […]
have revert this unexpect change
https://review.coreboot.org/c/coreboot/+/37996/8/src/soc/mediatek/mt8183/dra... File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/37996/8/src/soc/mediatek/mt8183/dra... PS8, Line 25: extern const u8 freq_shuffle[DRAM_DFS_SHUFFLE_MAX]; : extern const u8 freq_shuffle_emcp[DRAM_DFS_SHUFFLE_MAX]; : extern const u32 frequency_table[LP4X_DDRFREQ_MAX];
Please pass these as function arguments (for example, https://review.coreboot. […]
Done
https://review.coreboot.org/c/coreboot/+/37996/8/src/soc/mediatek/mt8183/dra... PS8, Line 2338: *
I would also use spaces here
Done
https://review.coreboot.org/c/coreboot/+/37996/8/src/soc/mediatek/mt8183/dra... PS8, Line 2345: if (shu_src >= DRAM_DFS_SHUFFLE_MAX || shu_dst>= DRAM_DFS_SHUFFLE_MAX) {
Note: Adding the extra space will make this line one character too long. […]
Done
https://review.coreboot.org/c/coreboot/+/37996/8/src/soc/mediatek/mt8183/dra... PS8, Line 2351: div_round_close((get_shu_frequency(shu_dst) >> 1)* 32,
Please fix this.
Done