View Change

11 comments:

• Commit Message:

  • Patch Set #5, Line 9: tracking

    track

    Done

  • Patch Set #5, Line 10:

    Please elaborate, what the problem is, and why using DQS OSC fixes this.

    updated at commit msg

• Commit Message:

  • Patch Set #8, Line 9: use

    Use

    Done

  • Patch Set #8, Line 9: tracking

    track

    Done

  • Patch Set #8, Line 9: DVFS

    DVFS.

    Done

• File src/soc/mediatek/mt8183/Kconfig:

  • Patch Set #5, Line 22: default y

    Unwanted?

    Done

• File src/soc/mediatek/mt8183/Kconfig:

  • Patch Set #8, Line 22: default y

    I think this was changed so that Jenkins build-tests the change. […]

    have revert this unexpect change

• File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:

  • Patch Set #8, Line 25:

    extern const u8 freq_shuffle[DRAM_DFS_SHUFFLE_MAX];
    extern const u8 freq_shuffle_emcp[DRAM_DFS_SHUFFLE_MAX];
    extern const u32 frequency_table[LP4X_DDRFREQ_MAX];
    

    Please pass these as function arguments (for example, https://review.coreboot. […]

    Done

  • Patch Set #8, Line 2338: *

    I would also use spaces here

    Done

  • Patch Set #8, Line 2345: if (shu_src >= DRAM_DFS_SHUFFLE_MAX || shu_dst>= DRAM_DFS_SHUFFLE_MAX) {

    Note: Adding the extra space will make this line one character too long. […]

    Done

  • Patch Set #8, Line 2351: div_round_close((get_shu_frequency(shu_dst) >> 1)* 32,

    Please fix this.

    Done

To view, visit change 37996. To unsubscribe, or for help writing mail filters, visit settings.