Attention is currently required from: Andy Ebrahiem, Angel Pons, Jincheng Li, Jérémy Compostella, Marvin Drees, Maximilian Brune, Naresh Solanki, NyeonWoo Kim, Patrick Rudolph, Shuo Liu.
Felix Held has posted comments on this change by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/85638?usp=email )
Change subject: arch/x86/cpu: Add helper function to compute cache
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/85638?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I60707de4c8242a8fbda8cb5b791a1db762d94449
Gerrit-Change-Number: 85638
Gerrit-PatchSet: 8
Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Marvin Drees <marvin.drees(a)9elements.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: NyeonWoo Kim
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Andy Ebrahiem <ahmet.ebrahiem(a)9elements.com>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Andy Ebrahiem <ahmet.ebrahiem(a)9elements.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-Attention: Marvin Drees <marvin.drees(a)9elements.com>
Gerrit-Attention: Naresh Solanki <naresh.solanki(a)9elements.com>
Gerrit-Attention: NyeonWoo Kim
Gerrit-Comment-Date: Wed, 02 Apr 2025 20:28:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Fred Reitberger, Jason Glenesk, Martin L Roth, Matt DeVillier, Naresh Solanki, Varshit Pandya.
Felix Held has posted comments on this change by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/87124?usp=email )
Change subject: soc/amd/*/include/soc/msr.h: Move MSR to common location
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/soc/amd/phoenix/include/soc/msr.h:
https://review.coreboot.org/c/coreboot/+/87124/comment/5863a798_3a51b6fe?us… :
PS1, Line 8: #include<cpu/amd/msr.h>
space missing before the '<'; also same for the other socs
--
To view, visit https://review.coreboot.org/c/coreboot/+/87124?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic0cb54b13320f8a38e70c0a76d9b9a51ba0ea01d
Gerrit-Change-Number: 87124
Gerrit-PatchSet: 1
Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Naresh Solanki <naresh.solanki(a)9elements.com>
Gerrit-Comment-Date: Wed, 02 Apr 2025 20:28:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Angel Pons, Brandon Weeks, Julian Intronati, Paul Menzel.
Felix Held has posted comments on this change by Julian Intronati. ( https://review.coreboot.org/c/coreboot/+/87027?usp=email )
Change subject: mb/cwwk: Add CWWK CW-ADLNTB-1C2L-V3.0 board as an adl variants
......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS1:
> It is my first coreboot commit ! I'm open to suggestions. […]
Hi Julian, welcome to coreboot development :)
Patchset:
PS2:
i'm a bit surprised that the devicetree is identical, but i'd guess that the devices are just very similar. cw-adl-4l-v2.0, which i have started to port, but didn't have to time to finish that one yet, has some devicetree differences compared to cw-adl-4l-v1.0
File src/mainboard/cwwk/adl/Kconfig:
https://review.coreboot.org/c/coreboot/+/87027/comment/98c48853_0968e150?us… :
PS2, Line 15:
i think this is missing the following lines here to make the board selection work properly:
```
config BOARD_CWWK_CW_ADL_4L_V1
select BOARD_CWWK_ADL_N_COMMON
config BOARD_CWWK_CW_ADLNTB_1C2L_V3
select BOARD_CWWK_ADL_N_COMMON
```
--
To view, visit https://review.coreboot.org/c/coreboot/+/87027?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia0553141b41717b560042de1136d53b9c3cf7a69
Gerrit-Change-Number: 87027
Gerrit-PatchSet: 2
Gerrit-Owner: Julian Intronati <julian.intronati(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Brandon Weeks <bweeks(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Julian Intronati <julian.intronati(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Brandon Weeks <bweeks(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Julian Intronati <julian.intronati(a)gmail.com>
Gerrit-Comment-Date: Wed, 02 Apr 2025 20:25:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julian Intronati <julian.intronati(a)gmail.com>
Attention is currently required from: Patrick Rudolph.
Julius Werner has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/87114?usp=email )
Change subject: drivers/smmstore: Support 64-bit MMIO addresses
......................................................................
Patch Set 1:
(1 comment)
File src/commonlib/include/commonlib/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/87114/comment/0c46192d_255ebddf?us… :
PS1, Line 548: uint64_t mmap_addr_high; /* When the ROM MMIO address is above 4GiB the 'mmap_addr' cannot hold it.
The naming here seems very confusing to me. When I see two fields `mmap_addr` and a later added `mmap_addr_high`, I'd expect that you want me to do `mmap_addr_high << 32 | mmap_addr`, but that's not how you designed it. How about renaming `mmap_addr` to `deprecated_mmap_addr` and naming the other one `mmap_addr_v2` or something like that?
--
To view, visit https://review.coreboot.org/c/coreboot/+/87114?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1131cfa5cdbf92bbd33de3e5b22a305136eec9f7
Gerrit-Change-Number: 87114
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Comment-Date: Wed, 02 Apr 2025 20:21:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Ben Kao, Dinesh Gehlot, Dtrain Hsu, Eric Lai, Intel coreboot Reviewers, Jamie Chen, Jayvik Desai, John Su, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Jérémy Compostella has posted comments on this change by John Su. ( https://review.coreboot.org/c/coreboot/+/87033?usp=email )
Change subject: mb/var/uldrenite: Configure descriptor for either MBVR or FIVR
......................................................................
Patch Set 10:
(1 comment)
Patchset:
PS10:
This is a google board, I'll let Google +2.
--
To view, visit https://review.coreboot.org/c/coreboot/+/87033?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I337574c8c55889ceb49b9f33625feadb48bd8890
Gerrit-Change-Number: 87033
Gerrit-PatchSet: 10
Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Ben Kao <ben.kao(a)intel.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Reviewer: Jamie Chen <jamie.chen(a)intel.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-CC: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Attention: Jamie Chen <jamie.chen(a)intel.com>
Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Ben Kao <ben.kao(a)intel.com>
Gerrit-Comment-Date: Wed, 02 Apr 2025 20:19:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Fred Reitberger, Jason Glenesk, Matt DeVillier.
Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/86864?usp=email )
Change subject: soc/amd/*/psp_verstage: Remove duplicate verstage-generic-ccopts
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
> not directly related to this change: is there a difference between '$(src)' and 'src'? looks a bit o […]
Not that I can see. $(obj) is at least useful and more consistently used, but I don't think $(src) is actually necessary. $(top) is also not really used consistently (or I am just not seeing it). Maybe something to bring up in mailing list or leadership meeting to gain some consistency and explicit rules in our codebase.
--
To view, visit https://review.coreboot.org/c/coreboot/+/86864?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic64f5187e50b903af5461bfa4d57bb4951d3b501
Gerrit-Change-Number: 86864
Gerrit-PatchSet: 5
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Ana Carolina Cabral <ana.cpmelo95(a)gmail.com>
Gerrit-Reviewer: Andy Ebrahiem <ahmet.ebrahiem(a)9elements.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Comment-Date: Wed, 02 Apr 2025 20:19:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>