coreboot-gerrit April 2025

coreboot-gerrit@coreboot.org

1 participants
3140 discussions

[S] Change in coreboot[main]: util/crossgcc: Build compiler-rt using runtimes
by Marvin Drees (Code Review) 14 Apr '25

14 Apr '25

Attention is currently required from: Arthur Heymans, Elyes Haouas, Martin L Roth. Marvin Drees has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/80737?usp=email ) Change subject: util/crossgcc: Build compiler-rt using runtimes ...................................................................... Patch Set 8: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/80737?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iacd9b5f1fc1444b3dd1a785b91510f346e7a2f51 Gerrit-Change-Number: 80737 Gerrit-PatchSet: 8 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Marvin Drees <marvin.drees(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Mon, 14 Apr 2025 11:58:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: util/crossgcc: Upgrade LLVM from version 18.1.8 to 20.1.2
by Marvin Drees (Code Review) 14 Apr '25

14 Apr '25

Attention is currently required from: Elyes Haouas. Marvin Drees has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/85986?usp=email ) Change subject: util/crossgcc: Upgrade LLVM from version 18.1.8 to 20.1.2 ...................................................................... Patch Set 8: (1 comment) File util/crossgcc/patches/clang-18.1.8.src_x86_baremetal.patch: https://review.coreboot.org/c/coreboot/+/85986/comment/2cf82c0b_c60ad1d7?us… : PS8, Line 1: diff --git a/lib/Driver/ToolChains/BareMetal.cpp b/lib/Driver/ToolChains/BareMetal.cpp Looking at the 20.1.x source this patch should rather be adapted to apply again instead of being deleted as the isX86BareMetal check is still not upstream, no? It would be rather trivial to rebase this patch as well. -- To view, visit https://review.coreboot.org/c/coreboot/+/85986?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4d12a0f46a9cddee1a06f584ff7193e81e7815a6 Gerrit-Change-Number: 85986 Gerrit-PatchSet: 8 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Marvin Drees <marvin.drees(a)9elements.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Mon, 14 Apr 2025 11:57:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in coreboot[main]: util/cbmem: Extract memory mapping to common functions
by Jakub "Kuba" Czapiga (Code Review) 14 Apr '25

14 Apr '25

Attention is currently required from: Elyes Haouas, Julius Werner, Karthik Ramasubramanian, Konrad Adamczyk, Paul Menzel, Stefan Reinauer, Yu-Ping Wu. Hello Elyes Haouas, Julius Werner, Konrad Adamczyk, Stefan Reinauer, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86487?usp=email to look at the new patch set (#8). Change subject: util/cbmem: Extract memory mapping to common functions ...................................................................... util/cbmem: Extract memory mapping to common functions Extract most of calls to map_memory() to dedicated functions instead providing allocated buffer eliminating a need to perform manual aligned memcpy. BUG=b:391874512 TEST=cbmem -l; cbmem -x; cbmem -r 434f4e53; cbmem -t Change-Id: I70f8790842a932c4cf7717298ef43c8110dfa878 Signed-off-by: Jakub Czapiga <czapiga(a)google.com> --- M util/cbmem/cbmem.c 1 file changed, 257 insertions(+), 189 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/86487/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/86487?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I70f8790842a932c4cf7717298ef43c8110dfa878 Gerrit-Change-Number: 86487 Gerrit-PatchSet: 8 Gerrit-Owner: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Konrad Adamczyk <konrada(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Konrad Adamczyk <konrada(a)google.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[L] Change in coreboot[main]: util/cbmem: Switch from coreboot table to cbmem
by Jakub "Kuba" Czapiga (Code Review) 14 Apr '25

14 Apr '25

Attention is currently required from: Elyes Haouas, Jakub "Kuba" Czapiga, Konrad Adamczyk, Stefan Reinauer, Yu-Ping Wu. Hello Elyes Haouas, Julius Werner, Konrad Adamczyk, Stefan Reinauer, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86488?usp=email to look at the new patch set (#7). Change subject: util/cbmem: Switch from coreboot table to cbmem ...................................................................... util/cbmem: Switch from coreboot table to cbmem Remove global variables wherever possible to make code easier to read and to isolate responsibilities of functions. Use CBMEM entries instead of coreboot table records. BUG=b:391874512 TEST=cbmem -l; cbmem -x; cbmem -r 434f4e53; cbmem -t; cbmem -a 1200 Change-Id: Iaa6e38b600c06ba72348250e865a4e8f30a31b8e Signed-off-by: Jakub Czapiga <czapiga(a)google.com> --- M util/cbmem/cbmem.c 1 file changed, 138 insertions(+), 207 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/86488/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/86488?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iaa6e38b600c06ba72348250e865a4e8f30a31b8e Gerrit-Change-Number: 86488 Gerrit-PatchSet: 7 Gerrit-Owner: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Konrad Adamczyk <konrada(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Konrad Adamczyk <konrada(a)google.com> Gerrit-Attention: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[L] Change in coreboot[main]: util/cbmem: Extract memory mapping to common functions
by Jakub "Kuba" Czapiga (Code Review) 14 Apr '25

14 Apr '25

Attention is currently required from: Elyes Haouas, Julius Werner, Karthik Ramasubramanian, Konrad Adamczyk, Paul Menzel, Stefan Reinauer, Yu-Ping Wu. Hello Elyes Haouas, Julius Werner, Konrad Adamczyk, Stefan Reinauer, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86487?usp=email to look at the new patch set (#7). Change subject: util/cbmem: Extract memory mapping to common functions ...................................................................... util/cbmem: Extract memory mapping to common functions Extract most of calls to map_memory() to dedicated functions instead providing allocated buffer eliminating a need to perform manual aligned memcpy. BUG=b:391874512 TEST=cbmem -l; cbmem -x; cbmem -r 434f4e53; cbmem -t Change-Id: I70f8790842a932c4cf7717298ef43c8110dfa878 Signed-off-by: Jakub Czapiga <czapiga(a)google.com> --- M util/cbmem/cbmem.c 1 file changed, 257 insertions(+), 189 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/86487/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/86487?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I70f8790842a932c4cf7717298ef43c8110dfa878 Gerrit-Change-Number: 86487 Gerrit-PatchSet: 7 Gerrit-Owner: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Konrad Adamczyk <konrada(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Konrad Adamczyk <konrada(a)google.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[S] Change in coreboot[main]: soc/amd/common/cpu/noncar: Compute core info boost freq & L3 cache
by Naresh Solanki (Code Review) 14 Apr '25

14 Apr '25

Attention is currently required from: Angel Pons, Felix Held, Fred Reitberger, Jason Glenesk, Marvin Drees, Matt DeVillier, Maximilian Brune, Paul Menzel. Naresh Solanki has posted comments on this change by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/85640?usp=email ) Change subject: soc/amd/common/cpu/noncar: Compute core info boost freq & L3 cache ...................................................................... Patch Set 17: (6 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85640/comment/0868a7b5_e64641d6?us… : PS16, Line 7: Compute core info > It’d be great if you could be more specific. Done https://review.coreboot.org/c/coreboot/+/85640/comment/9681c157_fa7d4096?us… : PS16, Line 9: In some SoC like Glinda, have : 1. Different CPU cores have > *In some … have, … have* is confusing to me. It’d be great if you could rephrase it. Done https://review.coreboot.org/c/coreboot/+/85640/comment/68a1b856_1488703d?us… : PS16, Line 13: function > function*s* Done https://review.coreboot.org/c/coreboot/+/85640/comment/301e560e_cf5098a8?us… : PS16, Line 19: Retrieves > Imperative mood: Retrieve […] Done https://review.coreboot.org/c/coreboot/+/85640/comment/03d4234f_15bc6d0c?us… : PS16, Line 26: 24MB > What was it before? Done File src/soc/amd/common/block/include/amdblocks/cpu.h: https://review.coreboot.org/c/coreboot/+/85640/comment/bdafec04_4150ff30?us… : PS16, Line 11: struct core_info { : /* Core max boost frequency */ : uint32_t max_frequency; : : /* L3 Cache block unique ID & size (in bytes) */ : uint16_t l3_cache_uid; : size_t l3_cache_size; : }; : > put this into the `cpu.c` file, since its not used outside of that file. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/85640?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I46947e8ac62c903036a81642e03201e353c3dac6 Gerrit-Change-Number: 85640 Gerrit-PatchSet: 17 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marvin Drees <marvin.drees(a)9elements.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Marvin Drees <marvin.drees(a)9elements.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 14 Apr 2025 11:36:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com>

1 0

[L] Change in coreboot[main]: util/cbmem: Extract memory mapping to common functions
by Jakub "Kuba" Czapiga (Code Review) 14 Apr '25

14 Apr '25

Attention is currently required from: Elyes Haouas, Julius Werner, Karthik Ramasubramanian, Konrad Adamczyk, Paul Menzel, Stefan Reinauer, Yu-Ping Wu. Jakub "Kuba" Czapiga has posted comments on this change by Jakub "Kuba" Czapiga. ( https://review.coreboot.org/c/coreboot/+/86487?usp=email ) Change subject: util/cbmem: Extract memory mapping to common functions ...................................................................... Patch Set 6: (10 comments) File util/cbmem/cbmem.c: https://review.coreboot.org/c/coreboot/+/86487/comment/df692c23_e825fe66?us… : PS3, Line 279: type > Note that types aren't necessarily exclusive. […] I am aware of that. That's why this function iterates from the end to account for CBMEM entry being the last one. This function is ony used by `dump_cbmem_hex()`, so technically it could be integrated into it, but I wanted to have some level of separation, as it helps later patches. https://review.coreboot.org/c/coreboot/+/86487/comment/84796c25_4a4ca008?us… : PS3, Line 480: static int lb_table_get_entry(uint32_t tag, uint8_t **buf_out, size_t *size_out) > This function is doing a lot of duplication. […] Great suggestion. It also allowed to remove unnecessary return statements. `cbmem` will not behave the same after this change, but I doubt anyone would like to get TPM log and timestamps at the same time as it would be a pain to parse. https://review.coreboot.org/c/coreboot/+/86487/comment/05a090e7_b36ed75f?us… : PS3, Line 594: static int lb_table_map_entry_rw(uint32_t id, struct mapping *mapping, uint8_t **buf_out, > FWIW, you can do that on a later patch if you prefer, but eventually to support the goal of using sy […] That's the approach I've taken with `sysfs` as we cannot `memmap` entries. However I'd like to leave this as it is for now. This can be solved in later patches where I introduce a better API. https://review.coreboot.org/c/coreboot/+/86487/comment/4bddc909_68860fe6?us… : PS3, Line 1456: printf("%c", buf[i]); > nit: Already in the old code, but wouldn't this be easier as `fwrite(buf, 1, size, stdout)`? Or does […] I've checked libc implementation and it does not do any coversion for `%c` so we can safely switch to `fwrite()`. File util/cbmem/cbmem.c: https://review.coreboot.org/c/coreboot/+/86487/comment/1dc576ff_c2d2931f?us… : PS5, Line 281: { > Is memory expected to be initialized always when this function gets called? We expect `LB_TAG_MEMORY` to always be present, thus `memory` too, but just to be sure I added a check here. https://review.coreboot.org/c/coreboot/+/86487/comment/adcc5a4b_3c70d434?us… : PS5, Line 340: const struct lb_memory *mem = lbtable + i; > This is probably not needed. […] Done https://review.coreboot.org/c/coreboot/+/86487/comment/ef78cdd5_274ad77b?us… : PS5, Line 483: { > Nit: Is curly braces needed for case block? I see that it is consistent with the rest of the file. […] Rework suggested by Julius allows easy removal braces. I kept them here to avoid name clashes/shadowing. https://review.coreboot.org/c/coreboot/+/86487/comment/6e771cdc_cfbcb114?us… : PS5, Line 597: if (id == LB_TAG_TIMESTAMPS) { > Nit: […] Done https://review.coreboot.org/c/coreboot/+/86487/comment/440d7449_66c1c433?us… : PS5, Line 893: size = sizeof(*tst_p) + tst_p->num_entries * sizeof(tst_p->entries[0]); > Isn't tst_buf_size equal to this value when lb_table_get_entry returns? If so, do we need both? I must have missed it while rearranging the code. Thanks! https://review.coreboot.org/c/coreboot/+/86487/comment/4b71e139_73bcfe48?us… : PS5, Line 1195: (void)size; > If size parameter is unused, can it be removed? It is not used until the last CL in this chain. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/86487?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I70f8790842a932c4cf7717298ef43c8110dfa878 Gerrit-Change-Number: 86487 Gerrit-PatchSet: 6 Gerrit-Owner: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Konrad Adamczyk <konrada(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Konrad Adamczyk <konrada(a)google.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Mon, 14 Apr 2025 11:35:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>

1 0

[L] Change in coreboot[main]: util/cbmem: Switch from coreboot table to cbmem
by Jakub "Kuba" Czapiga (Code Review) 14 Apr '25

14 Apr '25

Attention is currently required from: Elyes Haouas, Jakub "Kuba" Czapiga, Konrad Adamczyk, Stefan Reinauer, Yu-Ping Wu. Hello Elyes Haouas, Julius Werner, Konrad Adamczyk, Stefan Reinauer, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86488?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Code-Review+2 by Stefan Reinauer, Verified+1 by build bot (Jenkins) Change subject: util/cbmem: Switch from coreboot table to cbmem ...................................................................... util/cbmem: Switch from coreboot table to cbmem Remove global variables wherever possible to make code easier to read and to isolate responsibilities of functions. Use CBMEM entries instead of coreboot table records. BUG=b:391874512 TEST=cbmem -l; cbmem -x; cbmem -r 434f4e53; cbmem -t; cbmem -a 1200 Change-Id: Iaa6e38b600c06ba72348250e865a4e8f30a31b8e Signed-off-by: Jakub Czapiga <czapiga(a)google.com> --- M util/cbmem/cbmem.c 1 file changed, 149 insertions(+), 211 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/86488/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/86488?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iaa6e38b600c06ba72348250e865a4e8f30a31b8e Gerrit-Change-Number: 86488 Gerrit-PatchSet: 6 Gerrit-Owner: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Konrad Adamczyk <konrada(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Konrad Adamczyk <konrada(a)google.com> Gerrit-Attention: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[L] Change in coreboot[main]: util/cbmem: Extract memory mapping to common functions
by Jakub "Kuba" Czapiga (Code Review) 14 Apr '25

14 Apr '25

Attention is currently required from: Elyes Haouas, Jakub "Kuba" Czapiga, Konrad Adamczyk, Paul Menzel, Stefan Reinauer, Yu-Ping Wu. Hello Elyes Haouas, Julius Werner, Konrad Adamczyk, Stefan Reinauer, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86487?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Code-Review+2 by Stefan Reinauer, Verified+1 by build bot (Jenkins) Change subject: util/cbmem: Extract memory mapping to common functions ...................................................................... util/cbmem: Extract memory mapping to common functions Extract most of calls to map_memory() to dedicated functions instead providing allocated buffer eliminating a need to perform manual aligned memcpy. BUG=b:391874512 TEST=cbmem -l; cbmem -x; cbmem -r 434f4e53; cbmem -t Change-Id: I70f8790842a932c4cf7717298ef43c8110dfa878 Signed-off-by: Jakub Czapiga <czapiga(a)google.com> --- M util/cbmem/cbmem.c 1 file changed, 250 insertions(+), 189 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/86487/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/86487?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I70f8790842a932c4cf7717298ef43c8110dfa878 Gerrit-Change-Number: 86487 Gerrit-PatchSet: 6 Gerrit-Owner: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Konrad Adamczyk <konrada(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Konrad Adamczyk <konrada(a)google.com> Gerrit-Attention: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: MAINTAINERS: Add Avi for intel/pantherlake and google/fatcat
by Avi Uday (Code Review) 14 Apr '25

14 Apr '25

Attention is currently required from: Kapil Porwal, Subrata Banik. Avi Uday has posted comments on this change by Avi Uday. ( https://review.coreboot.org/c/coreboot/+/87303?usp=email ) Change subject: MAINTAINERS: Add Avi for intel/pantherlake and google/fatcat ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > we need to add maintainer file for ocelet as well ? Yes, I will create a separate CL for that -- To view, visit https://review.coreboot.org/c/coreboot/+/87303?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I295df41b6754dc3ef33f4979e325fbba7d0b8e82 Gerrit-Change-Number: 87303 Gerrit-PatchSet: 2 Gerrit-Owner: Avi Uday <aviuday(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Mon, 14 Apr 2025 10:51:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2025