coreboot-gerrit February 2025

coreboot-gerrit@coreboot.org

1 participants
2886 discussions

[M] Change in coreboot[main]: soc/intel/pantherlake: Inject CSE TS into CBMEM timestamp table
by Subrata Banik (Code Review) 24 Feb '25

24 Feb '25

Attention is currently required from: Bora Guvendik, Intel coreboot Reviewers, Jayvik Desai, Kapil Porwal, Pranava Y N, Wonkyu Kim. Subrata Banik has posted comments on this change by Bora Guvendik. ( https://review.coreboot.org/c/coreboot/+/84872?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: soc/intel/pantherlake: Inject CSE TS into CBMEM timestamp table ...................................................................... Patch Set 9: (1 comment) File src/soc/intel/common/block/cse/Kconfig: https://review.coreboot.org/c/coreboot/+/84872/comment/d26ee441_16ef9b34?us… : PS8, Line 316: _V4 > It wasn't used but I don't know the story behind it. can we not skip v3 and plan to change the file name to use v3 for PTL ? any concerns ? -- To view, visit https://review.coreboot.org/c/coreboot/+/84872?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie7716b8c371b82c13da1b0217dce1a16e7b95cee Gerrit-Change-Number: 84872 Gerrit-PatchSet: 9 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Tue, 25 Feb 2025 04:31:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Bora Guvendik <bora.guvendik(a)intel.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[S] Change in coreboot[main]: soc/intel/pantherlake: Display Sign-of-Life during memory training
by Subrata Banik (Code Review) 24 Feb '25

24 Feb '25

Attention is currently required from: Alok Agarwal, Intel coreboot Reviewers, Jayvik Desai, Jeremy Compostella, Julius Werner, Jérémy Compostella, Kapil Porwal, Karthik Ramasubramanian, Paul Menzel, Pranava Y N, Vikrant L Jadeja. Subrata Banik has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/85454?usp=email ) Change subject: soc/intel/pantherlake: Display Sign-of-Life during memory training ...................................................................... Patch Set 22: (1 comment) File src/soc/intel/pantherlake/romstage/fsp_params.c: https://review.coreboot.org/c/coreboot/+/85454/comment/72b820d4_638a2e28?us… : PS21, Line 387: m_cfg->VgaMessage = (efi_uintn_t)ux_locales_get_text(UX_LOCALE_MSG_MEMORY_TRAINING); > We have an open ticket to track the idea of whether to refactor some code or not. If I add a "TODO" comment in the code and we decide to take no action, I must create a semantically empty ChangeList (CL) just to remove the TODO comment. Including a TODO in the code would only make sense if something were only partially implemented, which is not the case here. I agree with you, having TO DO only make sense if we are planning to close that in some defined time scope which is not the case with b/398872610. This bug is for future generation depending upon if Intel FSP can commit to use common UPD name across all SoC generation. Therefore, adding TODO here is overdoing IMO. @kramasub@google.com thoughts ? -- To view, visit https://review.coreboot.org/c/coreboot/+/85454?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I993eb0d59cd01fa62f35a77f84e262e389efb367 Gerrit-Change-Number: 85454 Gerrit-PatchSet: 22 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Alok Agarwal <alok.agarwal(a)intel.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Vikrant L Jadeja <vikrant.l.jadeja(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-CC: Jeremy Compostella <jeremy.compostella(a)intel.corp-partner.google.com> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Jeremy Compostella <jeremy.compostella(a)intel.corp-partner.google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Vikrant L Jadeja <vikrant.l.jadeja(a)intel.com> Gerrit-Attention: Alok Agarwal <alok.agarwal(a)intel.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Tue, 25 Feb 2025 04:12:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>

1 0

[S] Change in coreboot[main]: libpayload/drivers/usb/ehci: Remove "else" after a "break"
by Elyes Haouas (Code Review) 24 Feb '25

24 Feb '25

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/86560?usp=email ) Change subject: libpayload/drivers/usb/ehci: Remove "else" after a "break" ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/86560?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0f511b8c4349ec64916b631c32d5db9487f24c9c Gerrit-Change-Number: 86560 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: libpayload/drivers/usb/uhci: Remove "else" after "return"
by Elyes Haouas (Code Review) 24 Feb '25

24 Feb '25

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/86559?usp=email ) Change subject: libpayload/drivers/usb/uhci: Remove "else" after "return" ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/86559?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8950ad576a0252529258978935dc31ba53028b28 Gerrit-Change-Number: 86559 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: libpayload/tests: Remove unused test files
by Elyes Haouas (Code Review) 24 Feb '25

24 Feb '25

Elyes Haouas has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86536?usp=email ) Change subject: libpayload/tests: Remove unused test files ...................................................................... libpayload/tests: Remove unused test files Change-Id: Id2cec6a56ba5ce98832aced6fc2cfd8ebda91f02 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86536 Reviewed-by: Julius Werner <jwerner(a)chromium.org> Reviewed-by: Maximilian Brune <maximilian.brune(a)9elements.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- D payloads/libpayload/tests/Makefile D payloads/libpayload/tests/cbfs-x86-test.c 2 files changed, 0 insertions(+), 46 deletions(-) Approvals: Julius Werner: Looks good to me, approved Maximilian Brune: Looks good to me, approved build bot (Jenkins): Verified diff --git a/payloads/libpayload/tests/Makefile b/payloads/libpayload/tests/Makefile deleted file mode 100644 index 8c55053..0000000 --- a/payloads/libpayload/tests/Makefile +++ /dev/null @@ -1,12 +0,0 @@ -CC=gcc -g -m32 -INCLUDES=-I. -I../include -I../include/x86 -TARGETS=cbfs-x86-test - -cbfs-x86-test: cbfs-x86-test.c ../arch/x86/rom_media.c ../libcbfs/ram_media.c ../libcbfs/cbfs.c - $(CC) -o $@ $^ $(INCLUDES) - - -all: $(TARGETS) - -run: all - for i in $(TARGETS); do ./$$i; done diff --git a/payloads/libpayload/tests/cbfs-x86-test.c b/payloads/libpayload/tests/cbfs-x86-test.c deleted file mode 100644 index 8102965..0000000 --- a/payloads/libpayload/tests/cbfs-x86-test.c +++ /dev/null @@ -1,34 +0,0 @@ -/* system headers */ -#include <stdlib.h> -#include <stdio.h> - -/* libpayload headers */ -#include "cbfs.h" - -int fail(const char* str) -{ - fprintf(stderr, "%s", str); - exit(1); -} - -int main(int argc, char** argv) -{ - FILE *cbfs = fopen("data/cbfs-x86.bin", "rb"); - if (!cbfs) fail("could not open test file\n"); - if (fseek(cbfs, 0, SEEK_END) != 0) fail("seek to end failed\n"); - - long size = ftell(cbfs); - if (size == -1) fail("could not determine file size\n"); - if (fseek(cbfs, 0, SEEK_SET) != 0) fail("seek to start failed\n"); - - void *data = malloc(size); - if (!data) fail("could not allocate buffer\n"); - - if (fread(data, size, 1, cbfs) != 1) fail("could not read data\n"); - if (fclose(cbfs)) fail("could not close file\n"); - - if (setup_cbfs_from_ram(data, size) != 0) fail("could not setup CBFS in RAM\n"); - struct cbfs_file *file = cbfs_find("foo"); - if (file == NULL) fail("could not find file in CBFS\n"); - exit(0); -} -- To view, visit https://review.coreboot.org/c/coreboot/+/86536?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id2cec6a56ba5ce98832aced6fc2cfd8ebda91f02 Gerrit-Change-Number: 86536 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in blobs[main]: soc/mediatek/mt8196: Update SSPM firmware to v5.0
by Yu-Ping Wu (Code Review) 24 Feb '25

24 Feb '25

Attention is currently required from: Liu Liu, Yidi Lin. Yu-Ping Wu has posted comments on this change by Liu Liu. ( https://review.coreboot.org/c/blobs/+/86586?usp=email ) Change subject: soc/mediatek/mt8196: Update SSPM firmware to v5.0 ...................................................................... Patch Set 5: Verified+1 -- To view, visit https://review.coreboot.org/c/blobs/+/86586?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I14a9d48920bc9f9d15b5b095f88257d5b5cd4f6e Gerrit-Change-Number: 86586 Gerrit-PatchSet: 5 Gerrit-Owner: Liu Liu <ot_liu.liu(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Liu Liu <ot_liu.liu(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Tue, 25 Feb 2025 03:56:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in blobs[main]: soc/mediatek/mt8196: Update SSPM firmware to v5.0
by Yu-Ping Wu (Code Review) 24 Feb '25

24 Feb '25

Attention is currently required from: Liu Liu, Yidi Lin. Yu-Ping Wu has posted comments on this change by Liu Liu. ( https://review.coreboot.org/c/blobs/+/86586?usp=email ) Change subject: soc/mediatek/mt8196: Update SSPM firmware to v5.0 ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/blobs/+/86586?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I14a9d48920bc9f9d15b5b095f88257d5b5cd4f6e Gerrit-Change-Number: 86586 Gerrit-PatchSet: 5 Gerrit-Owner: Liu Liu <ot_liu.liu(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Liu Liu <ot_liu.liu(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Tue, 25 Feb 2025 03:56:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: libpayload/tests: Remove unused test files
by Maximilian Brune (Code Review) 24 Feb '25

24 Feb '25

Attention is currently required from: Elyes Haouas, Jakub "Kuba" Czapiga. Maximilian Brune has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/86536?usp=email ) Change subject: libpayload/tests: Remove unused test files ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86536?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id2cec6a56ba5ce98832aced6fc2cfd8ebda91f02 Gerrit-Change-Number: 86536 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Tue, 25 Feb 2025 02:40:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in blobs[main]: soc/mediatek/mt8196: Update SSPM firmware to v5.0
by Liu Liu (Code Review) 24 Feb '25

24 Feb '25

Attention is currently required from: Liu Liu. Liu Liu has uploaded a new patch set (#5). ( https://review.coreboot.org/c/blobs/+/86586?usp=email ) Change subject: soc/mediatek/mt8196: Update SSPM firmware to v5.0 ...................................................................... soc/mediatek/mt8196: Update SSPM firmware to v5.0 Update sspm.bin to set USB reg to reduce ldm delay time and solve USB audio and video problems. BRANCH=rauru TEST=Build pass and usb 3.0 camera is working properly BUG=b:361690180,b:371733874 Change-Id: I14a9d48920bc9f9d15b5b095f88257d5b5cd4f6e Signed-off-by: Liu Liu <ot_liu.liu(a)mediatek.corp-partner.google.com> --- M soc/mediatek/mt8196/sspm.bin M soc/mediatek/mt8196/sspm.bin.md5 M soc/mediatek/mt8196/sspm_release_notes.txt 3 files changed, 5 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/blobs refs/changes/86/86586/5 -- To view, visit https://review.coreboot.org/c/blobs/+/86586?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I14a9d48920bc9f9d15b5b095f88257d5b5cd4f6e Gerrit-Change-Number: 86586 Gerrit-PatchSet: 5 Gerrit-Owner: Liu Liu <ot_liu.liu(a)mediatek.corp-partner.google.com> Gerrit-CC: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Liu Liu <ot_liu.liu(a)mediatek.corp-partner.google.com>

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/pujjoniru: Add Fn key scancode
by hualin wei (Code Review) 24 Feb '25

24 Feb '25

Attention is currently required from: Qinghong Zeng. hualin wei has posted comments on this change by hualin wei. ( https://review.coreboot.org/c/coreboot/+/86589?usp=email ) Change subject: mb/google/nissa/var/pujjoniru: Add Fn key scancode ...................................................................... Patch Set 3: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/86589?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8eb7f253a637741b0aa45aac4d1d59bd0309d559 Gerrit-Change-Number: 86589 Gerrit-PatchSet: 3 Gerrit-Owner: hualin wei <weihualin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-Attention: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Tue, 25 Feb 2025 02:15:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2025