coreboot-gerrit February 2025

coreboot-gerrit@coreboot.org

1 participants
2886 discussions

[XS] Change in coreboot[main]: mb/google/rauru: Correct GPIO name for BEEP_ON
by Jarried Lin (Code Review) 13 Feb '25

13 Feb '25

Attention is currently required from: Hung-Te Lin. Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86391?usp=email ) Change subject: mb/google/rauru: Correct GPIO name for BEEP_ON ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/86391/comment/973254b0_767dea31?us… : PS1, Line 7: to match schematics > `for BEEP_ON` Done -- To view, visit https://review.coreboot.org/c/coreboot/+/86391?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ica48ed4f4e2cd6a159203ba1f8c17ac371a08f87 Gerrit-Change-Number: 86391 Gerrit-PatchSet: 2 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Comment-Date: Thu, 13 Feb 2025 08:00:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/google/rauru: Notify EC that AP is in S0
by Jarried Lin (Code Review) 12 Feb '25

12 Feb '25

Attention is currently required from: Hung-Te Lin, Jarried Lin. Hello Hung-Te Lin, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86381?usp=email to look at the new patch set (#6). Change subject: mb/google/rauru: Notify EC that AP is in S0 ...................................................................... mb/google/rauru: Notify EC that AP is in S0 GPIO_AP_SUSPEND_L is supposed to be high in S0, and low in S3. EC uses this pin to determine the AP power state. This pin should be set as early as possible in bootblock. BRANCH=rauru TEST=Build pass, reboot pass, suspend/resume pass. BUG=b:395737458 Signed-off-by: Wenzhen Yu <wenzhen.yu(a)mediatek.com> Change-Id: I6ea56208256bb6f11fb6b0adf7627403963295bc --- M src/mainboard/google/rauru/chromeos.c M src/mainboard/google/rauru/gpio.h 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/86381/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/86381?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6ea56208256bb6f11fb6b0adf7627403963295bc Gerrit-Change-Number: 86381 Gerrit-PatchSet: 6 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>

1 0

[XS] Change in coreboot[main]: mb/google/rauru: Correct GPIO name for BEEP_ON
by Jarried Lin (Code Review) 12 Feb '25

12 Feb '25

Attention is currently required from: Hung-Te Lin, Jarried Lin. Hello Hung-Te Lin, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86391?usp=email to look at the new patch set (#2). Change subject: mb/google/rauru: Correct GPIO name for BEEP_ON ...................................................................... mb/google/rauru: Correct GPIO name for BEEP_ON Rename GPIO_BEEP_ON_OD to GPIO_BEEP_ON to match the schematics. BRANCH=rauru TEST=Build pass BUG=b:317009620 Change-Id: Ica48ed4f4e2cd6a159203ba1f8c17ac371a08f87 Signed-off-by: Jarried Lin <jarried.lin(a)mediatek.corp-partner.google.com> --- M src/mainboard/google/rauru/chromeos.c M src/mainboard/google/rauru/gpio.h 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/86391/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86391?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ica48ed4f4e2cd6a159203ba1f8c17ac371a08f87 Gerrit-Change-Number: 86391 Gerrit-PatchSet: 2 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>

1 0

[XS] Change in coreboot[main]: mb/google/rex/var/kanix: Update LAN clock request setting
by Kenneth Chan (Code Review) 12 Feb '25

12 Feb '25

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub "Kuba" Czapiga, Kapil Porwal, Ren Kuo, Subrata Banik, Tarun. Hello Dinesh Gehlot, Eran Mitrani, Jakub "Kuba" Czapiga, Kapil Porwal, Ren Kuo, Subrata Banik, Tarun, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86397?usp=email to look at the new patch set (#3). Change subject: mb/google/rex/var/kanix: Update LAN clock request setting ...................................................................... mb/google/rex/var/kanix: Update LAN clock request setting According to the EVT's circuit change, update LAN clock request setting. BUG=b:386025819 BRANCH=firmware-rex-15709.B TEST=emerge-rex coreboot chromeos-bootimage; test LAN function on kanix Change-Id: I5d27585717897203d6ac81ca47551be5771918c3 Signed-off-by: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> --- M src/mainboard/google/rex/variants/kanix/gpio.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/86397/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/86397?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5d27585717897203d6ac81ca47551be5771918c3 Gerrit-Change-Number: 86397 Gerrit-PatchSet: 3 Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com>

1 0

[M] Change in coreboot[main]: mb/google/rauru: Set up open-drain ChromeOS pins
by Yu-Ping Wu (Code Review) 12 Feb '25

12 Feb '25

Yu-Ping Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86398?usp=email ) Change subject: mb/google/rauru: Set up open-drain ChromeOS pins ...................................................................... mb/google/rauru: Set up open-drain ChromeOS pins Set open-drain GPIOs for ChromeOS as input and bias-disable mode. After applying this patch, the voltage of these pins will become the expected value 1.8V (previously 1.0V), preventing wrong judgement of low/high. BUG=b:396106564 TEST=emerge-rauru coreboot BRANCH=rauru Change-Id: I76c7931a56540a395eaf934125bded7fede84992 Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org> --- M src/mainboard/google/rauru/chromeos.c M src/mainboard/google/rauru/gpio.h 2 files changed, 59 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/86398/1 diff --git a/src/mainboard/google/rauru/chromeos.c b/src/mainboard/google/rauru/chromeos.c index 5196fbe..3331639 100644 --- a/src/mainboard/google/rauru/chromeos.c +++ b/src/mainboard/google/rauru/chromeos.c @@ -9,9 +9,37 @@ void setup_chromeos_gpios(void) { - gpio_input(GPIO_EC_AP_INT_ODL); - gpio_input(GPIO_GSC_AP_INT_ODL); + /* Set up open-drain pins */ + gpio_input(GPIO_RSVD_GPI0); + gpio_input(GPIO_EC_AP_DSI_HPD_OD); + gpio_input(GPIO_RSVD_GPI2); + gpio_input(GPIO_AP_WP_ODL); + gpio_input(GPIO_ALS_INT_SCP_ODL); + gpio_input(GPIO_LID_ACCEL_INT_SCP_L); + gpio_input(GPIO_IMU_INT_SCP_L); + gpio_input(GPIO_TCHSCR_INT_1V8_ODL); + gpio_input(GPIO_TCHPAD_INT_ODL); + gpio_input(GPIO_SPKR_INT_ODL); + gpio_input(GPIO_HP_INT_ODL); gpio_input(GPIO_SD_CD_AP_ODL); + gpio_input(GPIO_FP_AP_INT_1V8_S3_ODL); + gpio_input(GPIO_EDP_HPD_1V8); + gpio_input(GPIO_SAR_INT_ODL); + gpio_input(GPIO_RSVD_GPI15); + gpio_input(GPIO_RSVD_GPI16); + gpio_input(GPIO_RSVD_GPI17); + gpio_input(GPIO_GSC_AP_INT_ODL); + gpio_input(GPIO_EC_AP_INT_ODL); + gpio_input(GPIO_RSVD_GPI20); + gpio_input(GPIO_RSVD_GPI21); + gpio_input(GPIO_RSVD_GPI22); + gpio_input(GPIO_EC_AP_DP_HPD_OD); + gpio_input(GPIO_PCIE_SSD_WAKE_OBFF_1V8_ODL); + gpio_input(GPIO_PCIE_SSD_CLKREQ_1V8_ODL); + gpio_input(GPIO_PCIE_WLAN_WAKE_OBFF_1V2_ODL); + gpio_input(GPIO_PCIE_WLAN_CLKREQ_1V2_ODL); + + /* Set up GPIOs */ gpio_output(GPIO_AP_EC_WARM_RST_REQ, 0); gpio_output(GPIO_AP_FP_FW_UP_STRAP, 0); gpio_output(GPIO_BEEP_ON, 0); diff --git a/src/mainboard/google/rauru/gpio.h b/src/mainboard/google/rauru/gpio.h index bdbfc2b..ed7ec89 100644 --- a/src/mainboard/google/rauru/gpio.h +++ b/src/mainboard/google/rauru/gpio.h @@ -5,11 +5,37 @@ #include <soc/gpio.h> +#define GPIO_RSVD_GPI0 GPIO(EINT0) +#define GPIO_EC_AP_DSI_HPD_OD GPIO(EINT1) +#define GPIO_RSVD_GPI2 GPIO(EINT2) +#define GPIO_AP_WP_ODL GPIO(EINT3) +#define GPIO_ALS_INT_SCP_ODL GPIO(EINT4) +#define GPIO_LID_ACCEL_INT_SCP_L GPIO(EINT5) +#define GPIO_IMU_INT_SCP_L GPIO(EINT6) +#define GPIO_TCHSCR_INT_1V8_ODL GPIO(EINT7) +#define GPIO_TCHPAD_INT_ODL GPIO(EINT8) +#define GPIO_SPKR_INT_ODL GPIO(EINT9) +#define GPIO_HP_INT_ODL GPIO(EINT10) +#define GPIO_SD_CD_AP_ODL GPIO(EINT11) +#define GPIO_FP_AP_INT_1V8_S3_ODL GPIO(EINT12) +#define GPIO_EDP_HPD_1V8 GPIO(EINT13) +#define GPIO_SAR_INT_ODL GPIO(EINT14) +#define GPIO_RSVD_GPI15 GPIO(EINT15) +#define GPIO_RSVD_GPI16 GPIO(EINT16) +#define GPIO_RSVD_GPI17 GPIO(EINT17) +#define GPIO_GSC_AP_INT_ODL GPIO(EINT18) +#define GPIO_EC_AP_INT_ODL GPIO(EINT19) +#define GPIO_RSVD_GPI20 GPIO(EINT20) +#define GPIO_RSVD_GPI21 GPIO(EINT21) +#define GPIO_RSVD_GPI22 GPIO(EINT22) +#define GPIO_EC_AP_DP_HPD_OD GPIO(EINT32) +#define GPIO_PCIE_SSD_WAKE_OBFF_1V8_ODL GPIO(BPI_D_BUS0) +#define GPIO_PCIE_SSD_CLKREQ_1V8_ODL GPIO(BPI_D_BUS2) +#define GPIO_PCIE_WLAN_WAKE_OBFF_1V2_ODL GPIO(PCIE0_WAKEN) +#define GPIO_PCIE_WLAN_CLKREQ_1V2_ODL GPIO(PCIE0_CLKREQN) + #define GPIO_BEEP_ON GPIO(PERIPHERAL_EN1) #define GPIO_EN_SPKR GPIO(PERIPHERAL_EN0) -#define GPIO_SD_CD_AP_ODL GPIO(EINT11) -#define GPIO_GSC_AP_INT_ODL GPIO(EINT18) -#define GPIO_EC_AP_INT_ODL GPIO(EINT19) #define GPIO_XHCI_INIT_DONE GPIO(EINT28) #define GPIO_AP_EC_WARM_RST_REQ GPIO(EINT29) #define GPIO_FP_RST_1V8_S3_L GPIO(EINT26) -- To view, visit https://review.coreboot.org/c/coreboot/+/86398?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I76c7931a56540a395eaf934125bded7fede84992 Gerrit-Change-Number: 86398 Gerrit-PatchSet: 1 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/google/rex/var/kanix: Update LAN clock request setting
by Kenneth Chan (Code Review) 12 Feb '25

12 Feb '25

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub "Kuba" Czapiga, Kapil Porwal, Subrata Banik, Tarun. Kenneth Chan has posted comments on this change by Kenneth Chan. ( https://review.coreboot.org/c/coreboot/+/86397?usp=email ) Change subject: mb/google/rex/var/kanix: Update LAN clock request setting ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/86397?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5d27585717897203d6ac81ca47551be5771918c3 Gerrit-Change-Number: 86397 Gerrit-PatchSet: 2 Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub "Kuba" Czapiga <czapiga(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Thu, 13 Feb 2025 07:52:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/google/rex/var/kanix: Update LAN clock request setting
by Kenneth Chan (Code Review) 12 Feb '25

12 Feb '25

Kenneth Chan has posted comments on this change by Kenneth Chan. ( https://review.coreboot.org/c/coreboot/+/86397?usp=email ) Change subject: mb/google/rex/var/kanix: Update LAN clock request setting ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/86397?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5d27585717897203d6ac81ca47551be5771918c3 Gerrit-Change-Number: 86397 Gerrit-PatchSet: 1 Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 13 Feb 2025 07:49:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: soc/intel/pantherlake: Skip exposing CPUJTAG at kernel
by Subrata Banik (Code Review) 12 Feb '25

12 Feb '25

Attention is currently required from: Dinesh Gehlot, Intel coreboot Reviewers, Jayvik Desai, Kapil Porwal, Pranava Y N. Hello Dinesh Gehlot, Intel coreboot Reviewers, Jayvik Desai, Kapil Porwal, Pranava Y N, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86393?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: soc/intel/pantherlake: Skip exposing CPUJTAG at kernel ...................................................................... soc/intel/pantherlake: Skip exposing CPUJTAG at kernel This patch avoids exposing CPUJTAG GPIO PADs as these are not internal to SoC debugging purpose and shouldn't allow kernel level configuration. TEST=Able to build and boot google/fatat. Change-Id: I4d920acb95275fbf72b83b822eddc41829511626 Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/soc/intel/pantherlake/acpi/gpio.asl 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/86393/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86393?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4d920acb95275fbf72b83b822eddc41829511626 Gerrit-Change-Number: 86393 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/google/brya/Kconfig: Select SYSTEM_TYPE_BOX for Dirks
by Ivy Jian (Code Review) 12 Feb '25

12 Feb '25

Attention is currently required from: David Wu, Derek Huang, Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik. Ivy Jian has posted comments on this change by Ivy Jian. ( https://review.coreboot.org/c/coreboot/+/86392?usp=email ) Change subject: mb/google/brya/Kconfig: Select SYSTEM_TYPE_BOX for Dirks ...................................................................... Patch Set 3: (2 comments) Patchset: PS2: > please split the CLs into two parts […] Done File src/Kconfig: https://review.coreboot.org/c/coreboot/+/86392/comment/3de5775f_9658acde?us… : PS2, Line 659: For devices like chromebox, mac-mini etc. These devices without built-in display and operates on AC supply alone > please use line break ? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/86392?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iabc9afdfdb07d4d6cb4d3fb4b43bfdc3cf2aa383 Gerrit-Change-Number: 86392 Gerrit-PatchSet: 3 Gerrit-Owner: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Thu, 13 Feb 2025 06:55:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/google/rauru: Correct GPIO name to match schematics
by Yu-Ping Wu (Code Review) 12 Feb '25

12 Feb '25

Attention is currently required from: Hung-Te Lin, Jarried Lin. Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86391?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/google/rauru: Correct GPIO name to match schematics ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/86391/comment/93a7f1f7_8ceb991b?us… : PS1, Line 7: to match schematics `for BEEP_ON` -- To view, visit https://review.coreboot.org/c/coreboot/+/86391?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ica48ed4f4e2cd6a159203ba1f8c17ac371a08f87 Gerrit-Change-Number: 86391 Gerrit-PatchSet: 1 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Comment-Date: Thu, 13 Feb 2025 06:53:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2025