Attention is currently required from: Alicja Michalska, Ana Carolina Cabral, Felix Held, Matt DeVillier, Paul Menzel.
Hello Alicja Michalska, Ana Carolina Cabral, Matt DeVillier, Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84500?usp=email
to look at the new patch set (#6).
The following approvals got outdated and were removed:
Verified-1 by build bot (Jenkins)
Change subject: mb/amd/birman_plus: Update devicetree
......................................................................
mb/amd/birman_plus: Update devicetree
The devicetree was still a copy of a previous mainboard.
This patch updates the devicetree for the birman_plus mainboard.
Birman plus is an AMD reference board.
sources:
- document #58168 Rev 1.01 "Birman+ User Guide"
- birman+ schematic
Change-Id: I1cc2e4c8f722048b24d84cf782855ae7a8d64c42
Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com>
---
M src/mainboard/amd/birman_plus/Kconfig
M src/mainboard/amd/birman_plus/devicetree_glinda.cb
2 files changed, 43 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/84500/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/84500?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1cc2e4c8f722048b24d84cf782855ae7a8d64c42
Gerrit-Change-Number: 84500
Gerrit-PatchSet: 6
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Reviewer: Ana Carolina Cabral <ana.cpmelo95(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Ana Carolina Cabral <ana.cpmelo95(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Attention is currently required from: Alicja Michalska, Ana Carolina Cabral, Felix Held, Matt DeVillier, Paul Menzel.
Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/84500?usp=email )
Change subject: mb/amd/birman_plus: Update devicetree
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/amd/birman_plus/devicetree_glinda.cb:
https://review.coreboot.org/c/coreboot/+/84500/comment/0aef1bd2_e08529b5?us… :
PS4, Line 192: device ref gpp_bridge_2_4 on end # GBE
> gpp_bridge_2_5 (wwan), gpp_bridge_3_1 (mxm; probably rather a pcie slot though), and gpp_bridge_3_2 […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/84500?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1cc2e4c8f722048b24d84cf782855ae7a8d64c42
Gerrit-Change-Number: 84500
Gerrit-PatchSet: 5
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Reviewer: Ana Carolina Cabral <ana.cpmelo95(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Ana Carolina Cabral <ana.cpmelo95(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 13 Feb 2025 14:51:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Attention is currently required from: Alicja Michalska, Ana Carolina Cabral, Matt DeVillier, Maximilian Brune, Paul Menzel.
Hello Alicja Michalska, Ana Carolina Cabral, Matt DeVillier, Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84500?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Code-Review+1 by Alicja Michalska, Code-Review+1 by Paul Menzel, Code-Review+2 by Matt DeVillier, Verified+1 by build bot (Jenkins)
Change subject: mb/amd/birman_plus: Update devicetree
......................................................................
mb/amd/birman_plus: Update devicetree
The devicetree was still a copy of a previous mainboard.
This patch updates the devicetree for the birman_plus mainboard.
Birman plus is an AMD reference board.
sources:
- document #58168 Rev 1.01 "Birman+ User Guide"
- birman+ schematic
Change-Id: I1cc2e4c8f722048b24d84cf782855ae7a8d64c42
Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com>
---
M src/mainboard/amd/birman_plus/Kconfig
M src/mainboard/amd/birman_plus/devicetree_glinda.cb
2 files changed, 43 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/84500/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/84500?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1cc2e4c8f722048b24d84cf782855ae7a8d64c42
Gerrit-Change-Number: 84500
Gerrit-PatchSet: 5
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Reviewer: Ana Carolina Cabral <ana.cpmelo95(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Ana Carolina Cabral <ana.cpmelo95(a)gmail.com>
Attention is currently required from: Jarried Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/blobs/+/86380?usp=email )
Change subject: soc/mediatek/mt8196: update mtk_fsp_ramstage to 16174.22.0
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/blobs/+/86380?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: blobs
Gerrit-Branch: main
Gerrit-Change-Id: Ic785a04e576065a250f55a78105abf42b61a15a7
Gerrit-Change-Number: 86380
Gerrit-PatchSet: 3
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Thu, 13 Feb 2025 14:45:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86402?usp=email )
Change subject: drivers/wifi/generic: Add Methods to control CNVi enable GPIO
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/86402?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I09d0011ede6f739511a61daf2f1b317f6500a343
Gerrit-Change-Number: 86402
Gerrit-PatchSet: 6
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 13 Feb 2025 14:29:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86403?usp=email )
Change subject: soc/intel/common: Add support for RTD3 on CNVi
......................................................................
Patch Set 7: -Code-Review
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/86403?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I22292ad97c439e50fe5d7a6b79f77847e71ca62c
Gerrit-Change-Number: 86403
Gerrit-PatchSet: 7
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 13 Feb 2025 14:28:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Dinesh Gehlot, Intel coreboot Reviewers, Jayvik Desai, Kapil Porwal, Paul Menzel, Pranava Y N.
Hello Dinesh Gehlot, Intel coreboot Reviewers, Jayvik Desai, Kapil Porwal, Pranava Y N, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/86393?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: soc/intel/pantherlake: Skip exposing CPUJTAG at kernel
......................................................................
soc/intel/pantherlake: Skip exposing CPUJTAG at kernel
This patch avoids exposing CPUJTAG GPIO PADs as these are internal
GPIO PINs used for SoC debugging purpose and shouldn't allow kernel
level configuration.
TEST=Able to build and boot google/fatat. Decompile ACPI table
using iasl and ensure CPUJTAG entry not present.
Change-Id: I4d920acb95275fbf72b83b822eddc41829511626
Signed-off-by: Subrata Banik <subratabanik(a)google.com>
---
M src/soc/intel/pantherlake/acpi/gpio.asl
M src/soc/intel/pantherlake/include/soc/gpio_soc_defs.h
2 files changed, 7 insertions(+), 36 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/86393/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/86393?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4d920acb95275fbf72b83b822eddc41829511626
Gerrit-Change-Number: 86393
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Attention is currently required from: Felix Held, Fred Reitberger, Intel coreboot Reviewers, Jason Glenesk, Matt DeVillier.
Hello Felix Held, Fred Reitberger, Intel coreboot Reviewers, Jason Glenesk, Matt DeVillier, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/86399?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: soc/{intel,amd}/gpio: Correct SOC GPIO OP
......................................................................
soc/{intel,amd}/gpio: Correct SOC GPIO OP
The current use of `acpigen_write_integer` called via
`acpigen_soc_get_tx_gpio` will produce the below:
```
0x6E = \_SB.PCI0.GTXS /* External reference */
Local0
```
This does not work, as it includes the byte prefix.
Change it to use `acpigen_emit_integer`, so that it produces:
```
Local0 = GTXS (0x6E)
```
This fixes an issue in Device Manager on Windows where devices
report a power failure.
Test=build and boot various starlabs boards, dump SSDT and
verify it's correct.
Change-Id: Id03d7ca0e328917fc8379adb967a2a122c7ff85f
Signed-off-by: Sean Rhodes <sean(a)starlabs.systems>
---
M src/soc/amd/common/block/acpi/gpio.c
M src/soc/intel/common/block/acpi/gpio.c
2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/86399/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/86399?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id03d7ca0e328917fc8379adb967a2a122c7ff85f
Gerrit-Change-Number: 86399
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>