Maxim has posted comments on this change by Maxim. ( https://review.coreboot.org/c/coreboot/+/85552?usp=email )
Change subject: intelp2m/patform/ebg: Add unit tests
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
Thanks for the review!
--
To view, visit https://review.coreboot.org/c/coreboot/+/85552?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I10c313aa543a4e07c6685a7ae4e9d665eef7bf75
Gerrit-Change-Number: 85552
Gerrit-PatchSet: 5
Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 20 Jan 2025 18:55:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85915?usp=email )
Change subject: Documentation: Fix wrong link to commit message guidelines
......................................................................
Documentation: Fix wrong link to commit message guidelines
In the Gerrit guidelines there is an old link pointing to the retired
coreboot wiki (https://www.coreboot.org/Git#Commit_messages) when the
commit message guidelines are referenced. Indeed this section was never
ported over to the new documentation and is missing.
This commit rewrites this guidelines and adds them as a new section
based on what was in the wiki and updates the link accordingly.
Change-Id: I1cd2b13da6fe59697d677c7350d73eda5d486544
Signed-off-by: Werner Zeh <werner.zeh(a)siemens.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/85915
Reviewed-by: Maximilian Brune <maximilian.brune(a)9elements.com>
Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M Documentation/contributing/gerrit_guidelines.md
1 file changed, 48 insertions(+), 1 deletion(-)
Approvals:
build bot (Jenkins): Verified
Matt DeVillier: Looks good to me, approved
Maximilian Brune: Looks good to me, approved
Felix Singer: Looks good to me, approved
diff --git a/Documentation/contributing/gerrit_guidelines.md b/Documentation/contributing/gerrit_guidelines.md
index ce6fa6f..3b92d08 100644
--- a/Documentation/contributing/gerrit_guidelines.md
+++ b/Documentation/contributing/gerrit_guidelines.md
@@ -304,7 +304,7 @@
the files that you’ve changed, and add those people.
* Familiarize yourself with the coreboot [commit message
-guidelines](https://www.coreboot.org/Git#Commit_messages), before pushing
+guidelines](#commit-message-guidelines), before pushing
patches. This will help to keep annoying requests to fix your commit
message to a minimum.
@@ -433,8 +433,55 @@
Requests for clarification and suggestions for updates to these guidelines
should be sent to the coreboot mailing list at <coreboot(a)coreboot.org>.
+Commit message guidelines
+-------------------------
+Git does not enforce a certain style for commit messages. For all aspects of
+Git to work best with, it's important to follow these simple guidelines for
+commit messages:
+
+* The first line of the commit message consists of a short
+ (less than 65 characters, absolute maximum is 75) summary
+* The second line is empty (no whitespace at all)
+* The third and any following number of lines contains a longer description
+ of the commit as is necessary, including relevant background information
+ and quite possibly rationale for why the issue was solved in this particular
+ way. These lines should never be longer than 75 characters.
+* The next line is empty (no whitespace at all)
+* An optional TEST= line which describes the test that was done in order to
+ validate the patch
+* An optional BUG= line to reference to a bug (of [coreboot's bug tracker] or any
+ other) this patch resolves
+* The next line is empty if the optional lines are used
+* A Change-Id: line to let Gerrit track this logical change
+* A Signed-off-by: line according to [Signed-off-by policy](#sign-off-procedure)
+
+Please do not create the Change-Id: and Signed-off-by: entries manually because
+it is boring and error-prone. Instead, please install the commit-msg hook, e.g.
+by running
+```Bash
+make gitconfig
+```
+in coreboot's top-level directory, and let the hook script do it for you.
+And remember to always use
+```Bash
+git commit -s
+```
+to have git add your Signed-off-by: automatically.
+
+When you write your commit message, please keep the following two hints in mind:
+
+* If anyone involved in coreboot reads your comment in a year or so, they
+ shall still be able to understand what your commit is about, without the need
+ to analyze the code.
+* Double-check that you are really committing what you think you are, e.g. by
+ typing the following in the top-level coreboot directory:
+```Bash
+git show
+```
+
[ready changes]: https://review.coreboot.org/q/age:1d+project:coreboot+status:open+is:mergea…
[Developer's Certificate of Origin 1.1]: https://developercertificate.org/
[Creative Commons Attribution-ShareAlike 2.5 License]: https://creativecommons.org/licenses/by-sa/2.5/
[this LKML thread]: https://lkml.org/lkml/2004/5/23/10
[SCO-Linux disputes]: https://en.wikipedia.org/wiki/SCO%E2%80%93Linux_disputes
+[coreboot's bug tracker]: https://ticket.coreboot.org/
--
To view, visit https://review.coreboot.org/c/coreboot/+/85915?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1cd2b13da6fe59697d677c7350d73eda5d486544
Gerrit-Change-Number: 85915
Gerrit-PatchSet: 4
Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Attention is currently required from: Pranava Y N, Tongtong Pan.
Jayvik Desai has posted comments on this change by Tongtong Pan. ( https://review.coreboot.org/c/coreboot/+/85965?usp=email )
Change subject: mb/google/fatcat/var/felino: Modify the felino config for probing TPM I2C
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/85965?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I093c0bad181f133e601f3270de68c0848f847ccf
Gerrit-Change-Number: 85965
Gerrit-PatchSet: 3
Gerrit-Owner: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Gerrit-Comment-Date: Mon, 20 Jan 2025 17:22:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85978?usp=email )
Change subject: soc/mediatek/mt8196: Add RTC driver
......................................................................
Patch Set 5:
(1 comment)
File src/soc/mediatek/mt8196/include/soc/rtc.h:
https://review.coreboot.org/c/coreboot/+/85978/comment/534e56a9_4a73bbdc?us… :
PS1, Line 18: RTC_BBPU_PWREN = BIT(0),
> Sorry, but I'm not quite convinced of that approach. […]
@jarried.lin@mediatek.com
I will handle the code refactoring after the patch is merged. Please revert mt6685_hw.h, mt6685_rtc_hw.h to patchset 2 version.
--
To view, visit https://review.coreboot.org/c/coreboot/+/85978?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3dd337eaa3eed3012ddea300f7e04f2b63fb2daa
Gerrit-Change-Number: 85978
Gerrit-PatchSet: 5
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Shunxi Zhang <ot_shunxi.zhang(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Comment-Date: Mon, 20 Jan 2025 16:44:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shunxi Zhang <ot_shunxi.zhang(a)mediatek.corp-partner.google.com>
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86017?usp=email )
Change subject: soc/mediatek/mt8196: Add thermal driver
......................................................................
Patch Set 10: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/86017?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieef94a6909e4da82461351bcb9292e9d01db3362
Gerrit-Change-Number: 86017
Gerrit-PatchSet: 10
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: Zhaoqing Jiu <zhaoqing.jiu(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Comment-Date: Mon, 20 Jan 2025 16:42:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Hung-Te Lin, Jarried Lin.
Hello Hung-Te Lin, Yidi Lin, Yu-Ping Wu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/86042?usp=email
to look at the new patch set (#6).
Change subject: mb/google/rauru: Add DVFS support in romstage
......................................................................
mb/google/rauru: Add DVFS support in romstage
BUG=b:317009620
TEST=Build passed, boot successful. Verified that the available CPU
frequency ranges are correct using the command:
cat /sys/devices/system/cpu/cpufreq/policy*/scaling_available_frequencies
Change-Id: I6f290946365b4c5a650651ebea30ffc76583d2b2
Signed-off-by: Jarried Lin <jarried.lin(a)mediatek.corp-partner.google.com>
---
M src/mainboard/google/rauru/romstage.c
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/86042/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/86042?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6f290946365b4c5a650651ebea30ffc76583d2b2
Gerrit-Change-Number: 86042
Gerrit-PatchSet: 6
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>