coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
3269 discussions

[XS] Change in coreboot[main]: mb/starlabs/starbook/adl_n: Remove SSD detect delay
by Sean Rhodes (Code Review) 21 Jan '25

21 Jan '25

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86074?usp=email ) Change subject: mb/starlabs/starbook/adl_n: Remove SSD detect delay ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/86074?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9a234d8653c026b09411aa5b63ecba477aef325f Gerrit-Change-Number: 86074 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 21 Jan 2025 14:37:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: mb/starlabs/starbook/adl_n: Disconnect unused GPIOs
by Sean Rhodes (Code Review) 21 Jan '25

21 Jan '25

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86075?usp=email ) Change subject: mb/starlabs/starbook/adl_n: Disconnect unused GPIOs ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/86075?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5e5f7587b59da0b91e7c247b4813c5e78d2c1313 Gerrit-Change-Number: 86075 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 21 Jan 2025 14:37:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/starlabs/starbook/adl_n: Set TCP0 HPD GPIO to DEEP
by Sean Rhodes (Code Review) 21 Jan '25

21 Jan '25

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86076?usp=email ) Change subject: mb/starlabs/starbook/adl_n: Set TCP0 HPD GPIO to DEEP ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/86076?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ida3713bbbce1eb9c6793fec2172005b4dfd54e86 Gerrit-Change-Number: 86076 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 21 Jan 2025 14:36:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/starlabs/starbook/adl_n: Correct the DRAM Sleep GPIO config
by Sean Rhodes (Code Review) 21 Jan '25

21 Jan '25

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86077?usp=email ) Change subject: mb/starlabs/starbook/adl_n: Correct the DRAM Sleep GPIO config ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/86077?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie99903b0947165a70d260f383889421500f10b4c Gerrit-Change-Number: 86077 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 21 Jan 2025 14:36:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/starlabs/starbook/adl_n: Fix inconsistant PLD Name
by Sean Rhodes (Code Review) 21 Jan '25

21 Jan '25

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86082?usp=email ) Change subject: mb/starlabs/starbook/adl_n: Fix inconsistant PLD Name ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/86082?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I10285c081838b358f8708a69317ba6bf3b551eb2 Gerrit-Change-Number: 86082 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 21 Jan 2025 14:36:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/starlabs/starbook/adl_n: Fix PLD Group
by Sean Rhodes (Code Review) 21 Jan '25

21 Jan '25

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86083?usp=email ) Change subject: mb/starlabs/starbook/adl_n: Fix PLD Group ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/86083?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I87928f190af2ed7fd00cb08283036aede7fd6383 Gerrit-Change-Number: 86083 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 21 Jan 2025 14:36:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/starlabs/starbook/adl_n: Correct USB Port Type
by Sean Rhodes (Code Review) 21 Jan '25

21 Jan '25

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86086?usp=email ) Change subject: mb/starlabs/starbook/adl_n: Correct USB Port Type ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/86086?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic6b77f44a2d2607d201a2b097cea41aa361ebbee Gerrit-Change-Number: 86086 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Tue, 21 Jan 2025 14:36:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: ec/starlabs/merlin/acpi: Move Q Events under EC device
by Sean Rhodes (Code Review) 21 Jan '25

21 Jan '25

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86087?usp=email ) Change subject: ec/starlabs/merlin/acpi: Move Q Events under EC device ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/86087?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I58a41ae660ec466a08d4c290ff820b713b866f4f Gerrit-Change-Number: 86087 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Tue, 21 Jan 2025 14:36:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: mb/amd/birman_plus: Kconfig
by Ana Carolina Cabral (Code Review) 21 Jan '25

21 Jan '25

Attention is currently required from: Martin Roth, Paul Menzel. Ana Carolina Cabral has posted comments on this change by Ana Carolina Cabral. ( https://review.coreboot.org/c/coreboot/+/85493?usp=email ) Change subject: mb/amd/birman_plus: Kconfig ...................................................................... Patch Set 17: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85493/comment/c9c0caae_dc22e9d7?us… : PS12, Line 7: mb/amd/birman_plus: Kconfig > Please make it a statement by adding a verb (in imperative mood). Done File src/mainboard/amd/birman_plus/port_descriptors_glinda.c: https://review.coreboot.org/c/coreboot/+/85493/comment/89a16580_8255b208?us… : PS8, Line 87: 14 > So this is just ignored if it's set to disabled? I'd think we'd just want to the GBE/SD entries if W […] Done File src/mainboard/amd/birman_plus/port_descriptors_glinda.c: https://review.coreboot.org/c/coreboot/+/85493/comment/4d244e41_816bf4e4?us… : PS12, Line 42: \ > Not sure what the rule is or if it is important, but should the backslash be aligned with the others […] Done https://review.coreboot.org/c/coreboot/+/85493/comment/f74c07d0_6f7f858a?us… : PS12, Line 44: 15 > Should this value depend on ENABLE_WLAN02_BIRMANPLUS like in patchset 8? Same for 2-lane WWAN Done -- To view, visit https://review.coreboot.org/c/coreboot/+/85493?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia310ea616006479b9a052afb99d08df6a11431f4 Gerrit-Change-Number: 85493 Gerrit-PatchSet: 17 Gerrit-Owner: Ana Carolina Cabral Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-CC: Nick Kochlowski <nickkochlowski(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Tue, 21 Jan 2025 14:27:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Nick Kochlowski <nickkochlowski(a)gmail.com> Comment-In-Reply-To: Martin Roth <martin.roth(a)amd.corp-partner.google.com>

1 0

[M] Change in coreboot[main]: mb/amd/birman_plus: Kconfig
by Ana Carolina Cabral (Code Review) 21 Jan '25

21 Jan '25

Attention is currently required from: Ana Carolina Cabral. Hello Felix Held, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85493?usp=email to look at the new patch set (#17). Change subject: mb/amd/birman_plus: Kconfig ...................................................................... mb/amd/birman_plus: Kconfig Rectify board configuration flags based on the schematics Doc. 105-D99700-00C and User Guide #58168 (NDA). Change-Id: Ia310ea616006479b9a052afb99d08df6a11431f4 Signed-off-by: Ana Carolina Cabral <ana.cabral(a)amd.com> --- M src/mainboard/amd/birman_plus/Kconfig M src/mainboard/amd/birman_plus/ec.c M src/mainboard/amd/birman_plus/port_descriptors_glinda.c 3 files changed, 38 insertions(+), 49 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/85493/17 -- To view, visit https://review.coreboot.org/c/coreboot/+/85493?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia310ea616006479b9a052afb99d08df6a11431f4 Gerrit-Change-Number: 85493 Gerrit-PatchSet: 17 Gerrit-Owner: Ana Carolina Cabral Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-CC: Nick Kochlowski <nickkochlowski(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ana Carolina Cabral

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025