coreboot-gerrit September 2024

coreboot-gerrit@coreboot.org

1 participants
3342 discussions

[M] Change in coreboot[main]: soc/intel/{common,alderlake}: Add missing ADL-N SKUs
by Arthur Heymans (Code Review) 05 Sep '24

05 Sep '24

Attention is currently required from: David Milosevic, Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Michał Żygowski, Nick Vaccaro, Rishika Raj, Subrata Banik. Arthur Heymans has posted comments on this change by Michał Żygowski. ( https://review.coreboot.org/c/coreboot/+/84212?usp=email ) Change subject: soc/intel/{common,alderlake}: Add missing ADL-N SKUs ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/84212/comment/ef4289e4_9b147956?us… : PS1, Line 10: Withotu without. -- To view, visit https://review.coreboot.org/c/coreboot/+/84212?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0fbdb12c6411e4109e68a13960b4570701629bc9 Gerrit-Change-Number: 84212 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Comment-Date: Thu, 05 Sep 2024 14:28:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/google/brox/var/jubilant: Remove STORAGE_UNKNOWN fw_config option
by Karthik Ramasubramanian (Code Review) 05 Sep '24

05 Sep '24

Karthik Ramasubramanian has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84095?usp=email ) Change subject: mb/google/brox/var/jubilant: Remove STORAGE_UNKNOWN fw_config option ...................................................................... mb/google/brox/var/jubilant: Remove STORAGE_UNKNOWN fw_config option With `probe unprovisioned` fw_config rule, there is no need to define an explicit STORAGE_UNKNOWN option. Hence remove it. BUG=None TEST=Build Jubilant FW image. Change-Id: I4f6ace4b39a1ee0b63486d3872b20c8da719ae4a Signed-off-by: Karthikeyan Ramasubramanian <kramasub(a)google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/84095 Reviewed-by: Bob Moragues <moragues(a)google.com> Reviewed-by: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/google/brox/variants/jubilant/fw_config.c M src/mainboard/google/brox/variants/jubilant/overridetree.cb M src/mainboard/google/brox/variants/jubilant/variant.c 3 files changed, 3 insertions(+), 32 deletions(-) Approvals: build bot (Jenkins): Verified Bob Moragues: Looks good to me, but someone else must approve Ren Kuo: Looks good to me, approved diff --git a/src/mainboard/google/brox/variants/jubilant/fw_config.c b/src/mainboard/google/brox/variants/jubilant/fw_config.c index 7341afe..5076c73 100644 --- a/src/mainboard/google/brox/variants/jubilant/fw_config.c +++ b/src/mainboard/google/brox/variants/jubilant/fw_config.c @@ -74,11 +74,9 @@ gpio_configure_pads(lte_disable_pads, ARRAY_SIZE(lte_disable_pads)); } - if (!fw_config_probe(FW_CONFIG(STORAGE, STORAGE_UNKNOWN))) { - if (!fw_config_probe(FW_CONFIG(STORAGE, STORAGE_NVME))) { - printk(BIOS_INFO, "Disable NVMe GPIO pins by fw_config.\n"); - gpio_configure_pads(nvme_disable_pads, ARRAY_SIZE(nvme_disable_pads)); - } + if (!fw_config_probe(FW_CONFIG(STORAGE, STORAGE_NVME))) { + printk(BIOS_INFO, "Disable NVMe GPIO pins by fw_config.\n"); + gpio_configure_pads(nvme_disable_pads, ARRAY_SIZE(nvme_disable_pads)); } } BOOT_STATE_INIT_ENTRY(BS_DEV_ENABLE, BS_ON_ENTRY, fw_config_handle, NULL); diff --git a/src/mainboard/google/brox/variants/jubilant/overridetree.cb b/src/mainboard/google/brox/variants/jubilant/overridetree.cb index f6dac2f..52a3236 100644 --- a/src/mainboard/google/brox/variants/jubilant/overridetree.cb +++ b/src/mainboard/google/brox/variants/jubilant/overridetree.cb @@ -1,6 +1,5 @@ fw_config field STORAGE 2 3 - option STORAGE_UNKNOWN 0 option STORAGE_UFS 1 option STORAGE_NVME 2 end @@ -278,7 +277,6 @@ .flags = PCIE_RP_LTR | PCIE_RP_AER, }" probe STORAGE STORAGE_NVME - probe STORAGE STORAGE_UNKNOWN probe unprovisioned end device ref pcie_rp5 on @@ -320,12 +318,10 @@ device generic 0 alias ish_conf on end end probe STORAGE STORAGE_UFS - probe STORAGE STORAGE_UNKNOWN probe unprovisioned end device ref ufs on probe STORAGE STORAGE_UFS - probe STORAGE STORAGE_UNKNOWN probe unprovisioned end device ref i2c0 on diff --git a/src/mainboard/google/brox/variants/jubilant/variant.c b/src/mainboard/google/brox/variants/jubilant/variant.c index 4b214aa..6cbfe19 100644 --- a/src/mainboard/google/brox/variants/jubilant/variant.c +++ b/src/mainboard/google/brox/variants/jubilant/variant.c @@ -24,26 +24,3 @@ { return get_wifi_sar_fw_config_filename(FW_CONFIG_FIELD(WIFI_BT)); } - -void variant_devtree_update(void) -{ - struct device *ufs = DEV_PTR(ufs); - struct device *ish = DEV_PTR(ish); - struct device *nvme_rp = DEV_PTR(pcie4_0); - - if (fw_config_probe(FW_CONFIG(STORAGE, STORAGE_UNKNOWN)) || (!fw_config_is_provisioned())) { - printk(BIOS_INFO, "fw_config is unprovisioned or storage is unknown so enable all storage's configs.\n"); - return; - } - - if (!fw_config_probe(FW_CONFIG(STORAGE, STORAGE_NVME))) { - printk(BIOS_INFO, "NVMe disabled by fw_config.\n"); - nvme_rp->enabled = 0; - } - - if (!fw_config_probe(FW_CONFIG(STORAGE, STORAGE_UFS))) { - printk(BIOS_INFO, "UFS disabled by fw_config.\n"); - ufs->enabled = 0; - ish->enabled = 0; - } -} -- To view, visit https://review.coreboot.org/c/coreboot/+/84095?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4f6ace4b39a1ee0b63486d3872b20c8da719ae4a Gerrit-Change-Number: 84095 Gerrit-PatchSet: 9 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Bob Moragues <moragues(a)chromium.org> Gerrit-Reviewer: Bob Moragues <moragues(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quantatw.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: mb/google/dedede/var/awasuki: Update touchscreen power sequence
by Karthik Ramasubramanian (Code Review) 05 Sep '24

05 Sep '24

Attention is currently required from: Eric Lai, Tongtong Pan. Karthik Ramasubramanian has posted comments on this change by Tongtong Pan. ( https://review.coreboot.org/c/coreboot/+/84196?usp=email ) Change subject: mb/google/dedede/var/awasuki: Update touchscreen power sequence ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/84196/comment/dae02c56_4d675e9b?us… : PS3, Line 9: Reduce resume time. Have you confirmed that the touchscreen works even after multiple iterations of suspend/resume. I hope there are no issues with the updated power sequence. -- To view, visit https://review.coreboot.org/c/coreboot/+/84196?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I32b2b1c709ecab964a0e449d416c5d0ee2c1d97d Gerrit-Change-Number: 84196 Gerrit-PatchSet: 3 Gerrit-Owner: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Thu, 05 Sep 2024 13:31:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XL] Change in coreboot[main]: mb/starlabs/byte_adl: Add Alder Lake N Byte Mk II
by Matt DeVillier (Code Review) 05 Sep '24

05 Sep '24

Attention is currently required from: Elyes Haouas, Felix Singer, Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/80705?usp=email ) Change subject: mb/starlabs/byte_adl: Add Alder Lake N Byte Mk II ...................................................................... Patch Set 19: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80705?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idff2d883a8c29f0fee9d633708aac92061a45132 Gerrit-Change-Number: 80705 Gerrit-PatchSet: 19 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 05 Sep 2024 13:20:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/starlabs/starbook/rpl: Set I2C0 speed to fast
by Sean Rhodes (Code Review) 05 Sep '24

05 Sep '24

Sean Rhodes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/83627?usp=email ) Change subject: mb/starlabs/starbook/rpl: Set I2C0 speed to fast ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/83627?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6fdbd3124fca27fcd4dced81d8e2aa2f91fe4651 Gerrit-Change-Number: 83627 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: mb/google/dedede/var/awasuki: Update touchscreen power sequence
by Weimin Wu (Code Review) 05 Sep '24

05 Sep '24

Attention is currently required from: Eric Lai, Karthik Ramasubramanian, Tongtong Pan. Weimin Wu has posted comments on this change by Tongtong Pan. ( https://review.coreboot.org/c/coreboot/+/84196?usp=email ) Change subject: mb/google/dedede/var/awasuki: Update touchscreen power sequence ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/84196?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I32b2b1c709ecab964a0e449d416c5d0ee2c1d97d Gerrit-Change-Number: 84196 Gerrit-PatchSet: 3 Gerrit-Owner: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 05 Sep 2024 12:47:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: drivers/i2c/generic: Remove erroneous acpigen_pop_len
by Matt DeVillier (Code Review) 05 Sep '24

05 Sep '24

Attention is currently required from: Martin L Roth, Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84197?usp=email ) Change subject: drivers/i2c/generic: Remove erroneous acpigen_pop_len ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84197?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I913022144813f7f65eac1bcb7c97656f2c513c0b Gerrit-Change-Number: 84197 Gerrit-PatchSet: 5 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Thu, 05 Sep 2024 12:19:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XL] Change in coreboot[main]: mb/starlabs/byte_adl: Add Alder Lake N Byte Mk II
by Sean Rhodes (Code Review) 05 Sep '24

05 Sep '24

Attention is currently required from: Elyes Haouas, Felix Singer, Matt DeVillier, Sean Rhodes. Hello Matt DeVillier, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/80705?usp=email to look at the new patch set (#17). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/starlabs/byte_adl: Add Alder Lake N Byte Mk II ...................................................................... mb/starlabs/byte_adl: Add Alder Lake N Byte Mk II Tested using `edk2` from `github.com/starlabsltd/edk2/tree/uefipayload_vs`: * Windows 11 * Ubuntu 22.04 * Manjaro 22 No known issues. https://starlabs.systems/pages/byte-specification Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: Idff2d883a8c29f0fee9d633708aac92061a45132 --- M Documentation/mainboard/index.md A Documentation/mainboard/starlabs/byte_adl.md A src/mainboard/starlabs/byte_adl/Kconfig A src/mainboard/starlabs/byte_adl/Kconfig.name A src/mainboard/starlabs/byte_adl/Makefile.mk A src/mainboard/starlabs/byte_adl/acpi/cnvi.asl A src/mainboard/starlabs/byte_adl/acpi/ec.asl A src/mainboard/starlabs/byte_adl/acpi/mainboard.asl A src/mainboard/starlabs/byte_adl/acpi/sleep.asl A src/mainboard/starlabs/byte_adl/acpi/superio.asl A src/mainboard/starlabs/byte_adl/board_info.txt A src/mainboard/starlabs/byte_adl/bootblock.c A src/mainboard/starlabs/byte_adl/cmos.default A src/mainboard/starlabs/byte_adl/cmos.layout A src/mainboard/starlabs/byte_adl/dsdt.asl A src/mainboard/starlabs/byte_adl/hda_verb.c A src/mainboard/starlabs/byte_adl/include/variants.h A src/mainboard/starlabs/byte_adl/mainboard.c A src/mainboard/starlabs/byte_adl/smbios.c A src/mainboard/starlabs/byte_adl/variants/mk_ii/Makefile.mk A src/mainboard/starlabs/byte_adl/variants/mk_ii/board.fmd A src/mainboard/starlabs/byte_adl/variants/mk_ii/data.vbt A src/mainboard/starlabs/byte_adl/variants/mk_ii/devicetree.cb A src/mainboard/starlabs/byte_adl/variants/mk_ii/devtree.c A src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c A src/mainboard/starlabs/byte_adl/variants/mk_ii/hda_verb.c A src/mainboard/starlabs/byte_adl/variants/mk_ii/romstage.c A src/mainboard/starlabs/byte_adl/variants/mk_ii/vboot.fmd A src/mainboard/starlabs/byte_adl/vboot.c 29 files changed, 1,550 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/80705/17 -- To view, visit https://review.coreboot.org/c/coreboot/+/80705?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idff2d883a8c29f0fee9d633708aac92061a45132 Gerrit-Change-Number: 80705 Gerrit-PatchSet: 17 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[S] Change in coreboot[main]: soc/intel/alderlake: Migrate Alder Lake to Raptor Lake FSP
by Sean Rhodes (Code Review) 05 Sep '24

05 Sep '24

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84223?usp=email ) Change subject: soc/intel/alderlake: Migrate Alder Lake to Raptor Lake FSP ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/84223?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I245e35487112559462e057fdae38e535a1008afe Gerrit-Change-Number: 84223 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Thu, 05 Sep 2024 11:15:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: util/superiotool/ite: Add extra dumps for IT8613E EC
by Michał Żygowski (Code Review) 05 Sep '24

05 Sep '24

Attention is currently required from: Alicja Michalska, Angel Pons, Felix Held. Michał Żygowski has posted comments on this change by Michał Żygowski. ( https://review.coreboot.org/c/coreboot/+/80318?usp=email ) Change subject: util/superiotool/ite: Add extra dumps for IT8613E EC ...................................................................... Patch Set 8: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/80318/comment/68e4aefb_75f3cc34?us… : PS6, Line 7: util/superiotool/ite: Add extra dumps for IT8613E EC > I can test it next week to see if there's any improvement compared to previous patchset (as temperature reporting is the last issue preventing me from having my port being merged in upstream, it's been stable for a while now). It will show you the relevant registers, but you won't know which one is which. I would like to follow-up later with changes to ITE EC driver in coreboot that programs the registers for FAN and HW monitoring on this chip. I don;t think any of the Protectli devices have an option for attaching a fan, but ODROID has. When I find some free time to play with it more, I can draft some change. -- To view, visit https://review.coreboot.org/c/coreboot/+/80318?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic8fdc56d1b0fbe811e13bc6b800512af654c1cb6 Gerrit-Change-Number: 80318 Gerrit-PatchSet: 8 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 05 Sep 2024 10:52:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Alicja Michalska <ahplka19(a)gmail.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2024