coreboot-gerrit September 2024

coreboot-gerrit@coreboot.org

1 participants
3342 discussions

[S] Change in coreboot[main]: nb/intel/sandybridge: Add Kconfig to set default IGD allocation
by Matt DeVillier (Code Review) 05 Sep '24

05 Sep '24

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84225?usp=email ) Change subject: nb/intel/sandybridge: Add Kconfig to set default IGD allocation ...................................................................... nb/intel/sandybridge: Add Kconfig to set default IGD allocation Add a Kconfig choice to select the default IGD memory allocation, for users/ boards which do not use an option table to set it. TEST=build/boot google/link, verify IGD size changes with selection. Change-Id: I83d57cf4657cfccbb21416c5da05eeff9e95a44f Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/northbridge/intel/sandybridge/Kconfig M src/northbridge/intel/sandybridge/early_init.c 2 files changed, 31 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/84225/1 diff --git a/src/northbridge/intel/sandybridge/Kconfig b/src/northbridge/intel/sandybridge/Kconfig index fa40b06..7c8dba3 100644 --- a/src/northbridge/intel/sandybridge/Kconfig +++ b/src/northbridge/intel/sandybridge/Kconfig @@ -180,4 +180,32 @@ config PRERAM_CBFS_CACHE_SIZE default 0x0 +choice + prompt "Default IGD Memory Allocation" + default IGD_DEFAULT_SIZE_32MB + help + The amount of system memory allocated for the integrated GPU if not + set via a (CMOS-backed) option table. + +config IGD_DEFAULT_SIZE_32MB + bool "32MB" + +config IGD_DEFAULT_SIZE_64MB + bool "64MB" + +config IGD_DEFAULT_SIZE_96MB + bool "96MB" + +config IGD_DEFAULT_SIZE_128MB + bool "128MB" + +endchoice + +config IGD_DEFAULT_INT_VALUE + int + default 0 if IGD_DEFAULT_SIZE_32MB + default 1 if IGD_DEFAULT_SIZE_64MB + default 2 if IGD_DEFAULT_SIZE_96MB + default 3 if IGD_DEFAULT_SIZE_128MB + endif diff --git a/src/northbridge/intel/sandybridge/early_init.c b/src/northbridge/intel/sandybridge/early_init.c index a5ebf9d..60798f0 100644 --- a/src/northbridge/intel/sandybridge/early_init.c +++ b/src/northbridge/intel/sandybridge/early_init.c @@ -86,9 +86,10 @@ printk(BIOS_DEBUG, "Initializing Graphics...\n"); - /* Fall back to 32 MiB for IGD memory by setting GGC[7:3] = 1 */ - gfxsize = get_uint_option("gfx_uma_size", 0); + /* Fall back to IGD_DEFAULT_INT_VALUE for IGD memory */ + gfxsize = get_uint_option("gfx_uma_size", IGD_DEFAULT_INT_VALUE); + /* Program IGD memory allocation by setting GGC[7:3] */ reg16 = pci_read_config16(HOST_BRIDGE, GGC); reg16 &= ~0x00f8; reg16 |= (gfxsize + 1) << 3; -- To view, visit https://review.coreboot.org/c/coreboot/+/84225?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I83d57cf4657cfccbb21416c5da05eeff9e95a44f Gerrit-Change-Number: 84225 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

[M] Change in coreboot[main]: soc/intel/common/block/pmc: Add GPE1 functions
by Cliff Huang (Code Review) 05 Sep '24

05 Sep '24

Attention is currently required from: Anil Kumar K, Bora Guvendik, Hannah Williams, Jamie Ryu, Subrata Banik. Cliff Huang has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/84104?usp=email ) Change subject: soc/intel/common/block/pmc: Add GPE1 functions ...................................................................... Patch Set 11: (4 comments) File src/soc/intel/common/block/pmc/pmclib.c: https://review.coreboot.org/c/coreboot/+/84104/comment/85fbe16a_9f9e2ca6?us… : PS10, Line 296: : /* GPE */ : __weak const char *const *soc_std_gpe1_sts_array(int idx, size_t *a) : { : return NULL; : } : : /* disable the corresponding GPE1 bits based on standard GPE0 bits */ : __weak void soc_pmc_disable_std_gpe1(uint32_t gpe0_mask) : { : } : : /* enable the corresponding GPE1 bits based on standard GPE0 bits */ : __weak void soc_pmc_enable_std_gpe1(uint32_t gpe0_mask) : { : } > move this _weak implementation the file beginning and a comment saying `/* SoC overrides for GPE1 wh […] Done https://review.coreboot.org/c/coreboot/+/84104/comment/f8e733a8_0baea8a0?us… : PS10, Line 329: pmc_disable_gpe1 > can you please move this API after `pmc_disable_gpe0`? Done https://review.coreboot.org/c/coreboot/+/84104/comment/4c8826f8_6b99121f?us… : PS10, Line 396: reset_std_gpe1_status > move after `reset_std_gpe0_status` Done https://review.coreboot.org/c/coreboot/+/84104/comment/f9f52395_25ed52ea?us… : PS10, Line 406: print_std_gpe1_sts > move after `print_std_gpe0_sts`? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/84104?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7ac1fbe6d45cbe0c86c3f72911900d92a186168d Gerrit-Change-Number: 84104 Gerrit-PatchSet: 11 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-CC: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Thu, 05 Sep 2024 16:33:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[M] Change in coreboot[main]: soc/intel/common/block/pmc: Add GPE1 functions
by Cliff Huang (Code Review) 05 Sep '24

05 Sep '24

Attention is currently required from: Anil Kumar K, Bora Guvendik, Cliff Huang, Hannah Williams, Jamie Ryu. Hello Anil Kumar K, Bora Guvendik, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/84104?usp=email to look at the new patch set (#11). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: soc/intel/common/block/pmc: Add GPE1 functions ...................................................................... soc/intel/common/block/pmc: Add GPE1 functions - Requires CONFIG_SOC_INTEL_COMMON_BLOCK_ACPI_GPE1 flag. - The existing static gpe functions has been renamed with gpe0. - Add gpe1 functions. BUG=362310295 TEST=Build with CONFIG_SOC_INTEL_COMMON_BLOCK_ACPI_GPE1 flag, boot DUT, and check if GPE1 sts bits have been printed during boot. Signed-off-by: Cliff Huang <cliff.huang(a)intel.com> Change-Id: I7ac1fbe6d45cbe0c86c3f72911900d92a186168d --- M src/soc/intel/common/block/include/intelblocks/pmclib.h M src/soc/intel/common/block/pmc/pmclib.c 2 files changed, 96 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/84104/11 -- To view, visit https://review.coreboot.org/c/coreboot/+/84104?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7ac1fbe6d45cbe0c86c3f72911900d92a186168d Gerrit-Change-Number: 84104 Gerrit-PatchSet: 11 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-CC: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com>

1 0

[S] Change in coreboot[main]: soc/intel/mtl: Hook up GMA ACPI brightness controls
by Tim Crawford (Code Review) 05 Sep '24

05 Sep '24

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun. Tim Crawford has posted comments on this change by Tim Crawford. ( https://review.coreboot.org/c/coreboot/+/82729?usp=email ) Change subject: soc/intel/mtl: Hook up GMA ACPI brightness controls ...................................................................... Patch Set 2: (1 comment) File src/soc/intel/meteorlake/Kconfig: https://review.coreboot.org/c/coreboot/+/82729/comment/4a84251f_b40a6104?us… : PS2, Line 398: INTEL_GMA_BCLV_OFFSET > I'm curious, where exactly are these backlight offset configs used? Are there any subsequent changes […] I've added CB:84224 to use it for system76/mtl. -- To view, visit https://review.coreboot.org/c/coreboot/+/82729?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ied08e5e9fe4913bd60474ed7dcf88b945172558d Gerrit-Change-Number: 82729 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Thu, 05 Sep 2024 15:39:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Dinesh Gehlot <digehlot(a)google.com>

1 0

[S] Change in coreboot[main]: mb/system76/mtl: darp10: Add TCSS configs
by Tim Crawford (Code Review) 05 Sep '24

05 Sep '24

Attention is currently required from: Jeremy Soller, Paul Menzel. Tim Crawford has posted comments on this change by Tim Crawford. ( https://review.coreboot.org/c/coreboot/+/83696?usp=email ) Change subject: mb/system76/mtl: darp10: Add TCSS configs ...................................................................... Patch Set 2: (1 comment) File src/mainboard/system76/mtl/variants/darp10/ramstage.c: https://review.coreboot.org/c/coreboot/+/83696/comment/ab17a035_04983b18?us… : PS1, Line 10: BIT 6 is orientational > So it’s 0 below in 0x82. […] This is an enable/disable bit. I don't know what enabling it actually does. -- To view, visit https://review.coreboot.org/c/coreboot/+/83696?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9bc6c5fc4c13bfa2e31ee1ce334b91e151373b6e Gerrit-Change-Number: 83696 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Thu, 05 Sep 2024 15:31:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/riven: Update GPIO pins for 3rd dmic support
by Felix Held (Code Review) 05 Sep '24

05 Sep '24

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84141?usp=email ) Change subject: mb/google/nissa/var/riven: Update GPIO pins for 3rd dmic support ...................................................................... mb/google/nissa/var/riven: Update GPIO pins for 3rd dmic support When world-facing camera is absent, coreboot need to enable GPP_R6(DMIC_WCAM_CLK) and GPP_R7(DMIC_WCAM_DATA) for 3rd dmic support BUG=b:333973512 TEST=Boot google/riven to OS and verify 3rd dmic working properly. Change-Id: I6c8780ce37b5d3987f5cdf6e6e6d0b4896b33230 Signed-off-by: David Wu <david_wu(a)quanta.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/84141 Reviewed-by: Eric Lai <ericllai(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Kapil Porwal <kapilporwal(a)google.com> Reviewed-by: Jayvik Desai <jayvik(a)google.com> Reviewed-by: Subrata Banik <subratabanik(a)google.com> --- M src/mainboard/google/brya/variants/riven/fw_config.c 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved Kapil Porwal: Looks good to me, approved Eric Lai: Looks good to me, approved Jayvik Desai: Looks good to me, approved diff --git a/src/mainboard/google/brya/variants/riven/fw_config.c b/src/mainboard/google/brya/variants/riven/fw_config.c index b22463f..ba5460b 100644 --- a/src/mainboard/google/brya/variants/riven/fw_config.c +++ b/src/mainboard/google/brya/variants/riven/fw_config.c @@ -25,10 +25,6 @@ PAD_NC_LOCK(GPP_D16, NONE, LOCK_CONFIG), /* H22 : WCAM_MCLK_R */ PAD_NC(GPP_H22, NONE), - /* R6 : DMIC_WCAM_CLK_R */ - PAD_NC(GPP_R6, NONE), - /* R7 : DMIC_WCAM_DATA */ - PAD_NC(GPP_R7, NONE), }; static const struct pad_config stylus_disable_pads[] = { -- To view, visit https://review.coreboot.org/c/coreboot/+/84141?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6c8780ce37b5d3987f5cdf6e6e6d0b4896b33230 Gerrit-Change-Number: 84141 Gerrit-PatchSet: 3 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: soc/intel/common/systemagent: Fix grammer in comments
by Felix Held (Code Review) 05 Sep '24

05 Sep '24

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84199?usp=email ) Change subject: soc/intel/common/systemagent: Fix grammer in comments ...................................................................... soc/intel/common/systemagent: Fix grammer in comments Change-Id: I62d0e324329fdde599e67efb23f813e3b3c650ef Signed-off-by: Yuchi Chen <yuchi.chen(a)intel.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/84199 Reviewed-by: Nicholas Chin <nic.c3.14(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Shuo Liu <shuo.liu(a)intel.com> --- M src/soc/intel/common/block/systemagent/systemagent.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Nicholas Chin: Looks good to me, approved Shuo Liu: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/soc/intel/common/block/systemagent/systemagent.c b/src/soc/intel/common/block/systemagent/systemagent.c index e8d7432..6239a46 100644 --- a/src/soc/intel/common/block/systemagent/systemagent.c +++ b/src/soc/intel/common/block/systemagent/systemagent.c @@ -274,7 +274,7 @@ int index = 0; /** - * If SoC has multiple PCIe domains, only reading resources from the first one. + * If SoC has multiple PCIe domains, only read resources from the first one. */ if (!is_dev_on_domain0(dev)) return; -- To view, visit https://review.coreboot.org/c/coreboot/+/84199?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I62d0e324329fdde599e67efb23f813e3b3c650ef Gerrit-Change-Number: 84199 Gerrit-PatchSet: 2 Gerrit-Owner: yuchi.chen(a)intel.com Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: mb/system76/mtl: Enable gfx register for GMA ACPI
by Tim Crawford (Code Review) 05 Sep '24

05 Sep '24

Tim Crawford has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84224?usp=email ) Change subject: mb/system76/mtl: Enable gfx register for GMA ACPI ...................................................................... mb/system76/mtl: Enable gfx register for GMA ACPI Add gfx register so GMA ACPI data is generated. Fixes brightness controls on Windows. Change-Id: I10948fb2ba670ba5232f1b116acdd1820ad0c07d Signed-off-by: Tim Crawford <tcrawford(a)system76.com> --- M src/mainboard/system76/mtl/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/84224/1 diff --git a/src/mainboard/system76/mtl/devicetree.cb b/src/mainboard/system76/mtl/devicetree.cb index 9a4cfb4..412d4d5 100644 --- a/src/mainboard/system76/mtl/devicetree.cb +++ b/src/mainboard/system76/mtl/devicetree.cb @@ -28,7 +28,7 @@ [DDI_PORT_2] = DDI_ENABLE_HPD | DDI_ENABLE_DDC, }" - #register "gfx" = "GMA_DEFAULT_PANEL(0)" + register "gfx" = "GMA_DEFAULT_PANEL(0)" end device ref ioe_shared_sram on end device ref pmc_shared_sram on end -- To view, visit https://review.coreboot.org/c/coreboot/+/84224?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I10948fb2ba670ba5232f1b116acdd1820ad0c07d Gerrit-Change-Number: 84224 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>

1 0

[XS] Change in coreboot[main]: mb/google/puff: Use auto fan control
by Matt DeVillier (Code Review) 05 Sep '24

05 Sep '24

Matt DeVillier has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/83410?usp=email ) Change subject: mb/google/puff: Use auto fan control ...................................................................... Abandoned dropping as this seems to cause issues on some puff devices -- To view, visit https://review.coreboot.org/c/coreboot/+/83410?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I478cdb95757671d4ecd9c2d45af2aa1d53b4b833 Gerrit-Change-Number: 83410 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>

1 0

[M] Change in coreboot[main]: soc/intel/{common,alderlake}: Add missing ADL-N SKUs
by Subrata Banik (Code Review) 05 Sep '24

05 Sep '24

Attention is currently required from: David Milosevic, Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Michał Żygowski, Nick Vaccaro, Rishika Raj. Subrata Banik has posted comments on this change by Michał Żygowski. ( https://review.coreboot.org/c/coreboot/+/84212?usp=email ) Change subject: soc/intel/{common,alderlake}: Add missing ADL-N SKUs ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84212?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0fbdb12c6411e4109e68a13960b4570701629bc9 Gerrit-Change-Number: 84212 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Comment-Date: Thu, 05 Sep 2024 14:44:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2024