Attention is currently required from: Hung-Te Lin, Mengqi Zhang, Yidi Lin, Yu-Ping Wu.
Kiwi Liu has posted comments on this change by Kiwi Liu. ( https://review.coreboot.org/c/coreboot/+/84298?usp=email )
Change subject: UPSTREAM: soc/mediatek/common: Fix eMMC clock
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84298/comment/a972f32a_009d2449?us… :
PS1, Line 7: WIP:
> Is this patch ready for review ?
Done
https://review.coreboot.org/c/coreboot/+/84298/comment/ea604c64_f56cf4cd?us… :
PS1, Line 9: 2-3 MHz
> MHz is used to describe the frequency not the interval.
Done
https://review.coreboot.org/c/coreboot/+/84298/comment/a27d24c0_ea0ec0a0?us… :
PS1, Line 14: emerge-corsola coreboot
> does it impact the boot time ?
Impact can be ignored, because only very few commands in coreboot.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84298?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9c8836b23fb21e9b0bdc80fbe85142ea0fa5e381
Gerrit-Change-Number: 84298
Gerrit-PatchSet: 3
Gerrit-Owner: Kiwi Liu <kiwi.liu(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Mengqi Zhang <mengqi.zhang(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Mengqi Zhang <mengqi.zhang(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Thu, 12 Sep 2024 00:52:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>
Attention is currently required from: Forest Mittelberg, Matt DeVillier.
Peter Marheine has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/84300?usp=email )
Change subject: [RFC] ec/google/chromeec: Guard reading long battery strings
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
Do you know what Windows is doing that causes it to hang, or did you just bisect to the battery change without looking too deeply into what's happening?
EC communication seems like it shouldn't depend on the presence of a Google security chip so I suspect there's something deeper happening, but I don't mind this change as-is since I'm not concerned about availability of this feature on systems that lack a GSC.
File src/ec/google/chromeec/acpi/battery.asl:
https://review.coreboot.org/c/coreboot/+/84300/comment/d26f474e_ac81b544?us… :
PS1, Line 174: #if CONFIG(TPM_GOOGLE_CR50) || CONFIG(TPM_GOOGLE_TI50)
Seems simpler to put these guards inside BRSX (short-circuit to `BRSS=0`), so it only needs to be in one place.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84300?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If3686dc9b82b44202947081ec7e253317deb8fff
Gerrit-Change-Number: 84300
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Forest Mittelberg <bmbm(a)google.com>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Forest Mittelberg <bmbm(a)google.com>
Gerrit-Comment-Date: Wed, 11 Sep 2024 23:44:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Nicholas Chin.
Angel Pons has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/83184?usp=email )
Change subject: util/autoport: Make printing of SPDX headers generic
......................................................................
Patch Set 4:
(1 comment)
File util/autoport/ec_none.go:
https://review.coreboot.org/c/coreboot/+/83184/comment/dd8b48d7_7d820cbe?us… :
PS4, Line 17:
:
: si := Create(ctx, "acpi/superio.asl")
: defer si.Close()
:
: ec := Create(ctx, "acpi/ec.asl")
: defer ec.Close()
> I think we require empty files to be licensed under CC-PDDC or something?
CB:83185
--
To view, visit https://review.coreboot.org/c/coreboot/+/83184?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I24a1ccd0afb7045e878bf6eaae7a23f828a9240d
Gerrit-Change-Number: 83184
Gerrit-PatchSet: 4
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Wed, 11 Sep 2024 23:15:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Attention is currently required from: Martin L Roth, Nicholas Chin.
Angel Pons has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/83185?usp=email )
Change subject: util/autoport: Add CC-PDDC SPDX header to empty files
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83185?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5fdf0c80443a79c082b3d0418d16cd858782b2c9
Gerrit-Change-Number: 83185
Gerrit-PatchSet: 4
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Wed, 11 Sep 2024 23:14:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Nicholas Chin.
Angel Pons has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/83184?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: util/autoport: Make printing of SPDX headers generic
......................................................................
Patch Set 4: Code-Review+2
(2 comments)
File util/autoport/ec_none.go:
https://review.coreboot.org/c/coreboot/+/83184/comment/9d64ed8d_02048f71?us… :
PS4, Line 17:
:
: si := Create(ctx, "acpi/superio.asl")
: defer si.Close()
:
: ec := Create(ctx, "acpi/ec.asl")
: defer ec.Close()
I think we require empty files to be licensed under CC-PDDC or something?
File util/autoport/main.go:
https://review.coreboot.org/c/coreboot/+/83184/comment/d4c07adf_ec8ccef3?us… :
PS4, Line 237: func Add_SPDX(f *os.File, filetype Filetype, license License) {
> `Possible repeated word: 'filetype'`
*smacks checkpatch with a broom*
--
To view, visit https://review.coreboot.org/c/coreboot/+/83184?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I24a1ccd0afb7045e878bf6eaae7a23f828a9240d
Gerrit-Change-Number: 83184
Gerrit-PatchSet: 4
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Wed, 11 Sep 2024 23:14:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Martin L Roth, Nicholas Chin.
Nico Huber has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/83185?usp=email )
Change subject: util/autoport: Add CC-PDDC SPDX header to empty files
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
File util/autoport/main.go:
https://review.coreboot.org/c/coreboot/+/83185/comment/1c3fd224_6cfbcaa1?us… :
PS4, Line 245: }
Suggestion: You could turn it around and have a new function that
calls Add_SPDX() and then adds the comment, to avoid the if, e.g.
Add_Empty_File(name string).
--
To view, visit https://review.coreboot.org/c/coreboot/+/83185?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5fdf0c80443a79c082b3d0418d16cd858782b2c9
Gerrit-Change-Number: 83185
Gerrit-PatchSet: 4
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Wed, 11 Sep 2024 22:30:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes