Attention is currently required from: Nicholas Chin, Paul Menzel.
Felix Singer has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/79012?usp=email )
Change subject: mb/dell: Add Latitude E6530 (Ivy Bridge)
......................................................................
Patch Set 9: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/79012?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9fcd73416018574f8934962f92c8222d0101cb71
Gerrit-Change-Number: 79012
Gerrit-PatchSet: 9
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Mon, 26 Aug 2024 22:24:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Bob Moragues, Eran Mitrani, Karthik Ramasubramanian, Nick Vaccaro, Subrata Banik.
Bob Moragues has posted comments on this change by Karthik Ramasubramanian. ( https://review.coreboot.org/c/coreboot/+/84094?usp=email )
Change subject: mb/google/brox/var/lotso: Remove STORAGE_UNKNOWN fw_config option
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/84094?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia170a6e006cb51e95fbaf3efe1106ca907165eca
Gerrit-Change-Number: 84094
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Bob Moragues <moragues(a)chromium.org>
Gerrit-Reviewer: Bob Moragues <moragues(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Bob Moragues <moragues(a)chromium.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Mon, 26 Aug 2024 21:42:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Bob Moragues, Eran Mitrani, Karthik Ramasubramanian, Ren Kuo.
Bob Moragues has posted comments on this change by Karthik Ramasubramanian. ( https://review.coreboot.org/c/coreboot/+/84095?usp=email )
Change subject: mb/google/brox/var/jubilant: Remove STORAGE_UNKNOWN fw_config option
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/84095?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4f6ace4b39a1ee0b63486d3872b20c8da719ae4a
Gerrit-Change-Number: 84095
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Bob Moragues <moragues(a)chromium.org>
Gerrit-Reviewer: Bob Moragues <moragues(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Ren Kuo <ren.kuo(a)quantatw.com>
Gerrit-Attention: Bob Moragues <moragues(a)chromium.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Mon, 26 Aug 2024 21:41:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Nicholas Chin, Paul Menzel.
Felix Singer has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/79012?usp=email )
Change subject: mb/dell: Add Latitude E6530 (Ivy Bridge)
......................................................................
Patch Set 8:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79012/comment/472f135c_2f50605b?us… :
PS7, Line 10: someone with physical
: access to one sent me the output of autoport which I then modified to
: produce this port.
> Could you ask the person to test it?
It sounds like it was tested as a standalone mainboard, which is good enough for me.
--
To view, visit https://review.coreboot.org/c/coreboot/+/79012?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9fcd73416018574f8934962f92c8222d0101cb71
Gerrit-Change-Number: 79012
Gerrit-PatchSet: 8
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Mon, 26 Aug 2024 21:29:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Karthik Ramasubramanian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84093?usp=email )
Change subject: mb/google/brox: Disable Thunderbolt device
......................................................................
mb/google/brox: Disable Thunderbolt device
This feature is not required in Brox devices. Hence disable the
concerned device.
BUG=None
TEST=Build Brox firmware and boot to OS. Ensure that the concerned
device is disabled in the OS.
Change-Id: I355852c780c552e6f9b2c28508f53580f392c1b9
Signed-off-by: Karthikeyan Ramasubramanian <kramasub(a)google.com>
---
M src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/84093/1
diff --git a/src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb b/src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb
index a82b4f0..02712f9 100644
--- a/src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb
+++ b/src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb
@@ -160,8 +160,8 @@
}"
end
device ref dtt on end
- device ref tbt_pcie_rp0 on end
- device ref tbt_pcie_rp2 on end
+ device ref tbt_pcie_rp0 off end
+ device ref tbt_pcie_rp2 off end
device ref tcss_xhci on end
device ref tcss_dma0 on end
device ref tcss_dma1 on end
--
To view, visit https://review.coreboot.org/c/coreboot/+/84093?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I355852c780c552e6f9b2c28508f53580f392c1b9
Gerrit-Change-Number: 84093
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com>
Attention is currently required from: Arthur Heymans, Cliff Huang, Felix Held, Felix Singer, Lance Zhao, Naresh Solanki, Patrick Rudolph, Tim Wawrzynczak.
Angel Pons has posted comments on this change by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/79404?usp=email )
Change subject: acpi: Add IORT helper functions
......................................................................
Patch Set 5:
(7 comments)
File src/acpi/acpi_iort.c:
https://review.coreboot.org/c/coreboot/+/79404/comment/ac6eadef_3ea3174f?us… :
PS5, Line 9: acpi_iort_its_group_t *its_node_data;
Any reason to declare this in advance?
https://review.coreboot.org/c/coreboot/+/79404/comment/8260def4_1243c3c5?us… :
PS5, Line 11: *its = (acpi_iort_node_t *)current;
This is an exported function, `*its` may be null. Would be great to assert the function's preconditions
https://review.coreboot.org/c/coreboot/+/79404/comment/5418961d_7e123dda?us… :
PS5, Line 36: *smmu_v3 = (acpi_iort_node_t *)current;
Same here
https://review.coreboot.org/c/coreboot/+/79404/comment/24084dc7_4568e83f?us… :
PS5, Line 61: u16 device_name_len = strlen(device_name);
```suggestion
const u16 device_name_len = strlen(device_name);
```
https://review.coreboot.org/c/coreboot/+/79404/comment/a474f575_7ea9cd58?us… :
PS5, Line 63: *nc = (acpi_iort_node_t *)current;
Same here
https://review.coreboot.org/c/coreboot/+/79404/comment/6f05fae8_b652bbbb?us… :
PS5, Line 98: *rc = (acpi_iort_node_t *)current;
Same here
File src/include/acpi/acpi_iort.h:
https://review.coreboot.org/c/coreboot/+/79404/comment/87019951_1101d079?us… :
PS5, Line 113: /* ITS Group */
: unsigned long its_entry(unsigned long current, acpi_iort_t *iort, acpi_iort_node_t **its,
: u32 its_count, u32 *identifiers);
:
: /* SMMUv3 */
: unsigned long smmuv3_entry(unsigned long current, acpi_iort_t *iort, acpi_iort_node_t **smmu_v3,
: u64 base, u32 flags);
:
: /* ID mapping */
: unsigned long id_map_entry(unsigned long current, acpi_iort_node_t *node, u32 input_base,
: u32 id_count, u32 output_base, u32 output_reference, u32 flags);
:
: /* Named Component */
: unsigned long nc_entry(unsigned long current, acpi_iort_t *iort, acpi_iort_node_t **nc,
: u32 node_flags, u64 memory_properties, u32 memory_address_limit,
: char *device_name);
: /* Root Complex */
: unsigned long rc_entry(unsigned long current, acpi_iort_t *node, acpi_iort_node_t **rc,
: u64 memory_properties, u32 ats_attribute, u32 pci_segment_number,
: u8 memory_address_limit, u16 pasid_capabilities);
I would add a namespace-like prefix to these functions, e.g. `its_entry` ---> `acpi_iort_its_entry`.
--
To view, visit https://review.coreboot.org/c/coreboot/+/79404?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7feaf306b5eea21bfc9a2e2a1a2c3ddc3c683c0b
Gerrit-Change-Number: 79404
Gerrit-PatchSet: 5
Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Naresh Solanki <naresh.solanki(a)9elements.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Mon, 26 Aug 2024 20:07:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No