coreboot-gerrit August 2024

coreboot-gerrit@coreboot.org

1 participants
3913 discussions

[S] Change in coreboot[main]: ec/dell/mec5035: Replace defines with enums
by Felix Singer (Code Review) 27 Aug '24

27 Aug '24

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/82998?usp=email ) Change subject: ec/dell/mec5035: Replace defines with enums ...................................................................... ec/dell/mec5035: Replace defines with enums Instead of using defines for command IDs and argument values, use enums to provide more type safety. This also has the effect of moving the command IDs to a more central location instead of defines spread out throughout the header. Change-Id: I788531e8b70e79541213853f177326d217235ef2 Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/82998 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> --- M src/ec/dell/mec5035/mec5035.c M src/ec/dell/mec5035/mec5035.h 2 files changed, 17 insertions(+), 13 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved diff --git a/src/ec/dell/mec5035/mec5035.c b/src/ec/dell/mec5035/mec5035.c index 68b6b2f..dffbb79 100644 --- a/src/ec/dell/mec5035/mec5035.c +++ b/src/ec/dell/mec5035/mec5035.c @@ -66,17 +66,17 @@ return CB_SUCCESS; } -static void ec_command(u8 cmd) +static void ec_command(enum mec5035_cmd cmd) { outb(0, MAILBOX_INDEX); - outb(cmd, MAILBOX_DATA); + outb((u8)cmd, MAILBOX_DATA); wait_ec(); } -u8 mec5035_mouse_touchpad(u8 setting) +u8 mec5035_mouse_touchpad(enum ec_mouse_setting setting) { - u8 buf[15] = {0}; - write_mailbox_regs(&setting, 2, 1); + u8 buf[15] = {(u8)setting}; + write_mailbox_regs(buf, 2, 1); ec_command(CMD_MOUSE_TP); /* The vendor firmware reads 15 bytes starting at index 1, presumably to get some sort of return code. Though I don't know for sure if diff --git a/src/ec/dell/mec5035/mec5035.h b/src/ec/dell/mec5035/mec5035.h index fa15a9d..32f791c 100644 --- a/src/ec/dell/mec5035/mec5035.h +++ b/src/ec/dell/mec5035/mec5035.h @@ -7,16 +7,20 @@ #define NUM_REGISTERS 32 +enum mec5035_cmd { + CMD_MOUSE_TP = 0x1a, + CMD_RADIO_CTRL = 0x2b, + CMD_CPU_OK = 0xc2, +}; + /* Touchpad (TP) and mouse related. The EC seems to default to 0 which results in the TP not working. */ -#define CMD_MOUSE_TP 0x1a -#define SERIAL_MOUSE 0 /* Disable TP, force use of a serial mouse */ -#define PS2_MOUSE 1 /* Disable TP when using a PS/2 mouse */ -#define TP_PS2_MOUSE 2 /* Leave TP enabled when using a PS/2 mouse */ +enum ec_mouse_setting { + SERIAL_MOUSE = 0, /* Disable TP, force use of a serial mouse */ + PS2_MOUSE, /* Disable TP when using a PS/2 mouse */ + TP_PS2_MOUSE /* Leave TP enabled when using a PS/2 mouse */ +}; -#define CMD_CPU_OK 0xc2 - -#define CMD_RADIO_CTRL 0x2b #define RADIO_CTRL_NUM_ARGS 3 enum ec_radio_dev { RADIO_WLAN = 0, @@ -29,7 +33,7 @@ RADIO_ON }; -u8 mec5035_mouse_touchpad(u8 setting); +u8 mec5035_mouse_touchpad(enum ec_mouse_setting setting); void mec5035_cpu_ok(void); void mec5035_early_init(void); void mec5035_control_radio(enum ec_radio_dev device, enum ec_radio_state state); -- To view, visit https://review.coreboot.org/c/coreboot/+/82998?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I788531e8b70e79541213853f177326d217235ef2 Gerrit-Change-Number: 82998 Gerrit-PatchSet: 4 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: ec/dell/mec5035: Replace defines with enums
by Felix Singer (Code Review) 27 Aug '24

27 Aug '24

Attention is currently required from: Nicholas Chin. Felix Singer has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/82998?usp=email ) Change subject: ec/dell/mec5035: Replace defines with enums ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82998?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I788531e8b70e79541213853f177326d217235ef2 Gerrit-Change-Number: 82998 Gerrit-PatchSet: 3 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Mon, 26 Aug 2024 22:32:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: dsm:dsm test not to merge. to test
by Poornima Tom (Code Review) 27 Aug '24

27 Aug '24

Attention is currently required from: Poornima Tom. Hello Poornima Tom, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/84096?usp=email to review the following change. Change subject: dsm:dsm test not to merge. to test ...................................................................... dsm:dsm test not to merge. to test Change-Id: I979ddb5a9993a491ea48edaaf2a5ad2653430799 Signed-off-by: Poornima Tom <poornima.tom(a)intel.corp-partner.google.com> --- M src/drivers/wifi/generic/acpi.c 1 file changed, 14 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/84096/1 diff --git a/src/drivers/wifi/generic/acpi.c b/src/drivers/wifi/generic/acpi.c index 81620f7..ae63cf9 100644 --- a/src/drivers/wifi/generic/acpi.c +++ b/src/drivers/wifi/generic/acpi.c @@ -672,8 +672,9 @@ * If device type is PCI, ensure that the device has Intel vendor ID. CBFS SAR and SAR * ACPI tables are currently used only by Intel WiFi devices. */ - if (dev->path.type == DEVICE_PATH_PCI && dev->vendor != PCI_VID_INTEL) - return; + if (dev->path.type == DEVICE_PATH_PCI && dev->vendor != PCI_VID_INTEL) { + printk(BIOS_ERR, "PTOM-dev type PCI!\n"); + return;} /* Retrieve the SAR limits data */ if (get_wifi_sar_limits(&sar_limits) < 0) { @@ -687,10 +688,13 @@ sar_emit_ppag(sar_limits.ppag); sar_emit_wtas(sar_limits.wtas); sar_emit_wbem(sar_limits.wbem); + printk(BIOS_ERR, "PTOM-progressing in getting SAR limits!\n"); /* copy the dsm data to be later used for creating _DSM function */ - if (sar_limits.dsm != NULL) - memcpy(dsm, sar_limits.dsm, sizeof(struct dsm_profile)); + if (sar_limits.dsm != NULL) { + printk(BIOS_ERR, "PTOM- getting SAR limits-> dsm!\n"); + memcpy(dsm, sar_limits.dsm, sizeof(struct dsm_profile));} + printk(BIOS_ERR, "PTOM- !\n"); /* copy the bsar data to be later used for creating Bluetooth BRDS method */ if (sar_limits.bsar != NULL) { @@ -698,6 +702,10 @@ *bsar_loaded = true; } +// free(sar_limits.sar); + printk(BIOS_ERR, "PTOM- getting SAR limits-> dsm!\n"); +printk(BIOS_ERR, "PTOM-SARlimits-> dsm_reg = %d !\n",sar_limits.dsm.regulatory_configurations); +printk(BIOS_ERR, "PTOM-SARlimits-> dsm_reg = %d !\n",sar_limits.dsm.support_ultra_high_band); free(sar_limits.sar); } @@ -768,6 +776,8 @@ emit_sar_acpi_structures(dev, &dsm, &bsar, &bsar_loaded); if (dsm.supported_functions != 0) { + printk(BIOS_ERR, "PTOM - not supported func\n"); + for (int i = 1; i < ARRAY_SIZE(wifi_dsm_callbacks); i++) if (!(dsm.supported_functions & (1 << i))) wifi_dsm_callbacks[i] = NULL; -- To view, visit https://review.coreboot.org/c/coreboot/+/84096?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I979ddb5a9993a491ea48edaaf2a5ad2653430799 Gerrit-Change-Number: 84096 Gerrit-PatchSet: 1 Gerrit-Owner: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Reviewer: Poornima Tom <poornima.tom(a)intel.corp-partner.google.com> Gerrit-Attention: Poornima Tom <poornima.tom(a)intel.corp-partner.google.com>

1 0

[L] Change in coreboot[main]: mb/dell: Add Latitude E6320 (Sandy Bridge)
by Felix Singer (Code Review) 27 Aug '24

27 Aug '24

Attention is currently required from: Nicholas Chin. Felix Singer has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/82130?usp=email ) Change subject: mb/dell: Add Latitude E6320 (Sandy Bridge) ...................................................................... Patch Set 6: (1 comment) File src/mainboard/dell/snb_ivb_latitude/variants/e6320/early_init.c: https://review.coreboot.org/c/coreboot/+/82130/comment/4086a653_7b0e1bb2?us… : PS6, Line 8: const struct southbridge_usb_port mainboard_usb_ports[] = { : }; drop it? -- To view, visit https://review.coreboot.org/c/coreboot/+/82130?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5905f8c6a8dbad56e03bdeedc2179600d0c4ba46 Gerrit-Change-Number: 82130 Gerrit-PatchSet: 6 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Mon, 26 Aug 2024 22:29:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in coreboot[main]: mb/dell: Add Latitude E5420 (Sandy Bridge)
by Felix Singer (Code Review) 27 Aug '24

27 Aug '24

Attention is currently required from: Nicholas Chin. Felix Singer has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/82129?usp=email ) Change subject: mb/dell: Add Latitude E5420 (Sandy Bridge) ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82129?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0283653156083768e1fd451bcf539b4e028589f4 Gerrit-Change-Number: 82129 Gerrit-PatchSet: 6 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Mon, 26 Aug 2024 22:28:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: mb/dell: Add Latitude E5520 (Sandy Bridge)
by Felix Singer (Code Review) 27 Aug '24

27 Aug '24

Attention is currently required from: Nicholas Chin. Felix Singer has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/82128?usp=email ) Change subject: mb/dell: Add Latitude E5520 (Sandy Bridge) ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82128?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic9bfc028d4b8ae01ccc019157bb53e7764671134 Gerrit-Change-Number: 82128 Gerrit-PatchSet: 6 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Mon, 26 Aug 2024 22:28:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: mb/dell: Add Latitude E6520 (Sandy Bridge)
by Felix Singer (Code Review) 27 Aug '24

27 Aug '24

Attention is currently required from: Nicholas Chin. Felix Singer has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/82127?usp=email ) The change is no longer submittable: All-Comments-Resolved and Code-Review are unsatisfied now. Change subject: mb/dell: Add Latitude E6520 (Sandy Bridge) ...................................................................... Patch Set 6: -Code-Review (1 comment) File src/mainboard/dell/snb_ivb_latitude/variants/e6520/early_init.c: https://review.coreboot.org/c/coreboot/+/82127/comment/7c7d02ec_7226468f?us… : PS6, Line 8: const struct southbridge_usb_port mainboard_usb_ports[] = { : { 1, 1, 0 }, : { 1, 1, 0 }, : { 1, 1, 1 }, : { 1, 1, 1 }, : { 1, 0, 2 }, : { 1, 1, 2 }, : { 1, 0, 3 }, : { 1, 0, 3 }, : { 1, 1, 5 }, : { 1, 1, 5 }, : { 1, 1, 7 }, : { 1, 1, 6 }, : { 1, 0, 6 }, : { 1, 0, 7 }, : }; this differs from the configuration in the devicetree. and this should be dropped anyway. -- To view, visit https://review.coreboot.org/c/coreboot/+/82127?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibdd40cc15642b8d404159d5962670ccc4167a9ec Gerrit-Change-Number: 82127 Gerrit-PatchSet: 6 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Mon, 26 Aug 2024 22:28:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: mb/dell: Add Latitude E6520 (Sandy Bridge)
by Felix Singer (Code Review) 27 Aug '24

27 Aug '24

Attention is currently required from: Nicholas Chin. Felix Singer has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/82127?usp=email ) Change subject: mb/dell: Add Latitude E6520 (Sandy Bridge) ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82127?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibdd40cc15642b8d404159d5962670ccc4167a9ec Gerrit-Change-Number: 82127 Gerrit-PatchSet: 6 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Mon, 26 Aug 2024 22:26:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: mb/dell: Add Latitude E6420 (Sandy Bridge)
by Felix Singer (Code Review) 27 Aug '24

27 Aug '24

Attention is currently required from: Nicholas Chin. Felix Singer has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/82126?usp=email ) Change subject: mb/dell: Add Latitude E6420 (Sandy Bridge) ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82126?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic48d9ea58172a5b13958c8afebcb19c8929c4394 Gerrit-Change-Number: 82126 Gerrit-PatchSet: 6 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Mon, 26 Aug 2024 22:25:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: mb/dell: Add Latitude E5530 (Ivy Bridge)
by Felix Singer (Code Review) 27 Aug '24

27 Aug '24

Attention is currently required from: Nicholas Chin. Felix Singer has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/82125?usp=email ) Change subject: mb/dell: Add Latitude E5530 (Ivy Bridge) ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82125?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idaf6618df70aa19d8e60b2263088737712dec5f0 Gerrit-Change-Number: 82125 Gerrit-PatchSet: 6 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Mon, 26 Aug 2024 22:24:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2024