Attention is currently required from: Jon Murphy, Nick Vaccaro.
Subrata Banik has posted comments on this change by Jon Murphy. ( https://review.coreboot.org/c/coreboot/+/83745?usp=email )
Change subject: mb/google/hatch: Add FP enable for Dratini
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83745?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifc450f51b00b9c3b62268ce94884f5749a3e18c0
Gerrit-Change-Number: 83745
Gerrit-PatchSet: 5
Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Fri, 02 Aug 2024 18:25:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Nick Vaccaro, Subrata Banik.
Jon Murphy has posted comments on this change by Jon Murphy. ( https://review.coreboot.org/c/coreboot/+/83745?usp=email )
Change subject: mb/google/hatch: Add FP enable for Dratini
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/hatch/variants/dratini/ramstage.c:
https://review.coreboot.org/c/coreboot/+/83745/comment/10267567_30044133?us… :
PS4, Line 29: }
> > Not sure what happened to my comment.... […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/83745?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifc450f51b00b9c3b62268ce94884f5749a3e18c0
Gerrit-Change-Number: 83745
Gerrit-PatchSet: 5
Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Fri, 02 Aug 2024 18:20:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Jon Murphy <jpmurphy(a)google.com>
Attention is currently required from: Jon Murphy, Nick Vaccaro.
Hello Nick Vaccaro, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83745?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: mb/google/hatch: Add FP enable for Dratini
......................................................................
mb/google/hatch: Add FP enable for Dratini
Add FP enable/disable based on SKU ID for Dratini. This is meant
to resolve a UMA issue with Dratini devices that had the FPMCU
populated on non-fp devices. Since the FPMCU is present, and the
firmware enables the power GPIO's based on variant, not SKU, the
devices were reporting data on fingerprint errantly.
BUG=b:354769653
BUG=b:200825114
TEST=Flash to Dratini, test FP.
Disable test SKU, flash on Dratini, test FP.
Change-Id: Ifc450f51b00b9c3b62268ce94884f5749a3e18c0
Signed-off-by: Jon Murphy <jpmurphy(a)google.com>
---
M src/mainboard/google/hatch/variants/dratini/include/variant/sku.h
M src/mainboard/google/hatch/variants/dratini/ramstage.c
2 files changed, 31 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/83745/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/83745?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifc450f51b00b9c3b62268ce94884f5749a3e18c0
Gerrit-Change-Number: 83745
Gerrit-PatchSet: 5
Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Attention is currently required from: Benjamin Doron, Lean Sheng Tan, Martin L Roth, Sean Rhodes, Sergii Dmytruk.
Matt DeVillier has posted comments on this change by Sergii Dmytruk. ( https://review.coreboot.org/c/coreboot/+/83737?usp=email )
Change subject: payloads/edk2: set VARIABLE_SUPPORT=SMMSTORE on CONFIG_SMMSTORE_V2
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS1:
> Thanks, I did not look there, thus decided to move this option to `Makefile` for consistency. […]
yes, the Kconfig previously checked for SMMSTORE_V2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83737?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic59f89c0f708f9b144bd35cd18870d0e1c65677d
Gerrit-Change-Number: 83737
Gerrit-PatchSet: 2
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Comment-Date: Fri, 02 Aug 2024 17:45:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>
Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Attention is currently required from: Jon Murphy, Nick Vaccaro.
Subrata Banik has posted comments on this change by Jon Murphy. ( https://review.coreboot.org/c/coreboot/+/83745?usp=email )
Change subject: mb/google/hatch: Add FP enable for Dratini
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/hatch/variants/dratini/ramstage.c:
https://review.coreboot.org/c/coreboot/+/83745/comment/cf0652c1_487d572c?us… :
PS4, Line 29: }
> Not sure what happened to my comment....I didn't add a default case because I was following the style in variant.c. Would you prefer to match style or add the default case?
i have seen cases when Intel asks us to fix the missing default/missing else blobk while they are running code analysers.
Other than that, I'm good with anything
--
To view, visit https://review.coreboot.org/c/coreboot/+/83745?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifc450f51b00b9c3b62268ce94884f5749a3e18c0
Gerrit-Change-Number: 83745
Gerrit-PatchSet: 4
Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Fri, 02 Aug 2024 17:34:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Jon Murphy <jpmurphy(a)google.com>
Attention is currently required from: Arthur Heymans, Felix Held, Patrick Rudolph.
Hello Arthur Heymans, Felix Held, Krystian Hebel, Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83425?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: drivers/smmstore: add logic to disable capsule update handling code
......................................................................
drivers/smmstore: add logic to disable capsule update handling code
This adds a call to SMMSTORE that saves information about availability
of capsules in SMM memory. This new call is ignored when run more than
once, which means that there should be no way of enabling full flash
handling after it was disabled and vice versa.
The call should be always made by the firmware to lock further calls,
otherwise OS could gain full flash access. This is done on entry to
BS_POST_DEVICE, after capsules are obtained in BS_DEV_INIT.
Change-Id: I3dc175ea313aae1edae304520595b82db7206cbb
Signed-off-by: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
---
M src/drivers/efi/capsules.c
M src/drivers/smmstore/smi.c
M src/drivers/smmstore/store.c
M src/include/smmstore.h
4 files changed, 28 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/83425/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/83425?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3dc175ea313aae1edae304520595b82db7206cbb
Gerrit-Change-Number: 83425
Gerrit-PatchSet: 4
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Attention is currently required from: Nick Vaccaro, Subrata Banik.
Jon Murphy has posted comments on this change by Jon Murphy. ( https://review.coreboot.org/c/coreboot/+/83745?usp=email )
Change subject: mb/google/hatch: Add FP enable for Dratini
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/hatch/variants/dratini/ramstage.c:
https://review.coreboot.org/c/coreboot/+/83745/comment/b242f057_88fcdf26?us… :
PS4, Line 29: }
> The behavior change is desired and yes, it's because not all SKUs have a fingerprint sensor. […]
Not sure what happened to my comment....I didn't add a default case because I was following the style in variant.c. Would you prefer to match style or add the default case?
--
To view, visit https://review.coreboot.org/c/coreboot/+/83745?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifc450f51b00b9c3b62268ce94884f5749a3e18c0
Gerrit-Change-Number: 83745
Gerrit-PatchSet: 4
Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Fri, 02 Aug 2024 17:31:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Jon Murphy <jpmurphy(a)google.com>