coreboot-gerrit August 2024

coreboot-gerrit@coreboot.org

1 participants
3913 discussions

[XS] Change in coreboot[main]: mb/google/brox: Tune Touchpad I2C parameters
by Paul Menzel (Code Review) 05 Aug '24

05 Aug '24

Attention is currently required from: Karthik Ramasubramanian, Nick Vaccaro. Paul Menzel has posted comments on this change by Karthik Ramasubramanian. ( https://review.coreboot.org/c/coreboot/+/83755?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/google/brox: Tune Touchpad I2C parameters ...................................................................... Patch Set 1: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/83755/comment/e0db9607_f4f7e001?us… : PS1, Line 9: that it meets the : I2C fast mode specification What does it require? https://review.coreboot.org/c/coreboot/+/83755/comment/5da4a7ca_500ec147?us… : PS1, Line 13: BIOS firmware https://review.coreboot.org/c/coreboot/+/83755/comment/fc2cc217_8e0fe6b2?us… : PS1, Line 13: Confirm the I2C bus : frequency, rise and fall times meet the specification. Please list the measured values. -- To view, visit https://review.coreboot.org/c/coreboot/+/83755?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0006bfb9bb5839ffa1248d9f2ea055160ed0936e Gerrit-Change-Number: 83755 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Bob Moragues <moragues(a)google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 05 Aug 2024 20:25:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: MAINTAINERS: Add google/fatcat entry and update maintainers
by Paul Menzel (Code Review) 05 Aug '24

05 Aug '24

Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Pranava Y N. Paul Menzel has posted comments on this change by Pranava Y N. ( https://review.coreboot.org/c/coreboot/+/83767?usp=email ) Change subject: MAINTAINERS: Add google/fatcat entry and update maintainers ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/83767/comment/5d4ecfb2_2cec0ccd?us… : PS1, Line 7: Add google/fatcat entry and update maintainers Maybe: > Add Subrata and Pranava for new google/fatcat entry https://review.coreboot.org/c/coreboot/+/83767/comment/748c9a0c_24b15812?us… : PS1, Line 10: updated update -- To view, visit https://review.coreboot.org/c/coreboot/+/83767?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5ae0f0d24d43e91c2097c68446bb64b9ae507e2e Gerrit-Change-Number: 83767 Gerrit-PatchSet: 1 Gerrit-Owner: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Mon, 05 Aug 2024 20:22:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: mb/google/brya/var/nova: Adjust Type-C port to USB 2.0 only
by Paul Menzel (Code Review) 05 Aug '24

05 Aug '24

Paul Menzel has posted comments on this change by Pranava Y N. ( https://review.coreboot.org/c/coreboot/+/83707?usp=email ) Change subject: mb/google/brya/var/nova: Adjust Type-C port to USB 2.0 only ...................................................................... Patch Set 10: (1 comment) Patchset: PS4: > Acknowledged I’d preferred, if this suggestion would have been followed. The current message misses the motivation. -- To view, visit https://review.coreboot.org/c/coreboot/+/83707?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4b4025bea41f67224ac35ff2077b1394f2c3e380 Gerrit-Change-Number: 83707 Gerrit-PatchSet: 10 Gerrit-Owner: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 05 Aug 2024 20:21:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[M] Change in coreboot[main]: [for test] test upgrade crossgcc
by Elyes Haouas (Code Review) 05 Aug '24

05 Aug '24

Attention is currently required from: Cliff Huang, Lance Zhao, Martin L Roth, Tim Wawrzynczak. Hello Cliff Huang, Lance Zhao, Martin L Roth, Tim Wawrzynczak, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81419?usp=email to look at the new patch set (#24). Change subject: [for test] test upgrade crossgcc ...................................................................... [for test] test upgrade crossgcc Change-Id: I463c303694c304bb3bf664bc1d914462e7af5dbb Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/acpi/sata.c M src/commonlib/bsd/include/commonlib/bsd/metadata_hash.h M src/commonlib/include/commonlib/loglevel.h M src/include/cpu/intel/smm_reloc.h M util/crossgcc/buildgcc R util/crossgcc/patches/acpica-unix2-20240321_iasl.patch R util/crossgcc/patches/gcc-15-20240804_asan_shadow_offset_callback.patch R util/crossgcc/patches/gcc-15-20240804_gnat.patch R util/crossgcc/patches/gcc-15-20240804_libcpp.patch R util/crossgcc/patches/gcc-15-20240804_libgcc.patch R util/crossgcc/patches/gcc-15-20240804_musl_poisoned_calloc.patch R util/crossgcc/patches/gcc-15-20240804_rv32iafc.patch D util/crossgcc/sum/acpica-unix-20230628.tar.gz.cksum A util/crossgcc/sum/acpica-unix2-20240321.tar.gz.cksum D util/crossgcc/sum/clang-18.1.6.src.tar.xz.cksum A util/crossgcc/sum/clang-18.1.8.src.tar.xz.cksum D util/crossgcc/sum/clang-tools-extra-18.1.6.src.tar.xz.cksum A util/crossgcc/sum/clang-tools-extra-18.1.8.src.tar.xz.cksum D util/crossgcc/sum/cmake-18.1.6.src.tar.xz.cksum A util/crossgcc/sum/cmake-18.1.8.src.tar.xz.cksum D util/crossgcc/sum/cmake-3.29.3.tar.gz.cksum A util/crossgcc/sum/cmake-3.30.2.tar.gz.cksum D util/crossgcc/sum/compiler-rt-18.1.6.src.tar.xz.cksum A util/crossgcc/sum/compiler-rt-18.1.8.src.tar.xz.cksum D util/crossgcc/sum/gcc-14.1.0.tar.xz.cksum A util/crossgcc/sum/gcc-15-20240804.tar.xz.cksum D util/crossgcc/sum/libunwind-18.1.6.src.tar.xz.cksum A util/crossgcc/sum/libunwind-18.1.8.src.tar.xz.cksum D util/crossgcc/sum/lld-18.1.6.src.tar.xz.cksum A util/crossgcc/sum/lld-18.1.8.src.tar.xz.cksum D util/crossgcc/sum/llvm-18.1.6.src.tar.xz.cksum A util/crossgcc/sum/llvm-18.1.8.src.tar.xz.cksum 32 files changed, 35 insertions(+), 23 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/81419/24 -- To view, visit https://review.coreboot.org/c/coreboot/+/81419?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I463c303694c304bb3bf664bc1d914462e7af5dbb Gerrit-Change-Number: 81419 Gerrit-PatchSet: 24 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>

1 0

[XS] Change in coreboot[main]: src/device/Kconfig: Enable eSOL config with libgfx and uGOP
by Jayvik Desai (Code Review) 05 Aug '24

05 Aug '24

Attention is currently required from: Angel Pons, Dinesh Gehlot, Jayvik Desai, Subrata Banik. Jayvik Desai has posted comments on this change by Jayvik Desai. ( https://review.coreboot.org/c/coreboot/+/83705?usp=email ) Change subject: src/device/Kconfig: Enable eSOL config with libgfx and uGOP ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/83705?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic8fe4ca5234de7f8e579f950f6ccbf750f4c7950 Gerrit-Change-Number: 83705 Gerrit-PatchSet: 9 Gerrit-Owner: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 05 Aug 2024 18:49:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: soc/intel/mtl: enable FSP uGOP config in MTL for eSOL
by Jayvik Desai (Code Review) 05 Aug '24

05 Aug '24

Attention is currently required from: Andrey Petrov, Dinesh Gehlot, Jakub Czapiga, Jayvik Desai, Subrata Banik. Jayvik Desai has posted comments on this change by Jayvik Desai. ( https://review.coreboot.org/c/coreboot/+/83769?usp=email ) Change subject: soc/intel/mtl: enable FSP uGOP config in MTL for eSOL ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/83769?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib4589f52080229b1c83915b51272a042b7ac32cd Gerrit-Change-Number: 83769 Gerrit-PatchSet: 8 Gerrit-Owner: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Comment-Date: Mon, 05 Aug 2024 18:49:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: drivers/intel/fsp2: Add config for FSP uGOP eSOL
by Jayvik Desai (Code Review) 05 Aug '24

05 Aug '24

Attention is currently required from: Andrey Petrov, Ronak Kanabar, Subrata Banik. Jayvik Desai has posted comments on this change by Jayvik Desai. ( https://review.coreboot.org/c/coreboot/+/83770?usp=email ) Change subject: drivers/intel/fsp2: Add config for FSP uGOP eSOL ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/83770?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic0426ff7974a141ae9188b0098677b4cc97aee36 Gerrit-Change-Number: 83770 Gerrit-PatchSet: 4 Gerrit-Owner: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Comment-Date: Mon, 05 Aug 2024 18:49:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: [for test] test upgrade crossgcc
by Elyes Haouas (Code Review) 05 Aug '24

05 Aug '24

Attention is currently required from: Cliff Huang, Lance Zhao, Martin L Roth, Tim Wawrzynczak. Hello Cliff Huang, Lance Zhao, Martin L Roth, Tim Wawrzynczak, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81419?usp=email to look at the new patch set (#23). Change subject: [for test] test upgrade crossgcc ...................................................................... [for test] test upgrade crossgcc Change-Id: I463c303694c304bb3bf664bc1d914462e7af5dbb Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/acpi/sata.c M src/commonlib/bsd/include/commonlib/bsd/metadata_hash.h M src/commonlib/include/commonlib/loglevel.h M src/include/cpu/intel/smm_reloc.h M util/crossgcc/buildgcc R util/crossgcc/patches/acpica-unix2-20240321_iasl.patch R util/crossgcc/patches/gcc-15-20240804_asan_shadow_offset_callback.patch R util/crossgcc/patches/gcc-15-20240804_gnat.patch R util/crossgcc/patches/gcc-15-20240804_libcpp.patch R util/crossgcc/patches/gcc-15-20240804_libgcc.patch R util/crossgcc/patches/gcc-15-20240804_musl_poisoned_calloc.patch R util/crossgcc/patches/gcc-15-20240804_rv32iafc.patch D util/crossgcc/sum/acpica-unix-20230628.tar.gz.cksum A util/crossgcc/sum/acpica-unix2-20240321.tar.gz.cksum D util/crossgcc/sum/clang-18.1.6.src.tar.xz.cksum A util/crossgcc/sum/clang-18.1.8.src.tar.xz.cksum D util/crossgcc/sum/clang-tools-extra-18.1.6.src.tar.xz.cksum A util/crossgcc/sum/clang-tools-extra-18.1.8.src.tar.xz.cksum D util/crossgcc/sum/cmake-18.1.6.src.tar.xz.cksum A util/crossgcc/sum/cmake-18.1.8.src.tar.xz.cksum D util/crossgcc/sum/cmake-3.29.3.tar.gz.cksum A util/crossgcc/sum/cmake-3.30.2.tar.gz.cksum D util/crossgcc/sum/compiler-rt-18.1.6.src.tar.xz.cksum A util/crossgcc/sum/compiler-rt-18.1.8.src.tar.xz.cksum D util/crossgcc/sum/gcc-14.1.0.tar.xz.cksum A util/crossgcc/sum/gcc-15-20240728.tar.xz.cksum D util/crossgcc/sum/libunwind-18.1.6.src.tar.xz.cksum A util/crossgcc/sum/libunwind-18.1.8.src.tar.xz.cksum D util/crossgcc/sum/lld-18.1.6.src.tar.xz.cksum A util/crossgcc/sum/lld-18.1.8.src.tar.xz.cksum D util/crossgcc/sum/llvm-18.1.6.src.tar.xz.cksum A util/crossgcc/sum/llvm-18.1.8.src.tar.xz.cksum 32 files changed, 35 insertions(+), 23 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/81419/23 -- To view, visit https://review.coreboot.org/c/coreboot/+/81419?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I463c303694c304bb3bf664bc1d914462e7af5dbb Gerrit-Change-Number: 81419 Gerrit-PatchSet: 23 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>

1 0

[S] Change in coreboot[main]: drivers/intel/fsp2: Add config for FSP uGOP eSOL
by Jayvik Desai (Code Review) 05 Aug '24

05 Aug '24

Jayvik Desai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83770?usp=email ) Change subject: drivers/intel/fsp2: Add config for FSP uGOP eSOL ...................................................................... drivers/intel/fsp2: Add config for FSP uGOP eSOL This patch adds a new config 'FSP_UGOP_EARLY_SIGN_OF_LIFE' to FSP driver code to enable uGOP for early sign of life feature in the SOC using FSP-M BUG=NA TEST=Able to build google/rex and checked the config in output. Change-Id: Ic0426ff7974a141ae9188b0098677b4cc97aee36 Signed-off-by: Jayvik Desai <jayvik(a)google.com> --- M src/drivers/intel/fsp2_0/Kconfig 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/83770/1 diff --git a/src/drivers/intel/fsp2_0/Kconfig b/src/drivers/intel/fsp2_0/Kconfig index 9ea1526..a3d8907 100644 --- a/src/drivers/intel/fsp2_0/Kconfig +++ b/src/drivers/intel/fsp2_0/Kconfig @@ -467,6 +467,16 @@ To be able to use this, FSP has to be compiled with `PcdFspPerformanceEnable` set to `TRUE`. +config FSP_UGOP_EARLY_SIGN_OF_LIFE + bool + default n + select VBT_CBFS_COMPRESSION_DEFAULT_LZ4 + help + Enable the FSP-M Sign-of-Life feature to display a configurable + text message on screen during memory training and CSME update. + This utilizes Intel's underlying uGOP technology to enable + early sign of life (eSOL) as part of FSP-M. + config FSP_ENABLE_SERIAL_DEBUG bool "Output FSP debug messages on serial console" default y -- To view, visit https://review.coreboot.org/c/coreboot/+/83770?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic0426ff7974a141ae9188b0098677b4cc97aee36 Gerrit-Change-Number: 83770 Gerrit-PatchSet: 1 Gerrit-Owner: Jayvik Desai <jayvik(a)google.com>

1 0

[M] Change in coreboot[main]: [for test] test upgrade crossgcc
by Elyes Haouas (Code Review) 05 Aug '24

05 Aug '24

Attention is currently required from: Cliff Huang, Lance Zhao, Martin L Roth, Tim Wawrzynczak. Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/81419?usp=email ) Change subject: [for test] test upgrade crossgcc ...................................................................... Patch Set 21: (1 comment) File src/commonlib/bsd/include/commonlib/bsd/metadata_hash.h: https://review.coreboot.org/c/coreboot/+/81419/comment/7f303df3_f8298a0a?us… : PS21, Line 32: "\xadMdtHsh\x15" this needs `uint8_t magic[15];` , isn't it? -- To view, visit https://review.coreboot.org/c/coreboot/+/81419?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I463c303694c304bb3bf664bc1d914462e7af5dbb Gerrit-Change-Number: 81419 Gerrit-PatchSet: 21 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Comment-Date: Mon, 05 Aug 2024 16:42:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2024