Attention is currently required from: Karthik Ramasubramanian, Nick Vaccaro, Raj Astekar.
Subrata Banik has posted comments on this change by Karthik Ramasubramanian. ( https://review.coreboot.org/c/coreboot/+/83787?usp=email )
Change subject: mb/google/brox: Control HDMI Hot Plug Detect(HPD) during S0ix
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File src/mainboard/google/brox/mainboard.c:
https://review.coreboot.org/c/coreboot/+/83787/comment/0fd4b925_7d7a3aa6?us… :
PS1, Line 18:
: #define HDMI_HPD GPP_A18
can we move this macro inside https://github.com/coreboot/coreboot/blob/main/src/mainboard/google/brox/va… ?
https://review.coreboot.org/c/coreboot/+/83787/comment/35927577_2f2ec806?us… :
PS1, Line 199: mainboard_generate_hdmi_hpd_disable
Thinking loud here. There may be too few scenarios where we may not IGPU enabled, doesn't it make sense to skip just PAD configuration when IGPU itself is not enabled ?
```suggestion
const struct device *igpu = DEV_PTR(igpu);
if (igpu)
mainboard_generate_hdmi_hpd_disable();
```
--
To view, visit https://review.coreboot.org/c/coreboot/+/83787?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8d95f1d5e1286896c026405ac528dcc084cfa931
Gerrit-Change-Number: 83787
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Raj Astekar <raj.astekar(a)intel.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Wed, 07 Aug 2024 12:18:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Sean Rhodes.
Subrata Banik has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83796?usp=email )
Change subject: mb/starlabs/starlite_adl: Remove has_cdm from devicetree
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83796?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I62a9456e9a4f1571328ba6fd09ae383a8fd11767
Gerrit-Change-Number: 83796
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Comment-Date: Wed, 07 Aug 2024 11:58:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: David Wu, Karthik Ramasubramanian, Ren Kuo, Shelley Chen, Sheng-Liang Pan.
Hello David Wu, Karthik Ramasubramanian, Kenneth Chan, Shelley Chen, Sheng-Liang Pan, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83779?usp=email
to look at the new patch set (#7).
Change subject: mb/google/brox/var/jubilant: Add SAR sensor SX9324
......................................................................
mb/google/brox/var/jubilant: Add SAR sensor SX9324
Add SAR Sensor SX9324 for WWAN
BUG=b:345327104
TEST=Build and verify on jubilant
Change-Id: I629117f20ca513dc0c8eaa91744ad33e162ba4bb
Signed-off-by: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/brox/Kconfig
M src/mainboard/google/brox/variants/jubilant/gpio.c
M src/mainboard/google/brox/variants/jubilant/overridetree.cb
3 files changed, 26 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/83779/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/83779?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I629117f20ca513dc0c8eaa91744ad33e162ba4bb
Gerrit-Change-Number: 83779
Gerrit-PatchSet: 7
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Attention: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/81409?usp=email )
Change subject: i2c/drivers/generic: Add support for including a CDM
......................................................................
Patch Set 12:
(1 comment)
Patchset:
PS2:
> Understandable. […]
https://github.com/torvalds/linux/commit/3b4ebff2a1a9e87d9682db1fcd00ed5a36…
--
To view, visit https://review.coreboot.org/c/coreboot/+/81409?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If70c25288d835df7064b4051c43abeb2d6531f3b
Gerrit-Change-Number: 81409
Gerrit-PatchSet: 12
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Wed, 07 Aug 2024 10:48:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems>
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Attention is currently required from: Sean Rhodes.
Angel Pons has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/81409?usp=email )
Change subject: i2c/drivers/generic: Add support for including a CDM
......................................................................
Patch Set 12:
(1 comment)
Patchset:
PS2:
> AMI CRB is protected by about 50 million NDAs
Understandable. Which thing did you add to Linux?
--
To view, visit https://review.coreboot.org/c/coreboot/+/81409?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If70c25288d835df7064b4051c43abeb2d6531f3b
Gerrit-Change-Number: 81409
Gerrit-PatchSet: 12
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Comment-Date: Wed, 07 Aug 2024 10:47:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems>
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>