Attention is currently required from: David Wu, Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Rishika Raj.
Subrata Banik has posted comments on this change by David Wu. ( https://review.coreboot.org/c/coreboot/+/83823?usp=email )
Change subject: mb/google/nissa/var/riven: Add G2 touchscreen support
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83823/comment/78cf0cca_2c607ab5?us… :
PS1, Line 8:
: Add G2 touchscreen GTCH7503 for riven.
redundant.
Rather how about saying something like this
```
This change adds the necessary configuration for the G2 Touchscreen (GTCH7503) device, connected to I2C bus 40. It includes settings for:
* HID descriptor
* Device description
* IRQ configuration
* Detection
* Reset and enable GPIOs with their respective delays
* Power resource handling
* HID descriptor register offset
```
--
To view, visit https://review.coreboot.org/c/coreboot/+/83823?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If17367cd62eb69a1237efe4aa3ca1a0c9640ba4c
Gerrit-Change-Number: 83823
Gerrit-PatchSet: 1
Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Thu, 08 Aug 2024 08:17:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Morris Hsu has uploaded a new patch set (#3). ( https://review.coreboot.org/c/coreboot/+/83821?usp=email )
Change subject: mb/google/brox/jubilant: Add Fn key scancode
......................................................................
mb/google/brox/jubilant: Add Fn key scancode
The Fn key on jubilant emits a scancode of 94 (0x5e).
BUG=b:324079605
TEST=Flash jubilant, boot to Linux kernel, and verify that KEY_FN is
generated when pressed using `evtest`.
Change-Id: I963b0aa85598097fea69ec34d1e79ec0bbec3db3
Signed-off-by: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/brox/Kconfig
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/83821/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/83821?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I963b0aa85598097fea69ec34d1e79ec0bbec3db3
Gerrit-Change-Number: 83821
Gerrit-PatchSet: 3
Gerrit-Owner: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com>
Morris Hsu has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/83821?usp=email )
Change subject: mb/google/brox/jubilant: Add Fn key scancode
......................................................................
mb/google/brox/jubilant: Add Fn key scancode
The Fn key on Lotso emits a scancode of 94 (0x5e).
BUG=b:324079605
TEST=Flash jubilant, boot to Linux kernel, and verify that KEY_FN is
generated when pressed using `evtest`.
Change-Id: I963b0aa85598097fea69ec34d1e79ec0bbec3db3
Signed-off-by: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/brox/Kconfig
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/83821/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83821?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I963b0aa85598097fea69ec34d1e79ec0bbec3db3
Gerrit-Change-Number: 83821
Gerrit-PatchSet: 2
Gerrit-Owner: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com>
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83085?usp=email )
Change subject: commonlib/device_tree.c: Remove incorrect warning
......................................................................
commonlib/device_tree.c: Remove incorrect warning
Currently a warning is printed even if the maximum amount of nodes is
not exceeded.
Remove the warning, since in most cases the maximum amount of nodes
for a given prefix is usually well known. For example the /cpu nodes
always have a maximum of CONFIG_MAX_CPUS.
One may also just want to read the first X amount of nodes matching a
given prefix.
Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com>
Change-Id: Ic1111e8acb72ea1e9159da0d8386f40cbbdbc63f
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83085
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Julius Werner <jwerner(a)chromium.org>
---
M src/commonlib/device_tree.c
1 file changed, 2 insertions(+), 6 deletions(-)
Approvals:
build bot (Jenkins): Verified
Julius Werner: Looks good to me, approved
diff --git a/src/commonlib/device_tree.c b/src/commonlib/device_tree.c
index a8a64ec..cb7a596 100644
--- a/src/commonlib/device_tree.c
+++ b/src/commonlib/device_tree.c
@@ -414,18 +414,14 @@
// walk all children nodes of offset
while ((size = fdt_next_node_name(blob, offset, &node_name))) {
- if (count_results >= results_len) {
- printk(BIOS_WARNING,
- "%s: results_len (%zd) smaller than count_results (%zd)\n",
- __func__, results_len, count_results);
+ // check if there is space left in the results array
+ if (count_results >= results_len)
break;
- }
if (!strncmp(prefix, node_name, prefix_len)) {
// we found a node that matches the prefix
results[count_results++] = offset;
}
-
// node does not match the prefix. skip current node
offset += fdt_skip_node(blob, offset);
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/83085?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic1111e8acb72ea1e9159da0d8386f40cbbdbc63f
Gerrit-Change-Number: 83085
Gerrit-PatchSet: 6
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Attention is currently required from: Hung-Te Lin, Paul Menzel, Xi Chen, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/83703?usp=email )
Change subject: soc/mediatek/common: Refactor EINT driver
......................................................................
Patch Set 4:
(1 comment)
File src/soc/mediatek/common/gpio.c:
https://review.coreboot.org/c/coreboot/+/83703/comment/7deb8cdb_d0afce78?us… :
PS4, Line 124: mtk_eint = gpio_get_eint_reg(gpio);
assert not null. same below
--
To view, visit https://review.coreboot.org/c/coreboot/+/83703?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie53abc23971bfa39250ebd7dd48e28d6b91c5973
Gerrit-Change-Number: 83703
Gerrit-PatchSet: 4
Gerrit-Owner: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Comment-Date: Thu, 08 Aug 2024 08:04:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No