Attention is currently required from: Jarried Lin, Yidi Lin.
Hello Yidi Lin, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/blobs/+/84029?usp=email
to look at the new patch set (#2).
Change subject: soc/mediatek/mt8196: Add MCUPM firmware v1.0
......................................................................
soc/mediatek/mt8196: Add MCUPM firmware v1.0
Add mcupm.bin initial version
TEST=NA
BUG=b:317009620
Change-Id: I639eb495e3499e0ed886368e6581031baaec0b9d
Signed-off-by: Jarried Lin <jarried.lin(a)mediatek.corp-partner.google.com>
---
M soc/mediatek/mt8196/README.md
A soc/mediatek/mt8196/mcupm.bin
A soc/mediatek/mt8196/mcupm.bin.md5
A soc/mediatek/mt8196/mcupm_release_notes.txt
4 files changed, 23 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/blobs refs/changes/29/84029/2
--
To view, visit https://review.coreboot.org/c/blobs/+/84029?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: blobs
Gerrit-Branch: main
Gerrit-Change-Id: I639eb495e3499e0ed886368e6581031baaec0b9d
Gerrit-Change-Number: 84029
Gerrit-PatchSet: 2
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Rishika Raj, Subrata Banik.
Jianeng Ceng has posted comments on this change by Jianeng Ceng. ( https://review.coreboot.org/c/coreboot/+/84137?usp=email )
Change subject: mb/google/nissa/var/teliks: Force audio mute to avoid screen flick
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Why don't ask panel vendor to change their FW?
Based on cost and other project sharing considerations, OEM hope to repair it by the BIOS first.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84137?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iff488f6844c717ef24069c7176e7b8dfb07d8abc
Gerrit-Change-Number: 84137
Gerrit-PatchSet: 1
Gerrit-Owner: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Fri, 30 Aug 2024 03:31:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai <ericllai(a)google.com>
Attention is currently required from: Karthik Ramasubramanian, Marx Wang, Marx Wang, Nick Vaccaro.
Ren Kuo has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/84124?usp=email )
Change subject: mb/google/brox/jubilant: Update GPE0 routing
......................................................................
Patch Set 4: -Code-Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/84124?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic4a7ca07eab0dab234ab025cf77bbb8093b6b9d1
Gerrit-Change-Number: 84124
Gerrit-PatchSet: 4
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Bob Moragues <moragues(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Marx Wang <marx.wang(a)intel.com>
Gerrit-Reviewer: Marx Wang <marx.wang(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Marx Wang <marx.wang(a)intel.com>
Gerrit-Attention: Marx Wang <marx.wang(a)intel.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Fri, 30 Aug 2024 02:36:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Bob Moragues, Karthik Ramasubramanian, Nick Vaccaro, Subrata Banik.
Ren Kuo has posted comments on this change by Karthik Ramasubramanian. ( https://review.coreboot.org/c/coreboot/+/84135?usp=email )
Change subject: mb/google/brox: Remove ACPI Power Resource for Bluetooth device
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/84135?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If6e679aa3f4181e7963ac53d0847b1512959b3a7
Gerrit-Change-Number: 84135
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Bob Moragues <moragues(a)chromium.org>
Gerrit-Reviewer: Bob Moragues <moragues(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Bob Moragues <moragues(a)chromium.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Fri, 30 Aug 2024 02:31:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Jianeng Ceng has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84137?usp=email )
Change subject: mb/google/nissa/var/teliks: Force audio mute to avoid screen flick
......................................................................
mb/google/nissa/var/teliks: Force audio mute to avoid screen flick
Panel CSOT MNB601LS1-3 will flicker once during enter Chrome login
screen, it is because it inserts 12 blank frames if it receives the
unmute in VB-ID.
Always override the mute in VB-ID to avoid Tcon EC detected the
audiomute_flag change.
BUG:b=360243615
BRANCH=firmware-nissa-15217.B
TEST:Verfied on Teliks and cannot reproduce the issue
Change-Id: Iff488f6844c717ef24069c7176e7b8dfb07d8abc
Signed-off-by: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/brya/variants/teliks/variant.c
1 file changed, 18 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/84137/1
diff --git a/src/mainboard/google/brya/variants/teliks/variant.c b/src/mainboard/google/brya/variants/teliks/variant.c
index 7cc4af8..3f7cfd6 100644
--- a/src/mainboard/google/brya/variants/teliks/variant.c
+++ b/src/mainboard/google/brya/variants/teliks/variant.c
@@ -5,6 +5,11 @@
#include <fw_config.h>
#include <sar.h>
#include <soc/gpio_soc_defs.h>
+#include <intelblocks/graphics.h>
+
+/* Per-pipe DDI Function Control 2 */
+#define TRANS_DDI_FUNC_CTL2_A 0x60404
+#define TRANS_DDI_AUDIO_MUTE_OVERRIDE_BITS_FIELDS (3 << 6)
const char *get_wifi_sar_cbfs_filename(void)
{
@@ -36,3 +41,16 @@
ARRAY_SIZE(wifi_pcie_enable_pad));
}
}
+
+void variant_finalize(void)
+{
+ /*
+ * Panel CSOT MNB601LS1-3 will flicker once during enter Chrome login screen,
+ * it is because it inserts 12 blank frames if it receives the unmute in VB-ID.
+ *
+ * Always override the mute in VB-ID to avoid Tcon EC detected the
+ * audiomute_flag change.
+ */
+ graphics_gtt_rmw(TRANS_DDI_FUNC_CTL2_A, ~TRANS_DDI_AUDIO_MUTE_OVERRIDE_BITS_FIELDS,
+ TRANS_DDI_AUDIO_MUTE_OVERRIDE_BITS_FIELDS);
+}
--
To view, visit https://review.coreboot.org/c/coreboot/+/84137?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iff488f6844c717ef24069c7176e7b8dfb07d8abc
Gerrit-Change-Number: 84137
Gerrit-PatchSet: 1
Gerrit-Owner: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Attention is currently required from: Dinesh Gehlot, Julius Werner, Paul Menzel.
Subrata Banik has posted comments on this change by Dinesh Gehlot. ( https://review.coreboot.org/c/coreboot/+/84120?usp=email )
Change subject: vc/google/chromeos: Skip boot info logging if cse sync at payload
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> Do we really need to do this? We've had issues where vboot state is getting confused across additional platform resets (like CSE sync) in the past, I don't think it's necessarily a bad thing to just log the in-between state as well. Either way I don't think a double log is worth making all this more complicated and porting all this code (and adding the future maintenance burden of updating this code in two places, etc.).
We logged vboot_info so late in the boot process to ensure that there were no other agents that could trigger a known reset of the platform. These known agents include FSP boot flow, CSE slot change, and others. We wanted to register vboot information as part of elog so that we could understand if there was any abnormal behavior that caused the boot process to be reinitialized. For example, we wanted to know if the boot process failed from the previous boot, what slot was in use, and so on.
With the planned move of CSE sync to payload, there is another agent that could trigger a platform reset. This is because the CSE slot switch from RO to RW could cause a reset. Therefore, it does not make sense to register vboot information twice in elog, before (coreboot) and after (payload) the CSE slot change. Additionally, if we do not register the vboot information from payload, then we are not capturing the actual boot information event. Instead, we are using information that was interrupted by a CSE slot switch or global reset. Therefore, it makes more sense to avoid the coreboot attempt to log vboot information (when the platform decided to perform CSE switch at payload) and simply add one more entry to the payload. This way, we can still capture one instance of vboot boot information in normal scenarios.
The maintenance burden is one time, like we kept the CSE sync implementation both in coreboot and depthcharge. If time permits later, we shall try to use commonlib to keep only one instance of CSE sync to avoid maintenance overhaul.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84120?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia29ec350facc6850c04bb988027ecb146e648a50
Gerrit-Change-Number: 84120
Gerrit-PatchSet: 2
Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Fri, 30 Aug 2024 02:25:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Attention is currently required from: Karthik Ramasubramanian, Marx Wang, Marx Wang, Nick Vaccaro.
Ren Kuo has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/84124?usp=email )
Change subject: mb/google/brox/jubilant: Update GPE0 routing
......................................................................
Patch Set 4: Code-Review-1
--
To view, visit https://review.coreboot.org/c/coreboot/+/84124?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic4a7ca07eab0dab234ab025cf77bbb8093b6b9d1
Gerrit-Change-Number: 84124
Gerrit-PatchSet: 4
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Bob Moragues <moragues(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Marx Wang <marx.wang(a)intel.com>
Gerrit-Reviewer: Marx Wang <marx.wang(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Marx Wang <marx.wang(a)intel.com>
Gerrit-Attention: Marx Wang <marx.wang(a)intel.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Fri, 30 Aug 2024 01:45:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes