coreboot-gerrit August 2024

coreboot-gerrit@coreboot.org

1 participants
3913 discussions

[S] Change in blobs[main]: soc/mediatek/mt8196: Add dpm.pm and dpm.dm version 1.0
by Jarried Lin (Code Review) 30 Aug '24

30 Aug '24

Attention is currently required from: Yidi Lin, Yu-Ping Wu. Hello Yidi Lin, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/blobs/+/84028?usp=email to look at the new patch set (#4). Change subject: soc/mediatek/mt8196: Add dpm.pm and dpm.dm version 1.0 ...................................................................... soc/mediatek/mt8196: Add dpm.pm and dpm.dm version 1.0 See the README file for details. Change-Id: I91c34f105992f38aa42521f7e11f42a4ccb81856 Signed-off-by: Jarried Lin <jarried.lin(a)mediatek.corp-partner.google.com> --- M soc/mediatek/mt8196/README.md A soc/mediatek/mt8196/dpm.dm A soc/mediatek/mt8196/dpm.dm.md5 A soc/mediatek/mt8196/dpm.pm A soc/mediatek/mt8196/dpm.pm.md5 A soc/mediatek/mt8196/dpm_release_notes.txt 6 files changed, 37 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/blobs refs/changes/28/84028/4 -- To view, visit https://review.coreboot.org/c/blobs/+/84028?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I91c34f105992f38aa42521f7e11f42a4ccb81856 Gerrit-Change-Number: 84028 Gerrit-PatchSet: 4 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com>

1 0

[S] Change in blobs[main]: soc/mediatek/mt8196: Add MCUPM firmware v1.0
by Jarried Lin (Code Review) 30 Aug '24

30 Aug '24

Attention is currently required from: Yidi Lin, Yu-Ping Wu. Hello Yidi Lin, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/blobs/+/84029?usp=email to look at the new patch set (#4). Change subject: soc/mediatek/mt8196: Add MCUPM firmware v1.0 ...................................................................... soc/mediatek/mt8196: Add MCUPM firmware v1.0 Add mcupm.bin initial version TEST=NA BUG=b:317009620 Change-Id: I639eb495e3499e0ed886368e6581031baaec0b9d Signed-off-by: Jarried Lin <jarried.lin(a)mediatek.corp-partner.google.com> --- M soc/mediatek/mt8196/README.md A soc/mediatek/mt8196/mcupm.bin A soc/mediatek/mt8196/mcupm.bin.md5 A soc/mediatek/mt8196/mcupm_release_notes.txt 4 files changed, 23 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/blobs refs/changes/29/84029/4 -- To view, visit https://review.coreboot.org/c/blobs/+/84029?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I639eb495e3499e0ed886368e6581031baaec0b9d Gerrit-Change-Number: 84029 Gerrit-PatchSet: 4 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com>

1 0

[S] Change in blobs[main]: soc/mediatek/mt8196: Add SSPM firmware v1
by Yu-Ping Wu (Code Review) 30 Aug '24

30 Aug '24

Attention is currently required from: Jarried Lin, Yidi Lin. Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/blobs/+/84027?usp=email ) Change subject: soc/mediatek/mt8196: Add SSPM firmware v1 ...................................................................... Patch Set 3: (1 comment) File soc/mediatek/mt8196/sspm.bin.md5: https://review.coreboot.org/c/blobs/+/84027/comment/37e106aa_a12ed12b?usp=e… : PS3, Line 2: cbfd0cac5f9ee49a20a64291de7ab8b4 sspm.bin `-b/--binary` should be passed (`md5sum -b sspm.bin`), resulting an `*` right before the file name. Example: ``` b0d23881d809f3c3ef7d1c9855cedf6d *dram.elf ``` Please correct the other 2 patches as well. -- To view, visit https://review.coreboot.org/c/blobs/+/84027?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I180421be4077198edd4bcabc2d25ed52a3abedda Gerrit-Change-Number: 84027 Gerrit-PatchSet: 3 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 30 Aug 2024 03:56:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in blobs[main]: soc/mediatek/mt8196: Add SSPM firmware v1
by Yu-Ping Wu (Code Review) 30 Aug '24

30 Aug '24

Attention is currently required from: Jarried Lin, Yidi Lin. Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/blobs/+/84027?usp=email ) Change subject: soc/mediatek/mt8196: Add SSPM firmware v1 ...................................................................... Patch Set 3: (1 comment) File soc/mediatek/mt8196/sspm.bin.md5: https://review.coreboot.org/c/blobs/+/84027/comment/99a26095_c493371a?usp=e… : PS3, Line 1: 4da8300c63118b78c2850b53369bd8b6 sspm.bin Which one is correct? -- To view, visit https://review.coreboot.org/c/blobs/+/84027?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I180421be4077198edd4bcabc2d25ed52a3abedda Gerrit-Change-Number: 84027 Gerrit-PatchSet: 3 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 30 Aug 2024 03:53:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XL] Change in coreboot[main]: soc/intel/ptl: Do initial Panther Lake SoC commit till ramstage
by Saurabh Mishra (Code Review) 30 Aug '24

30 Aug '24

Attention is currently required from: Kapil Porwal, Pranava Y N, Subrata Banik. Saurabh Mishra has posted comments on this change by Saurabh Mishra. ( https://review.coreboot.org/c/coreboot/+/83798?usp=email ) Change subject: soc/intel/ptl: Do initial Panther Lake SoC commit till ramstage ...................................................................... Patch Set 62: (1 comment) File src/soc/intel/pantherlake/acpi.c: https://review.coreboot.org/c/coreboot/+/83798/comment/418e459d_6d57df06?us… : PS55, Line 247: (is_devfn_enabled(PCI_DEVFN_DPTF) || : is_devfn_enabled(PCI_DEVFN_IPU) || : is_devfn_enabled(PCI_DEVFN_NPU) || : is_devfn_enabled(PCI_DEVFN_IAA)) > why we need to check these logic twice? […] Hi Subrata, this check is introduced to check if none of the IPs (i.e., DPTF, IPU, NPU, IAA) are enabled, then it should not create the drhd table for nongfxvt. -- To view, visit https://review.coreboot.org/c/coreboot/+/83798?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idc6fb11e9e84c28c7567ae2b7abc1ab832a88362 Gerrit-Change-Number: 83798 Gerrit-PatchSet: 62 Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-CC: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-CC: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-CC: Cliff Huang <cliff.huang(a)intel.com> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-CC: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-CC: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-CC: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-CC: Sanju Jose Thottan <sanjujose.thottan(a)intel.com> Gerrit-CC: Saurabh Mishra <mishra.saurabh(a)intel.corp-partner.google.com> Gerrit-CC: Vikrant L Jadeja <vikrant.l.jadeja(a)intel.com> Gerrit-CC: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Fri, 30 Aug 2024 03:33:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Saurabh Mishra <mishra.saurabh(a)intel.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[S] Change in blobs[main]: soc/mediatek/mt8196: Add MCUPM firmware v1.0
by Jarried Lin (Code Review) 30 Aug '24

30 Aug '24

Attention is currently required from: Yidi Lin, Yu-Ping Wu. Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/blobs/+/84029?usp=email ) Change subject: soc/mediatek/mt8196: Add MCUPM firmware v1.0 ...................................................................... Patch Set 2: (1 comment) File soc/mediatek/mt8196/README.md: https://review.coreboot.org/c/blobs/+/84029/comment/a2a78761_02c4dff9?usp=e… : PS1, Line 22: `$ strings mcupm.bin | grep "MCUPM firmware"` > This doesn't work. Done -- To view, visit https://review.coreboot.org/c/blobs/+/84029?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I639eb495e3499e0ed886368e6581031baaec0b9d Gerrit-Change-Number: 84029 Gerrit-PatchSet: 2 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 30 Aug 2024 03:32:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>

1 0

[S] Change in blobs[main]: soc/mediatek/mt8196: Add dpm.pm and dpm.dm version 1.0
by Jarried Lin (Code Review) 30 Aug '24

30 Aug '24

Attention is currently required from: Yidi Lin, Yu-Ping Wu. Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/blobs/+/84028?usp=email ) Change subject: soc/mediatek/mt8196: Add dpm.pm and dpm.dm version 1.0 ...................................................................... Patch Set 2: (1 comment) File soc/mediatek/mt8196/README.md: https://review.coreboot.org/c/blobs/+/84028/comment/6ea2e5fc_4d2e150a?usp=e… : PS1, Line 50: ## Version > This doesn't work. Done -- To view, visit https://review.coreboot.org/c/blobs/+/84028?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I91c34f105992f38aa42521f7e11f42a4ccb81856 Gerrit-Change-Number: 84028 Gerrit-PatchSet: 2 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 30 Aug 2024 03:32:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>

1 0

[S] Change in blobs[main]: soc/mediatek/mt8196: Add SSPM firmware v1
by Jarried Lin (Code Review) 30 Aug '24

30 Aug '24

Attention is currently required from: Yidi Lin, Yu-Ping Wu. Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/blobs/+/84027?usp=email ) Change subject: soc/mediatek/mt8196: Add SSPM firmware v1 ...................................................................... Patch Set 2: (3 comments) Patchset: PS1: > Missing license.txt. Done File soc/mediatek/mt8196/README.md: https://review.coreboot.org/c/blobs/+/84027/comment/939f741f_c3c57e4b?usp=e… : PS1, Line 23: `$ strings sspm.bin | grep "SSPM firmware"` > This doesn't work. Done https://review.coreboot.org/c/blobs/+/84027/comment/924db1cd_fdd17de0?usp=e… : PS1, Line 24: -------------------------------------------------------------------------------- > One blank line above. Done -- To view, visit https://review.coreboot.org/c/blobs/+/84027?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I180421be4077198edd4bcabc2d25ed52a3abedda Gerrit-Change-Number: 84027 Gerrit-PatchSet: 2 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 30 Aug 2024 03:32:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>

1 0

[S] Change in blobs[main]: soc/mediatek/mt8196: Add SSPM firmware v1
by Jarried Lin (Code Review) 30 Aug '24

30 Aug '24

Attention is currently required from: Jarried Lin, Yidi Lin. Hello Yidi Lin, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/blobs/+/84027?usp=email to look at the new patch set (#2). Change subject: soc/mediatek/mt8196: Add SSPM firmware v1 ...................................................................... soc/mediatek/mt8196: Add SSPM firmware v1 Add sspm.bin to support suspend/resume. TEST=NA BUG=b:317009620 Change-Id: I180421be4077198edd4bcabc2d25ed52a3abedda Signed-off-by: Jarried Lin <jarried.lin(a)mediatek.corp-partner.google.com> --- A soc/mediatek/mt8196/README.md A soc/mediatek/mt8196/license.txt A soc/mediatek/mt8196/sspm.bin A soc/mediatek/mt8196/sspm.bin.md5 A soc/mediatek/mt8196/sspm_release_notes.txt 5 files changed, 40 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/blobs refs/changes/27/84027/2 -- To view, visit https://review.coreboot.org/c/blobs/+/84027?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I180421be4077198edd4bcabc2d25ed52a3abedda Gerrit-Change-Number: 84027 Gerrit-PatchSet: 2 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com>

1 0

[S] Change in blobs[main]: soc/mediatek/mt8196: Add dpm.pm and dpm.dm version 1.0
by Jarried Lin (Code Review) 30 Aug '24

30 Aug '24

Attention is currently required from: Jarried Lin, Yidi Lin. Hello Yidi Lin, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/blobs/+/84028?usp=email to look at the new patch set (#2). Change subject: soc/mediatek/mt8196: Add dpm.pm and dpm.dm version 1.0 ...................................................................... soc/mediatek/mt8196: Add dpm.pm and dpm.dm version 1.0 See the README file for details. Change-Id: I91c34f105992f38aa42521f7e11f42a4ccb81856 Signed-off-by: Jarried Lin <jarried.lin(a)mediatek.corp-partner.google.com> --- M soc/mediatek/mt8196/README.md A soc/mediatek/mt8196/dpm.dm A soc/mediatek/mt8196/dpm.dm.md5 A soc/mediatek/mt8196/dpm.pm A soc/mediatek/mt8196/dpm.pm.md5 A soc/mediatek/mt8196/dpm_release_notes.txt 6 files changed, 37 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/blobs refs/changes/28/84028/2 -- To view, visit https://review.coreboot.org/c/blobs/+/84028?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I91c34f105992f38aa42521f7e11f42a4ccb81856 Gerrit-Change-Number: 84028 Gerrit-PatchSet: 2 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2024