coreboot-gerrit August 2024

coreboot-gerrit@coreboot.org

1 participants
3913 discussions

[S] Change in coreboot[main]: mb/google/fatcat: Add support for soldered-down memory
by Ravishankar Sarawadi (Code Review) 08 Aug '24

08 Aug '24

Attention is currently required from: Dinesh Gehlot, Pranava Y N, Saurabh Mishra, Subrata Banik. Ravishankar Sarawadi has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/83828?usp=email ) Change subject: mb/google/fatcat: Add support for soldered-down memory ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: I will incorporate similar change for Intel RVP. Thanks! -- To view, visit https://review.coreboot.org/c/coreboot/+/83828?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7edc1134630940812186118a29cbbd550f0e3634 Gerrit-Change-Number: 83828 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Thu, 08 Aug 2024 16:26:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: util/spd_tools: Add Intel Panther Lake (PTL) platform
by Ravishankar Sarawadi (Code Review) 08 Aug '24

08 Aug '24

Attention is currently required from: Dinesh Gehlot, Reka Norman, Subrata Banik. Ravishankar Sarawadi has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/83822?usp=email ) Change subject: util/spd_tools: Add Intel Panther Lake (PTL) platform ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83822?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I55c3f49439fb1ad961c6866f03594431e54279b9 Gerrit-Change-Number: 83822 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Comment-Date: Thu, 08 Aug 2024 16:23:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/google/brox/var/jubilant: Add SAR sensor SX9324
by Karthik Ramasubramanian (Code Review) 08 Aug '24

08 Aug '24

Attention is currently required from: Paul Menzel, Ren Kuo, Shelley Chen, Sheng-Liang Pan. Karthik Ramasubramanian has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/83779?usp=email ) Change subject: mb/google/brox/var/jubilant: Add SAR sensor SX9324 ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83779?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I629117f20ca513dc0c8eaa91744ad33e162ba4bb Gerrit-Change-Number: 83779 Gerrit-PatchSet: 8 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Thu, 08 Aug 2024 16:17:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/brox/var/lotso: Enable wifi sar
by Karthik Ramasubramanian (Code Review) 08 Aug '24

08 Aug '24

Attention is currently required from: Kun Liu, Shelley Chen. Karthik Ramasubramanian has posted comments on this change by Kun Liu. ( https://review.coreboot.org/c/coreboot/+/83793?usp=email ) Change subject: mb/google/brox/var/lotso: Enable wifi sar ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83793?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibf5425e72eddc45e376ef4e2d077180dab502200 Gerrit-Change-Number: 83793 Gerrit-PatchSet: 2 Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Jian Tong <tongjian(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Thu, 08 Aug 2024 16:14:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: intel/alderlake: Drop redundant Client/AlderLake* FSP paths
by Subrata Banik (Code Review) 08 Aug '24

08 Aug '24

Attention is currently required from: Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Nico Huber, Rishika Raj, Ronak Kanabar. Subrata Banik has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/83826?usp=email ) Change subject: intel/alderlake: Drop redundant Client/AlderLake* FSP paths ...................................................................... Patch Set 1: (1 comment) File src/soc/intel/alderlake/Kconfig: https://review.coreboot.org/c/coreboot/+/83826/comment/49b4aee3_f43498ff?us… : PS1, Line 413: default "3rdparty/fsp/AlderLakeFspBinPkg/Client/AlderLakeP/Include/" if SOC_INTEL_ALDERLAKE_PCH_P && !SOC_INTEL_RAPTORLAKE > > > Either way we would need additional infrastructure to track which boards > > > shouldn't get the update. And after all, this is the *main* branch. So we > > > should really ask, is it worth the hassle? > > > > I'm leaving this upto you if you think it's okay to enforce all ADL device to switch to converged FW (with RPL). > > > > I have shared my side of the story where forcing ADL to RPL migration involves validation cost and it should leave upto the platform owners if they are okay to offer RPL FSP for their older ADL device or not. > > I don't see us enforcing anything. I'm not saying that you/your CL is enforcing anything rather I'm saying Intel is enforcing ADL only devices with coreboot/FSP to switch to RPL FSP (this will bring additional cost of validation). > There is no policy that I know of that says > platform owners have to validate the upstream main branch. And if anybody wants > to go through and add additional infrastructure to track more FSP versions, I > wouldn't stop them (in fact, I've argued in the past that one submodule pointer > per platform or even per board might be better). > > Subrata, please help me understand the problem you see better to avoid future > friction: > * Do you / does Google validate the upstream main branch with configs that include `CONFIG_FSP_USE_REPO=y`? We don't use FSP repo for blobs and we compile the binary from source. What I have shared in my experience working on converged FSP where some of the ADL device broken and the fixed with later RPL FSP releases. > * Do you know about anybody else who does? > * Does your validation differ for minor FSP updates (that we can have with any submodule pointer update) vs. switching from ADL to converged RPL? The validation/debugging cost includes feature, functionality and stability brokenness issue seen on few ADL devices with RPL FSP. -- To view, visit https://review.coreboot.org/c/coreboot/+/83826?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia9b256ce1940894e2cf31acaa4a83ea39f6723b6 Gerrit-Change-Number: 83826 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Comment-Date: Thu, 08 Aug 2024 15:29:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/teliks: Add DP AUX BIAS connect
by Subrata Banik (Code Review) 08 Aug '24

08 Aug '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Qinghong Zeng, Rishika Raj. Subrata Banik has posted comments on this change by Qinghong Zeng. ( https://review.coreboot.org/c/coreboot/+/83829?usp=email ) Change subject: mb/google/nissa/var/teliks: Add DP AUX BIAS connect ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83829?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id89d02212cdad549d1c26ed51a8d5af0f4e757c6 Gerrit-Change-Number: 83829 Gerrit-PatchSet: 2 Gerrit-Owner: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Thu, 08 Aug 2024 12:51:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/teliks: Configure TPM IRQ for teliks
by Subrata Banik (Code Review) 08 Aug '24

08 Aug '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Qinghong Zeng, Rishika Raj, Weimin Wu. Subrata Banik has posted comments on this change by Qinghong Zeng. ( https://review.coreboot.org/c/coreboot/+/83832?usp=email ) Change subject: mb/google/nissa/var/teliks: Configure TPM IRQ for teliks ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83832?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iaed51e0bb8abac0ed0b35bfcf12e95fd34f92242 Gerrit-Change-Number: 83832 Gerrit-PatchSet: 1 Gerrit-Owner: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Attention: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Thu, 08 Aug 2024 12:50:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: commonlib/bsd: Add strnlen() and strlen() functions
by Maximilian Brune (Code Review) 08 Aug '24

08 Aug '24

Attention is currently required from: Jakub Czapiga, Julius Werner, Yu-Ping Wu. Maximilian Brune has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/83830?usp=email ) Change subject: commonlib/bsd: Add strnlen() and strlen() functions ...................................................................... Patch Set 1: (1 comment) File payloads/libpayload/libc/string.c: https://review.coreboot.org/c/coreboot/+/83830/comment/d88515a2_685329cc?us… : PS1, Line 71: /* NULL and empty strings have length 0. */ : if (!str) : return 0; You don't have this NULL check in the commonlib implementation. If you are unlucky a payload actually calls these functions with a possible NULL value. That would break the payloads if they did depend on that fact before this patch. -- To view, visit https://review.coreboot.org/c/coreboot/+/83830?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1203ec9affabe493bd14b46662d212b08240cced Gerrit-Change-Number: 83830 Gerrit-PatchSet: 1 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Thu, 08 Aug 2024 12:48:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: soc/intel/cmn/block/cse: Add support for explicit CSE_RW_VERSION
by Dinesh Gehlot (Code Review) 08 Aug '24

08 Aug '24

Attention is currently required from: Nick Vaccaro, Subrata Banik. Dinesh Gehlot has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/83831?usp=email ) Change subject: soc/intel/cmn/block/cse: Add support for explicit CSE_RW_VERSION ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83831?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1327c813b7aef77c65766eb9c40003bb8a71d4b6 Gerrit-Change-Number: 83831 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Thu, 08 Aug 2024 12:43:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/teliks: Configure TPM IRQ for teliks
by Qinghong Zeng (Code Review) 08 Aug '24

08 Aug '24

Attention is currently required from: Weimin Wu. Qinghong Zeng has posted comments on this change by Qinghong Zeng. ( https://review.coreboot.org/c/coreboot/+/83832?usp=email ) Change subject: mb/google/nissa/var/teliks: Configure TPM IRQ for teliks ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/83832?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iaed51e0bb8abac0ed0b35bfcf12e95fd34f92242 Gerrit-Change-Number: 83832 Gerrit-PatchSet: 1 Gerrit-Owner: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Thu, 08 Aug 2024 12:41:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2024