Attention is currently required from: Ashish Kumar Mishra, Nico Huber, Saurabh Mishra.
Hello Ashish Kumar Mishra, Nico Huber, Saurabh Mishra, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83887?usp=email
to look at the new patch set (#3).
Change subject: Fix no-op for empty arg in Makefile for Bash 5.2.21
......................................................................
Fix no-op for empty arg in Makefile for Bash 5.2.21
This change addresses an issue in Ubuntu 24.04 with GNU Bash version
5.2.21, where the Makefile failed with the error:
/bin/bash: -c: option requires an argument
make: *** [Makefile.mk:1261: build/coreboot.pre] Error 2
The error was due to an empty third argument `$(3)` in a conditional
`$(if ...)` statement. The original line did not have an explicit no-op
for the case when `$(3)` is empty, leading to an incomplete command.
By adding a colon `:` as a no-op command in the else-part of the `$(if
...)`, we ensure execution of a harmless command when `$(3)` is empty,
preventing the Makefile from failing due to a missing argument.
This fix ensures compatibility with the newer Bash version and prevents
the Makefile from breaking under the specified conditions.
Change-Id: I276e89792779832edf325d4f781aa8df101e9091
Signed-off-by: Manigandan, Balaji <balaji.manigandan(a)intel.com>
---
M Makefile.mk
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/83887/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/83887?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I276e89792779832edf325d4f781aa8df101e9091
Gerrit-Change-Number: 83887
Gerrit-PatchSet: 3
Gerrit-Owner: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-Attention: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Attention is currently required from: Ashish Kumar Mishra, Saurabh Mishra.
Balaji Manigandan has posted comments on this change by Balaji Manigandan. ( https://review.coreboot.org/c/coreboot/+/83887?usp=email )
Change subject: Fix no-op for empty arg in Makefile for Bash 5.2.21
......................................................................
Patch Set 2:
(7 comments)
Patchset:
PS2:
Fixed the comments from checkpatch
Commit Message:
https://review.coreboot.org/c/coreboot/+/83887/comment/54e74fd3_b85dadad?us… :
PS1, Line 15: The error was triggered by an empty third argument `$(3)` in a conditional
> `Possible unwrapped commit description (prefer a maximum 72 chars per line)`
Please fix.
https://review.coreboot.org/c/coreboot/+/83887/comment/94a717d1_c687a09f?us… :
PS1, Line 16: `$(if ...)` statement. The original line did not specify an explicit no-op
> `Possible unwrapped commit description (prefer a maximum 72 chars per line)`
Please fix.
https://review.coreboot.org/c/coreboot/+/83887/comment/4e20d7ea_34e72b3f?us… :
PS1, Line 17: for the case when `$(3)` is empty, which led to the execution of an incomplete
> `Possible unwrapped commit description (prefer a maximum 72 chars per line)`
Please fix.
https://review.coreboot.org/c/coreboot/+/83887/comment/a4f28f93_3e4d58ae?us… :
PS1, Line 20: By adding a colon `:` as a no-op command in the else-part of the `$(if ...)`,
> `Possible unwrapped commit description (prefer a maximum 72 chars per line)`
Please fix.
https://review.coreboot.org/c/coreboot/+/83887/comment/74027ed4_eec694ce?us… :
PS1, Line 21: we ensure that a harmless command is executed when `$(3)` is empty, preventing
> `Possible unwrapped commit description (prefer a maximum 72 chars per line)`
Please fix.
https://review.coreboot.org/c/coreboot/+/83887/comment/d7726f27_4b077f0c?us… :
PS1, Line 24: This fix ensures compatibility with the newer Bash version and prevents the
> `Possible unwrapped commit description (prefer a maximum 72 chars per line)`
Please fix.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83887?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I276e89792779832edf325d4f781aa8df101e9091
Gerrit-Change-Number: 83887
Gerrit-PatchSet: 2
Gerrit-Owner: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-Reviewer: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-Attention: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-Comment-Date: Tue, 13 Aug 2024 03:43:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: David Wu, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Rishika Raj, Subrata Banik.
Eric Lai has posted comments on this change by David Wu. ( https://review.coreboot.org/c/coreboot/+/83891?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/nissa/var/riven: Disable external fivr
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/mainboard/google/brya/variants/riven/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/83891/comment/16021f67_2fddaf70?us… :
PS1, Line 87: .configure_ext_fivr = 1,
I think you can remove all?
--
To view, visit https://review.coreboot.org/c/coreboot/+/83891?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id5f538b2eda7820a922b8d9ee14b2bae7df3726c
Gerrit-Change-Number: 83891
Gerrit-PatchSet: 1
Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Tue, 13 Aug 2024 03:21:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Ashish Kumar Mishra, Saurabh Mishra.
Hello Ashish Kumar Mishra, Saurabh Mishra, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83887?usp=email
to look at the new patch set (#2).
Change subject: Fix no-op for empty arg in Makefile for Bash 5.2.21
......................................................................
Fix no-op for empty arg in Makefile for Bash 5.2.21
This change addresses an issue in Ubuntu 24.04 with GNU Bash version
5.2.21, where the Makefile failed with the error:
/bin/bash: -c: option requires an argument
make: *** [Makefile.mk:1215: build/coreboot.pre] Error 2
The error was due to an empty third argument `$(3)` in a conditional
`$(if ...)` statement. The original line did not have an explicit no-op
for the case when `$(3)` is empty, leading to an incomplete command.
By adding a colon `:` as a no-op command in the else-part of the `$(if
...)`, we ensure execution of a harmless command when `$(3)` is empty,
preventing the Makefile from failing due to a missing argument.
This fix ensures compatibility with the newer Bash version and prevents
the Makefile from breaking under the specified conditions.
Change-Id: I276e89792779832edf325d4f781aa8df101e9091
Signed-off-by: Manigandan, Balaji <balaji.manigandan(a)intel.com>
---
M Makefile.mk
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/83887/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83887?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I276e89792779832edf325d4f781aa8df101e9091
Gerrit-Change-Number: 83887
Gerrit-PatchSet: 2
Gerrit-Owner: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-Reviewer: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-Attention: Saurabh Mishra <mishra.saurabh(a)intel.com>