Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/83924?usp=email )
Change subject: mb/google/rauru: Initialize flash controller in bootblock
......................................................................
Patch Set 10: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83924?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I88960ce7a50f67ea6f402884b714cb205836a6d8
Gerrit-Change-Number: 83924
Gerrit-PatchSet: 10
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Thu, 22 Aug 2024 00:06:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/83989?usp=email )
Change subject: soc/mediatek: Move SNFC pad_func into MediaTek common directory
......................................................................
Patch Set 3:
(5 comments)
File src/soc/mediatek/common/include/soc/snfc.h:
PS1:
move to flash_controller_common.h
File src/soc/mediatek/common/snfc.c:
https://review.coreboot.org/c/coreboot/+/83989/comment/14de6e62_6a6b3176?us… :
PS1, Line 9: uint8_t drive_strength
enum gpio_drv strength
https://review.coreboot.org/c/coreboot/+/83989/comment/9fac4555_601fbfa4?us… :
PS1, Line 17: 14
It seems to me that we can convert `enum gpio_drv` into `mA` by `(drive_strength + 1) * 2`.
https://review.coreboot.org/c/coreboot/+/83989/comment/792b3397_0b1c8a81?us… :
PS1, Line 8:
: void mtk_snfc_init_pad_func(const struct pad_func *pad_func, uint8_t drive_strength)
: {
:
: gpio_set_pull(pad_func->gpio, GPIO_PULL_ENABLE, pad_func->select);
: gpio_set_mode(pad_func->gpio, pad_func->func);
:
: if (gpio_set_driving(pad_func->gpio, drive_strength) < 0)
: printk(BIOS_ERR,
: "%s: failed to set pin drive to 14 mA for %d\n",
: __func__, pad_func->gpio.id);
: else
: printk(BIOS_DEBUG, "%s: got pin drive: %#x\n", __func__,
: gpio_get_driving(pad_func->gpio));
: }
what about moving this function to flash_controller.c
https://review.coreboot.org/c/coreboot/+/83989/comment/5e1415fb_cab512f8?us… :
PS1, Line 23:
remove blank lines
--
To view, visit https://review.coreboot.org/c/coreboot/+/83989?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I145233ef887a38251e8fc129b8357f236c5f7a2b
Gerrit-Change-Number: 83989
Gerrit-PatchSet: 3
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Thu, 22 Aug 2024 00:06:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/83922?usp=email )
Change subject: soc/mediatek/mt8196: Add GPIO driver
......................................................................
Patch Set 9: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83922?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6d1e6ef17660308c8de908697ffba6b5f17ff9ae
Gerrit-Change-Number: 83922
Gerrit-PatchSet: 9
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Thu, 22 Aug 2024 00:05:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Xi Chen, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/83988?usp=email )
Change subject: soc/mediatek/common: Move GPIO definition to the common directory
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83988/comment/ac1b2e6a_73a72569?us… :
PS3, Line 9: To reduce duplicate gpio definitions of MediaTek SoCs,
: move definitions to a common directory.
```
To reduce duplicate gpio_base.h in each SoC folder, move gpio_base.h to
mediatek/common folder.
```
wrap the message to 72 characters.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83988?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I815df8a3083cf04b821165ec834ca98ee71a0c78
Gerrit-Change-Number: 83988
Gerrit-PatchSet: 3
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Thu, 22 Aug 2024 00:05:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/83987?usp=email )
Change subject: soc/mediatek/common: Print error if GPIO raw_id is not in the range
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83987?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5dffdb9f3e4e7e0d49209e6012893cd246948ee8
Gerrit-Change-Number: 83987
Gerrit-PatchSet: 3
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Wed, 21 Aug 2024 23:58:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Jakub Czapiga, Julius Werner, Maximilian Brune, Philipp Hug, ron minnich.
Nico Huber has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/79907?usp=email )
Change subject: [RFC] region: Hide struct region members
......................................................................
Patch Set 8:
(2 comments)
Patchset:
PS8:
> One thing though: Can't region-test.c just use the getter/setter functions instead of directly accessing the properties?
I thought that wouldn't work because of the explicit overflows (see comment
on top). But looking closer, it might just fit in the limits of region_create().
I'll try it out...
File src/arch/arm/fit_payload.c:
https://review.coreboot.org/c/coreboot/+/79907/comment/f68a0909_00644b5e?us… :
PS8, Line 3: /* FIXME: should use the high-level region api */
> I don't think we have an actual maintainer for the FIT payload support. I have only tried to use a FIT payload once (~1 year ago) and at the time it didn't even work (I think). I wouldn't be surprised if it still doesn't work and no one noticed, since no one uses it. If it were up to me I would just remove the FIT payload entirely and just use SELF (maybe generate a SELF from a FIT in build time like we do with everything else). But that is something for another time/patch.
Ok, now I'm surprised. I somehow expected it'd be used with RISCV... what do
you use as payload there? I also had the impression that it would be needed
for the UPL thing. But even then, adding it as SELF might be reasonable *shrug*
IIRC, it was originally introduced with the canceled ARM server project (Cavium).
When I saw it adopted by other architectures, I thought it's used.
> I would suggest we ignore the FIT stuff and just move on with this patch (aka marking this as resolved).
It just wouldn't be right to leave the FIXME, I guess. I'll think about it.
--
To view, visit https://review.coreboot.org/c/coreboot/+/79907?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I713be9cf0bab4c2e21113b55e7229ab50f06c6cf
Gerrit-Change-Number: 79907
Gerrit-PatchSet: 8
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: coreboot org <coreboot.org(a)gmail.com>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-Comment-Date: Wed, 21 Aug 2024 21:20:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: coreboot org <coreboot.org(a)gmail.com>
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com>
Attention is currently required from: Arthur Heymans, Jakub Czapiga, Julius Werner, Jérémy Compostella, Lean Sheng Tan, Matt DeVillier, Maximilian Brune, Philipp Hug, Simon Glass, ron minnich.
Nico Huber has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/76591?usp=email )
Change subject: [RFC] Add UPL FDT handoff
......................................................................
Patch Set 19:
(1 comment)
Patchset:
PS17:
> I then created a mailing list around end of 2022
I missed that, it seems. Is the list still active? is there an archive?
--
To view, visit https://review.coreboot.org/c/coreboot/+/76591?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I36148e9de6ee992a67ec853ef5cbf1b5f83b44ae
Gerrit-Change-Number: 76591
Gerrit-PatchSet: 19
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: Simon Glass <sjg(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-CC: coreboot org <coreboot.org(a)gmail.com>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Simon Glass <sjg(a)chromium.org>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-Comment-Date: Wed, 21 Aug 2024 21:04:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: coreboot org <coreboot.org(a)gmail.com>
Comment-In-Reply-To: Lean Sheng Tan <sheng.tan(a)9elements.com>
Attention is currently required from: Julia Kittlinger.
Felix Singer has posted comments on this change by Julia Kittlinger. ( https://review.coreboot.org/c/coreboot/+/83968?usp=email )
Change subject: mb/acer/g43t-am3: Add Acer Q45T-AM as a variant
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/acer/g43t-am3/variants/q45t-am/early_init.c:
https://review.coreboot.org/c/coreboot/+/83968/comment/2c451700_5f8b3d25?us… :
PS3, Line 7: <superio/ite/it8720f/it8720f.h>
> please keep me in Cc
Why do you think this is unused? Look at the bootblock_mainboard_early_init() below, which is using the macros from above which are using the definitions from that header file.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83968?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic2654ca4b198bfea409992be14e89702cf67ea50
Gerrit-Change-Number: 83968
Gerrit-PatchSet: 4
Gerrit-Owner: Julia Kittlinger <julia.kittlinger(a)pm.me>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Julia Kittlinger <julia.kittlinger(a)pm.me>
Gerrit-Comment-Date: Wed, 21 Aug 2024 19:16:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Attention is currently required from: Angel Pons, Arthur Heymans, Philipp Hug, ron minnich.
Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83056?usp=email )
Change subject: arch/riscv/pmp: Avoid race conditions in logging
......................................................................
Patch Set 2:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83056/comment/933412eb_b258d015?us… :
PS2, Line 7: arch/riscv/pmp: Add print macro
> "Add print macro" is not very informative. How about: […]
Done
https://review.coreboot.org/c/coreboot/+/83056/comment/b09ca679_7b18acfe?us… :
PS2, Line 9: This adds a printk macro in the PMP code to avoid all harts writing onto
: the serial which causes crappy/broken output.
:
> The problem is that currently all harts/cores are printing that information on the console. […]
I marked it as solved. If you have concerns or think we can solve this better or in a more readable manner, let me know. I just chose the simplest and most performant way I could think of.
File src/arch/riscv/pmp.c:
https://review.coreboot.org/c/coreboot/+/83056/comment/2c1bfbe0_855dfc6b?us… :
PS2, Line 14: #define PMP_PRINTK(level, fmt, ...) { \
: if (read_csr(mhartid) == CONFIG_RISCV_WORKING_HARTID) \
: printk(level, fmt, __VA_ARGS__); \
: }
> To avoid what https://gcc.gnu.org/onlinedocs/cpp/Swallowing-the-Semicolon. […]
Done
https://review.coreboot.org/c/coreboot/+/83056/comment/c1596f0e_24362b0f?us… :
PS2, Line 231: PMP_PRINTK(BIOS_INFO, "%s(%d, %lx) = %lx\n", __func__, idx, val, read_pmpaddr(idx));
> nit: drop one tab
Done
https://review.coreboot.org/c/coreboot/+/83056/comment/76d726d5_8f5e4547?us… :
PS2, Line 234: if (read_csr(mhartid) == CONFIG_RISCV_WORKING_HARTID)
> Seems redundant
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/83056?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icaded168bd7302ad1ea29bebb7900810ebeff92d
Gerrit-Change-Number: 83056
Gerrit-PatchSet: 2
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-Comment-Date: Wed, 21 Aug 2024 18:50:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com>
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Attention is currently required from: Angel Pons, Arthur Heymans, Maximilian Brune, Philipp Hug, ron minnich.
Hello Angel Pons, Philipp Hug, build bot (Jenkins), ron minnich,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83056?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by Angel Pons, Verified+1 by build bot (Jenkins)
Change subject: arch/riscv/pmp: Avoid race conditions in logging
......................................................................
arch/riscv/pmp: Avoid race conditions in logging
The problem is that currently all harts/cores are printing that
information on the console. But we only need it to be printed by one of
them, since all harts/cores are configured the same. So instead of
synchronizing it and let it be printed by all of them I chose to only
let it be printed by the working hart (aka BSP).
This adds a printk macro in the PMP code to avoid all harts writing onto
the serial which causes crappy/broken output.
Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com>
Change-Id: Icaded168bd7302ad1ea29bebb7900810ebeff92d
---
M src/arch/riscv/pmp.c
1 file changed, 17 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/83056/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/83056?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icaded168bd7302ad1ea29bebb7900810ebeff92d
Gerrit-Change-Number: 83056
Gerrit-PatchSet: 3
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>