Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84002?usp=email )
Change subject: mb/google/brox/var/jubilant: Enable devices on unprovisioned fw_config
......................................................................
mb/google/brox/var/jubilant: Enable devices on unprovisioned fw_config
Add the condition of unprovisioned fw_config to enable all storages
and devices. It's for first boot on all storags and preliminary test
in factory when fw_config is unprovisioned.
BUG=None
TEST=Build jubilant firmware and boot to OS on storages when fw_config
is unprovisioned and ensure all devices are enable.
Change-Id: Ia14632744c34548e2c201dfc58d82515cdd02df0
Signed-off-by: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/84002
Reviewed-by: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Reviewed-by: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M src/mainboard/google/brox/variants/jubilant/fw_config.c
M src/mainboard/google/brox/variants/jubilant/overridetree.cb
M src/mainboard/google/brox/variants/jubilant/variant.c
3 files changed, 11 insertions(+), 4 deletions(-)
Approvals:
build bot (Jenkins): Verified
Kenneth Chan: Looks good to me, approved
Tyler Wang: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/brox/variants/jubilant/fw_config.c b/src/mainboard/google/brox/variants/jubilant/fw_config.c
index ec95c57..7341afe 100644
--- a/src/mainboard/google/brox/variants/jubilant/fw_config.c
+++ b/src/mainboard/google/brox/variants/jubilant/fw_config.c
@@ -60,7 +60,7 @@
static void fw_config_handle(void *unused)
{
if (!fw_config_is_provisioned()) {
- printk(BIOS_WARNING, "FW_CONFIG is not provisioned. Exiting...\n");
+ printk(BIOS_WARNING, "FW_CONFIG is unprovisioned. Skip disable device's pads.\n");
return;
}
diff --git a/src/mainboard/google/brox/variants/jubilant/overridetree.cb b/src/mainboard/google/brox/variants/jubilant/overridetree.cb
index 01ac731..6d7c3f8 100644
--- a/src/mainboard/google/brox/variants/jubilant/overridetree.cb
+++ b/src/mainboard/google/brox/variants/jubilant/overridetree.cb
@@ -232,6 +232,7 @@
register "type" = "UPC_TYPE_INTERNAL"
device ref usb2_port4 on
probe DB_USB DB_1A_LTE
+ probe unprovisioned
end
end
chip drivers/usb/acpi
@@ -281,6 +282,7 @@
register "type" = "UPC_TYPE_INTERNAL"
device ref usb3_port4 on
probe DB_USB DB_1A_LTE
+ probe unprovisioned
end
end
end
@@ -308,6 +310,7 @@
register "add_acpi_dma_property" = "true"
device pci 00.0 on
probe WIFI_BT WIFI_BT_PCIE
+ probe unprovisioned
end
end
chip soc/intel/common/block/pcie/rtd3
@@ -317,6 +320,7 @@
device generic 0 on end
end
probe WIFI_BT WIFI_BT_PCIE
+ probe unprovisioned
end
device ref cnvi_wifi on
chip drivers/wifi/generic
@@ -326,6 +330,7 @@
device generic 0 on end
end
probe WIFI_BT WIFI_BT_CNVI
+ probe unprovisioned
end
device ref ish on
chip drivers/intel/ish
@@ -441,6 +446,7 @@
register "input_analog_gain" = "1"
device i2c 28 on
probe DB_USB DB_1A_LTE
+ probe unprovisioned
end
end
end
@@ -458,6 +464,7 @@
register "enable_delay_ms" = "3"
device spi 0 on
probe FPMCU FPMCU_NUVOTON
+ probe unprovisioned
end
end # FPMCU
end
diff --git a/src/mainboard/google/brox/variants/jubilant/variant.c b/src/mainboard/google/brox/variants/jubilant/variant.c
index c6b2626..4b214aa 100644
--- a/src/mainboard/google/brox/variants/jubilant/variant.c
+++ b/src/mainboard/google/brox/variants/jubilant/variant.c
@@ -9,7 +9,7 @@
void variant_update_soc_chip_config(struct soc_intel_alderlake_config *config)
{
- if (fw_config_probe(FW_CONFIG(WIFI_BT, WIFI_BT_CNVI))) {
+ if (fw_config_probe(FW_CONFIG(WIFI_BT, WIFI_BT_CNVI)) || (!fw_config_is_provisioned())) {
printk(BIOS_INFO, "CNVi bluetooth enabled by fw_config\n");
config->cnvi_bt_core = true;
config->cnvi_bt_audio_offload = true;
@@ -31,8 +31,8 @@
struct device *ish = DEV_PTR(ish);
struct device *nvme_rp = DEV_PTR(pcie4_0);
- if (fw_config_probe(FW_CONFIG(STORAGE, STORAGE_UNKNOWN))) {
- printk(BIOS_INFO, "fw_config storage is unknown so enable all storage devices.\n");
+ if (fw_config_probe(FW_CONFIG(STORAGE, STORAGE_UNKNOWN)) || (!fw_config_is_provisioned())) {
+ printk(BIOS_INFO, "fw_config is unprovisioned or storage is unknown so enable all storage's configs.\n");
return;
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/84002?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia14632744c34548e2c201dfc58d82515cdd02df0
Gerrit-Change-Number: 84002
Gerrit-PatchSet: 4
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83984?usp=email )
Change subject: mb/google/brox: Enable storage devices on unprovisioned fw_config
......................................................................
mb/google/brox: Enable storage devices on unprovisioned fw_config
Storage devices are very critical to boot to OS. When probe list is
defined for storage devices, all of them get disabled when fw_config is
unprovisioned - a typical situation in the factory. Fix this by
configuring the storage devices in device/override tree to probe and
enable them when fw_config is unprovisioned.
BUG=None
TEST=Build Brox firmware and boot to OS when fw_config is unprovisioned.
Change-Id: I0537f7d1d83293b9b3408f0aadf11fa2e7908163
Signed-off-by: Karthikeyan Ramasubramanian <kramasub(a)google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83984
Reviewed-by: Eric Lai <ericllai(a)google.com>
Reviewed-by: Jon Murphy <jpmurphy(a)google.com>
Reviewed-by: Bob Moragues <moragues(a)google.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M src/mainboard/google/brox/variants/brox/overridetree.cb
M src/mainboard/google/brox/variants/jubilant/overridetree.cb
M src/mainboard/google/brox/variants/lotso/overridetree.cb
3 files changed, 9 insertions(+), 0 deletions(-)
Approvals:
Bob Moragues: Looks good to me, but someone else must approve
build bot (Jenkins): Verified
Eric Lai: Looks good to me, approved
Jon Murphy: Looks good to me, approved
diff --git a/src/mainboard/google/brox/variants/brox/overridetree.cb b/src/mainboard/google/brox/variants/brox/overridetree.cb
index 21774f8..18baa5d 100644
--- a/src/mainboard/google/brox/variants/brox/overridetree.cb
+++ b/src/mainboard/google/brox/variants/brox/overridetree.cb
@@ -290,6 +290,7 @@
.flags = PCIE_RP_LTR | PCIE_RP_AER,
}"
probe STORAGE STORAGE_NVME
+ probe unprovisioned
end
device ref pcie_rp5 on
register "pch_pcie_rp[PCH_RP(5)]" = "{
@@ -327,9 +328,11 @@
end
probe ISH ISH_ENABLE
probe STORAGE STORAGE_UFS
+ probe unprovisioned
end
device ref ufs on
probe STORAGE STORAGE_UFS
+ probe unprovisioned
end
end
end
diff --git a/src/mainboard/google/brox/variants/jubilant/overridetree.cb b/src/mainboard/google/brox/variants/jubilant/overridetree.cb
index 0613ff9..01ac731 100644
--- a/src/mainboard/google/brox/variants/jubilant/overridetree.cb
+++ b/src/mainboard/google/brox/variants/jubilant/overridetree.cb
@@ -295,6 +295,7 @@
}"
probe STORAGE STORAGE_NVME
probe STORAGE STORAGE_UNKNOWN
+ probe unprovisioned
end
device ref pcie_rp5 on
register "pch_pcie_rp[PCH_RP(5)]" = "{
@@ -333,10 +334,12 @@
end
probe STORAGE STORAGE_UFS
probe STORAGE STORAGE_UNKNOWN
+ probe unprovisioned
end
device ref ufs on
probe STORAGE STORAGE_UFS
probe STORAGE STORAGE_UNKNOWN
+ probe unprovisioned
end
device ref i2c0 on
chip drivers/i2c/generic
diff --git a/src/mainboard/google/brox/variants/lotso/overridetree.cb b/src/mainboard/google/brox/variants/lotso/overridetree.cb
index e7c5f6b..6876b64 100644
--- a/src/mainboard/google/brox/variants/lotso/overridetree.cb
+++ b/src/mainboard/google/brox/variants/lotso/overridetree.cb
@@ -333,6 +333,7 @@
}"
probe STORAGE STORAGE_UNKNOWN
probe STORAGE STORAGE_NVME
+ probe unprovisioned
end
device ref pcie_rp5 on
register "pch_pcie_rp[PCH_RP(5)]" = "{
@@ -382,10 +383,12 @@
end
probe STORAGE STORAGE_UNKNOWN
probe STORAGE STORAGE_UFS
+ probe unprovisioned
end
device ref ufs on
probe STORAGE STORAGE_UNKNOWN
probe STORAGE STORAGE_UFS
+ probe unprovisioned
end
device ref i2c0 on
chip drivers/i2c/generic
--
To view, visit https://review.coreboot.org/c/coreboot/+/83984?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0537f7d1d83293b9b3408f0aadf11fa2e7908163
Gerrit-Change-Number: 83984
Gerrit-PatchSet: 3
Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Bob Moragues <moragues(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Ren Kuo <ren.kuo(a)quantatw.com>
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84001?usp=email )
Change subject: mb/google/nissa/var/teliks: Adjust usb2 pin of wlan
......................................................................
mb/google/nissa/var/teliks: Adjust usb2 pin of wlan
Since the voltage value measured by the USB2 pin of the wlan is 500mv,
it does not meet the design requirements. Adjusting the port length
can reduce the voltage to 450mv, which meets the expected settings.
BUG=b:361037189
TEST=1. The voltage measurements are as expected.
2. The Bluetooth and WiFi functions of the wlan module are
verified to be normal.
Change-Id: Icd1ec3b561ee5b3f55e5f97a56fd9cb7df893508
Signed-off-by: zengqinghong <zengqinghong(a)huaqin.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/84001
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Subrata Banik <subratabanik(a)google.com>
Reviewed-by: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/brya/variants/teliks/overridetree.cb
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
build bot (Jenkins): Verified
Subrata Banik: Looks good to me, approved
Weimin Wu: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/brya/variants/teliks/overridetree.cb b/src/mainboard/google/brya/variants/teliks/overridetree.cb
index 6ca555a..2f4534f 100644
--- a/src/mainboard/google/brya/variants/teliks/overridetree.cb
+++ b/src/mainboard/google/brya/variants/teliks/overridetree.cb
@@ -460,8 +460,8 @@
register "usb2_ports[3]" = "USB2_PORT_MID(OC_SKIP)" # Type-A DB (6.2 inch)
register "usb2_ports[4]" = "USB2_PORT_SHORT(OC_SKIP)" # LTE (3.3 inch)
register "usb2_ports[5]" = "USB2_PORT_SHORT(OC_SKIP)" # UFC (3.7 inch)
- register "usb2_ports[7]" = "USB2_PORT_SHORT(OC_SKIP)" # Bluetooth port for PCIe WLAN (2.5 inch)
- register "usb2_ports[9]" = "USB2_PORT_SHORT(OC_SKIP)" # Bluetooth port for CNVi WLAN
+ register "usb2_ports[7]" = "USB2_PORT_MID(OC_SKIP)" # Bluetooth port for PCIe WLAN (2.5 inch)
+ register "usb2_ports[9]" = "USB2_PORT_MID(OC_SKIP)" # Bluetooth port for CNVi WLAN
register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC_SKIP)" # USB3 Type-A port A0(MLB))
register "usb3_ports[1]" = "USB3_PORT_DEFAULT(OC_SKIP)" # USB3 Type-A port A1(DB)
--
To view, visit https://review.coreboot.org/c/coreboot/+/84001?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icd1ec3b561ee5b3f55e5f97a56fd9cb7df893508
Gerrit-Change-Number: 84001
Gerrit-PatchSet: 3
Gerrit-Owner: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83994?usp=email )
Change subject: mb/lenovo/thinkcentre_m710s: Disable DRIVER_LENOVO_SERIALS
......................................................................
mb/lenovo/thinkcentre_m710s: Disable DRIVER_LENOVO_SERIALS
This mainboard does not have AT24RF08C (Asset Identification EEPROM) and
will show "*INVALID*" in the SMBIOS table.
Change-Id: If6f948bc4c63c7afdc8b31e1945d3c3beb99883f
Signed-off-by: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83994
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Angel Pons <th3fanbus(a)gmail.com>
Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
---
M src/mainboard/lenovo/thinkcentre_m710s/Kconfig
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Felix Singer: Looks good to me, approved
build bot (Jenkins): Verified
Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/lenovo/thinkcentre_m710s/Kconfig b/src/mainboard/lenovo/thinkcentre_m710s/Kconfig
index c01aaec..c9bcd75 100644
--- a/src/mainboard/lenovo/thinkcentre_m710s/Kconfig
+++ b/src/mainboard/lenovo/thinkcentre_m710s/Kconfig
@@ -23,4 +23,7 @@
config MAINBOARD_PART_NUMBER
default "ThinkCentre M710s"
+config DRIVER_LENOVO_SERIALS
+ default n
+
endif # BOARD_LENOVO_THINKCENTRE_M710S
--
To view, visit https://review.coreboot.org/c/coreboot/+/83994?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If6f948bc4c63c7afdc8b31e1945d3c3beb99883f
Gerrit-Change-Number: 83994
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Attention is currently required from: Alexander Couzens, Nicholas Sudsgaard.
Felix Held has posted comments on this change by Nicholas Sudsgaard. ( https://review.coreboot.org/c/coreboot/+/83993?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/lenovo/thinkcentre_m710s: Drop PCH UPDs from PEG device
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
have you tested if aspm still works for a device in the PEG slot? i'm not sure how this works on intel socs regarding PCIe ports and their clock request lines from the CPU vs from the PCH
--
To view, visit https://review.coreboot.org/c/coreboot/+/83993?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic0e0864b99c5078e5b84b9183262b3c47ffcb329
Gerrit-Change-Number: 83993
Gerrit-PatchSet: 1
Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Thu, 22 Aug 2024 13:24:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No