Paul Menzel has posted comments on this change by Nicholas Sudsgaard. ( https://review.coreboot.org/c/coreboot/+/83991?usp=email )
Change subject: mb/lenovo/thinkcentre_m710s: Add SMBIOS data for PCIe slots
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
For posterity, it’d be great if you pasted the new output of `dmidecode` in a comment?
--
To view, visit https://review.coreboot.org/c/coreboot/+/83991?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iaa761108acbf275820ecbec9837b81bc5d64613e
Gerrit-Change-Number: 83991
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Thu, 22 Aug 2024 20:01:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Julia Kittlinger.
Elyes Haouas has posted comments on this change by Julia Kittlinger. ( https://review.coreboot.org/c/coreboot/+/83968?usp=email )
Change subject: mb/acer/g43t-am3: Add Acer Q45T-AM as a variant
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/acer/g43t-am3/variants/q45t-am/early_init.c:
https://review.coreboot.org/c/coreboot/+/83968/comment/64d9e93a_03bcfc23?us… :
PS3, Line 7: <superio/ite/it8720f/it8720f.h>
> Why do you think this is unused? Look at the bootblock_mainboard_early_init() below, which is using […]
indeed, my mistake.
<southbridge/intel/i82801jx/i82801jx.h> is unused
--
To view, visit https://review.coreboot.org/c/coreboot/+/83968?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic2654ca4b198bfea409992be14e89702cf67ea50
Gerrit-Change-Number: 83968
Gerrit-PatchSet: 4
Gerrit-Owner: Julia Kittlinger <julia.kittlinger(a)pm.me>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Julia Kittlinger <julia.kittlinger(a)pm.me>
Gerrit-Comment-Date: Thu, 22 Aug 2024 18:56:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Attention is currently required from: Angel Pons, Jason Glenesk, Martin L Roth.
Hello Angel Pons, Jason Glenesk, Martin L Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84034?usp=email
to look at the new patch set (#2).
Change subject: documentation/release: Update release checklist
......................................................................
documentation/release: Update release checklist
Sync checklist with release template; add new heading for paragraph
on pushing the signed tag to make it stand out.
Change-Id: Id49b3f38d3501382b7fb7ac791190c0cacd58a11
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M Documentation/releases/checklist.md
1 file changed, 31 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/84034/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/84034?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id49b3f38d3501382b7fb7ac791190c0cacd58a11
Gerrit-Change-Number: 84034
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84034?usp=email )
Change subject: documentation/release: Update release checklist
......................................................................
documentation/release: Update release checklist
Sync checklist with release template; add new heading for paragraph
on pushing the signed tag to make it stand out.
Change-Id: Id49b3f38d3501382b7fb7ac791190c0cacd58a11
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M Documentation/releases/checklist.md
1 file changed, 15 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/84034/1
diff --git a/Documentation/releases/checklist.md b/Documentation/releases/checklist.md
index 29ebdbb..6ef0ac3 100644
--- a/Documentation/releases/checklist.md
+++ b/Documentation/releases/checklist.md
@@ -66,13 +66,23 @@
## Checklist
-### ~2 weeks prior to release
+### ~6 weeks prior to release
- [ ] Announce upcoming release to mailing list, ask people to test and
to update release notes.
- [ ] Start marking patches that should to go into the release with a
tag "coreboot_release_X.yy"
+### ~4 weeks prior to release
+- [ ] Freezing toolchain state. Only relevant fixes are allowed from this point on.
+- [ ] Schedule release meetings
+
+### ~2 weeks prior to release
+- [ ] Meeting with release team
+- [ ] Send reminder email to mailing list, ask for people to test, and to update the release notes.
+- [ ] Update the topic in the IRC channel with the date of the upcoming release.
+
### ~1 week prior to release
+- [ ] Meeting with release team
- [ ] Send reminder email to mailing list, ask for people to test,
and to update the release notes.
- [ ] Update the topic in the IRC channel with the date of the upcoming
@@ -87,14 +97,15 @@
should get a new release. Announce these branch releases and
prepare release notes.
-### Day before release
+### Day before release tag
- [ ] Make sure patches with tags for the release are merged.
- [ ] Announce to IRC that the release will be tomorrow and ask for
testing.
- [ ] Run `util/vboot_list/vboot_list.sh` script to update the list of
boards supported by vboot.
-### Day of release
+### Day of release tag
+- [ ] Meeting with release team
- [ ] Review the full documentation about doing the release below.
- [ ] Select a commit ID to base the release upon.
- [ ] Test the commit selected for release.
@@ -230,6 +241,7 @@
...
````
+## Push the signed tag
When you used the script to generate the release, a signed tag was
generated in the tree that was downloaded. From the coreboot-X.Y tree,
just run: `git push origin X.Y`. In case you pushed the wrong tag
--
To view, visit https://review.coreboot.org/c/coreboot/+/84034?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id49b3f38d3501382b7fb7ac791190c0cacd58a11
Gerrit-Change-Number: 84034
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Attention is currently required from: Jakub Czapiga, Julius Werner, Nico Huber, Philipp Hug, ron minnich.
Maximilian Brune has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/79907?usp=email )
Change subject: [RFC] region: Hide struct region members
......................................................................
Patch Set 8:
(1 comment)
File src/arch/arm/fit_payload.c:
https://review.coreboot.org/c/coreboot/+/79907/comment/3c7fcd24_67b2b41a?us… :
PS8, Line 3: /* FIXME: should use the high-level region api */
>> I don't think we have an actual maintainer for the FIT payload support. I have only tried to use a FIT payload once (~1 year ago) and at the time it didn't even work (I think). I wouldn't be surprised if it still doesn't work and no one noticed, since no one uses it. If it were up to me I would just remove the FIT payload entirely and just use SELF (maybe generate a SELF from a FIT in build time like we do with everything else). But that is something for another time/patch.
> Ok, now I'm surprised. I somehow expected it'd be used with RISC-V... what do
you use as payload there? I also had the impression that it would be needed
for the UPL thing. But even then, adding it as SELF might be reasonable shrug
IIRC, it was originally introduced with the canceled ARM server project (Cavium).
When I saw it adopted by other architectures, I thought it's used.
I usually use Linuxboot (either `CONFIG_ELF` or `CONFIG_FLAT_BINARY`). So I start coreboot -> Linux (as payload). That way I can test if all devices work as expected early on in Linux without needing support from an extra payload (like grub, u-boot ...). I can also test it even if there is yet no storage interface working (e.g. USB, PCIe) for a given platform, since the payload is on the flash anyway. But even if I would use a different payload I would just use `CONFIG_ELF` and `CONFIG_FLAT_BINARY`. I don't know what the reasons were to add runtime support/parsing for a FIT payload, but for RISC-V on coreboot that is usually an unnecessary overhead. We always compile the payload into coreboot anyway, so I don't see a reason to parse an entire FIT image in runtime. I mean we don't even do that for ELF executable (hence SELF was created). But I guess there are/were reasons for doing it the way it is now. I know FIT has support for multiple payloads, so you can choose at runtime which one to load. So maybe that is the reason. Although I guess you could accomplish something similar with the `fallback/payload` stuff. But anyway I diverged.
> It just wouldn't be right to leave the FIXME, I guess. I'll think about it.
I would also prefer if you fixed it (and maybe completely remove the macro), but I also don't mind if you currently don't have time for that.
--
To view, visit https://review.coreboot.org/c/coreboot/+/79907?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I713be9cf0bab4c2e21113b55e7229ab50f06c6cf
Gerrit-Change-Number: 79907
Gerrit-PatchSet: 8
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: coreboot org <coreboot.org(a)gmail.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-Comment-Date: Thu, 22 Aug 2024 18:18:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: coreboot org <coreboot.org(a)gmail.com>
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com>
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84033?usp=email )
Change subject: [NOT_FOR_MERGE]Kconfig: Build all targets with LTO
......................................................................
[NOT_FOR_MERGE]Kconfig: Build all targets with LTO
Change-Id: I3be6a71fdf9c2d1e14226550daa734b7cdc7e350
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/Kconfig
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/84033/1
diff --git a/src/Kconfig b/src/Kconfig
index 55fad95..a46dfd4 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -118,7 +118,7 @@
config LTO
bool "Use link time optimization (LTO) (experimental)"
- default n
+ default y
help
Compile with link time optimization. This can often decrease the
final binary size, but may increase compilation time.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84033?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3be6a71fdf9c2d1e14226550daa734b7cdc7e350
Gerrit-Change-Number: 84033
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Attention is currently required from: Arthur Heymans, Marvin Drees, Nico Huber, Patrick Rudolph.
Hello Marvin Drees, Nico Huber, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84003?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Code-Review+1 by Marvin Drees, Code-Review+2 by Nico Huber, Verified+1 by build bot (Jenkins)
The change is no longer submittable: Code-Review and Verified are unsatisfied now.
Change subject: Add initial experimental LTO support
......................................................................
Add initial experimental LTO support
This will not succeed in compiling on all target and compiler
combinations but at least gets the ball rolling. The change is not
invasive.
Some notes:
- GCC has issues with LTO on ARM
- Clang uses LLD automatically on some arch
- Clang with LTO fails on x86 as it forwards the linking to GCC for some
reason
- SMM building succeeds but the binary is empty
Change-Id: Ieb9204777fd349542744a8946e2207731c37969c
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M Makefile.mk
M src/Kconfig
2 files changed, 19 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/84003/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/84003?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieb9204777fd349542744a8946e2207731c37969c
Gerrit-Change-Number: 84003
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Marvin Drees <marvin.drees(a)9elements.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Marvin Drees <marvin.drees(a)9elements.com>
Julius Werner has abandoned this change. ( https://review.coreboot.org/c/qc_blobs/+/59637?usp=email )
Change subject: sc7180/qtiseclib blob update
......................................................................
Abandoned
out of date
--
To view, visit https://review.coreboot.org/c/qc_blobs/+/59637?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: abandon
Gerrit-Project: qc_blobs
Gerrit-Branch: main
Gerrit-Change-Id: I3363c7144363c51f2e6fa0091b895b7bccc5daa2
Gerrit-Change-Number: 59637
Gerrit-PatchSet: 1
Gerrit-Owner: Saurabh Gorecha <quic_sgorecha(a)quicinc.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Ravi Kumar Bokka <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: mturney mturney <quic_mturney(a)quicinc.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>