coreboot-gerrit August 2024

coreboot-gerrit@coreboot.org

1 participants
3913 discussions

[S] Change in coreboot[main]: cpu/x86: Don't do partial linking
by Arthur Heymans (Code Review) 23 Aug '24

23 Aug '24

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84037?usp=email ) Change subject: cpu/x86: Don't do partial linking ...................................................................... cpu/x86: Don't do partial linking For LTO we want to link everything in one go. Change-Id: If2c186eb87072e0b80c7e8998b2a0d9bdfddf740 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/cpu/x86/smm/Makefile.mk M src/lib/Makefile.mk 2 files changed, 7 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/84037/1 diff --git a/src/cpu/x86/smm/Makefile.mk b/src/cpu/x86/smm/Makefile.mk index 33b24a8..a104a87 100644 --- a/src/cpu/x86/smm/Makefile.mk +++ b/src/cpu/x86/smm/Makefile.mk @@ -17,8 +17,10 @@ smm-generic-ccopts += -D__SMM__ smm-c-deps+=$$(OPTION_TABLE_H) -$(obj)/smm/smm.o: $$(smm-objs) $(COMPILER_RT_smm) - $(LD_smm) -nostdlib -r -o $@ $(COMPILER_RT_FLAGS_smm) --whole-archive --start-group $(filter-out %.ld, $(smm-objs)) --no-whole-archive $(COMPILER_RT_smm) --end-group +$(obj)/smm/smm.a: $$(smm-objs) + $(AR_smm) rcsT $@.tmp $(filter-out %.ld, $(smm-objs)) + mv $@.tmp $@ + # change to the target path because objcopy will use the path name in its # ELF symbol names. @@ -65,9 +67,9 @@ # C-based SMM handler. ifeq ($(CONFIG_ARCH_RAMSTAGE_X86_32),y) -$(eval $(call rmodule_link,$(obj)/smm/smm.elf, $(obj)/smm/smm.o,x86_32)) +$(eval $(call rmodule_link,$(obj)/smm/smm.elf, $(obj)/smm/smm.a,x86_32)) else -$(eval $(call rmodule_link,$(obj)/smm/smm.elf, $(obj)/smm/smm.o,x86_64)) +$(eval $(call rmodule_link,$(obj)/smm/smm.elf, $(obj)/smm/smm.a,x86_64)) endif $(obj)/smm/smm: $(obj)/smm/smm.elf.rmod diff --git a/src/lib/Makefile.mk b/src/lib/Makefile.mk index 56d8b1a..89e5b65 100644 --- a/src/lib/Makefile.mk +++ b/src/lib/Makefile.mk @@ -314,7 +314,7 @@ # rmdoule is named $(1).rmod define rmodule_link $(strip $(1)): $(strip $(2)) $$(COMPILER_RT_rmodules_$(3)) $(call src-to-obj,rmodules_$(3),src/lib/rmodule.ld) | $$(RMODTOOL) - $$(LD_rmodules_$(3)) $$(LDFLAGS_rmodules_$(3)) $(RMODULE_LDFLAGS) $($(1)-ldflags) -T $(call src-to-obj,rmodules_$(3),src/lib/rmodule.ld) -o $$@ --whole-archive --start-group $(filter-out %.ld,$(2)) --end-group + $$(LD_rmodules_$(3)) $$(LDFLAGS_rmodules_$(3)) $(RMODULE_LDFLAGS) $($(1)-ldflags) -T $(call src-to-obj,rmodules_$(3),src/lib/rmodule.ld) -o $$@ --whole-archive --start-group $(filter-out %.ld,$(2)) --no-whole-archive $$(COMPILER_RT_rmodules_$(3)) --end-group $$(NM_rmodules_$(3)) -n $$@ > $$(basename $$(a)).map endef -- To view, visit https://review.coreboot.org/c/coreboot/+/84037?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If2c186eb87072e0b80c7e8998b2a0d9bdfddf740 Gerrit-Change-Number: 84037 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

[M] Change in coreboot[main]: Documentation/releases: Add 24.11 release notes template
by Matt DeVillier (Code Review) 23 Aug '24

23 Aug '24

Attention is currently required from: Angel Pons, Felix Singer, Jason Glenesk, Martin L Roth. Matt DeVillier has posted comments on this change by Jason Glenesk. ( https://review.coreboot.org/c/coreboot/+/84036?usp=email ) Change subject: Documentation/releases: Add 24.11 release notes template ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84036?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1e524f1db0090bf8815b08315f9cbc9894965af7 Gerrit-Change-Number: 84036 Gerrit-PatchSet: 2 Gerrit-Owner: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 22 Aug 2024 22:09:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: documentation/release: Update release checklist
by Jason Glenesk (Code Review) 23 Aug '24

23 Aug '24

Attention is currently required from: Angel Pons, Martin L Roth, Matt DeVillier. Jason Glenesk has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/84034?usp=email ) Change subject: documentation/release: Update release checklist ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84034?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id49b3f38d3501382b7fb7ac791190c0cacd58a11 Gerrit-Change-Number: 84034 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 22 Aug 2024 22:08:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: Documentation/releases: Add 24.11 release notes template
by Jason Glenesk (Code Review) 22 Aug '24

22 Aug '24

Attention is currently required from: Angel Pons, Felix Singer, Jason Glenesk, Martin L Roth, Matt DeVillier. Jason Glenesk has posted comments on this change by Jason Glenesk. ( https://review.coreboot.org/c/coreboot/+/84036?usp=email ) Change subject: Documentation/releases: Add 24.11 release notes template ...................................................................... Patch Set 2: (1 comment) File Documentation/releases/coreboot-24.11-relnotes.md: https://review.coreboot.org/c/coreboot/+/84036/comment/146838d0_f7b7ca2e?us… : PS1, Line 73: 24.05 to the 24.08 > 2408 / 2411 respectively? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/84036?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1e524f1db0090bf8815b08315f9cbc9894965af7 Gerrit-Change-Number: 84036 Gerrit-PatchSet: 2 Gerrit-Owner: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 22 Aug 2024 21:56:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

[M] Change in coreboot[main]: Documentation/releases: Add 24.11 release notes template
by Jason Glenesk (Code Review) 22 Aug '24

22 Aug '24

Attention is currently required from: Angel Pons, Felix Singer, Jason Glenesk, Martin L Roth. Hello Angel Pons, Felix Singer, Martin L Roth, Matt DeVillier, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/84036?usp=email to look at the new patch set (#2). Change subject: Documentation/releases: Add 24.11 release notes template ...................................................................... Documentation/releases: Add 24.11 release notes template In preparation for the upcoming release, add the template for the 24.11 release and update index.md. Change-Id: I1e524f1db0090bf8815b08315f9cbc9894965af7 Signed-off-by: Jason Glenesk <jason.glenesk(a)gmail.com> --- A Documentation/releases/coreboot-24.11-relnotes.md M Documentation/releases/index.md 2 files changed, 97 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/84036/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84036?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1e524f1db0090bf8815b08315f9cbc9894965af7 Gerrit-Change-Number: 84036 Gerrit-PatchSet: 2 Gerrit-Owner: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>

1 0

[S] Change in coreboot[main]: Documentation/vboot: Update vboot supported boards list
by Matt DeVillier (Code Review) 22 Aug '24

22 Aug '24

Attention is currently required from: Felix Singer, Jason Glenesk, Martin Roth. Matt DeVillier has posted comments on this change by Jason Glenesk. ( https://review.coreboot.org/c/coreboot/+/84035?usp=email ) Change subject: Documentation/vboot: Update vboot supported boards list ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84035?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie2d3378e8995b09372291294f9ffb0d2d8eccc8b Gerrit-Change-Number: 84035 Gerrit-PatchSet: 1 Gerrit-Owner: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Thu, 22 Aug 2024 21:49:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: Documentation/releases: Add 24.11 release notes template
by Matt DeVillier (Code Review) 22 Aug '24

22 Aug '24

Attention is currently required from: Angel Pons, Felix Singer, Jason Glenesk, Martin L Roth. Matt DeVillier has posted comments on this change by Jason Glenesk. ( https://review.coreboot.org/c/coreboot/+/84036?usp=email ) Change subject: Documentation/releases: Add 24.11 release notes template ...................................................................... Patch Set 1: (1 comment) File Documentation/releases/coreboot-24.11-relnotes.md: https://review.coreboot.org/c/coreboot/+/84036/comment/f47bbff9_1f8b96d7?us… : PS1, Line 73: 24.05 to the 24.08 2408 / 2411 respectively? -- To view, visit https://review.coreboot.org/c/coreboot/+/84036?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1e524f1db0090bf8815b08315f9cbc9894965af7 Gerrit-Change-Number: 84036 Gerrit-PatchSet: 1 Gerrit-Owner: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 22 Aug 2024 21:48:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: Documentation/releases: Add 24.11 release notes template
by Jason Glenesk (Code Review) 22 Aug '24

22 Aug '24

Attention is currently required from: Angel Pons, Martin L Roth. Jason Glenesk has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84036?usp=email ) Change subject: Documentation/releases: Add 24.11 release notes template ...................................................................... Documentation/releases: Add 24.11 release notes template In preparation for the upcoming release, add the template for the 24.11 release and update index.md. Change-Id: I1e524f1db0090bf8815b08315f9cbc9894965af7 Signed-off-by: Jason Glenesk <jason.glenesk(a)gmail.com> --- A Documentation/releases/coreboot-24.11-relnotes.md M Documentation/releases/index.md 2 files changed, 97 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/84036/1 diff --git a/Documentation/releases/coreboot-24.11-relnotes.md b/Documentation/releases/coreboot-24.11-relnotes.md new file mode 100644 index 0000000..81c433c --- /dev/null +++ b/Documentation/releases/coreboot-24.11-relnotes.md @@ -0,0 +1,95 @@ +Upcoming release - coreboot 24.11 +======================================================================== + +The 24.11 release is scheduled for Mid November, 2024 + + +Update this document with changes that should be in the release notes. + +* Please use Markdown. +* See the past few release notes for the general format. +* The chip and board additions and removals will be updated right + before the release, so those do not need to be added. +* Note that all changes before the release are done are marked upcoming. + A final version of the notes are done after the release. + + + +Significant or interesting changes +---------------------------------- + +* Add changes that need a full description here + +* This section should have full descriptions and can or should have + a link to the referenced commits. + + + +Additional coreboot changes +--------------------------- + +The following are changes across a number of patches, or changes worth +noting, but not needing a full description. + +* Changes that only need a line or two of description go here. + + + +Changes to external resources +----------------------------- + +### Toolchain updates + + +### Git submodule pointers + + +### External payloads + + + +Platform Updates +---------------- + +### Added mainboards: +* To be filled in immediately before the release by the release team + + +### Removed Mainboards +* To be filled in immediately before the release by the release team + + +### Updated SoCs +* To be filled in immediately before the release by the release team + + + +Plans to move platform support to a branch +------------------------------------------ +* To be filled in immediately before the release by the release team + + + +Statistics from the 24.05 to the 24.08 release +-------------------------------------------- +* To be filled in immediately before the release by the release team + + + +Significant Known and Open Issues +--------------------------------- + +Issues from the coreboot bugtracker: https://ticket.coreboot.org/ +* To be filled in immediately before the release by the release team + + + +coreboot Links and Contact Information +-------------------------------------- + +* Main Web site: https://www.coreboot.org +* Downloads: https://coreboot.org/downloads.html +* Source control: https://review.coreboot.org +* Documentation: https://doc.coreboot.org +* Issue tracker: https://ticket.coreboot.org/projects/coreboot +* Donations: https://coreboot.org/donate.html diff --git a/Documentation/releases/index.md b/Documentation/releases/index.md index cbf487b..0266fcb 100644 --- a/Documentation/releases/index.md +++ b/Documentation/releases/index.md @@ -6,7 +6,7 @@ ```{toctree} :maxdepth: 1 -24.08 - August 2024 <coreboot-24.08-relnotes.md> +24.11 - November 2024 <coreboot-24.11-relnotes.md> ``` The [checklist] contains instructions to ensure that a release covers all @@ -22,6 +22,7 @@ ```{toctree} :maxdepth: 1 +24.08 - August 2024 <coreboot-24.08-relnotes.md> 24.05 - May 2024 <coreboot-24.05-relnotes.md> 24.02 - February 2024 <coreboot-24.02-relnotes.md> 4.22 - November 2023 <coreboot-4.22-relnotes.md> -- To view, visit https://review.coreboot.org/c/coreboot/+/84036?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1e524f1db0090bf8815b08315f9cbc9894965af7 Gerrit-Change-Number: 84036 Gerrit-PatchSet: 1 Gerrit-Owner: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>

1 0

[S] Change in coreboot[main]: Documentation/vboot: Update vboot supported boards list
by Jason Glenesk (Code Review) 22 Aug '24

22 Aug '24

Jason Glenesk has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84035?usp=email ) Change subject: Documentation/vboot: Update vboot supported boards list ...................................................................... Documentation/vboot: Update vboot supported boards list Auto-generated by util/vboot_list/vboot_list.sh. Change-Id: Ie2d3378e8995b09372291294f9ffb0d2d8eccc8b Signed-off-by: Jason Glenesk <jason.glenesk(a)gmail.com> --- M Documentation/security/vboot/list_vboot.md 1 file changed, 14 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/84035/1 diff --git a/Documentation/security/vboot/list_vboot.md b/Documentation/security/vboot/list_vboot.md index 8340db4..a38eb24 100644 --- a/Documentation/security/vboot/list_vboot.md +++ b/Documentation/security/vboot/list_vboot.md @@ -38,8 +38,10 @@ - Zako (HP Chromebox G1) - Brox - Brox EC ISH -- Lotso +- Brox TI PDC - Greenbayupoc +- Jubilant +- Lotso - Agah - Anahera - Anahera4ES @@ -53,6 +55,7 @@ - Constitution - Crota - Dochi +- Domika - Felwinter - Gaelin - Gimble @@ -86,6 +89,8 @@ - Taeko - Taeko4ES - Taniks +- Teliks +- Tereid - Tivviks - Trulo - Uldren @@ -101,6 +106,7 @@ - Yavista - Sundance - Pujjoga +- Orisa - Butterfly (HP Pavilion Chromebook 14) - Cherry - Dojo @@ -132,6 +138,7 @@ - Wizpig - Drallion - Eve (Google Pixelbook) +- Fatcat - Fizz - Karma - Endeavour @@ -235,6 +242,7 @@ - Puff - Scout - Wyvern (CTL Chromebox CBx2) +- Rauru - Reef/Electro (Acer Chromebook Spin 11 R751T) - Pyro (Lenovo Thinkpad (Yoga) 11e Chromebook) - Sand (Acer Chromebook 15 CB515-1HT/1H) @@ -250,6 +258,7 @@ - Rex EC ISH - Rex4ES - Rex4ES EC ISH +- Rex 64 - Screebo - Screebo4ES - Arcada (Latitude 5300 2-in-1 Chromebook Enterprise) @@ -317,6 +326,7 @@ - Woomax (ASUS Chromebook Flip CM5) ## HP +- Compaq Elite 8300 USDT - Z220 CMT Workstation - Z220 SFF Workstation @@ -395,8 +405,8 @@ - Elgon (GBCv2) ## Protectli -- VP4630/VP4650 -- VP4670 +- VP6630/VP6650/VP6670 +- VP4630/VP4650/VP4670 - VP2420 ## SAMSUNG @@ -420,6 +430,7 @@ - Star Labs StarBook Mk V (i3-1115G4 and i7-1165G7) - Star Labs StarBook Mk VI (i3-1220P and i7-1260P) - Star Labs StarBook Mk VI (i3-1315U and i7-1360P) +- Star Labs Lite Mk V (N200) ## Supermicro - X11SSH-TF -- To view, visit https://review.coreboot.org/c/coreboot/+/84035?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie2d3378e8995b09372291294f9ffb0d2d8eccc8b Gerrit-Change-Number: 84035 Gerrit-PatchSet: 1 Gerrit-Owner: Jason Glenesk <jason.glenesk(a)gmail.com>

1 0

[M] Change in coreboot[main]: arch/riscv: Refactor SMP code
by Tim Wawrzynczak (Code Review) 22 Aug '24

22 Aug '24

Attention is currently required from: Maximilian Brune, Philipp Hug, ron minnich. Tim Wawrzynczak has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/81082?usp=email ) Change subject: arch/riscv: Refactor SMP code ...................................................................... Patch Set 5: (3 comments) File src/arch/riscv/smp.c: https://review.coreboot.org/c/coreboot/+/81082/comment/77561f0f_45d2b91c?us… : PS5, Line 20: atomic_set(&HLS()->entry.sync_a, 0x01234567); // mark the hart as sleeping. Add a symbolic constant for this magic value? https://review.coreboot.org/c/coreboot/+/81082/comment/cb19cedc_507063dd?us… : PS5, Line 49: for (int i = 0; i < hart_count; i++) { There seems to be an assumption that hartid are always contiguous from 0, is that the case? https://review.coreboot.org/c/coreboot/+/81082/comment/fefe5389_650bc197?us… : PS5, Line 80: while (atomic_read(&OTHER_HLS(i)->entry.sync_a) != 0) should there be a timeout ? -- To view, visit https://review.coreboot.org/c/coreboot/+/81082?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icc53185991fed4dbed032a52e51ff71d085ad587 Gerrit-Change-Number: 81082 Gerrit-PatchSet: 5 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Thu, 22 Aug 2024 21:03:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2024