Attention is currently required from: Caveh Jalali, Felix Singer, Forest Mittelberg, Martin L Roth, Matt DeVillier.
Hello Caveh Jalali, Felix Singer, Forest Mittelberg, Martin L Roth, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83639?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by build bot (Jenkins)
Change subject: ec/google/chromeec: Drop 'choice' selections for EC and PD firmware
......................................................................
ec/google/chromeec: Drop 'choice' selections for EC and PD firmware
Since the EC and PD firmware sources are now limited to two options -
'none' and 'external' - drop the choice selection and make the
EC and PD external options independent.
TEST=build google/lulu with external EC binary using existing defconfig
Change-Id: Ie37ff3a188b414fd099fbb344858bca4df419086
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/ec/google/chromeec/Kconfig
M src/ec/google/chromeec/Makefile.mk
2 files changed, 8 insertions(+), 42 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/83639/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83639?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie37ff3a188b414fd099fbb344858bca4df419086
Gerrit-Change-Number: 83639
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Forest Mittelberg <bmbm(a)google.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Forest Mittelberg <bmbm(a)google.com>
Attention is currently required from: Krystian Hebel, Michał Kopeć, Michał Żygowski, Paul Menzel.
Sergii Dmytruk has posted comments on this change by Krystian Hebel. ( https://review.coreboot.org/c/coreboot/+/82555?usp=email )
Change subject: mb/qemu-{i440fx,q35}/rom_media.c: add code for writable flash
......................................................................
Patch Set 9: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/82555?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3ab9f22c6165064a769881d4be5eab13a0a2f519
Gerrit-Change-Number: 82555
Gerrit-PatchSet: 9
Gerrit-Owner: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Comment-Date: Wed, 24 Jul 2024 22:14:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Elyes Haouas, Matt DeVillier.
Felix Singer has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/83524?usp=email )
Change subject: mb/intel/coffelake_rvp: Make use of chipset devicetree
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/intel/coffeelake_rvp/variants/cfl_s/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/83524/comment/d2cd640c_4af497b2?us… :
PS6, Line 97: device pci 15.0 on end # I2C #0
: device pci 15.1 on end # I2C #1
: device pci 15.2 on end # I2C #2
: device pci 15.3 on end # I2C #3
> what happened to these?
Very good question.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83524?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I79de952d95798aa3c241e7864223c63c0a72ce31
Gerrit-Change-Number: 83524
Gerrit-PatchSet: 6
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Wed, 24 Jul 2024 22:09:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>
Attention is currently required from: Felix Held, Michał Żygowski, Piotr Król.
Felix Singer has posted comments on this change by Felix Held. ( https://review.coreboot.org/c/coreboot/+/83640?usp=email )
Change subject: mb/protectli/vault_[adl_p,bsw]/Kconfig: drop unneeded MAINBOARD_VENDOR
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83640?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icfcbcec005fadb8eaf1b8f90e1d71b3c6ee32088
Gerrit-Change-Number: 83640
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Comment-Date: Wed, 24 Jul 2024 22:05:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83525?usp=email )
Change subject: mb/google/volteer/{delbin,drobit}: Use alias name for DPTF PCI device
......................................................................
mb/google/volteer/{delbin,drobit}: Use alias name for DPTF PCI device
Change-Id: If514ee7c1174d13b8ca8eb7fd20359e0730a8893
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83525
Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M src/mainboard/google/volteer/variants/delbin/overridetree.cb
M src/mainboard/google/volteer/variants/drobit/overridetree.cb
2 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
build bot (Jenkins): Verified
Matt DeVillier: Looks good to me, approved
diff --git a/src/mainboard/google/volteer/variants/delbin/overridetree.cb b/src/mainboard/google/volteer/variants/delbin/overridetree.cb
index c4f915c..92bd9e5 100644
--- a/src/mainboard/google/volteer/variants/delbin/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/delbin/overridetree.cb
@@ -61,7 +61,7 @@
}"
device domain 0 on
- device pci 04.0 on
+ device ref dptf on
chip drivers/intel/dptf
## Active Policy
register "policies.active" = "{
@@ -123,7 +123,7 @@
device generic 0 on end
end
- end # DPTF 0x9A03
+ end
device ref i2c0 on
chip drivers/i2c/generic
# register "hid" is set in variant.c because of FW_CONFIG
diff --git a/src/mainboard/google/volteer/variants/drobit/overridetree.cb b/src/mainboard/google/volteer/variants/drobit/overridetree.cb
index aefe141..1269f17 100644
--- a/src/mainboard/google/volteer/variants/drobit/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/drobit/overridetree.cb
@@ -60,7 +60,7 @@
}"
device domain 0 on
- device pci 04.0 on
+ device ref dptf on
chip drivers/intel/dptf
## Active Policy
register "policies.active" = "{
@@ -116,7 +116,7 @@
device generic 0 on end
end
- end # DPTF
+ end
device ref tbt_pcie_rp0 on
probe DB_USB USB4_GEN2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83525?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If514ee7c1174d13b8ca8eb7fd20359e0730a8893
Gerrit-Change-Number: 83525
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Felix Held has posted comments on this change by Michał Żygowski. ( https://review.coreboot.org/c/coreboot/+/80501?usp=email )
Change subject: mb/protectli/vault_adl_p: Add initial support for VP6630/VP6650/VP6670
......................................................................
Patch Set 11:
(1 comment)
File src/mainboard/protectli/vault_adl_p/Kconfig:
https://review.coreboot.org/c/coreboot/+/80501/comment/79fdbfb0_45eb9814?us… :
PS10, Line 26: config MAINBOARD_VENDOR
: default "Protectli"
> this is already set in mainboard/protectli/Kconfig, so it's not needed in here. […]
see CB:83640 for that
--
To view, visit https://review.coreboot.org/c/coreboot/+/80501?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If4ae5b14b69806b6b0727d1ca1dcf56f47cfcd8e
Gerrit-Change-Number: 80501
Gerrit-PatchSet: 11
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-Comment-Date: Wed, 24 Jul 2024 21:25:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83640?usp=email )
Change subject: mb/protectli/vault_[adl_p,bsw]/Kconfig: drop unneeded MAINBOARD_VENDOR
......................................................................
mb/protectli/vault_[adl_p,bsw]/Kconfig: drop unneeded MAINBOARD_VENDOR
MAINBOARD_VENDOR is already provided by the Kconfig file on the vendor
level, so there's no need to redefine it to the same value at the
mainboard level.
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: Icfcbcec005fadb8eaf1b8f90e1d71b3c6ee32088
---
M src/mainboard/protectli/vault_adl_p/Kconfig
M src/mainboard/protectli/vault_bsw/Kconfig
2 files changed, 0 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/83640/1
diff --git a/src/mainboard/protectli/vault_adl_p/Kconfig b/src/mainboard/protectli/vault_adl_p/Kconfig
index 51fb7c5..b7578ab 100644
--- a/src/mainboard/protectli/vault_adl_p/Kconfig
+++ b/src/mainboard/protectli/vault_adl_p/Kconfig
@@ -23,9 +23,6 @@
config MAINBOARD_PART_NUMBER
default "VP66XX"
-config MAINBOARD_VENDOR
- default "Protectli"
-
config MAINBOARD_FAMILY
default "Vault Pro"
diff --git a/src/mainboard/protectli/vault_bsw/Kconfig b/src/mainboard/protectli/vault_bsw/Kconfig
index 9bbb1b9..8650b57 100644
--- a/src/mainboard/protectli/vault_bsw/Kconfig
+++ b/src/mainboard/protectli/vault_bsw/Kconfig
@@ -29,10 +29,6 @@
default "FW2B" if BOARD_PROTECTLI_FW2B
default "FW4B" if BOARD_PROTECTLI_FW4B
-config MAINBOARD_VENDOR
- string
- default "Protectli"
-
config DIMM_MAX
default 1
--
To view, visit https://review.coreboot.org/c/coreboot/+/83640?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icfcbcec005fadb8eaf1b8f90e1d71b3c6ee32088
Gerrit-Change-Number: 83640
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Attention is currently required from: Elyes Haouas, Felix Singer.
Matt DeVillier has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/83524?usp=email )
Change subject: mb/intel/coffelake_rvp: Make use of chipset devicetree
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/intel/coffeelake_rvp/variants/cfl_s/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/83524/comment/08aaf342_eb0ea73e?us… :
PS6, Line 97: device pci 15.0 on end # I2C #0
: device pci 15.1 on end # I2C #1
: device pci 15.2 on end # I2C #2
: device pci 15.3 on end # I2C #3
what happened to these?
--
To view, visit https://review.coreboot.org/c/coreboot/+/83524?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I79de952d95798aa3c241e7864223c63c0a72ce31
Gerrit-Change-Number: 83524
Gerrit-PatchSet: 6
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Wed, 24 Jul 2024 21:16:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Elyes Haouas, Eric Lai, Felix Singer, Nick Vaccaro.
Matt DeVillier has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/83525?usp=email )
Change subject: mb/google/volteer/{delbin,drobit}: Use alias name for DPTF PCI device
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83525?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If514ee7c1174d13b8ca8eb7fd20359e0730a8893
Gerrit-Change-Number: 83525
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Wed, 24 Jul 2024 21:13:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83455?usp=email )
Change subject: mb/protectli/vault_cml: Drop superfluous devices from devicetree
......................................................................
mb/protectli/vault_cml: Drop superfluous devices from devicetree
In order to clean up a bit, drop devices which are equivalent to the
ones from chipset devicetree.
Change-Id: Ie485684747efccb8fb0ab87f10694c52a98f3c88
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83455
Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M src/mainboard/protectli/vault_cml/devicetree.cb
1 file changed, 0 insertions(+), 35 deletions(-)
Approvals:
Matt DeVillier: Looks good to me, approved
build bot (Jenkins): Verified
diff --git a/src/mainboard/protectli/vault_cml/devicetree.cb b/src/mainboard/protectli/vault_cml/devicetree.cb
index ccfe118..14e6048 100644
--- a/src/mainboard/protectli/vault_cml/devicetree.cb
+++ b/src/mainboard/protectli/vault_cml/devicetree.cb
@@ -140,42 +140,18 @@
}"
device domain 0 on
- device ref system_agent on end
device ref igpu on end
device ref dptf on end
- device ref gna off end
device ref thermal on end
- device ref ufs off end
- device ref gspi2 off end
device ref xhci on end
- device ref xdci off end
- device ref sdxc off end
- device ref i2c0 off end
- device ref i2c1 off end
- device ref i2c2 off end
- device ref i2c3 off end
- device ref heci1 on end
- device ref heci2 off end
- device ref csme_ider off end
- device ref csme_ktr off end
- device ref heci3 off end
- device ref heci4 off end
device ref sata on end
- device ref i2c4 off end
- device ref i2c5 off end
- device ref uart2 off end
device ref emmc on end
- device ref pcie_rp1 off end
- device ref pcie_rp2 off end
- device ref pcie_rp3 off end
- device ref pcie_rp4 off end
device ref pcie_rp5 on end # LAN1
device ref pcie_rp6 on end # LAN2
device ref pcie_rp7 on end # LAN3
device ref pcie_rp8 on end # LAN4
device ref pcie_rp9 on end # LAN5
device ref pcie_rp10 on end # LAN6
- device ref pcie_rp11 off end
device ref pcie_rp12 on end
smbios_slot_desc "SlotTypeM2Socket1_SD" "SlotLengthOther"
"M.2/E 2230 (M2_WIFI2)" "SlotDataBusWidth1X"
@@ -183,13 +159,6 @@
smbios_slot_desc "SlotTypeM2Socket3" "SlotLengthOther"
"M.2/M 2280 (J1)" "SlotDataBusWidth4X"
end
- device ref pcie_rp14 off end
- device ref pcie_rp15 off end
- device ref pcie_rp16 off end
- device ref uart0 off end
- device ref uart1 off end
- device ref gspi0 off end
- device ref gspi1 off end
device ref lpc_espi on
chip superio/ite/it8784e
register "TMPIN1.mode" = "THERMAL_RESISTOR"
@@ -231,11 +200,7 @@
device pnp 0c31.0 on end
end
end
- device ref p2sb hidden end
- device ref pmc hidden end
device ref hda on end
device ref smbus on end
- device ref fast_spi on end
- device ref gbe off end
end
end
--
To view, visit https://review.coreboot.org/c/coreboot/+/83455?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie485684747efccb8fb0ab87f10694c52a98f3c88
Gerrit-Change-Number: 83455
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>