Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83308?usp=email )
Change subject: ec/system76/ec: Remove RPM calculation
......................................................................
ec/system76/ec: Remove RPM calculation
System76 EC since system76/ec@80cfa91b9fd5 ("acpi: Report RPM values
instead of raw tachometer values") performs the RPM calculation itself
and stores it in EC RAM where previously the raw tachometer values were
saved. The SBIOS is no longer required to make the conversion.
Change-Id: I82a4e25a8ce0f274b2d98e7ff2b12595acf6c3c5
Signed-off-by: Tim Crawford <tcrawford(a)system76.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83308
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Jeremy Soller <jeremy(a)system76.com>
---
M src/ec/system76/ec/acpi/s76.asl
1 file changed, 0 insertions(+), 4 deletions(-)
Approvals:
build bot (Jenkins): Verified
Jeremy Soller: Looks good to me, approved
diff --git a/src/ec/system76/ec/acpi/s76.asl b/src/ec/system76/ec/acpi/s76.asl
index 329c5d3..06000a4 100644
--- a/src/ec/system76/ec/acpi/s76.asl
+++ b/src/ec/system76/ec/acpi/s76.asl
@@ -146,10 +146,6 @@
Local1 = ^^PCI0.LPCB.EC0.RPM2
}
}
- If (Local1 != 0) {
- // 60 * (EC frequency / 120) / 2
- Local1 = 2156250 / Local1
- }
Return ((Local1 << 8) | Local0)
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/83308?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I82a4e25a8ce0f274b2d98e7ff2b12595acf6c3c5
Gerrit-Change-Number: 83308
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Attention is currently required from: Dinesh Gehlot, Jayvik Desai.
Subrata Banik has posted comments on this change by Dinesh Gehlot. ( https://review.coreboot.org/c/coreboot/+/83667?usp=email )
Change subject: vc/google/chromeos/Kconfig: Enable config to determine eSOL status
......................................................................
Patch Set 3:
(1 comment)
File src/vendorcode/google/chromeos/Kconfig:
https://review.coreboot.org/c/coreboot/+/83667/comment/180675e4_666e8594?us… :
PS3, Line 82: CHROMEOS_ENABLES_ESOL
can we use this as a choice menu where, default `y` if libgfxinit (device/Kconfig) or uGOP (which could come from FSP driver) , otherwise `n`.
hence, the flow would be like
1. either mainboard or soc selects MAINBOARD_HAS_EARLY_LIBGFXINIT
2. or SOC_INTEL_METEORLAKE_SIGN_OF_LIFE would select the FSP Kconfig
no one needs to select this config because either #1 or #2 should set this Kconfig set to enable otherwise eSOL not enabled.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83667?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I68aca8033cf843e8a569339ab1af85fab104b36a
Gerrit-Change-Number: 83667
Gerrit-PatchSet: 3
Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Comment-Date: Fri, 26 Jul 2024 20:46:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Jayvik Desai, Subrata Banik.
Hello Jayvik Desai, Subrata Banik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83668?usp=email
to look at the new patch set (#2).
Change subject: src/device/Kconfig: Enable eSOL config with libgfx
......................................................................
src/device/Kconfig: Enable eSOL config with libgfx
This patch enables the eSOL config option when libgfx is enabled for
early graphics initialization.
BUG=NA
TEST=Able to build google/rex and google/tivviks
Change-Id: I04081591fee18b2d3263aa7c955620aebcf4b09d
Signed-off-by: Dinesh Gehlot <digehlot(a)google.com>
---
M src/device/Kconfig
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/83668/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83668?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I04081591fee18b2d3263aa7c955620aebcf4b09d
Gerrit-Change-Number: 83668
Gerrit-PatchSet: 2
Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Attention is currently required from: Jayvik Desai, Subrata Banik.
Dinesh Gehlot has posted comments on this change by Dinesh Gehlot. ( https://review.coreboot.org/c/coreboot/+/83667?usp=email )
Change subject: vc/google/chromeos/Kconfig: Enable config to determine eSOL status
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS1:
> ideally you can split this into three cls […]
Splited the change as suggested.
File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/83667/comment/a9d94998_351fcfe4?us… :
PS1, Line 55: MAINBOARD_HAS_EARLY_SIGN_OF_LIFE
> eSOL is a chromeos feature then why this is here ? i would request to have the config added as part […]
Acknowledged
--
To view, visit https://review.coreboot.org/c/coreboot/+/83667?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I68aca8033cf843e8a569339ab1af85fab104b36a
Gerrit-Change-Number: 83667
Gerrit-PatchSet: 2
Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Comment-Date: Fri, 26 Jul 2024 19:27:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Dinesh Gehlot has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83668?usp=email )
Change subject: src/device/Kconfig: Enable eSOL config with libgfx
......................................................................
src/device/Kconfig: Enable eSOL config with libgfx
This patch enables the eSOL config option when libgfx is enabled for
early graphics initialization.
BUG=NA
TEST=Able to build google/rex and google/tivviks
Change-Id: I04081591fee18b2d3263aa7c955620aebcf4b09d
Signed-off-by: Dinesh Gehlot <digehlot(a)google.com>
---
M src/device/Kconfig
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/83668/1
diff --git a/src/device/Kconfig b/src/device/Kconfig
index 243e23e..5d4dac1 100644
--- a/src/device/Kconfig
+++ b/src/device/Kconfig
@@ -60,6 +60,7 @@
config MAINBOARD_HAS_EARLY_LIBGFXINIT
def_bool n
+ select CHROMEOS_ENABLES_ESOL if CHROMEOS
help
Selected by mainboards that implement early (cache-as-ram
stage) support of `libgfxinit`. Usually this requires a list
--
To view, visit https://review.coreboot.org/c/coreboot/+/83668?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I04081591fee18b2d3263aa7c955620aebcf4b09d
Gerrit-Change-Number: 83668
Gerrit-PatchSet: 1
Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com>
Attention is currently required from: Dinesh Gehlot, Jayvik Desai.
Hello Eran Mitrani, Jakub Czapiga, Jayvik Desai, Kapil Porwal, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83667?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: vc/google/chromeos/Kconfig: Enable config to determine eSOL status
......................................................................
vc/google/chromeos/Kconfig: Enable config to determine eSOL status
The patch adds a config CHROMEOS_ENABLES_ESOL to determine whether eSOL
is enabled.
BUG=NA
TEST=Able to build google/rex and google/tivviks
Change-Id: I68aca8033cf843e8a569339ab1af85fab104b36a
Signed-off-by: Dinesh Gehlot <digehlot(a)google.com>
---
M src/vendorcode/google/chromeos/Kconfig
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/83667/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83667?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I68aca8033cf843e8a569339ab1af85fab104b36a
Gerrit-Change-Number: 83667
Gerrit-PatchSet: 2
Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Attention is currently required from: David Wu, Ren Kuo, Shelley Chen, Subrata Banik, Tyler Wang.
Karthik Ramasubramanian has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/83212?usp=email )
Change subject: mb/google/brox: Create jubilant variant
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/brox/variants/jubilant/gpio.c:
https://review.coreboot.org/c/coreboot/+/83212/comment/deed9f59_2b7ecf08?us… :
PS4, Line 227:
Nit: Remove all the empty newlines at the end of the file. Checkpatch is raising an error. Here and in other files.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83212?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic54437697058f8bce2167093bd88c0880d1b7cac
Gerrit-Change-Number: 83212
Gerrit-PatchSet: 4
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 26 Jul 2024 17:05:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No