coreboot-gerrit July 2024

coreboot-gerrit@coreboot.org

1 participants
3025 discussions

[XL] Change in coreboot[main]: skl/kbl mainboards: Move PCIe related settings into their device scope
by Felix Singer (Code Review) 10 Jul '24

10 Jul '24

Felix Singer has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/83373?usp=email ) Change subject: skl/kbl mainboards: Move PCIe related settings into their device scope ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/83373?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1ffa87eeee521180f37371e5a0d1f9a1a06091aa Gerrit-Change-Number: 83373 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 10 Jul 2024 01:50:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in qc_blobs[main]: sc7180/qtiseclib: Update qtiseclib blobs and release notes from 69 to 71
by Felix Singer (Code Review) 10 Jul '24

10 Jul '24

Attention is currently required from: Bharath N, Julius Werner, Paul Menzel, Shelley Chen. Felix Singer has posted comments on this change by Bharath N. ( https://review.coreboot.org/c/qc_blobs/+/83305?usp=email ) Change subject: sc7180/qtiseclib: Update qtiseclib blobs and release notes from 69 to 71 ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/qc_blobs/+/83305?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: qc_blobs Gerrit-Branch: main Gerrit-Change-Id: Ia390035cdd591c1d31fd2e28ad53e63d16e91a37 Gerrit-Change-Number: 83305 Gerrit-PatchSet: 3 Gerrit-Owner: Bharath N <quic_bharn(a)quicinc.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: mturney mturney <quic_mturney(a)quicinc.com> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Bharath N <quic_bharn(a)quicinc.com> Gerrit-Comment-Date: Wed, 10 Jul 2024 01:40:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/google/brox/var/lotso: Add FW_CONFIG for FP
by Wentao Qin (Code Review) 10 Jul '24

10 Jul '24

Attention is currently required from: Eric Lai, Jian Tong, Karthik Ramasubramanian, Shelley Chen, Subrata Banik. Wentao Qin has posted comments on this change by Wentao Qin. ( https://review.coreboot.org/c/coreboot/+/83388?usp=email ) Change subject: mb/google/brox/var/lotso: Add FW_CONFIG for FP ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/brox/variants/lotso/overridetree.cb: https://review.coreboot.org/c/coreboot/+/83388/comment/ccaed741_bb412e00?us… : PS2, Line 30: option FP_PRESENT 0 > Yes, because our proto stage is all SKUs that present in FP, so in order to be compatible with the p […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/83388?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1ee5fcd1c29099bdbee741ef76c00cf45fcc1189 Gerrit-Change-Number: 83388 Gerrit-PatchSet: 2 Gerrit-Owner: Wentao Qin <qinwentao(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jian Tong <tongjian(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jian Tong <tongjian(a)huaqin.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 10 Jul 2024 01:16:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Comment-In-Reply-To: Wentao Qin <qinwentao(a)huaqin.corp-partner.google.com>

1 0

[S] Change in coreboot[main]: autoport: Drop ioapic, ioapic_irq, and lapic handling for devicetree
by Felix Singer (Code Review) 10 Jul '24

10 Jul '24

Attention is currently required from: Arthur Heymans, Nicholas Chin. Felix Singer has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/83358?usp=email ) Change subject: autoport: Drop ioapic, ioapic_irq, and lapic handling for devicetree ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83358?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icf2582594b244cf5f726c722eb3a3c12573a2662 Gerrit-Change-Number: 83358 Gerrit-PatchSet: 3 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Wed, 10 Jul 2024 01:10:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/google/brox/var/lotso: Add FW_CONFIG for FP
by Wentao Qin (Code Review) 10 Jul '24

10 Jul '24

Attention is currently required from: Eric Lai, Jian Tong, Karthik Ramasubramanian, Shelley Chen, Subrata Banik. Wentao Qin has posted comments on this change by Wentao Qin. ( https://review.coreboot.org/c/coreboot/+/83388?usp=email ) Change subject: mb/google/brox/var/lotso: Add FW_CONFIG for FP ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/brox/variants/lotso/overridetree.cb: https://review.coreboot.org/c/coreboot/+/83388/comment/f8f90948_14e31b5d?us… : PS2, Line 30: option FP_PRESENT 0 > This bit config value seems counter intuitive - 0 for present/enabled and 1 for absent/disabled. […] Yes, because our proto stage is all SKUs that present in FP, so in order to be compatible with the proto stage, we set 0 to present -- To view, visit https://review.coreboot.org/c/coreboot/+/83388?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1ee5fcd1c29099bdbee741ef76c00cf45fcc1189 Gerrit-Change-Number: 83388 Gerrit-PatchSet: 2 Gerrit-Owner: Wentao Qin <qinwentao(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jian Tong <tongjian(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jian Tong <tongjian(a)huaqin.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 10 Jul 2024 01:03:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>

1 0

[XS] Change in coreboot[main]: Revert "Makefile.mk: Remove bc dependency"
by Felix Singer (Code Review) 10 Jul '24

10 Jul '24

Felix Singer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/83375?usp=email ) Change subject: Revert "Makefile.mk: Remove bc dependency" ...................................................................... Abandoned Superseded by CB:83377 -- To view, visit https://review.coreboot.org/c/coreboot/+/83375?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibf9041b0095ac486d4ee7e8925be8cebb13d2c8f Gerrit-Change-Number: 83375 Gerrit-PatchSet: 2 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: Makefile: unexport CFLAGS
by Julius Werner (Code Review) 10 Jul '24

10 Jul '24

Attention is currently required from: Felix Singer, Martin L Roth, Nico Huber, Torsten Schenk. Julius Werner has posted comments on this change by Torsten Schenk. ( https://review.coreboot.org/c/coreboot/+/83379?usp=email ) Change subject: Makefile: unexport CFLAGS ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > The leak is in `payloads/libpayload/Makefile.payload`. […] Maybe we should do this in that file, then, that would make a little more sense (or rewrite the payload Makefiles so they don't rely on CFLAGS at all, although that would probably be too much of a hassle). -- To view, visit https://review.coreboot.org/c/coreboot/+/83379?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5fe75095aec620ef1bcdb5506dc7d29e482697a1 Gerrit-Change-Number: 83379 Gerrit-PatchSet: 1 Gerrit-Owner: Torsten Schenk Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Torsten Schenk Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Wed, 10 Jul 2024 00:19:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>

1 0

[XS] Change in coreboot[main]: Makefile: unexport CFLAGS
by Felix Singer (Code Review) 10 Jul '24

10 Jul '24

Attention is currently required from: Julius Werner, Martin L Roth, Nico Huber, Torsten Schenk. Felix Singer has posted comments on this change by Torsten Schenk. ( https://review.coreboot.org/c/coreboot/+/83379?usp=email ) Change subject: Makefile: unexport CFLAGS ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Where does the flag leak, exactly? I believe for the actual coreboot cross-compilation, nothing shou […] The leak is in `payloads/libpayload/Makefile.payload`. If CFLAGS is present in the environment, then the CFLAGS variable from the Makefile will expand to it. I think Torsten tried to build coreboot with the coreinfo payload. -- To view, visit https://review.coreboot.org/c/coreboot/+/83379?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5fe75095aec620ef1bcdb5506dc7d29e482697a1 Gerrit-Change-Number: 83379 Gerrit-PatchSet: 1 Gerrit-Owner: Torsten Schenk Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Torsten Schenk Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Wed, 10 Jul 2024 00:05:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>

1 0

[XS] Change in coreboot[main]: Makefile: unexport CFLAGS
by Julius Werner (Code Review) 10 Jul '24

10 Jul '24

Attention is currently required from: Martin L Roth, Nico Huber, Torsten Schenk. Julius Werner has posted comments on this change by Torsten Schenk. ( https://review.coreboot.org/c/coreboot/+/83379?usp=email ) Change subject: Makefile: unexport CFLAGS ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Where does the flag leak, exactly? I believe for the actual coreboot cross-compilation, nothing should be using a variable that's just called `CFLAGS` (coreboot is using `CFLAGS_common`, `CFLAGS_ramstage`, etc.). For host utilities like `cbmem` I believe this may be "working as intended" and in line with other Linux utilities that are usually sensitive to these variables to allow the host environment to add custom options if it needs to (although we're not very consistent in that, e.g. `cbfstool` doesn't seem to use it either). If you don't want things you compile to fail from extra errors, you probably shouldn't have `CFLAGS=-Werror` in your environment. -- To view, visit https://review.coreboot.org/c/coreboot/+/83379?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5fe75095aec620ef1bcdb5506dc7d29e482697a1 Gerrit-Change-Number: 83379 Gerrit-PatchSet: 1 Gerrit-Owner: Torsten Schenk Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Torsten Schenk Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Tue, 09 Jul 2024 23:55:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XL] Change in coreboot[main]: soc/intel/ptl: Do initial Panther Lake SoC commit till bootblock
by Felix Singer (Code Review) 10 Jul '24

10 Jul '24

Attention is currently required from: Saurabh Mishra. Felix Singer has posted comments on this change by Saurabh Mishra. ( https://review.coreboot.org/c/coreboot/+/83354?usp=email ) Change subject: soc/intel/ptl: Do initial Panther Lake SoC commit till bootblock ...................................................................... Patch Set 4: (2 comments) File src/soc/intel/pantherlake/Kconfig: https://review.coreboot.org/c/coreboot/+/83354/comment/ae295e5f_2fd50e33?us… : PS4, Line 12: config CPU_SPECIFIC_OPTIONS Please move the selects to SOC_INTEL_PANTHERLAKE_BASE. We don't use CPU_SPECIFIC_OPTIONS anymore. File src/soc/intel/pantherlake/Makefile.mk: https://review.coreboot.org/c/coreboot/+/83354/comment/0a194052_d83ca8fc?us… : PS4, Line 1: ## SPDX-License-Identifier: GPL-2.0-only : if ```suggestion ## SPDX-License-Identifier: GPL-2.0-only ifeq ($(CONFIG_SOC_INTEL_PANTHERLAKE_BASE),y) ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/83354?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibcfe71eec27cebf04f10ec343a73dd92f1272aca Gerrit-Change-Number: 83354 Gerrit-PatchSet: 4 Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-CC: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-CC: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-CC: Saurabh Mishra <mishra.saurabh(a)intel.corp-partner.google.com> Gerrit-CC: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Comment-Date: Tue, 09 Jul 2024 23:23:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2024