Attention is currently required from: Matt DeVillier, Nick Vaccaro, Subrata Banik.
Felix Singer has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/83409?usp=email )
Change subject: mb/google/hatch/var/jinlon: Use display device type vs hardocded address
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83409?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ief22928ea831d4cb5b483406ac388218a97ad98b
Gerrit-Change-Number: 83409
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Fri, 12 Jul 2024 16:47:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Elyes Haouas has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/83435?usp=email )
Change subject: [for test] define NULL as ((nullptr_t)0)
......................................................................
[for test] define NULL as ((nullptr_t)0)
nullptr_t added to GCC-14, let give it a shot (just for test).
Change-Id: Ia0b91cf998748b496d2650475ed0fd010e6e9abd
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M src/include/stddef.h
M src/lib/thread.c
2 files changed, 5 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/83435/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83435?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia0b91cf998748b496d2650475ed0fd010e6e9abd
Gerrit-Change-Number: 83435
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Attention is currently required from: Matt DeVillier.
Felix Singer has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/83410?usp=email )
Change subject: mb/google/puff: Use auto fan control
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/puff/Kconfig:
https://review.coreboot.org/c/coreboot/+/83410/comment/c85f919e_8d0ae25f?us… :
PS1, Line 17: select EC_GOOGLE_CHROMEEC_AUTO_FAN_CTRL
Since this should be applied for non-ChromeOS builds, shouldn't this be conditional on !CHROMEOS?
```suggestion
select EC_GOOGLE_CHROMEEC_AUTO_FAN_CTRL if !CHROMEOS
```
--
To view, visit https://review.coreboot.org/c/coreboot/+/83410?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I478cdb95757671d4ecd9c2d45af2aa1d53b4b833
Gerrit-Change-Number: 83410
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Comment-Date: Fri, 12 Jul 2024 16:41:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Lawrence Chang, Tongtong Pan.
Karthik Ramasubramanian has posted comments on this change by Tongtong Pan. ( https://review.coreboot.org/c/coreboot/+/83427?usp=email )
Change subject: mb/google/dedede/variants/awasuki: Generate 3 RAM IDs
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83427?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9a03c86770101ec70c2ee5d6b914313c1bf23b5f
Gerrit-Change-Number: 83427
Gerrit-PatchSet: 3
Gerrit-Owner: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Lawrence Chang <lawrence.chang(a)intel.com>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-CC: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Lawrence Chang <lawrence.chang(a)intel.com>
Gerrit-Comment-Date: Fri, 12 Jul 2024 16:21:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Dolan Liu, Lawrence Chang, Paul Menzel, Tongtong Pan.
Karthik Ramasubramanian has posted comments on this change by Tongtong Pan. ( https://review.coreboot.org/c/coreboot/+/83376?usp=email )
Change subject: mb/google/dedede: Create awasuki variant
......................................................................
Patch Set 9: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83376?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If18afc92afdbdff5df3f5b034f4357feda6690b0
Gerrit-Change-Number: 83376
Gerrit-PatchSet: 9
Gerrit-Owner: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Lawrence Chang <lawrence.chang(a)intel.com>
Gerrit-Reviewer: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Lawrence Chang <lawrence.chang(a)intel.com>
Gerrit-Comment-Date: Fri, 12 Jul 2024 16:20:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Matt DeVillier, Nick Vaccaro, Subrata Banik.
Eric Lai has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/83434?usp=email )
Change subject: mb/google/byra: Add VBTs for variants missing them
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83434?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6848c2b78cf37157299d94bf12c0b6d925ea1432
Gerrit-Change-Number: 83434
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Fri, 12 Jul 2024 16:15:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Jérémy Compostella has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83310?usp=email )
Change subject: mb/intel/mtlrvp: Set USB2-10 as cnvi_wifi bluetooth companion device
......................................................................
mb/intel/mtlrvp: Set USB2-10 as cnvi_wifi bluetooth companion device
To publish the Bluetooth Regulator Domain Settings under the right
ACPI device scope, the wifi generic driver requires the bluetooth
companion to be set accordingly.
This commit also updates the USB2 port 10 description and set its type
to the more appropriate `UPC_TYPE_INTERNAL' type.
BUG=b:348345301
TEST=BRDS method is added to the CNVW device and returns the data
supplied by the SAR binary blob
Change-Id: I66c9b75d2aaa1b221313b037defcd2c579fd6b61
Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83310
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Subrata Banik <subratabanik(a)google.com>
Reviewed-by: Cliff Huang <cliff.huang(a)intel.com>
---
M src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Cliff Huang: Looks good to me, but someone else must approve
Subrata Banik: Looks good to me, approved
build bot (Jenkins): Verified
diff --git a/src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb b/src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb
index a0f27f0..010cae2 100644
--- a/src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb
+++ b/src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb
@@ -402,8 +402,8 @@
device ref usb2_port9 on end
end
chip drivers/usb/acpi
- register "desc" = ""USB2 Type-A Port 10""
- register "type" = "UPC_TYPE_A"
+ register "desc" = ""USB2 Bluetooth""
+ register "type" = "UPC_TYPE_INTERNAL"
register "group" = "ACPI_PLD_GROUP(10, 1)"
device ref usb2_port10 on end
end
@@ -426,6 +426,7 @@
chip drivers/wifi/generic
register "wake" = "GPE0_PME_B0"
register "enable_cnvi_ddr_rfim" = "true"
+ use usb2_port10 as bluetooth_companion
device generic 0 on end
end
end
--
To view, visit https://review.coreboot.org/c/coreboot/+/83310?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I66c9b75d2aaa1b221313b037defcd2c579fd6b61
Gerrit-Change-Number: 83310
Gerrit-PatchSet: 4
Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: YH Lin <yueherngl(a)google.com>
Attention is currently required from: Lawrence Chang, Tongtong Pan.
Eric Lai has posted comments on this change by Tongtong Pan. ( https://review.coreboot.org/c/coreboot/+/83427?usp=email )
Change subject: mb/google/dedede/variants/awasuki: Generate 3 RAM IDs
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83427/comment/0611bdd5_314f09a4?us… :
PS3, Line 7: variants
var
--
To view, visit https://review.coreboot.org/c/coreboot/+/83427?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9a03c86770101ec70c2ee5d6b914313c1bf23b5f
Gerrit-Change-Number: 83427
Gerrit-PatchSet: 3
Gerrit-Owner: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Lawrence Chang <lawrence.chang(a)intel.com>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-CC: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Lawrence Chang <lawrence.chang(a)intel.com>
Gerrit-Comment-Date: Fri, 12 Jul 2024 16:13:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83435?usp=email )
Change subject: [for test] define NULL as ((nullptr_t)0)
......................................................................
[for test] define NULL as ((nullptr_t)0)
nullptr_t added to GCC-14, let give it a shot (just for test).
Change-Id: Ia0b91cf998748b496d2650475ed0fd010e6e9abd
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M src/include/stddef.h
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/83435/1
diff --git a/src/include/stddef.h b/src/include/stddef.h
index 82d38c3..e613622 100644
--- a/src/include/stddef.h
+++ b/src/include/stddef.h
@@ -19,8 +19,11 @@
typedef __WCHAR_TYPE__ wchar_t;
typedef __WINT_TYPE__ wint_t;
+#if (__GNUC__ >= 14)
+#define NULL ((nullptr_t)0)
+#else
#define NULL ((void *)0)
-
+#endif
/* The devicetree data structures are only mutable in ramstage. All other
stages have a constant devicetree. */
#if !ENV_PAYLOAD_LOADER
--
To view, visit https://review.coreboot.org/c/coreboot/+/83435?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia0b91cf998748b496d2650475ed0fd010e6e9abd
Gerrit-Change-Number: 83435
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83412?usp=email )
Change subject: amdfwtool: make fields unsigned
......................................................................
amdfwtool: make fields unsigned
The value stored in `gen` is only ever `1` or `0`. Storing `1` causes
Clang to warn, since the only valid values for a 1-bit int are -1 and 0:
```
amdfwtool.c:1487:27: error: implicit truncation from 'int' to a one-bit
wide bit-field changes value from 1 to -1
[-Werror,-Wsingle-bit-bitfield-constant-conversion]
1487 | amd_romsig->efs_gen.gen = EFS_BEFORE_SECOND_GEN;
```
TEST=Rebuilt coreboot; no warning was emitted.
Change-Id: Ibd83be8302e8a717db7e7dc86a403b5648976586
Signed-off-by: George Burgess IV <gbiv(a)google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83412
Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de>
Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Raul Rangel <rrangel(a)chromium.org>
---
M util/amdfwtool/amdfwtool.h
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
build bot (Jenkins): Verified
Felix Held: Looks good to me, approved
Raul Rangel: Looks good to me, approved
Matt DeVillier: Looks good to me, but someone else must approve
diff --git a/util/amdfwtool/amdfwtool.h b/util/amdfwtool/amdfwtool.h
index 1dc445c..b2fd2c0 100644
--- a/util/amdfwtool/amdfwtool.h
+++ b/util/amdfwtool/amdfwtool.h
@@ -143,8 +143,8 @@
} amd_addr_mode;
struct second_gen_efs { /* todo: expand for Server products */
- int gen:1; /* Client products only use bit 0 */
- int reserved:31;
+ uint32_t gen:1; /* Client products only use bit 0 */
+ uint32_t reserved:31;
} __attribute__((packed));
#define EFS_SECOND_GEN 0
--
To view, visit https://review.coreboot.org/c/coreboot/+/83412?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibd83be8302e8a717db7e7dc86a403b5648976586
Gerrit-Change-Number: 83412
Gerrit-PatchSet: 3
Gerrit-Owner: George Burgess <gbiv(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jon Murphy <jpmurphy(a)google.com>