Attention is currently required from: Jeremy Soller, Tim Crawford.
Felix Singer has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/78840?usp=email )
Change subject: mb/system76/whl-u/dt: Make use of chipset devicetree
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/78840?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iebe5f8729d463767f5a1b52c375d11bb9d413144
Gerrit-Change-Number: 78840
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Comment-Date: Fri, 12 Jul 2024 19:16:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Felix Singer has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/78839?usp=email )
Change subject: mb/system76/oryp5/dt: Make use of chipset devicetree
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/78839?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4769f255ce5652a9969ad6535c997ec1ad0be8d2
Gerrit-Change-Number: 78839
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 12 Jul 2024 19:16:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Attention is currently required from: Jeremy Soller, Tim Crawford.
Felix Singer has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/78838?usp=email )
Change subject: mb/system76/cml-u/dt: Make use of chipset devicetree
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/78838?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic33bf07041a8c966dce66109c577621513147609
Gerrit-Change-Number: 78838
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Comment-Date: Fri, 12 Jul 2024 19:16:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Attention is currently required from: Jeremy Soller, Tim Crawford.
Felix Singer has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/78837?usp=email )
Change subject: mb/system76/addw1/dt: Make use of chipset devicetree
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/78837?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ide536c74683416b34b0984fe1bddb250e72b045b
Gerrit-Change-Number: 78837
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Comment-Date: Fri, 12 Jul 2024 19:16:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Attention is currently required from: Jeremy Soller, Tim Crawford.
Felix Singer has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/78836?usp=email )
Change subject: mb/system76/oryp6/dt: Make use of chipset devicetree
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/78836?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id3605e8e05d9d97a73af966459692276265df8bc
Gerrit-Change-Number: 78836
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Comment-Date: Fri, 12 Jul 2024 19:16:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Attention is currently required from: Jeremy Soller, Tim Crawford.
Felix Singer has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/78835?usp=email )
Change subject: mb/system76/bonw14/dt: Make use of chipset devicetree
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/78835?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2b0e19581e0f0111a56bc57185acfcdd70588141
Gerrit-Change-Number: 78835
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Comment-Date: Fri, 12 Jul 2024 19:16:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Felix Singer has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/78834?usp=email )
Change subject: mb/system76/gaze15/dt: Make use of chipset devicetree
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/78834?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I290fcfdd7b2cff61c4f6cd153133c5205c6fd6d1
Gerrit-Change-Number: 78834
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 12 Jul 2024 19:16:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Attention is currently required from: Eric Lai, Nick Vaccaro, Subrata Banik.
Maximilian Brune has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/83436?usp=email )
Change subject: libpayload: Unconditionally handle "CBMEM_ID_CSE_*" entries
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83436?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icf056f8426015e99509be5f5a67cb66468645cd9
Gerrit-Change-Number: 83436
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Fri, 12 Jul 2024 19:03:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Fred Reitberger, Jason Glenesk, Matt DeVillier.
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83439?usp=email )
Change subject: soc/amd/phoenix/include/gpio: update GPIO HID to AMDI0030
......................................................................
soc/amd/phoenix/include/gpio: update GPIO HID to AMDI0030
The UEFI reference firmware uses AMDI0030 instead of AMD0030 as HID for
the GPIO controller.
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: I4a6fa1acdca0ee5b6e1358b6279b7c501d3dfd16
---
M src/soc/amd/phoenix/include/soc/gpio.h
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/83439/1
diff --git a/src/soc/amd/phoenix/include/soc/gpio.h b/src/soc/amd/phoenix/include/soc/gpio.h
index daad3b0..e62568e 100644
--- a/src/soc/amd/phoenix/include/soc/gpio.h
+++ b/src/soc/amd/phoenix/include/soc/gpio.h
@@ -3,7 +3,7 @@
#ifndef AMD_PHOENIX_GPIO_H
#define AMD_PHOENIX_GPIO_H
-#define GPIO_DEVICE_NAME "AMD0030"
+#define GPIO_DEVICE_NAME "AMDI0030"
#define GPIO_DEVICE_DESC "GPIO Controller"
#ifndef __ACPI__
--
To view, visit https://review.coreboot.org/c/coreboot/+/83439?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4a6fa1acdca0ee5b6e1358b6279b7c501d3dfd16
Gerrit-Change-Number: 83439
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>