Attention is currently required from: Balázs Vinarz, Mike Banon, Vlado Ilic.
Hello Balázs Vinarz, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79838?usp=email
to look at the new patch set (#15).
The following approvals got outdated and were removed:
Verified-1 by build bot (Jenkins)
Change subject: restore_agesa.sh - restores the opensource AMD AGESA boards
......................................................................
restore_agesa.sh - restores the opensource AMD AGESA boards
restore_agesa.sh reverts the opensource AGESA AMD boards removal
that happened after 5e8e911b7caee021faff96c4e82a77a42544ea62
commit (0 point of history, or 0 PoH) - by git-reverting:
1) the "bad commits" (marked as "CBF" = coreboot build failure)
- that either remove or break a code needed for our boards
2) the "unlucky commits" (marked as "GRF" = git revert failure)
- that are a roadblock for git-reverting the "bad commits"
Right now at 88bc0f1604494de0f87c6954c050e7ef4d1c4457 (7153 PoH),
it takes 57 CBF git reverts - just 1% of 7153 commits since the
OSS AGESA removal! - making this removal look questionable and
the idea of opensource AGESA AMD boards restoration viable.
SUCCESSFUL BOOT TESTS for the opensource AGESA boards which I own
(Lenovo G505S - fam15 laptop, ASUS A88XM-E - fam15 desktop,
ASUS AM1I-A - fam16 desktop) :
88bc0f1604494de0f87c6954c050e7ef4d1c4457 (7153 PoH) for Lenovo G505S
1879b6a34a6e93a93d691a0d9f2457d6251a17c1 (6092 PoH) for ASUS AM1I-A
1879b6a34a6e93a93d691a0d9f2457d6251a17c1 (6092 PoH) for ASUS A88XM-E
69ffebf5ccf123bc0b3fb28b485985af0597761d (3698 PoH) for ASUS A88XM-E
NOTE for A88XM-E and AM1I-A: may be a bootable USB detection problem
if you add too many floppy images (csb_patcher.sh) to a coreflop ROM
Change-Id: Ia97e80ffaad9459e54ff5cb01f20d9129241433c
Signed-off-by: Mike Banon <mikebdp2(a)gmail.com>
---
A restore_agesa.sh
1 file changed, 573 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/79838/15
--
To view, visit https://review.coreboot.org/c/coreboot/+/79838?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia97e80ffaad9459e54ff5cb01f20d9129241433c
Gerrit-Change-Number: 79838
Gerrit-PatchSet: 15
Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: Balázs Vinarz <vinibali1(a)gmail.com>
Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Vlado Ilic <kakonema(a)gmail.com>
Gerrit-CC: awokd(a)danwin1210.me
Gerrit-Attention: Balázs Vinarz <vinibali1(a)gmail.com>
Gerrit-Attention: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Attention: Vlado Ilic <kakonema(a)gmail.com>
Attention is currently required from: Felix Singer.
Matt DeVillier has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/83411?usp=email )
Change subject: mb/google/drallion: Don't enable DPTF PCI device
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/drallion/variants/drallion/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/83411/comment/2e4d1795_2232448a?us… :
PS1, Line 49: register "Device4Enable" = "1"
> Then it might be better find the source for the issue. […]
I'll try, but my drallion is glitchy and it's not exactly something I want to spend a lot of time on, you know?
--
To view, visit https://review.coreboot.org/c/coreboot/+/83411?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic0e07d9d64c543121aa51a7cfd63fe3686192825
Gerrit-Change-Number: 83411
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Comment-Date: Fri, 12 Jul 2024 21:05:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>
Attention is currently required from: Matt DeVillier.
Felix Singer has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/83411?usp=email )
Change subject: mb/google/drallion: Don't enable DPTF PCI device
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/drallion/variants/drallion/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/83411/comment/12f3fa34_27f01198?us… :
PS1, Line 49: register "Device4Enable" = "1"
> that doesn't really matter, the PCI device being enabled isn't the issue, just the duplicate ACPI de […]
Then it might be better find the source for the issue. I'm about to hook up the Device4Enable option to the devicetree, which requires to turn on the PCI device.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83411?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic0e07d9d64c543121aa51a7cfd63fe3686192825
Gerrit-Change-Number: 83411
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Comment-Date: Fri, 12 Jul 2024 20:37:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>
Attention is currently required from: Felix Singer.
Matt DeVillier has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/83411?usp=email )
Change subject: mb/google/drallion: Don't enable DPTF PCI device
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/drallion/variants/drallion/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/83411/comment/6354f826_f4f0d6a0?us… :
PS1, Line 49: register "Device4Enable" = "1"
> This needs to be removed as well.
that doesn't really matter, the PCI device being enabled isn't the issue, just the duplicate ACPI device
--
To view, visit https://review.coreboot.org/c/coreboot/+/83411?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic0e07d9d64c543121aa51a7cfd63fe3686192825
Gerrit-Change-Number: 83411
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Comment-Date: Fri, 12 Jul 2024 20:33:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Attention is currently required from: Matt DeVillier.
Felix Singer has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/83411?usp=email )
Change subject: mb/google/drallion: Don't enable DPTF PCI device
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/drallion/variants/drallion/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/83411/comment/e7559031_1ca6c170?us… :
PS1, Line 49: register "Device4Enable" = "1"
This needs to be removed as well.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83411?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic0e07d9d64c543121aa51a7cfd63fe3686192825
Gerrit-Change-Number: 83411
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Comment-Date: Fri, 12 Jul 2024 20:29:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Felix Singer, Jeremy Soller.
Tim Crawford has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/78835?usp=email )
Change subject: mb/system76/bonw14/dt: Make use of chipset devicetree
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/78835?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2b0e19581e0f0111a56bc57185acfcdd70588141
Gerrit-Change-Number: 78835
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Comment-Date: Fri, 12 Jul 2024 20:00:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Felix Singer, Jeremy Soller.
Tim Crawford has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/78834?usp=email )
Change subject: mb/system76/gaze15/dt: Make use of chipset devicetree
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/78834?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I290fcfdd7b2cff61c4f6cd153133c5205c6fd6d1
Gerrit-Change-Number: 78834
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Comment-Date: Fri, 12 Jul 2024 19:58:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Felix Singer, Jeremy Soller.
Tim Crawford has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/78836?usp=email )
Change subject: mb/system76/oryp6/dt: Make use of chipset devicetree
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/78836?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id3605e8e05d9d97a73af966459692276265df8bc
Gerrit-Change-Number: 78836
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Comment-Date: Fri, 12 Jul 2024 19:55:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes