Attention is currently required from: Fred Reitberger, Jason Glenesk, Matt DeVillier.
Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83444?usp=email )
Change subject: soc/amd/common/root_complex: move IOHC_MMIO_EN definition to header
......................................................................
soc/amd/common/root_complex: move IOHC_MMIO_EN definition to header
To be able to use the IOHC_MMIO_EN define in other compilation units,
move the define to the corresponding header file.
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: If88950418406d1709ed95b3d05f7e6ad66438f95
---
M src/soc/amd/common/block/include/amdblocks/root_complex.h
M src/soc/amd/common/block/root_complex/non_pci_resources.c
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/83444/1
diff --git a/src/soc/amd/common/block/include/amdblocks/root_complex.h b/src/soc/amd/common/block/include/amdblocks/root_complex.h
index 8761626..f7b7c53 100644
--- a/src/soc/amd/common/block/include/amdblocks/root_complex.h
+++ b/src/soc/amd/common/block/include/amdblocks/root_complex.h
@@ -11,6 +11,8 @@
#define SMN_IOHC_MISC_BASE_13D1 0x13d10000
#define SMN_IOHC_MISC_BASE_13E1 0x13e10000
+#define IOHC_MMIO_EN BIT(0)
+
#define NON_PCI_RES_IDX_AUTO 0
struct domain_iohc_info {
diff --git a/src/soc/amd/common/block/root_complex/non_pci_resources.c b/src/soc/amd/common/block/root_complex/non_pci_resources.c
index 54f3de2..1e2e235 100644
--- a/src/soc/amd/common/block/root_complex/non_pci_resources.c
+++ b/src/soc/amd/common/block/root_complex/non_pci_resources.c
@@ -5,8 +5,6 @@
#include <device/device.h>
#include <types.h>
-#define IOHC_MMIO_EN BIT(0)
-
void read_non_pci_resources(struct device *domain, unsigned long *idx)
{
const uint32_t iohc_misc_base = get_iohc_misc_smn_base(domain);
--
To view, visit https://review.coreboot.org/c/coreboot/+/83444?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If88950418406d1709ed95b3d05f7e6ad66438f95
Gerrit-Change-Number: 83444
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Attention is currently required from: Martin L Roth.
Felix Singer has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/83442?usp=email )
Change subject: util/scripts: Add script to capture commands from build
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/83442?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I67efc5096747c2e746642639f88273132e070e49
Gerrit-Change-Number: 83442
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Sat, 13 Jul 2024 00:12:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83442?usp=email )
Change subject: util/scripts: Add script to capture commands from build
......................................................................
util/scripts: Add script to capture commands from build
This allows better debugging of the build by writing all the commands
run by the build into a file by replacing the standard shell.
Run with:
make SHELL="${PWD}/util/scripts/capture_commands.sh"
This will allow us to verify that the commands being run are posix
compliant.
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: I67efc5096747c2e746642639f88273132e070e49
---
A util/scripts/capture_commands.sh
M util/scripts/description.md
2 files changed, 19 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/83442/1
diff --git a/util/scripts/capture_commands.sh b/util/scripts/capture_commands.sh
new file mode 100755
index 0000000..9e2e08f
--- /dev/null
+++ b/util/scripts/capture_commands.sh
@@ -0,0 +1,17 @@
+#!/usr/bin/env sh
+## SPDX-License-Identifier: BSD-3-Clause
+
+# This script allows us to capture all the commands run in the shell by the
+# coreboot build. This is better than using 'make v=1' because it captures
+# commands right from the beginning of the build, and sends the output of any
+# command to the interactive shell.
+
+# To use, run:
+# make SHELL="${PWD}/util/scripts/capture_commands.sh"
+
+REALSHELL=${REALSHELL:-sh}
+OUTPUT_DIR=${TOP:-/tmp}
+CAPTURE_FILE=${CAPTURE_FILE:-commands.txt}
+
+env echo "$*" | sed 's/^-c '// >> "${OUTPUT_DIR}/${CAPTURE_FILE}"
+"${REALSHELL}" "$@"
diff --git a/util/scripts/description.md b/util/scripts/description.md
index 1c67f07..91a108c 100644
--- a/util/scripts/description.md
+++ b/util/scripts/description.md
@@ -1,4 +1,6 @@
__scripts__
+ * capture_commands.sh - Write all commands from the build to a file.
+ `Shell`
* _config_ - Manipulate options in a .config file from the command
line `Bash`
* _cross-repo-cherrypick_ - Pull in patches from another tree from a
--
To view, visit https://review.coreboot.org/c/coreboot/+/83442?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I67efc5096747c2e746642639f88273132e070e49
Gerrit-Change-Number: 83442
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Attention is currently required from: Cliff Huang, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun.
Jérémy Compostella has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/82174?usp=email )
Change subject: soc/intel/meteorlake: Enable SOC config override during boot
......................................................................
Patch Set 4:
(1 comment)
File src/soc/intel/meteorlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/82174/comment/d9a6eb9e_ea8b9072?us… :
PS4, Line 785: const struct soc_intel_meteorlake_config *config)
> Per discussion with Will (WonkyuKim), one of changes is to move the function that provides read-writ […]
It looks like you are cleaning up something unrelated to that patch. Shouldn't be a separate patch then ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/82174?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1621d38455895a5acc9e9b55d1fc8e4911bc5b1a
Gerrit-Change-Number: 82174
Gerrit-PatchSet: 4
Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Tarun <tstuli(a)gmail.com>
Gerrit-Comment-Date: Fri, 12 Jul 2024 23:37:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Cliff Huang <cliff.huang(a)intel.com>
Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com>
Attention is currently required from: Jérémy Compostella, Subrata Banik.
YH Lin has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/83431?usp=email )
Change subject: drivers/wifi: Support Radio Frequency Interference Mitigation
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/83431?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I02808b0ce6a0a380845612e774e326c698ad1adc
Gerrit-Change-Number: 83431
Gerrit-PatchSet: 4
Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Comment-Date: Fri, 12 Jul 2024 23:16:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Jérémy Compostella has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/83430?usp=email )
Change subject: drivers/wifi: Support Energy Detection Threshold
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/83430?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2e2e9d4f5420020bd7540cb36fa8aebfedf62285
Gerrit-Change-Number: 83430
Gerrit-PatchSet: 4
Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 12 Jul 2024 23:08:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Jérémy Compostella has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/83431?usp=email )
Change subject: drivers/wifi: Support Radio Frequency Interference Mitigation
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/83431?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I02808b0ce6a0a380845612e774e326c698ad1adc
Gerrit-Change-Number: 83431
Gerrit-PatchSet: 4
Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 12 Jul 2024 23:07:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No