coreboot-gerrit July 2024

coreboot-gerrit@coreboot.org

1 participants
3025 discussions

[S] Change in coreboot[main]: mb/google/trulo: support ISH
by Varun Upadhyay (Code Review) 31 Jul '24

31 Jul '24

Attention is currently required from: Deepti Deshatty, Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Li1 Feng, Nick Vaccaro, Rishika Raj, Subrata Banik, V Sowmya, Yuval Peress. Varun Upadhyay has posted comments on this change by Varun Upadhyay. ( https://review.coreboot.org/c/coreboot/+/83671?usp=email ) Change subject: mb/google/trulo: support ISH ...................................................................... Patch Set 2: (3 comments) Patchset: PS2: > kindly also submit the changes for orisa/gpio. […] In progress in CL - https://review.coreboot.org/c/coreboot/+/83656 File src/mainboard/google/brya/variants/baseboard/trulo/devicetree.cb: https://review.coreboot.org/c/coreboot/+/83671/comment/2663cb27_43a897ab?us… : PS2, Line 50: trulo_ish > my review comment from other cl https://review.coreboot. […] Acknowledged File src/mainboard/google/brya/variants/trulo/gpio.c: https://review.coreboot.org/c/coreboot/+/83671/comment/2f9bf3ca_aebe5b88?us… : PS2, Line 147: PAD_CFG_NF > why not lock these GPIOs? any reason for keeping these ISH GPIOs unlock when you need debugging purp […] Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/83671?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id60cb416a1cce5407bd483f0ce54f477584459b1 Gerrit-Change-Number: 83671 Gerrit-PatchSet: 2 Gerrit-Owner: Varun Upadhyay <varun.upadhyay(a)intel.com> Gerrit-Reviewer: Deepti Deshatty <deepti.deshatty(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Li1 Feng <li1.feng(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Yuval Peress <peress(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tanu Malhotra <tanu.malhotra(a)intel.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Yuval Peress <peress(a)google.com> Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Li1 Feng <li1.feng(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Deepti Deshatty <deepti.deshatty(a)intel.com> Gerrit-Comment-Date: Wed, 31 Jul 2024 07:42:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[M] Change in coreboot[main]: mb/google/dedede/var/awasuki: Enable ELAN touchscreen with fw_config
by Weimin Wu (Code Review) 31 Jul '24

31 Jul '24

Attention is currently required from: Weimin Wu. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83704?usp=email to look at the new patch set (#4). Change subject: mb/google/dedede/var/awasuki: Enable ELAN touchscreen with fw_config ...................................................................... mb/google/dedede/var/awasuki: Enable ELAN touchscreen with fw_config 1. Change driver form i2c/hid to i2c/generic. 2. Add fw_config for touchscreen. BUG=b:351968527 TEST=ectool cbi set 6 0x0x10200a0; touchscreen functions normally; Change-Id: Ifd6330be8924d4873f0efab3ce404168a62099eb Signed-off-by: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/dedede/variants/awasuki/overridetree.cb M src/mainboard/google/dedede/variants/awasuki/ramstage.c 2 files changed, 40 insertions(+), 15 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/83704/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/83704?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifd6330be8924d4873f0efab3ce404168a62099eb Gerrit-Change-Number: 83704 Gerrit-PatchSet: 4 Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>

1 0

[M] Change in coreboot[main]: mb/google/dedede/var/awasuki: Enable ELAN touchscreen with fw_config
by Weimin Wu (Code Review) 31 Jul '24

31 Jul '24

Attention is currently required from: Weimin Wu. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83704?usp=email to look at the new patch set (#3). Change subject: mb/google/dedede/var/awasuki: Enable ELAN touchscreen with fw_config ...................................................................... mb/google/dedede/var/awasuki: Enable ELAN touchscreen with fw_config 1. Change driver form i2c/hid to i2c/generic. 2. Add fw_config for touchscreen. BUG=b:351968527 BRANCH=firmware-dedede-13606.B TEST=ectool cbi set 6 0x0x10200a0; touchscreen functions normally; Change-Id: Ifd6330be8924d4873f0efab3ce404168a62099eb Signed-off-by: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/dedede/variants/awasuki/overridetree.cb M src/mainboard/google/dedede/variants/awasuki/ramstage.c 2 files changed, 40 insertions(+), 15 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/83704/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/83704?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifd6330be8924d4873f0efab3ce404168a62099eb Gerrit-Change-Number: 83704 Gerrit-PatchSet: 3 Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>

1 0

[M] Change in coreboot[main]: mb/google/dedede/var/awasuki: Enable ELAN touchscreen with fw_config
by Weimin Wu (Code Review) 31 Jul '24

31 Jul '24

Attention is currently required from: Weimin Wu. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83704?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: mb/google/dedede/var/awasuki: Enable ELAN touchscreen with fw_config ...................................................................... mb/google/dedede/var/awasuki: Enable ELAN touchscreen with fw_config 1. Change driver form i2c/hid to i2c/generic. 2. Add fw_config for touchscreen. BUG=b:351968527 BRANCH=firmware-dedede-13606.B TEST=ectool cbi set 6 0x0x10200a0; touchscreen functions normally; Change-Id: Ifd6330be8924d4873f0efab3ce404168a62099eb --- M src/mainboard/google/dedede/variants/awasuki/overridetree.cb M src/mainboard/google/dedede/variants/awasuki/ramstage.c 2 files changed, 40 insertions(+), 15 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/83704/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83704?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifd6330be8924d4873f0efab3ce404168a62099eb Gerrit-Change-Number: 83704 Gerrit-PatchSet: 2 Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>

1 0

[M] Change in coreboot[main]: mb/google/dedede/var/awasuki: Enable ELAN touchscreen with fw_config
by Weimin Wu (Code Review) 31 Jul '24

31 Jul '24

Weimin Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83704?usp=email ) Change subject: mb/google/dedede/var/awasuki: Enable ELAN touchscreen with fw_config ...................................................................... mb/google/dedede/var/awasuki: Enable ELAN touchscreen with fw_config 1. Change driver form i2c/hid to i2c/generic. 2. Add fw_config for touchscreen. BUG=b:351968527 BRANCH=firmware-dedede-13606.B TEST=ectool cbi set 6 0x0x10200a0; touchscreen functions normally; Change-Id: Ifd6330be8924d4873f0efab3ce404168a62099eb --- M src/mainboard/google/dedede/variants/awasuki/overridetree.cb M src/mainboard/google/dedede/variants/awasuki/ramstage.c 2 files changed, 40 insertions(+), 15 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/83704/1 diff --git a/src/mainboard/google/dedede/variants/awasuki/overridetree.cb b/src/mainboard/google/dedede/variants/awasuki/overridetree.cb index 5b1793c..d8a7d24 100644 --- a/src/mainboard/google/dedede/variants/awasuki/overridetree.cb +++ b/src/mainboard/google/dedede/variants/awasuki/overridetree.cb @@ -1,3 +1,10 @@ +fw_config + field TOUCH 5 + option TOUCH_ABSENT 0 + option TOUCH_PRESENT 1 + end +end + chip soc/intel/jasperlake # USB Port Configuration register "usb2_ports[1]" = "USB2_PORT_EMPTY" @@ -177,18 +184,24 @@ end # I2C 0 device pci 15.1 off end # I2C 1 device pci 15.2 on - chip drivers/i2c/hid - register "generic.hid" = ""ELAN9008"" - register "generic.desc" = ""ELAN Touchscreen"" - register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D4_IRQ)" - register "generic.detect" = "1" - register "generic.reset_gpio" = + probe TOUCH TOUCH_PRESENT + chip drivers/i2c/generic + register "hid" = ""ELAN0001"" + register "desc" = ""ELAN Touchscreen"" + register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D4_IRQ)" + register "probed" = "1" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D5)" - register "generic.enable_gpio" = + register "reset_delay_ms" = "20" + register "reset_off_delay_ms" = "8" + register "stop_gpio" = + "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A11)" + register "stop_delay_ms" = "280" + register "stop_off_delay_ms" = "2" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D6)" - register "generic.enable_delay_ms" = "7" - register "generic.has_power_resource" = "1" - register "hid_desc_reg_offset" = "0x01" + register "enable_delay_ms" = "7" + register "has_power_resource" = "1" device i2c 10 on end end end # I2C 2 diff --git a/src/mainboard/google/dedede/variants/awasuki/ramstage.c b/src/mainboard/google/dedede/variants/awasuki/ramstage.c index 7199c7c..b3be79e 100644 --- a/src/mainboard/google/dedede/variants/awasuki/ramstage.c +++ b/src/mainboard/google/dedede/variants/awasuki/ramstage.c @@ -3,8 +3,16 @@ #include <baseboard/variants.h> #include <fw_config.h> #include <soc/soc_chip.h> +#include <soc/gpio.h> -static void ext_vr_update(void) +static const struct pad_config ts_disable_pad[] = { + /* H4 : AP_I2C_TS_SDA */ + PAD_NC(GPP_H4, NONE), + /* H5 : AP_I2C_TS_SCL */ + PAD_NC(GPP_H5, NONE), +}; + +void variant_devtree_update(void) { struct soc_intel_jasperlake_config *cfg = config_of_soc(); @@ -12,9 +20,13 @@ printk(BIOS_INFO, "Device config for EXT_VR_ABSENT.\n"); cfg->disable_external_bypass_vr = 1; } -} -void variant_devtree_update(void) -{ - ext_vr_update(); + if (!fw_config_probe(FW_CONFIG(TOUCH, TOUCH_PRESENT))) { + cfg->SerialIoI2cMode[PchSerialIoIndexI2C2] = PchSerialIoDisabled; + } + + if (!fw_config_probe(FW_CONFIG(TOUCH, TOUCH_PRESENT))) { + printk(BIOS_INFO, "Disable TS GPIO pins.\n"); + gpio_configure_pads(ts_disable_pad, ARRAY_SIZE(ts_disable_pad)); + } } -- To view, visit https://review.coreboot.org/c/coreboot/+/83704?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifd6330be8924d4873f0efab3ce404168a62099eb Gerrit-Change-Number: 83704 Gerrit-PatchSet: 1 Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>

1 0

[S] Change in coreboot[main]: src: Enforce CSE sync with pertinent GBB flag
by Paul Menzel (Code Review) 31 Jul '24

31 Jul '24

Attention is currently required from: Dinesh Gehlot, Yu-Ping Wu. Paul Menzel has posted comments on this change by Dinesh Gehlot. ( https://review.coreboot.org/c/coreboot/+/83686?usp=email ) Change subject: src: Enforce CSE sync with pertinent GBB flag ...................................................................... Patch Set 2: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/83686/comment/3a4dadaa_b609c6fa?us… : PS2, Line 7: src: Wrong prefix? https://review.coreboot.org/c/coreboot/+/83686/comment/7de09e6e_23d71786?us… : PS2, Line 9: The patch enforces CSE sync when the GBB flag GBB_FLAG_FORCE_CSE_SYNC is : enabled and the system is currently booting from the RO section. Why is enforcing this the right thing to do? https://review.coreboot.org/c/coreboot/+/83686/comment/3864a21f_6d4e1c52?us… : PS2, Line 13: CL:5705989 It’s not marked up in the upstream Gerrit. Please add a URL. -- To view, visit https://review.coreboot.org/c/coreboot/+/83686?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I228bc8ebf58719776f6c39e0bfbb7ad53d9bfb7f Gerrit-Change-Number: 83686 Gerrit-PatchSet: 2 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Wed, 31 Jul 2024 07:27:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: soc/mediatek/common: Refactor EINT driver
by Paul Menzel (Code Review) 31 Jul '24

31 Jul '24

Attention is currently required from: Hung-Te Lin, Xi Chen, Yidi Lin, Yu-Ping Wu. Paul Menzel has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/83703?usp=email ) Change subject: soc/mediatek/common: Refactor EINT driver ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/83703/comment/b513e94d_e94ba8b4?us… : PS2, Line 13: This change is prepared for the driver change in MT8196. As you named the new file `eint_v1`, is it planned to have v2 driver? -- To view, visit https://review.coreboot.org/c/coreboot/+/83703?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie53abc23971bfa39250ebd7dd48e28d6b91c5973 Gerrit-Change-Number: 83703 Gerrit-PatchSet: 2 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Wed, 31 Jul 2024 07:21:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: acpi/acpigen_ps2_keybd: Move KEY_DELETE to rest_of_keymaps
by Dinesh Gehlot (Code Review) 31 Jul '24

31 Jul '24

Attention is currently required from: Aseda Aboagye, Cliff Huang, Kapil Porwal, Lance Zhao, Nick Vaccaro, Tim Wawrzynczak, Tyler Wang. Dinesh Gehlot has posted comments on this change by Tyler Wang. ( https://review.coreboot.org/c/coreboot/+/83684?usp=email ) Change subject: acpi/acpigen_ps2_keybd: Move KEY_DELETE to rest_of_keymaps ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83684?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib922a2b52fa7152ba3d9deb44e2c8200b2a3802c Gerrit-Change-Number: 83684 Gerrit-PatchSet: 4 Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Comment-Date: Wed, 31 Jul 2024 06:43:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: soc/mediatek/common: Refactor EINT driver
by Yidi Lin (Code Review) 31 Jul '24

31 Jul '24

Attention is currently required from: Hung-Te Lin, Xi Chen, Yu-Ping Wu. Hello Hung-Te Lin, Xi Chen, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83703?usp=email to look at the new patch set (#2). Change subject: soc/mediatek/common: Refactor EINT driver ...................................................................... soc/mediatek/common: Refactor EINT driver Refactor EINT driver by - Move `pos_bit_calc_for_eint` to `common/eint_v1.c` - Implement `eint_find_reg_addr` to obtain EINT base address. This change is prepared for the driver change in MT8196. BUG=b:334723688 TEST=EINT works on Geralt Change-Id: Ie53abc23971bfa39250ebd7dd48e28d6b91c5973 Signed-off-by: Yidi Lin <yidilin(a)chromium.org> --- A src/soc/mediatek/common/eint_v1.c M src/soc/mediatek/common/gpio.c M src/soc/mediatek/common/include/soc/gpio_common.h M src/soc/mediatek/mt8183/Makefile.mk M src/soc/mediatek/mt8186/Makefile.mk M src/soc/mediatek/mt8188/Makefile.mk M src/soc/mediatek/mt8192/Makefile.mk M src/soc/mediatek/mt8195/Makefile.mk 8 files changed, 35 insertions(+), 20 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/83703/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83703?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie53abc23971bfa39250ebd7dd48e28d6b91c5973 Gerrit-Change-Number: 83703 Gerrit-PatchSet: 2 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>

1 0

[M] Change in coreboot[main]: soc/mediatek/common: Refactor EINT driver
by Yidi Lin (Code Review) 31 Jul '24

31 Jul '24

Yidi Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83703?usp=email ) Change subject: soc/mediatek/common: Refactor EINT driver ...................................................................... soc/mediatek/common: Refactor EINT driver Refactor EINT driver by - Move `pos_bit_calc_for_eint` to `common/eint_v1.c` - Implment `eint_find_reg_addr` to obtain EINT base address. This change is prepared for the driver change in MT8196. BUG=b:334723688 TEST=EINT works on Geralt Change-Id: Ie53abc23971bfa39250ebd7dd48e28d6b91c5973 Signed-off-by: Yidi Lin <yidilin(a)chromium.org> --- A src/soc/mediatek/common/eint_v1.c M src/soc/mediatek/common/gpio.c M src/soc/mediatek/common/include/soc/gpio_common.h M src/soc/mediatek/mt8183/Makefile.mk M src/soc/mediatek/mt8186/Makefile.mk M src/soc/mediatek/mt8188/Makefile.mk M src/soc/mediatek/mt8192/Makefile.mk M src/soc/mediatek/mt8195/Makefile.mk 8 files changed, 35 insertions(+), 20 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/83703/1 diff --git a/src/soc/mediatek/common/eint_v1.c b/src/soc/mediatek/common/eint_v1.c new file mode 100644 index 0000000..f0fd7e3 --- /dev/null +++ b/src/soc/mediatek/common/eint_v1.c @@ -0,0 +1,15 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <soc/addressmap.h> +#include <gpio.h> + +void pos_bit_calc_for_eint(gpio_t gpio, u32 *pos, u32 *bit) +{ + *pos = gpio.id / MAX_EINT_REG_BITS; + *bit = gpio.id % MAX_EINT_REG_BITS; +} + +void *eint_find_reg_addr(gpio_t gpio) +{ + return (void *)(EINT_BASE); +} diff --git a/src/soc/mediatek/common/gpio.c b/src/soc/mediatek/common/gpio.c index e8a50b2..12532e5 100644 --- a/src/soc/mediatek/common/gpio.c +++ b/src/soc/mediatek/common/gpio.c @@ -113,23 +113,15 @@ gpio_set_mode(gpio, GPIO_MODE); } -enum { - MAX_EINT_REG_BITS = 32, -}; - -static void pos_bit_calc_for_eint(gpio_t gpio, u32 *pos, u32 *bit) -{ - *pos = gpio.id / MAX_EINT_REG_BITS; - *bit = gpio.id % MAX_EINT_REG_BITS; -} - int gpio_eint_poll(gpio_t gpio) { u32 pos; u32 bit; u32 status; + struct eint_regs *mtk_eint; pos_bit_calc_for_eint(gpio, &pos, &bit); + mtk_eint = eint_find_reg_addr(gpio); status = (read32(&mtk_eint->sta.regs[pos]) >> bit) & 0x1; @@ -143,8 +135,11 @@ { u32 pos; u32 bit, mask; + struct eint_regs *mtk_eint; pos_bit_calc_for_eint(gpio, &pos, &bit); + mtk_eint = eint_find_reg_addr(gpio); + mask = 1 << bit; /* Make it an input first. */ diff --git a/src/soc/mediatek/common/include/soc/gpio_common.h b/src/soc/mediatek/common/include/soc/gpio_common.h index b12d9c9..dd63cf7 100644 --- a/src/soc/mediatek/common/include/soc/gpio_common.h +++ b/src/soc/mediatek/common/include/soc/gpio_common.h @@ -102,8 +102,6 @@ check_member(eint_regs, d1en, 0x420); -static struct eint_regs *const mtk_eint = (void *)(EINT_BASE); - /* * Firmware never enables interrupts on this platform. This function * reads current EINT status and clears the pending interrupt. @@ -117,4 +115,11 @@ */ void gpio_eint_configure(gpio_t gpio, enum gpio_irq_type type); +enum { + MAX_EINT_REG_BITS = 32, +}; + +void pos_bit_calc_for_eint(gpio_t gpio, u32 *pos, u32 *bit); +void *eint_find_reg_addr(gpio_t gpio); + #endif diff --git a/src/soc/mediatek/mt8183/Makefile.mk b/src/soc/mediatek/mt8183/Makefile.mk index 3b4a1e8..e0a5dd9 100644 --- a/src/soc/mediatek/mt8183/Makefile.mk +++ b/src/soc/mediatek/mt8183/Makefile.mk @@ -3,7 +3,7 @@ bootblock-y += bootblock.c bootblock-y += ../common/auxadc.c -bootblock-y += ../common/gpio.c gpio.c +bootblock-y += ../common/eint_v1.c ../common/gpio.c gpio.c bootblock-y += ../common/pll.c pll.c bootblock-$(CONFIG_SPI_FLASH) += ../common/spi.c spi.c bootblock-y += mt8183.c @@ -17,7 +17,7 @@ decompressor-y += ../common/timer.c verstage-y += ../common/auxadc.c -verstage-y += ../common/gpio.c gpio.c +verstage-y += ../common/eint_v1.c ../common/gpio.c gpio.c verstage-$(CONFIG_SPI_FLASH) += ../common/spi.c spi.c verstage-y += mt8183.c verstage-y += ../common/i2c.c i2c.c @@ -34,7 +34,7 @@ romstage-y += memory.c romstage-$(CONFIG_MEMORY_TEST) += ../common/memory_test.c romstage-y += mt8183.c -romstage-y += ../common/gpio.c gpio.c +romstage-y += ../common/eint_v1.c ../common/gpio.c gpio.c romstage-y += ../common/mmu_operations.c mmu_operations.c romstage-y += ../common/pll.c pll.c romstage-y += ../common/pmic_wrap.c pmic_wrap.c mt6358.c @@ -50,7 +50,7 @@ ramstage-y += ../common/auxadc.c ramstage-y += ../common/ddp.c ddp.c ramstage-y += ../common/dsi.c ../common/mtk_mipi_dphy.c -ramstage-y += ../common/gpio.c gpio.c +ramstage-y += ../common/eint_v1.c ../common/gpio.c gpio.c ramstage-y += ../common/i2c.c i2c.c ramstage-y += ../common/mcu.c ramstage-y += ../common/mmu_operations.c mmu_operations.c diff --git a/src/soc/mediatek/mt8186/Makefile.mk b/src/soc/mediatek/mt8186/Makefile.mk index 8e116f8..724991c 100644 --- a/src/soc/mediatek/mt8186/Makefile.mk +++ b/src/soc/mediatek/mt8186/Makefile.mk @@ -4,7 +4,7 @@ # for bootblock, verstage, romstage, ramstage all-y += ../common/cpu_id.c all-y += ../common/flash_controller.c -all-y += ../common/gpio.c ../common/gpio_op.c gpio.c +all-y += ../common/eint_v1.c ../common/gpio.c ../common/gpio_op.c gpio.c all-y += ../common/i2c.c i2c.c all-y += ../common/pll.c pll.c all-$(CONFIG_SPI_FLASH) += ../common/spi.c spi.c diff --git a/src/soc/mediatek/mt8188/Makefile.mk b/src/soc/mediatek/mt8188/Makefile.mk index f67c827..f253a22 100644 --- a/src/soc/mediatek/mt8188/Makefile.mk +++ b/src/soc/mediatek/mt8188/Makefile.mk @@ -2,7 +2,7 @@ ifeq ($(CONFIG_SOC_MEDIATEK_MT8188),y) all-y += ../common/flash_controller.c -all-y += ../common/gpio.c ../common/gpio_op.c gpio.c +all-y += ../common/eint_v1.c ../common/gpio.c ../common/gpio_op.c gpio.c all-y += ../common/i2c.c i2c.c all-y += ../common/pll.c pll.c all-$(CONFIG_SPI_FLASH) += ../common/spi.c spi.c diff --git a/src/soc/mediatek/mt8192/Makefile.mk b/src/soc/mediatek/mt8192/Makefile.mk index 5d4b87b..c83125e 100644 --- a/src/soc/mediatek/mt8192/Makefile.mk +++ b/src/soc/mediatek/mt8192/Makefile.mk @@ -3,7 +3,7 @@ # for bootblock, verstage, romstage, ramstage all-y += ../common/flash_controller.c -all-y += ../common/gpio.c ../common/gpio_op.c gpio.c +all-y += ../common/eint_v1.c ../common/gpio.c ../common/gpio_op.c gpio.c all-y += ../common/i2c.c i2c.c all-$(CONFIG_SPI_FLASH) += ../common/spi.c spi.c all-y += ../common/timer.c diff --git a/src/soc/mediatek/mt8195/Makefile.mk b/src/soc/mediatek/mt8195/Makefile.mk index 56a10bc..9940814 100644 --- a/src/soc/mediatek/mt8195/Makefile.mk +++ b/src/soc/mediatek/mt8195/Makefile.mk @@ -3,7 +3,7 @@ # for bootblock, verstage, romstage, ramstage all-y += ../common/flash_controller.c -all-y += ../common/gpio.c ../common/gpio_op.c gpio.c +all-y += ../common/eint_v1.c ../common/gpio.c ../common/gpio_op.c gpio.c all-y += ../common/i2c.c i2c.c all-$(CONFIG_SPI_FLASH) += ../common/spi.c spi.c all-y += ../common/timer.c ../common/timer_prepare.c -- To view, visit https://review.coreboot.org/c/coreboot/+/83703?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie53abc23971bfa39250ebd7dd48e28d6b91c5973 Gerrit-Change-Number: 83703 Gerrit-PatchSet: 1 Gerrit-Owner: Yidi Lin <yidilin(a)google.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2024