Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83539?usp=email )
(
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: mb/google/brya/var/trulo: Add LPDDR5 DRAM (MT62F512M32D2DR-031)
......................................................................
mb/google/brya/var/trulo: Add LPDDR5 DRAM (MT62F512M32D2DR-031)
This patch adds Micron Technology LPDDR5 DRAM
(part: MT62F512M32D2DR-031) for Trulo.
Make use of spd_tools to generate SPD file after following the below
steps:
1. make -C util/spd_tools
2. ./util/spd_tools/bin/part_id_gen ADL lp5
src/mainboard/google/brya/variants/trulo/memory
src/mainboard/google/brya/variants/trulo/memory/mem_parts_used.txt
Output files are:
1. dram_id.generated.txt
2. Makefile.mk
BUG=b:351976770
TEST=Able to build google/trulo.
Change-Id: Id35f6b57b716375abb66db187413f0f82361d962
Signed-off-by: Subrata Banik <subratabanik(a)google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83539
Reviewed-by: Dinesh Gehlot <digehlot(a)google.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M src/mainboard/google/brya/variants/trulo/memory/Makefile.mk
M src/mainboard/google/brya/variants/trulo/memory/dram_id.generated.txt
M src/mainboard/google/brya/variants/trulo/memory/mem_parts_used.txt
3 files changed, 6 insertions(+), 3 deletions(-)
Approvals:
Dinesh Gehlot: Looks good to me, approved
build bot (Jenkins): Verified
diff --git a/src/mainboard/google/brya/variants/trulo/memory/Makefile.mk b/src/mainboard/google/brya/variants/trulo/memory/Makefile.mk
index 850a62c..5cb4476 100644
--- a/src/mainboard/google/brya/variants/trulo/memory/Makefile.mk
+++ b/src/mainboard/google/brya/variants/trulo/memory/Makefile.mk
@@ -1,6 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-or-later
# This is an auto-generated file. Do not edit!!
# Generated by:
-# /tmp/go-build204585115/b001/exe/part_id_gen ADL lp5 src/mainboard/google/brya/variants/trulo/memory src/mainboard/google/brya/variants/trulo/memory/mem_parts_used.txt
+# ./util/spd_tools/bin/part_id_gen ADL lp5 src/mainboard/google/brya/variants/trulo/memory src/mainboard/google/brya/variants/trulo/memory/mem_parts_used.txt
-SPD_SOURCES = placeholder
+SPD_SOURCES =
+SPD_SOURCES += spd/lp5/set-0/spd-1.hex # ID = 0(0b0000) Parts = MT62F512M32D2DR-031 WT:B
diff --git a/src/mainboard/google/brya/variants/trulo/memory/dram_id.generated.txt b/src/mainboard/google/brya/variants/trulo/memory/dram_id.generated.txt
index 8ce2480..8790f22 100644
--- a/src/mainboard/google/brya/variants/trulo/memory/dram_id.generated.txt
+++ b/src/mainboard/google/brya/variants/trulo/memory/dram_id.generated.txt
@@ -1,6 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-or-later
# This is an auto-generated file. Do not edit!!
# Generated by:
-# /tmp/go-build204585115/b001/exe/part_id_gen ADL lp5 src/mainboard/google/brya/variants/trulo/memory src/mainboard/google/brya/variants/trulo/memory/mem_parts_used.txt
+# ./util/spd_tools/bin/part_id_gen ADL lp5 src/mainboard/google/brya/variants/trulo/memory src/mainboard/google/brya/variants/trulo/memory/mem_parts_used.txt
DRAM Part Name ID to assign
+MT62F512M32D2DR-031 WT:B 0 (0000)
diff --git a/src/mainboard/google/brya/variants/trulo/memory/mem_parts_used.txt b/src/mainboard/google/brya/variants/trulo/memory/mem_parts_used.txt
index 2499005..fc41c85 100644
--- a/src/mainboard/google/brya/variants/trulo/memory/mem_parts_used.txt
+++ b/src/mainboard/google/brya/variants/trulo/memory/mem_parts_used.txt
@@ -9,3 +9,4 @@
# See util/spd_tools/README.md for more details and instructions.
# Part Name
+MT62F512M32D2DR-031 WT:B
--
To view, visit https://review.coreboot.org/c/coreboot/+/83539?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id35f6b57b716375abb66db187413f0f82361d962
Gerrit-Change-Number: 83539
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83585?usp=email )
Change subject: [wip C11 to C23] use nullptr & nullptr_t
......................................................................
[wip C11 to C23] use nullptr & nullptr_t
Change-Id: Ie21b10251d72adee93c25c34ea5387c48d341f01
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M Makefile.mk
M payloads/coreinfo/bootlog_module.c
M payloads/coreinfo/cbfs_module.c
M payloads/coreinfo/coreinfo.c
M payloads/coreinfo/cpuinfo_module.c
M payloads/coreinfo/timestamps_module.c
M payloads/libpayload/Makefile
M payloads/libpayload/arch/arm/main.c
M payloads/libpayload/arch/arm/virtual.c
M payloads/libpayload/arch/arm64/main.c
M payloads/libpayload/arch/arm64/mmu.c
M payloads/libpayload/arch/x86/main.c
M payloads/libpayload/curses/PDCurses/curses.h
M payloads/libpayload/curses/PDCurses/demos/newdemo.c
M payloads/libpayload/curses/PDCurses/demos/testcurs.c
M payloads/libpayload/curses/PDCurses/demos/tui.c
M payloads/libpayload/curses/PDCurses/demos/tuidemo.c
M payloads/libpayload/curses/PDCurses/demos/worm.c
M payloads/libpayload/curses/PDCurses/doc/manext.c
M payloads/libpayload/curses/PDCurses/dos/pdcclip.c
M payloads/libpayload/curses/PDCurses/dos/pdcscrn.c
M payloads/libpayload/curses/PDCurses/os2/pdcclip.c
M payloads/libpayload/curses/PDCurses/os2/pdckbd.c
M payloads/libpayload/curses/PDCurses/os2/pdcscrn.c
M payloads/libpayload/curses/PDCurses/pdcurses/bkgd.c
M payloads/libpayload/curses/PDCurses/pdcurses/border.c
M payloads/libpayload/curses/PDCurses/pdcurses/getyx.c
M payloads/libpayload/curses/PDCurses/pdcurses/inch.c
M payloads/libpayload/curses/PDCurses/pdcurses/initscr.c
M payloads/libpayload/curses/PDCurses/pdcurses/kernel.c
M payloads/libpayload/curses/PDCurses/pdcurses/mouse.c
M payloads/libpayload/curses/PDCurses/pdcurses/pad.c
M payloads/libpayload/curses/PDCurses/pdcurses/panel.c
M payloads/libpayload/curses/PDCurses/pdcurses/scanw.c
M payloads/libpayload/curses/PDCurses/pdcurses/scr_dump.c
M payloads/libpayload/curses/PDCurses/pdcurses/slk.c
M payloads/libpayload/curses/PDCurses/pdcurses/terminfo.c
M payloads/libpayload/curses/PDCurses/pdcurses/util.c
M payloads/libpayload/curses/PDCurses/pdcurses/window.c
M payloads/libpayload/curses/PDCurses/sdl1/pdcclip.c
M payloads/libpayload/curses/PDCurses/sdl1/pdcscrn.c
M payloads/libpayload/curses/PDCurses/win32/pdcclip.c
M payloads/libpayload/curses/PDCurses/win32/pdcscrn.c
M payloads/libpayload/curses/PDCurses/x11/ScrollBox.c
M payloads/libpayload/curses/PDCurses/x11/ScrollBox.h
M payloads/libpayload/curses/PDCurses/x11/pdckbd.c
M payloads/libpayload/curses/PDCurses/x11/pdcscrn.c
M payloads/libpayload/curses/PDCurses/x11/x11.c
M payloads/libpayload/curses/curses.h
M payloads/libpayload/curses/curses.priv.h
M payloads/libpayload/curses/form/fld_arg.c
M payloads/libpayload/curses/form/fld_def.c
M payloads/libpayload/curses/form/fld_dup.c
M payloads/libpayload/curses/form/fld_ftlink.c
M payloads/libpayload/curses/form/fld_link.c
M payloads/libpayload/curses/form/fld_newftyp.c
M payloads/libpayload/curses/form/fld_type.c
M payloads/libpayload/curses/form/fld_user.c
M payloads/libpayload/curses/form/form.priv.h
M payloads/libpayload/curses/form/frm_def.c
M payloads/libpayload/curses/form/frm_driver.c
M payloads/libpayload/curses/form/frm_hook.c
M payloads/libpayload/curses/form/frm_req_name.c
M payloads/libpayload/curses/form/frm_user.c
M payloads/libpayload/curses/form/fty_alnum.c
M payloads/libpayload/curses/form/fty_alpha.c
M payloads/libpayload/curses/form/fty_enum.c
M payloads/libpayload/curses/form/fty_generic.c
M payloads/libpayload/curses/form/fty_int.c
M payloads/libpayload/curses/form/fty_ipv4.c
M payloads/libpayload/curses/form/fty_num.c
M payloads/libpayload/curses/form/fty_regex.c
M payloads/libpayload/curses/keyboard.c
M payloads/libpayload/curses/menu/m_hook.c
M payloads/libpayload/curses/menu/m_item_cur.c
M payloads/libpayload/curses/menu/m_item_nam.c
M payloads/libpayload/curses/menu/m_item_new.c
M payloads/libpayload/curses/menu/m_item_opt.c
M payloads/libpayload/curses/menu/m_item_use.c
M payloads/libpayload/curses/menu/m_items.c
M payloads/libpayload/curses/menu/m_new.c
M payloads/libpayload/curses/menu/m_opts.c
M payloads/libpayload/curses/menu/m_pattern.c
M payloads/libpayload/curses/menu/m_req_name.c
M payloads/libpayload/curses/menu/m_sub.c
M payloads/libpayload/curses/menu/m_userptr.c
M payloads/libpayload/curses/menu/m_win.c
M payloads/libpayload/curses/pdcurses-backend/pdckbd.c
M payloads/libpayload/curses/pdcurses-backend/pdcscrn.c
M payloads/libpayload/curses/tinycurses.c
M payloads/libpayload/drivers/cbmem_console.c
M payloads/libpayload/drivers/hid.c
M payloads/libpayload/drivers/i8042/i8042.c
M payloads/libpayload/drivers/i8042/keyboard.c
M payloads/libpayload/drivers/mouse_cursor.c
M payloads/libpayload/drivers/options.c
M payloads/libpayload/drivers/serial/ipq40xx.c
M payloads/libpayload/drivers/serial/qcs405.c
M payloads/libpayload/drivers/storage/ahci_common.c
M payloads/libpayload/drivers/storage/ata.c
M payloads/libpayload/drivers/storage/atapi.c
M payloads/libpayload/drivers/storage/nvme.c
M payloads/libpayload/drivers/storage/storage.c
M payloads/libpayload/drivers/udc/chipidea.c
M payloads/libpayload/drivers/udc/dwc2.c
M payloads/libpayload/drivers/udc/udc.c
M payloads/libpayload/drivers/usb/dwc2.c
M payloads/libpayload/drivers/usb/dwc2_rh.c
M payloads/libpayload/drivers/usb/ehci.c
M payloads/libpayload/drivers/usb/generic_hub.c
M payloads/libpayload/drivers/usb/ohci.c
M payloads/libpayload/drivers/usb/uhci.c
M payloads/libpayload/drivers/usb/uhci_rh.c
M payloads/libpayload/drivers/usb/usb.c
M payloads/libpayload/drivers/usb/usb_dev.c
M payloads/libpayload/drivers/usb/usbhid.c
M payloads/libpayload/drivers/usb/usbhub.c
M payloads/libpayload/drivers/usb/usbinit.c
M payloads/libpayload/drivers/usb/usbmsc.c
M payloads/libpayload/drivers/usb/xhci.c
M payloads/libpayload/drivers/usb/xhci_debug.c
M payloads/libpayload/drivers/usb/xhci_devconf.c
M payloads/libpayload/drivers/usb/xhci_rh.c
M payloads/libpayload/drivers/video/font8x16.c
M payloads/libpayload/drivers/video/graphics.c
M payloads/libpayload/include/arm/arch/types.h
M payloads/libpayload/include/arm64/arch/types.h
M payloads/libpayload/include/cbfs.h
M payloads/libpayload/include/getopt.h
M payloads/libpayload/include/libpayload.h
M payloads/libpayload/include/mock/arch/types.h
M payloads/libpayload/include/queue.h
M payloads/libpayload/include/x86/arch/types.h
M payloads/libpayload/libc/args.c
M payloads/libpayload/libc/getopt_long.c
M payloads/libpayload/libc/lib.c
M payloads/libpayload/libc/malloc.c
M payloads/libpayload/libc/printf.c
M payloads/libpayload/libc/readline.c
M payloads/libpayload/libc/string.c
M payloads/libpayload/libc/time.c
M payloads/libpayload/libcbfs/cbfs.c
M payloads/libpayload/liblz4/lz4_wrapper.c
M payloads/libpayload/libpci/libpci.c
M payloads/libpayload/tests/Makefile.mk
M payloads/libpayload/tests/cbfs-x86-test.c
M payloads/libpayload/tests/drivers/speaker-test.c
M payloads/libpayload/tests/libc/fmap_locate_area-test.c
M payloads/libpayload/tests/libcbfs/cbfs-lookup-test.c
M payloads/libpayload/tests/libcbfs/cbfs-verification-test.c
M payloads/linuxcheck/linuxcheck.c
M payloads/nvramcui/nvramcui.c
M src/acpi/acpi.c
M src/acpi/acpi_gic.c
M src/acpi/acpi_pptt.c
M src/acpi/acpigen.c
M src/acpi/acpigen_dsm.c
M src/acpi/acpigen_pci_root_resource_producer.c
M src/acpi/acpigen_ps2_keybd.c
M src/acpi/device.c
M src/acpi/gnvs.c
M src/arch/arm/fit_payload.c
M src/arch/arm64/armv8/cache.c
M src/arch/arm64/armv8/exception.c
M src/arch/arm64/bl31.c
M src/arch/arm64/fit_payload.c
M src/arch/arm64/smc.c
M src/arch/riscv/arch_timer.c
M src/arch/riscv/fit_payload.c
M src/arch/riscv/smp.c
M src/arch/x86/acpi_bert_storage.c
M src/arch/x86/breakpoint.c
M src/arch/x86/cpu.c
M src/arch/x86/ebda.c
M src/arch/x86/include/arch/cpu.h
M src/arch/x86/null_breakpoint.c
M src/arch/x86/postcar_loader.c
M src/commonlib/bsd/cbfs_private.c
M src/commonlib/bsd/elog.c
M src/commonlib/bsd/include/commonlib/bsd/cbfs_mdata.h
M src/commonlib/bsd/include/commonlib/bsd/cbfs_private.h
M src/commonlib/bsd/lz4_wrapper.c
M src/commonlib/device_tree.c
M src/commonlib/fsp_relocate.c
M src/commonlib/include/commonlib/iobuf.h
M src/commonlib/include/commonlib/mem_pool.h
M src/commonlib/include/commonlib/region.h
M src/commonlib/iobuf.c
M src/commonlib/mem_pool.c
M src/commonlib/region.c
M src/commonlib/storage/mmc.c
M src/commonlib/storage/pci_sdhci.c
M src/commonlib/storage/sd.c
M src/commonlib/storage/sd_mmc.c
M src/commonlib/storage/sdhci.c
M src/commonlib/storage/sdhci_adma.c
M src/commonlib/storage/storage.c
M src/commonlib/storage/storage_erase.c
M src/commonlib/storage/storage_write.c
M src/console/console.c
M src/console/printk.c
M src/console/vtxprintf.c
M src/cpu/intel/microcode/microcode.c
M src/cpu/x86/backup_default_smm.c
M src/cpu/x86/mp_init.c
M src/cpu/x86/mtrr/mtrr.c
M src/cpu/x86/smi_trigger.c
M src/cpu/x86/smm/pci_resource_store.c
M src/cpu/x86/smm/save_state.c
M src/cpu/x86/smm/smm_module_handler.c
M src/cpu/x86/smm/smm_module_loader.c
M src/cpu/x86/smm/tseg_region.c
M src/device/cardbus_device.c
M src/device/cpu_device.c
M src/device/device.c
M src/device/device_const.c
M src/device/device_util.c
M src/device/dram/spd.c
M src/device/gpio.c
M src/device/i2c_bus.c
M src/device/mdio.c
M src/device/oprom/realmode/x86.c
M src/device/oprom/x86emu/debug.c
M src/device/oprom/x86emu/decode.c
M src/device/oprom/x86emu/ops2.c
M src/device/oprom/x86emu/sys.c
M src/device/oprom/yabel/biosemu.h
M src/device/oprom/yabel/compat/functions.c
M src/device/oprom/yabel/interrupt.c
M src/device/oprom/yabel/io.c
M src/device/oprom/yabel/vbe.c
M src/device/pci_class.c
M src/device/pci_device.c
M src/device/pci_ops.c
M src/device/pci_rom.c
M src/device/pciexp_device.c
M src/device/pnp_device.c
M src/device/resource_allocator_common.c
M src/device/resource_allocator_v4.c
M src/drivers/acpi/thermal_zone/thermal_zone.c
M src/drivers/amd/agesa/acpi_tables.c
M src/drivers/amd/agesa/def_callouts.c
M src/drivers/amd/agesa/heapmanager.c
M src/drivers/amd/agesa/oem_s3.c
M src/drivers/amd/agesa/state_machine.c
M src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c
M src/drivers/aspeed/common/aspeed_coreboot.h
M src/drivers/aspeed/common/ast_dp501.c
M src/drivers/aspeed/common/ast_main.c
M src/drivers/aspeed/common/ast_mode.c
M src/drivers/crb/tis.c
M src/drivers/efi/efivars.c
M src/drivers/efi/efivars.h
M src/drivers/elog/elog.c
M src/drivers/emulation/qemu/bochs.c
M src/drivers/generic/cbfs-uuid/cbfs-uuid.c
M src/drivers/generic/gpio_keys/gpio_keys.c
M src/drivers/i2c/at24rf08c/lenovo_serials.c
M src/drivers/i2c/cs35l53/cs35l53.c
M src/drivers/i2c/da7219/da7219.c
M src/drivers/i2c/designware/dw_i2c.c
M src/drivers/i2c/designware/dw_i2c.h
M src/drivers/i2c/generic/generic.c
M src/drivers/i2c/gpiomux/mux/mux.c
M src/drivers/i2c/max98390/max98390.c
M src/drivers/i2c/nau8825/nau8825.c
M src/drivers/i2c/ptn3460/ptn3460.c
M src/drivers/i2c/sx9310/sx9310.c
M src/drivers/i2c/tpm/cr50.c
M src/drivers/i2c/tpm/tis.c
M src/drivers/i2c/tpm/tis_atmel.c
M src/drivers/i2c/tpm/tpm.c
M src/drivers/intel/dptf/dptf.c
M src/drivers/intel/fsp1_1/car.c
M src/drivers/intel/fsp1_1/fsp_relocate.c
M src/drivers/intel/fsp1_1/fsp_util.c
M src/drivers/intel/fsp1_1/hob.c
M src/drivers/intel/fsp1_1/raminit.c
M src/drivers/intel/fsp1_1/ramstage.c
M src/drivers/intel/fsp1_1/romstage.c
M src/drivers/intel/fsp1_1/temp_ram_exit.c
M src/drivers/intel/fsp1_1/vbt.c
M src/drivers/intel/fsp2_0/debug.c
M src/drivers/intel/fsp2_0/fsp_gop_blt.c
M src/drivers/intel/fsp2_0/hand_off_block.c
M src/drivers/intel/fsp2_0/hob_display.c
M src/drivers/intel/fsp2_0/include/fsp/upd.h
M src/drivers/intel/fsp2_0/include/fsp/util.h
M src/drivers/intel/fsp2_0/memory_init.c
M src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c
M src/drivers/intel/fsp2_0/silicon_init.c
M src/drivers/intel/fsp2_0/temp_ram_exit.c
M src/drivers/intel/gma/opregion.c
M src/drivers/intel/gma/opregion.h
M src/drivers/intel/ish/ish.c
M src/drivers/intel/mipi_camera/camera.c
M src/drivers/intel/pmc_mux/conn/conn.c
M src/drivers/intel/usb4/retimer/retimer.c
M src/drivers/ipmi/ipmi_fru.c
M src/drivers/ipmi/ipmi_if.c
M src/drivers/ipmi/ipmi_ops.c
M src/drivers/ipmi/ipmi_ops_premem.c
M src/drivers/ipmi/ocp/ipmi_ocp_romstage.c
M src/drivers/ipmi/ocp/ipmi_sel.c
M src/drivers/ipmi/supermicro_oem.c
M src/drivers/mrc_cache/mrc_cache.c
M src/drivers/net/atl1e.c
M src/drivers/net/r8168.c
M src/drivers/ocp/dmi/smbios.c
M src/drivers/pc80/pc/keyboard.c
M src/drivers/pc80/rtc/option.c
M src/drivers/pc80/tpm/tis.c
M src/drivers/pc80/vga/vga.c
M src/drivers/pc80/vga/vga_palette.c
M src/drivers/pcie/generic/generic.c
M src/drivers/pcie/rtd3/device/chip.c
M src/drivers/siemens/nc_fpga/nc_fpga.c
M src/drivers/smmstore/store.c
M src/drivers/soundwire/alc1308/alc1308.c
M src/drivers/soundwire/alc5682/alc5682.c
M src/drivers/soundwire/alc711/alc711.c
M src/drivers/soundwire/cs42l42/cs42l42.c
M src/drivers/soundwire/max98363/max98363.c
M src/drivers/soundwire/max98373/max98373.c
M src/drivers/spi/boot_device_rw_nommap.c
M src/drivers/spi/cbfs_spi.c
M src/drivers/spi/issi.c
M src/drivers/spi/spi-generic.c
M src/drivers/spi/spi_flash.c
M src/drivers/spi/spi_sdcard.c
M src/drivers/spi/spiconsole.c
M src/drivers/spi/sst.c
M src/drivers/spi/tpm/tis.c
M src/drivers/spi/tpm/tpm.c
M src/drivers/spi/winbond.c
M src/drivers/tpm/ppi.c
M src/drivers/tpm/ppi_stub.c
M src/drivers/tpm/tpm.c
M src/drivers/usb/acpi/usb_acpi.c
M src/drivers/usb/ehci_debug.c
M src/drivers/usb/gadget.c
M src/drivers/usb/hub/acpi.c
M src/drivers/usb/pci_xhci/pci_xhci.c
M src/drivers/vpd/vpd.c
M src/drivers/vpd/vpd.h
M src/drivers/wifi/generic/acpi.c
M src/drivers/wwan/fm/acpi_fm350gl.c
M src/ec/51nb/npce985la0dx/npce985la0dx.c
M src/ec/compal/ene932/ec.c
M src/ec/dasharo/ec/dasharo_ec.h
M src/ec/dell/mec5035/mec5035.c
M src/ec/google/chromeec/crosec_proto.c
M src/ec/google/chromeec/ec.c
M src/ec/google/chromeec/ec.h
M src/ec/google/chromeec/ec_acpi.c
M src/ec/google/chromeec/ec_cmd_api.h
M src/ec/google/chromeec/ec_i2c.c
M src/ec/google/chromeec/ec_lpc.c
M src/ec/google/chromeec/ec_spi.c
M src/ec/google/wilco/chip.c
M src/ec/google/wilco/commands.c
M src/ec/google/wilco/ec.h
M src/ec/kontron/it8516e/ec.c
M src/ec/quanta/ene_kb3940q/ec.c
M src/ec/quanta/it8518/ec.c
M src/ec/roda/it8518/ec.c
M src/ec/starlabs/merlin/ite.c
M src/ec/starlabs/merlin/nuvoton.c
M src/ec/system76/ec/system76_ec.h
M src/include/acpi/acpi_gnvs.h
M src/include/acpi/acpigen.h
M src/include/boot/tables.h
M src/include/bootmem.h
M src/include/bootstate.h
M src/include/cbfs.h
M src/include/cbmem.h
M src/include/cpu/intel/microcode.h
M src/include/device/device.h
M src/include/device/dram/ddr2.h
M src/include/device/dram/ddr3.h
M src/include/device/i2c_bus.h
M src/include/device/resource.h
M src/include/fw_config.h
M src/include/gpio.h
M src/include/imd.h
M src/include/memory_info.h
M src/include/memrange.h
M src/include/metadata_hash.h
M src/include/nhlt.h
M src/include/spi_flash.h
M src/include/stdbool.h
M src/include/string.h
M src/include/vbe.h
M src/lib/asan.c
M src/lib/bmp_logo.c
M src/lib/boot_device.c
M src/lib/bootblock.c
M src/lib/bootmem.c
M src/lib/cbfs.c
M src/lib/cbmem_console.c
M src/lib/cbmem_stage_cache.c
M src/lib/coreboot_table.c
M src/lib/edid_fill_fb.c
M src/lib/ext_stage_cache.c
M src/lib/fit.c
M src/lib/fit_payload.c
M src/lib/fmap.c
M src/lib/fw_config.c
M src/lib/gcov-glue.c
M src/lib/gcov-io.c
M src/lib/gcov-io.h
M src/lib/gpio.c
M src/lib/hardwaremain.c
M src/lib/imd.c
M src/lib/imd_cbmem.c
M src/lib/jpeg.c
M src/lib/libgcov.c
M src/lib/malloc.c
M src/lib/memchr.c
M src/lib/memrange.c
M src/lib/metadata_hash.c
M src/lib/nhlt.c
M src/lib/prog_loaders.c
M src/lib/reg_script.c
M src/lib/rmodule.c
M src/lib/romstage_handoff.c
M src/lib/selfboot.c
M src/lib/smbios.c
M src/lib/smbios_defaults.c
M src/lib/spd_bin.c
M src/lib/spd_cache.c
M src/lib/string.c
M src/lib/thread.c
M src/lib/timer_queue.c
M src/lib/timestamp.c
M src/lib/ux_locales.c
M src/lib/xxhash.c
M src/mainboard/amd/pademelon/fan_init.c
M src/mainboard/aopen/dxplplusu/acpi_tables.c
M src/mainboard/apple/macbook21/mptable.c
M src/mainboard/asus/p2b/variants/p2b-d/mptable.c
M src/mainboard/asus/p2b/variants/p2b-ds/mptable.c
M src/mainboard/cavium/cn8100_sff_evb/mainboard.c
M src/mainboard/dell/optiplex_9020/mainboard.c
M src/mainboard/dell/snb_ivb_workstations/mainboard.c
M src/mainboard/dell/snb_ivb_workstations/sch5545_ec.c
M src/mainboard/emulation/qemu-i440fx/fw_cfg.c
M src/mainboard/emulation/qemu-i440fx/northbridge.c
M src/mainboard/emulation/qemu-sbsa/mainboard.c
M src/mainboard/facebook/fbg1701/board_mboot.h
M src/mainboard/facebook/fbg1701/board_verified_boot.c
M src/mainboard/getac/p470/mptable.c
M src/mainboard/google/asurada/mainboard.c
M src/mainboard/google/auron/variants/buddy/variant.c
M src/mainboard/google/beltino/lan.c
M src/mainboard/google/brox/variants/baseboard/brox/gpio.c
M src/mainboard/google/brox/variants/brox/fw_config.c
M src/mainboard/google/brox/variants/brox/gpio.c
M src/mainboard/google/brya/variants/anahera/fw_config.c
M src/mainboard/google/brya/variants/anahera4es/fw_config.c
M src/mainboard/google/brya/variants/aurash/fw_config.c
M src/mainboard/google/brya/variants/baseboard/brask/gpio.c
M src/mainboard/google/brya/variants/baseboard/brya/gpio.c
M src/mainboard/google/brya/variants/baseboard/brya/ramstage.c
M src/mainboard/google/brya/variants/baseboard/hades/ramstage.c
M src/mainboard/google/brya/variants/baseboard/nissa/gpio.c
M src/mainboard/google/brya/variants/baseboard/nissa/ramstage.c
M src/mainboard/google/brya/variants/baseboard/trulo/memory.c
M src/mainboard/google/brya/variants/brask/fw_config.c
M src/mainboard/google/brya/variants/brya0/fw_config.c
M src/mainboard/google/brya/variants/brya0/gpio.c
M src/mainboard/google/brya/variants/constitution/variant.c
M src/mainboard/google/brya/variants/felwinter/fw_config.c
M src/mainboard/google/brya/variants/gimble/fw_config.c
M src/mainboard/google/brya/variants/gimble4es/fw_config.c
M src/mainboard/google/brya/variants/hades/gpio.c
M src/mainboard/google/brya/variants/kano/fw_config.c
M src/mainboard/google/brya/variants/kuldax/fw_config.c
M src/mainboard/google/brya/variants/marasov/fw_config.c
M src/mainboard/google/brya/variants/marasov/variant.c
M src/mainboard/google/brya/variants/moli/fw_config.c
M src/mainboard/google/brya/variants/omnigul/variant.c
M src/mainboard/google/brya/variants/orisa/gpio.c
M src/mainboard/google/brya/variants/osiris/fw_config.c
M src/mainboard/google/brya/variants/primus/fw_config.c
M src/mainboard/google/brya/variants/redrix/fw_config.c
M src/mainboard/google/brya/variants/redrix4es/fw_config.c
M src/mainboard/google/brya/variants/skolas/fw_config.c
M src/mainboard/google/brya/variants/skolas/gpio.c
M src/mainboard/google/brya/variants/skolas4es/fw_config.c
M src/mainboard/google/brya/variants/skolas4es/gpio.c
M src/mainboard/google/brya/variants/taeko/fw_config.c
M src/mainboard/google/brya/variants/taeko4es/fw_config.c
M src/mainboard/google/brya/variants/taniks/fw_config.c
M src/mainboard/google/brya/variants/trulo/gpio.c
M src/mainboard/google/brya/variants/volmar/fw_config.c
M src/mainboard/google/brya/variants/xol/ramstage.c
M src/mainboard/google/brya/variants/yaviks/variant.c
M src/mainboard/google/brya/variants/zydron/fw_config.c
M src/mainboard/google/butterfly/mainboard.c
M src/mainboard/google/cherry/bootblock.c
M src/mainboard/google/corsola/panel_starmie.c
M src/mainboard/google/corsola/panel_wugtrio.c
M src/mainboard/google/cyan/spd/spd.c
M src/mainboard/google/daisy/memory.c
M src/mainboard/google/dedede/fw_config.c
M src/mainboard/google/dedede/variants/baseboard/gpio.c
M src/mainboard/google/dedede/variants/beadrix/gpio.c
M src/mainboard/google/dedede/variants/bugzzy/gpio.c
M src/mainboard/google/dedede/variants/bugzzy/ramstage.c
M src/mainboard/google/dedede/variants/cappy2/gpio.c
M src/mainboard/google/dedede/variants/cret/gpio.c
M src/mainboard/google/dedede/variants/cret/variant.c
M src/mainboard/google/dedede/variants/drawcia/gpio.c
M src/mainboard/google/dedede/variants/drawcia/ramstage.c
M src/mainboard/google/dedede/variants/magolor/gpio.c
M src/mainboard/google/fizz/mainboard.c
M src/mainboard/google/foster/mainboard.c
M src/mainboard/google/gale/mmu.c
M src/mainboard/google/geralt/panel.c
M src/mainboard/google/geralt/panel_ciri.c
M src/mainboard/google/geralt/panel_geralt.c
M src/mainboard/google/glados/mainboard.c
M src/mainboard/google/guybrush/variants/baseboard/gpio.c
M src/mainboard/google/guybrush/variants/guybrush/gpio.c
M src/mainboard/google/hatch/variants/akemi/variant.c
M src/mainboard/google/hatch/variants/baseboard/gpio.c
M src/mainboard/google/hatch/variants/kindred/variant.c
M src/mainboard/google/jecht/lan.c
M src/mainboard/google/kahlee/variants/careena/mainboard.c
M src/mainboard/google/kahlee/variants/treeya/audio.c
M src/mainboard/google/kukui/mainboard.c
M src/mainboard/google/kukui/panel_anx7625.c
M src/mainboard/google/kukui/panel_flapjack.c
M src/mainboard/google/kukui/panel_kakadu.c
M src/mainboard/google/kukui/panel_katsu.c
M src/mainboard/google/kukui/panel_kodama.c
M src/mainboard/google/kukui/panel_krane.c
M src/mainboard/google/kukui/panel_kukui.c
M src/mainboard/google/kukui/panel_ps8640.c
M src/mainboard/google/kukui/sdram_configs.c
M src/mainboard/google/myst/variants/baseboard/fw_config.c
M src/mainboard/google/myst/variants/baseboard/gpio.c
M src/mainboard/google/oak/mainboard.c
M src/mainboard/google/octopus/mainboard.c
M src/mainboard/google/octopus/romstage.c
M src/mainboard/google/octopus/variants/baseboard/gpio.c
M src/mainboard/google/octopus/variants/bobba/variant.c
M src/mainboard/google/octopus/variants/dood/variant.c
M src/mainboard/google/octopus/variants/fleex/variant.c
M src/mainboard/google/octopus/variants/foob/gpio.c
M src/mainboard/google/octopus/variants/foob/variant.c
M src/mainboard/google/octopus/variants/garg/variant.c
M src/mainboard/google/octopus/variants/phaser/gpio.c
M src/mainboard/google/octopus/variants/phaser/variant.c
M src/mainboard/google/peach_pit/romstage.c
M src/mainboard/google/poppy/mainboard.c
M src/mainboard/google/poppy/variants/baseboard/gpio.c
M src/mainboard/google/poppy/variants/nami/mainboard.c
M src/mainboard/google/puff/romstage.c
M src/mainboard/google/puff/variants/baseboard/gpio.c
M src/mainboard/google/rambi/mainboard.c
M src/mainboard/google/rambi/romstage.c
M src/mainboard/google/rambi/variants/ninja/lan.c
M src/mainboard/google/rambi/variants/sumo/lan.c
M src/mainboard/google/reef/mainboard.c
M src/mainboard/google/reef/variants/coral/mainboard.c
M src/mainboard/google/rex/variants/baseboard/ovis/ramstage.c
M src/mainboard/google/rex/variants/deku/ramstage.c
M src/mainboard/google/skyrim/variants/baseboard/gpio.c
M src/mainboard/google/smaug/mainboard.c
M src/mainboard/google/storm/mmu.c
M src/mainboard/google/stout/mainboard.c
M src/mainboard/google/trogdor/mainboard.c
M src/mainboard/google/volteer/fw_config.c
M src/mainboard/google/volteer/variants/baseboard/gpio.c
M src/mainboard/google/volteer/variants/drobit/gpio.c
M src/mainboard/google/volteer/variants/eldrid/gpio.c
M src/mainboard/google/volteer/variants/elemi/gpio.c
M src/mainboard/google/volteer/variants/halvor/gpio.c
M src/mainboard/google/volteer/variants/malefor/gpio.c
M src/mainboard/google/volteer/variants/terrador/gpio.c
M src/mainboard/google/volteer/variants/trondo/gpio.c
M src/mainboard/google/volteer/variants/voema/gpio.c
M src/mainboard/google/volteer/variants/volet/gpio.c
M src/mainboard/google/volteer/variants/volteer2/gpio.c
M src/mainboard/google/volteer/variants/voxel/gpio.c
M src/mainboard/google/volteer/variants/voxel/variant.c
M src/mainboard/google/zork/mainboard.c
M src/mainboard/google/zork/variants/baseboard/dalboz/fsps.c
M src/mainboard/google/zork/variants/baseboard/dalboz/gpio.c
M src/mainboard/google/zork/variants/baseboard/ramstage_common.c
M src/mainboard/google/zork/variants/baseboard/trembyle/gpio.c
M src/mainboard/google/zork/variants/dalboz/gpio.c
M src/mainboard/google/zork/variants/morphius/gpio.c
M src/mainboard/google/zork/variants/trembyle/gpio.c
M src/mainboard/ibase/mb899/mptable.c
M src/mainboard/ibm/sbp1/ramstage.c
M src/mainboard/intel/adlrvp/fw_config.c
M src/mainboard/intel/coffeelake_rvp/mainboard.c
M src/mainboard/intel/d945gclf/mptable.c
M src/mainboard/intel/glkrvp/mainboard.c
M src/mainboard/intel/harcuvar/hsio.c
M src/mainboard/intel/harcuvar/ramstage.c
M src/mainboard/intel/harcuvar/romstage.c
M src/mainboard/intel/kblrvp/ramstage.c
M src/mainboard/intel/kunimitsu/mainboard.c
M src/mainboard/intel/mtlrvp/fw_config.c
M src/mainboard/intel/shadowmountain/variants/baseboard/gpio.c
M src/mainboard/inventec/transformers/ipmi.c
M src/mainboard/kontron/986lcd-m/mainboard.c
M src/mainboard/kontron/986lcd-m/mptable.c
M src/mainboard/lenovo/t60/mptable.c
M src/mainboard/lenovo/x60/mptable.c
M src/mainboard/ocp/deltalake/ipmi.c
M src/mainboard/ocp/tiogapass/ramstage.c
M src/mainboard/ocp/tiogapass/romstage.c
M src/mainboard/opencellular/elgon/mainboard.c
M src/mainboard/pcengines/apu2/OemCustomize.c
M src/mainboard/prodrive/atlas/vpd.c
M src/mainboard/prodrive/atlas/vpd.h
M src/mainboard/prodrive/hermes/eeprom.c
M src/mainboard/prodrive/hermes/mainboard.c
M src/mainboard/protectli/vault_cml/mainboard.c
M src/mainboard/protectli/vault_ehl/romstage.c
M src/mainboard/purism/librem_cnl/romstage.c
M src/mainboard/roda/rk886ex/mptable.c
M src/mainboard/siemens/fa_ehl/mainboard.c
M src/mainboard/siemens/fa_ehl/variants/fa_ehl/mainboard.c
M src/mainboard/siemens/mc_apl1/mainboard.c
M src/mainboard/siemens/mc_apl1/variants/mc_apl1/mainboard.c
M src/mainboard/siemens/mc_apl1/variants/mc_apl3/mainboard.c
M src/mainboard/siemens/mc_apl1/variants/mc_apl5/mainboard.c
M src/mainboard/siemens/mc_apl1/variants/mc_apl6/mainboard.c
M src/mainboard/siemens/mc_ehl/mainboard.c
M src/mainboard/siemens/mc_ehl/variants/mc_ehl2/mainboard.c
M src/mainboard/siemens/mc_ehl/variants/mc_ehl3/mainboard.c
M src/mainboard/siemens/mc_ehl/variants/mc_ehl5/mainboard.c
M src/mainboard/sifive/hifive-unleashed/fixup_fdt.c
M src/mainboard/sifive/hifive-unleashed/media.c
M src/mainboard/sifive/hifive-unmatched/cbfs_spi.c
M src/mainboard/sifive/hifive-unmatched/fixup_fdt.c
M src/northbridge/amd/pi/00730F01/dimmSpd.c
M src/northbridge/amd/pi/00730F01/northbridge.c
M src/northbridge/intel/gm45/gma.c
M src/northbridge/intel/gm45/northbridge.c
M src/northbridge/intel/gm45/raminit.c
M src/northbridge/intel/haswell/broadwell_mrc/raminit.c
M src/northbridge/intel/haswell/gma.c
M src/northbridge/intel/haswell/haswell_mrc/raminit.c
M src/northbridge/intel/haswell/native_raminit/spd_bitmunching.c
M src/northbridge/intel/haswell/northbridge.c
M src/northbridge/intel/haswell/pcie.c
M src/northbridge/intel/i945/northbridge.c
M src/northbridge/intel/i945/raminit.c
M src/northbridge/intel/ironlake/gma.c
M src/northbridge/intel/ironlake/northbridge.c
M src/northbridge/intel/ironlake/raminit.c
M src/northbridge/intel/pineview/gma.c
M src/northbridge/intel/pineview/northbridge.c
M src/northbridge/intel/sandybridge/gma.c
M src/northbridge/intel/sandybridge/northbridge.c
M src/northbridge/intel/sandybridge/pcie.c
M src/northbridge/intel/sandybridge/raminit.c
M src/northbridge/intel/sandybridge/raminit_mrc.c
M src/northbridge/intel/sandybridge/raminit_native.c
M src/northbridge/intel/x4x/northbridge.c
M src/security/intel/stm/SmmStm.c
M src/security/intel/stm/SmmStm.h
M src/security/intel/stm/StmPlatformResource.c
M src/security/intel/txt/common.c
M src/security/intel/txt/getsec.c
M src/security/intel/txt/logging.c
M src/security/intel/txt/ramstage.c
M src/security/lockdown/lockdown.c
M src/security/memory/memory_clear.c
M src/security/tpm/tis.h
M src/security/tpm/tspi.h
M src/security/tpm/tspi/crtm.c
M src/security/tpm/tspi/log-tpm1.c
M src/security/tpm/tspi/log-tpm2.c
M src/security/tpm/tspi/tspi.c
M src/security/tpm/tss/tcg-1.2/tss.c
M src/security/tpm/tss/tcg-2.0/tss.c
M src/security/tpm/tss/tcg-2.0/tss_marshaling.c
M src/security/tpm/tss/tcg-2.0/tss_marshaling.h
M src/security/tpm/tss/tss.c
M src/security/tpm/tss1.h
M src/security/vboot/bootmode.c
M src/security/vboot/common.c
M src/security/vboot/secdata_tpm2.c
M src/security/vboot/vbnv_cmos.c
M src/security/vboot/vboot_common.h
M src/security/vboot/vboot_loader.c
M src/soc/amd/cezanne/chip.c
M src/soc/amd/cezanne/fch.c
M src/soc/amd/cezanne/fsp_m_params.c
M src/soc/amd/cezanne/include/soc/xhci.h
M src/soc/amd/cezanne/mca.c
M src/soc/amd/cezanne/smihandler.c
M src/soc/amd/cezanne/xhci.c
M src/soc/amd/common/block/acpi/ivrs.c
M src/soc/amd/common/block/acpi/madt.c
M src/soc/amd/common/block/acpi/pm_state.c
M src/soc/amd/common/block/acpi/tables.c
M src/soc/amd/common/block/apob/apob_cache.c
M src/soc/amd/common/block/cpu/cpu.c
M src/soc/amd/common/block/cpu/smm/finalize.c
M src/soc/amd/common/block/cpu/smm/smi_apmc.c
M src/soc/amd/common/block/cpu/update_microcode.c
M src/soc/amd/common/block/data_fabric/data_fabric_helper.c
M src/soc/amd/common/block/gpio/gpio.c
M src/soc/amd/common/block/graphics/graphics.c
M src/soc/amd/common/block/i2c/i2c.c
M src/soc/amd/common/block/include/amdblocks/agesawrapper.h
M src/soc/amd/common/block/include/amdblocks/apob_cache.h
M src/soc/amd/common/block/pci/amd_pci_util.c
M src/soc/amd/common/block/pci/pci_routing_info.c
M src/soc/amd/common/block/pci/pcie_gpp.c
M src/soc/amd/common/block/psp/psb.c
M src/soc/amd/common/block/psp/psp.c
M src/soc/amd/common/block/psp/psp_gen1.c
M src/soc/amd/common/block/psp/spl_fuse.c
M src/soc/amd/common/block/stb/stb.c
M src/soc/amd/common/block/uart/uart.c
M src/soc/amd/common/fsp/dmi.c
M src/soc/amd/common/fsp/fsp-acpi.c
M src/soc/amd/common/fsp/fsp_ccx_cppc_hob.c
M src/soc/amd/common/fsp/pci/pci_routing_info.c
M src/soc/amd/common/fsp/pci/pcie_clk_req.c
M src/soc/amd/common/fsp/preload_fsps.c
M src/soc/amd/common/pi/agesawrapper.c
M src/soc/amd/common/pi/amd_late_init.c
M src/soc/amd/common/pi/amd_resume_final.c
M src/soc/amd/common/pi/def_callouts.c
M src/soc/amd/common/pi/heapmanager.c
M src/soc/amd/common/pi/image.c
M src/soc/amd/common/pi/refcode_loader.c
M src/soc/amd/common/pi/s3_resume.c
M src/soc/amd/common/psp_verstage/boot_dev.c
M src/soc/amd/common/psp_verstage/fch.c
M src/soc/amd/common/psp_verstage/psp_verstage.c
M src/soc/amd/common/psp_verstage/vboot_crypto.c
M src/soc/amd/genoa_poc/domain.c
M src/soc/amd/genoa_poc/mca.c
M src/soc/amd/genoa_poc/smihandler.c
M src/soc/amd/glinda/chip.c
M src/soc/amd/glinda/fch.c
M src/soc/amd/glinda/fsp_m_params.c
M src/soc/amd/glinda/mca.c
M src/soc/amd/glinda/psp_verstage/chipset.c
M src/soc/amd/glinda/smihandler.c
M src/soc/amd/glinda/xhci.c
M src/soc/amd/mendocino/chip.c
M src/soc/amd/mendocino/fch.c
M src/soc/amd/mendocino/fsp_m_params.c
M src/soc/amd/mendocino/fsp_misc_data_hob.c
M src/soc/amd/mendocino/include/soc/xhci.h
M src/soc/amd/mendocino/manifest.c
M src/soc/amd/mendocino/mca.c
M src/soc/amd/mendocino/psp_verstage/chipset.c
M src/soc/amd/mendocino/smihandler.c
M src/soc/amd/mendocino/xhci.c
M src/soc/amd/phoenix/chip.c
M src/soc/amd/phoenix/fch.c
M src/soc/amd/phoenix/fsp_m_params.c
M src/soc/amd/phoenix/include/soc/xhci.h
M src/soc/amd/phoenix/mca.c
M src/soc/amd/phoenix/pci_irq_routing.c
M src/soc/amd/phoenix/psp_verstage/chipset.c
M src/soc/amd/phoenix/smihandler.c
M src/soc/amd/phoenix/xhci.c
M src/soc/amd/picasso/acpi_crat.c
M src/soc/amd/picasso/chip.c
M src/soc/amd/picasso/fch.c
M src/soc/amd/picasso/fsp_s_params.c
M src/soc/amd/picasso/mca.c
M src/soc/amd/picasso/smihandler.c
M src/soc/amd/picasso/soc_util.c
M src/soc/amd/picasso/xhci.c
M src/soc/amd/stoneyridge/BiosCallOuts.c
M src/soc/amd/stoneyridge/chip.c
M src/soc/amd/stoneyridge/fch.c
M src/soc/amd/stoneyridge/mca.c
M src/soc/amd/stoneyridge/northbridge.c
M src/soc/amd/stoneyridge/smihandler.c
M src/soc/cavium/cn81xx/ecam0.c
M src/soc/cavium/cn81xx/soc.c
M src/soc/example/min86/chip.c
M src/soc/ibm/power9/rom_media.c
M src/soc/intel/alderlake/chip.c
M src/soc/intel/alderlake/elog.c
M src/soc/intel/alderlake/finalize.c
M src/soc/intel/alderlake/fsp_params.c
M src/soc/intel/alderlake/hsphy.c
M src/soc/intel/alderlake/include/soc/pci_devs.h
M src/soc/intel/alderlake/meminit.c
M src/soc/intel/alderlake/pmc.c
M src/soc/intel/alderlake/romstage/romstage.c
M src/soc/intel/alderlake/systemagent.c
M src/soc/intel/alderlake/xhci.c
M src/soc/intel/apollolake/chip.c
M src/soc/intel/apollolake/cpu.c
M src/soc/intel/apollolake/cse.c
M src/soc/intel/apollolake/meminit_util_apl.c
M src/soc/intel/apollolake/meminit_util_glk.c
M src/soc/intel/apollolake/pmc.c
M src/soc/intel/apollolake/pnpconfig.c
M src/soc/intel/apollolake/romstage.c
M src/soc/intel/baytrail/chip.c
M src/soc/intel/baytrail/dptf.c
M src/soc/intel/baytrail/gfx.c
M src/soc/intel/baytrail/gpio.c
M src/soc/intel/baytrail/hda.c
M src/soc/intel/baytrail/lpe.c
M src/soc/intel/baytrail/perf_power.c
M src/soc/intel/baytrail/pmutil.c
M src/soc/intel/baytrail/ramstage.c
M src/soc/intel/baytrail/refcode.c
M src/soc/intel/baytrail/romstage/pmc.c
M src/soc/intel/baytrail/romstage/raminit.c
M src/soc/intel/baytrail/romstage/romstage.c
M src/soc/intel/baytrail/smihandler.c
M src/soc/intel/baytrail/southcluster.c
M src/soc/intel/braswell/acpi.c
M src/soc/intel/braswell/chip.c
M src/soc/intel/braswell/gpio.c
M src/soc/intel/braswell/lpe.c
M src/soc/intel/braswell/romstage/romstage.c
M src/soc/intel/braswell/smihandler.c
M src/soc/intel/braswell/southcluster.c
M src/soc/intel/broadwell/finalize.c
M src/soc/intel/broadwell/gma.c
M src/soc/intel/broadwell/pch/elog.c
M src/soc/intel/broadwell/pch/me.c
M src/soc/intel/broadwell/pch/me_status.c
M src/soc/intel/broadwell/pch/pcie.c
M src/soc/intel/broadwell/pch/power_state.c
M src/soc/intel/broadwell/pch/ramstage.c
M src/soc/intel/broadwell/pch/smihandler.c
M src/soc/intel/broadwell/raminit.c
M src/soc/intel/broadwell/refcode.c
M src/soc/intel/cannonlake/chip.c
M src/soc/intel/cannonlake/elog.c
M src/soc/intel/cannonlake/finalize.c
M src/soc/intel/cannonlake/fsp_params.c
M src/soc/intel/cannonlake/include/soc/pci_devs.h
M src/soc/intel/cannonlake/pmc.c
M src/soc/intel/cannonlake/romstage/fsp_params.c
M src/soc/intel/cannonlake/romstage/romstage.c
M src/soc/intel/common/basecode/debug/debug_feature.c
M src/soc/intel/common/block/acpi/acpi.c
M src/soc/intel/common/block/acpi/acpi_bert.c
M src/soc/intel/common/block/acpi/acpi_wake_source.c
M src/soc/intel/common/block/acpi/cpu_hybrid.c
M src/soc/intel/common/block/acpi/pep.c
M src/soc/intel/common/block/cpu/mp_init.c
M src/soc/intel/common/block/crashlog/crashlog.c
M src/soc/intel/common/block/cse/cse.c
M src/soc/intel/common/block/cse/cse_eop.c
M src/soc/intel/common/block/cse/cse_lite.c
M src/soc/intel/common/block/cse/cse_spec.c
M src/soc/intel/common/block/gpio/gpio.c
M src/soc/intel/common/block/graphics/early_graphics.c
M src/soc/intel/common/block/graphics/graphics.c
M src/soc/intel/common/block/gspi/gspi.c
M src/soc/intel/common/block/i2c/i2c.c
M src/soc/intel/common/block/include/intelblocks/uart.h
M src/soc/intel/common/block/include/intelblocks/xhci.h
M src/soc/intel/common/block/irq/irq.c
M src/soc/intel/common/block/memory/meminit.c
M src/soc/intel/common/block/pcie/pcie_rp.c
M src/soc/intel/common/block/pcie/rtd3/rtd3.c
M src/soc/intel/common/block/pcr/pcr.c
M src/soc/intel/common/block/pmc/pmclib.c
M src/soc/intel/common/block/scs/early_mmc.c
M src/soc/intel/common/block/smbus/smbuslib.c
M src/soc/intel/common/block/smm/smihandler.c
M src/soc/intel/common/block/systemagent/systemagent.c
M src/soc/intel/common/block/tcss/tcss.c
M src/soc/intel/common/block/uart/uart.c
M src/soc/intel/common/block/usb4/usb4.c
M src/soc/intel/common/block/usb4/xhci.c
M src/soc/intel/common/block/vtd/vtd.c
M src/soc/intel/common/block/xhci/xhci.c
M src/soc/intel/common/mma.c
M src/soc/intel/common/nhlt.c
M src/soc/intel/common/pch/lockdown/lockdown.c
M src/soc/intel/common/vbt.c
M src/soc/intel/denverton_ns/acpi.c
M src/soc/intel/denverton_ns/chip.c
M src/soc/intel/denverton_ns/fiamux.c
M src/soc/intel/denverton_ns/gpio_dnv.c
M src/soc/intel/denverton_ns/hob_display.c
M src/soc/intel/denverton_ns/hob_mem.c
M src/soc/intel/denverton_ns/include/soc/hob_mem.h
M src/soc/intel/denverton_ns/lpc.c
M src/soc/intel/denverton_ns/romstage.c
M src/soc/intel/denverton_ns/smihandler.c
M src/soc/intel/denverton_ns/uart.c
M src/soc/intel/elkhartlake/chip.c
M src/soc/intel/elkhartlake/finalize.c
M src/soc/intel/elkhartlake/include/soc/pci_devs.h
M src/soc/intel/elkhartlake/romstage/romstage.c
M src/soc/intel/jasperlake/chip.c
M src/soc/intel/jasperlake/elog.c
M src/soc/intel/jasperlake/finalize.c
M src/soc/intel/jasperlake/include/soc/pci_devs.h
M src/soc/intel/jasperlake/pmc.c
M src/soc/intel/jasperlake/romstage/romstage.c
M src/soc/intel/meteorlake/chip.c
M src/soc/intel/meteorlake/elog.c
M src/soc/intel/meteorlake/finalize.c
M src/soc/intel/meteorlake/fsp_params.c
M src/soc/intel/meteorlake/include/soc/pci_devs.h
M src/soc/intel/meteorlake/meminit.c
M src/soc/intel/meteorlake/pmc.c
M src/soc/intel/meteorlake/romstage/romstage.c
M src/soc/intel/meteorlake/systemagent.c
M src/soc/intel/meteorlake/xhci.c
M src/soc/intel/skylake/chip.c
M src/soc/intel/skylake/cpu.c
M src/soc/intel/skylake/elog.c
M src/soc/intel/skylake/finalize.c
M src/soc/intel/skylake/me.c
M src/soc/intel/skylake/pmc.c
M src/soc/intel/skylake/romstage/romstage.c
M src/soc/intel/tigerlake/chip.c
M src/soc/intel/tigerlake/crashlog_lib.c
M src/soc/intel/tigerlake/elog.c
M src/soc/intel/tigerlake/finalize.c
M src/soc/intel/tigerlake/fsp_params.c
M src/soc/intel/tigerlake/include/soc/pci_devs.h
M src/soc/intel/tigerlake/pmc.c
M src/soc/intel/tigerlake/romstage/romstage.c
M src/soc/intel/tigerlake/xhci.c
M src/soc/intel/xeon_sp/acpi.c
M src/soc/intel/xeon_sp/chip_common.c
M src/soc/intel/xeon_sp/chip_gen1.c
M src/soc/intel/xeon_sp/chip_gen6.c
M src/soc/intel/xeon_sp/cpx/chip.c
M src/soc/intel/xeon_sp/cpx/cpu.c
M src/soc/intel/xeon_sp/cpx/hob_display.c
M src/soc/intel/xeon_sp/cpx/soc_util.c
M src/soc/intel/xeon_sp/ebg/soc_xhci.c
M src/soc/intel/xeon_sp/finalize.c
M src/soc/intel/xeon_sp/gnr/cpu.c
M src/soc/intel/xeon_sp/gnr/soc_util.c
M src/soc/intel/xeon_sp/memmap.c
M src/soc/intel/xeon_sp/skx/cpu.c
M src/soc/intel/xeon_sp/skx/hob_display.c
M src/soc/intel/xeon_sp/skx/soc_util.c
M src/soc/intel/xeon_sp/smmrelocate.c
M src/soc/intel/xeon_sp/spr/chip.c
M src/soc/intel/xeon_sp/spr/cpu.c
M src/soc/intel/xeon_sp/spr/hob_display.c
M src/soc/intel/xeon_sp/spr/romstage.c
M src/soc/intel/xeon_sp/spr/soc_util.c
M src/soc/intel/xeon_sp/uncore.c
M src/soc/intel/xeon_sp/uncore_acpi.c
M src/soc/intel/xeon_sp/util.c
M src/soc/mediatek/common/display.c
M src/soc/mediatek/common/i2c.c
M src/soc/mediatek/common/memory.c
M src/soc/mediatek/common/msdc.c
M src/soc/mediatek/common/mt6315.c
M src/soc/mediatek/common/mt6359p.c
M src/soc/mediatek/common/pmic_wrap.c
M src/soc/mediatek/common/pmif.c
M src/soc/mediatek/common/rtc_mt6359p.c
M src/soc/mediatek/mt8173/pll.c
M src/soc/mediatek/mt8183/gpio.c
M src/soc/mediatek/mt8186/gpio.c
M src/soc/mediatek/mt8186/spi.c
M src/soc/mediatek/mt8188/gpio.c
M src/soc/mediatek/mt8188/spi.c
M src/soc/mediatek/mt8192/devapc.c
M src/soc/mediatek/mt8192/gpio.c
M src/soc/mediatek/mt8192/pll.c
M src/soc/mediatek/mt8192/spi.c
M src/soc/mediatek/mt8195/gpio.c
M src/soc/mediatek/mt8195/spi.c
M src/soc/nvidia/tegra/software_i2c.c
M src/soc/nvidia/tegra124/dma.c
M src/soc/nvidia/tegra124/spi.c
M src/soc/nvidia/tegra210/dma.c
M src/soc/nvidia/tegra210/dp.c
M src/soc/nvidia/tegra210/dsi.c
M src/soc/nvidia/tegra210/include/soc/console_uart.h
M src/soc/nvidia/tegra210/include/soc/funitcfg.h
M src/soc/nvidia/tegra210/include/soc/mipi_dsi.h
M src/soc/nvidia/tegra210/mipi_dsi.c
M src/soc/nvidia/tegra210/mtc.c
M src/soc/nvidia/tegra210/soc.c
M src/soc/nvidia/tegra210/spi.c
M src/soc/qualcomm/common/mmu.c
M src/soc/qualcomm/common/pcie_common.c
M src/soc/qualcomm/common/qclib.c
M src/soc/qualcomm/common/qspi.c
M src/soc/qualcomm/common/qupv3_config.c
M src/soc/qualcomm/common/qupv3_i2c.c
M src/soc/qualcomm/common/qupv3_spi.c
M src/soc/qualcomm/common/storage/sdhci_msm.c
M src/soc/qualcomm/ipq40xx/blobs_init.c
M src/soc/qualcomm/ipq40xx/include/soc/iomap.h
M src/soc/qualcomm/ipq40xx/spi.c
M src/soc/qualcomm/ipq806x/blobs_init.c
M src/soc/qualcomm/ipq806x/spi.c
M src/soc/qualcomm/ipq806x/uart.c
M src/soc/qualcomm/ipq806x/usb.c
M src/soc/qualcomm/qcs405/include/soc/iomap.h
M src/soc/qualcomm/qcs405/spi.c
M src/soc/qualcomm/sc7180/display/dsi.c
M src/soc/qualcomm/sc7180/soc.c
M src/soc/qualcomm/sc7280/display/edp_aux.c
M src/soc/qualcomm/sc7280/sdhci.c
M src/soc/qualcomm/sc7280/soc.c
M src/soc/rockchip/rk3288/software_i2c.c
M src/soc/rockchip/rk3399/display.c
M src/soc/samsung/exynos5250/alternate_cbfs.c
M src/soc/samsung/exynos5250/clock.c
M src/soc/samsung/exynos5250/gpio.c
M src/soc/samsung/exynos5420/alternate_cbfs.c
M src/soc/samsung/exynos5420/clock.c
M src/soc/samsung/exynos5420/gpio.c
M src/soc/samsung/exynos5420/spi.c
M src/soc/ti/am335x/gpio.c
M src/soc/ti/am335x/mmc.c
M src/southbridge/amd/common/amd_pci_util.c
M src/southbridge/amd/pi/hudson/lpc.c
M src/southbridge/amd/pi/hudson/pci.c
M src/southbridge/intel/bd82x6x/early_pch.c
M src/southbridge/intel/bd82x6x/me.c
M src/southbridge/intel/bd82x6x/me_common.c
M src/southbridge/intel/bd82x6x/me_smm.c
M src/southbridge/intel/bd82x6x/pcie.c
M src/southbridge/intel/bd82x6x/sata.c
M src/southbridge/intel/bd82x6x/usb_ehci.c
M src/southbridge/intel/common/smihandler.c
M src/southbridge/intel/common/spi.c
M src/southbridge/intel/i82801gx/ide.c
M src/southbridge/intel/i82801gx/pcie.c
M src/southbridge/intel/i82801gx/sata.c
M src/southbridge/intel/i82801ix/sata.c
M src/southbridge/intel/i82801jx/sata.c
M src/southbridge/intel/ibexpeak/bootblock.c
M src/southbridge/intel/ibexpeak/me.c
M src/southbridge/intel/ibexpeak/sata.c
M src/southbridge/intel/lynxpoint/early_pch.c
M src/southbridge/intel/lynxpoint/me.c
M src/southbridge/intel/lynxpoint/pcie.c
M src/southbridge/intel/lynxpoint/sata.c
M src/southbridge/intel/lynxpoint/smihandler.c
M src/superio/aspeed/ast2400/superio.c
M src/superio/common/ssdt.c
M src/superio/fintek/f71808a/superio.c
M src/superio/fintek/f71859/superio.c
M src/superio/fintek/f71863fg/superio.c
M src/superio/fintek/f71869ad/superio.c
M src/superio/fintek/f81803a/fan_control.c
M src/superio/fintek/f81865f/superio.c
M src/superio/fintek/f81866d/superio.c
M src/superio/ite/it8528e/superio.c
M src/superio/ite/it8613e/superio.c
M src/superio/ite/it8623e/superio.c
M src/superio/ite/it8629e/superio.c
M src/superio/ite/it8659e/superio.c
M src/superio/ite/it8712f/superio.c
M src/superio/ite/it8718f/superio.c
M src/superio/ite/it8720f/superio.c
M src/superio/ite/it8721f/superio.c
M src/superio/ite/it8728f/superio.c
M src/superio/ite/it8772f/superio.c
M src/superio/ite/it8783ef/superio.c
M src/superio/ite/it8784e/superio.c
M src/superio/ite/it8786e/superio.c
M src/superio/nsc/pc87382/superio.c
M src/superio/nsc/pc87384/superio.c
M src/superio/nsc/pc87392/superio.c
M src/superio/nsc/pc87417/superio.c
M src/superio/nuvoton/nct5104d/superio.c
M src/superio/nuvoton/nct5539d/superio.c
M src/superio/nuvoton/nct5572d/superio.c
M src/superio/nuvoton/nct6687d/superio.c
M src/superio/nuvoton/nct6776/superio.c
M src/superio/nuvoton/nct6779d/superio.c
M src/superio/nuvoton/nct6791d/superio.c
M src/superio/nuvoton/npcd378/superio.c
M src/superio/nuvoton/wpcm450/superio.c
M src/superio/renesas/m3885x/superio.c
M src/superio/smsc/fdc37n972/superio.c
M src/superio/smsc/kbc1100/superio.c
M src/superio/smsc/lpc47m10x/superio.c
M src/superio/smsc/lpc47m15x/superio.c
M src/superio/smsc/lpc47n217/superio.c
M src/superio/smsc/lpc47n227/superio.c
M src/superio/smsc/mec1308/superio.c
M src/superio/smsc/sch5545/superio.c
M src/superio/smsc/sch555x/ramstage.c
M src/superio/smsc/sio1036/superio.c
M src/superio/smsc/sio10n268/superio.c
M src/superio/smsc/smscsuperio/superio.c
M src/superio/winbond/w83627dhg/superio.c
M src/superio/winbond/w83627ehg/superio.c
M src/superio/winbond/w83627hf/superio.c
M src/superio/winbond/w83627thg/superio.c
M src/superio/winbond/w83627uhg/superio.c
M src/superio/winbond/w83667hg-a/superio.c
M src/superio/winbond/w83977tf/superio.c
M src/superio/winbond/wpcd376i/superio.c
M tests/Makefile.common
M tests/acpi/acpigen-test.c
M tests/commonlib/bsd/gcd-test.c
M tests/commonlib/bsd/helpers-test.c
M tests/commonlib/bsd/ipchksum-test.c
M tests/commonlib/bsd/string-test.c
M tests/commonlib/device_tree-test.c
M tests/commonlib/list-test.c
M tests/commonlib/rational-test.c
M tests/commonlib/region-test.c
M tests/console/routing-test.c
M tests/device/ddr4-test.c
M tests/device/i2c-test.c
M tests/drivers/efivars.c
M tests/lib/b64_decode-test.c
M tests/lib/bootmem-test.c
M tests/lib/cbfs-lookup-test.c
M tests/lib/cbfs-verification-test.c
M tests/lib/cbmem_console-test.c
M tests/lib/cbmem_stage_cache-test.c
M tests/lib/coreboot_table-test.c
M tests/lib/crc_byte-test.c
M tests/lib/dimm_info_util-test.c
M tests/lib/edid-test.c
M tests/lib/fmap-test.c
M tests/lib/hexstrtobin-test.c
M tests/lib/imd-test.c
M tests/lib/imd_cbmem-test.c
M tests/lib/lib-test.c
M tests/lib/libgcc-test.c
M tests/lib/lzma-test.c
M tests/lib/malloc-test.c
M tests/lib/memchr-test.c
M tests/lib/memcmp-test.c
M tests/lib/memcpy-test.c
M tests/lib/memmove-test.c
M tests/lib/memrange-test.c
M tests/lib/memset-test.c
M tests/lib/region_file-test.c
M tests/lib/rtc-test.c
M tests/lib/spd_cache-test.c
M tests/lib/stack-test.c
M tests/lib/string-test.c
M tests/lib/timestamp-test.c
M tests/lib/uuid-test.c
M tests/lib/ux_locales-test.c
M util/cbfstool/Makefile.mk
M util/cbfstool/lz4/lib/Makefile
D util/crossgcc/tarballs/.empty
M util/nvidia/Makefile.mk
M util/superiotool/Makefile
1,161 files changed, 4,479 insertions(+), 4,477 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/83585/1
--
To view, visit https://review.coreboot.org/c/coreboot/+/83585?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie21b10251d72adee93c25c34ea5387c48d341f01
Gerrit-Change-Number: 83585
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Attention is currently required from: Nicholas Sudsgaard, Paul Menzel.
Nico Huber has posted comments on this change by Nicholas Sudsgaard. ( https://review.coreboot.org/c/coreboot/+/83504?usp=email )
Change subject: southbridge/intel: Use azalia_audio_init() instead of duplicating code
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83504/comment/300c706d_8df4c2e9?us… :
PS3, Line 12: The southbridge's codect_detect() was written a long time ago and
: mentions that it was "not working yet" in the commit message. Therefore,
: I believe that the differences was due to it being a rough
: implementation and did not follow the specification exactly in some
: places (e.g. only using 4 bits for codec_mask instead of 15 bits).
> Thanks, you're right this commit message was made without much merit. I will remove it. […]
Ah, thanks, but maybe dropped a bit too much. I think Paul is right,
you should mention differences. IMO it's enough to say that there
are some(*). Just don't try to justify them.
(* if somebody is looking through the log for potential regressions,
they should be able to spot this change, that's all)
--
To view, visit https://review.coreboot.org/c/coreboot/+/83504?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie174ba29c115e3a3419362602d3e3175c9a03708
Gerrit-Change-Number: 83504
Gerrit-PatchSet: 4
Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Comment-Date: Sat, 20 Jul 2024 18:18:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Attention is currently required from: Angel Pons, Jason Glenesk, Martin L Roth.
Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83007?usp=email )
Change subject: [wip]crossgcc: Upgrade CMake from 3.28.3 to 3.30.1
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/83007?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0bb1a2a84d81ec03c4468955926f3f0c94276203
Gerrit-Change-Number: 83007
Gerrit-PatchSet: 5
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Sat, 20 Jul 2024 13:54:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Attention is currently required from: Nico Huber, Paul Menzel.
Nicholas Sudsgaard has posted comments on this change by Nicholas Sudsgaard. ( https://review.coreboot.org/c/coreboot/+/83504?usp=email )
Change subject: southbridge/intel: Use azalia_audio_init() instead of duplicating code
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83504/comment/da5ec929_3963965d?us… :
PS3, Line 12: The southbridge's codect_detect() was written a long time ago and
: mentions that it was "not working yet" in the commit message. Therefore,
: I believe that the differences was due to it being a rough
: implementation and did not follow the specification exactly in some
: places (e.g. only using 4 bits for codec_mask instead of 15 bits).
> Just digged a little deeper. The BKDG references relate […]
Thanks, you're right this commit message was made without much merit. I will remove it.
For the record, I was referring to commit a8e1168064 in the commit message.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83504?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie174ba29c115e3a3419362602d3e3175c9a03708
Gerrit-Change-Number: 83504
Gerrit-PatchSet: 4
Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Sat, 20 Jul 2024 13:15:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Attention is currently required from: Nicholas Sudsgaard, Paul Menzel.
Hello Felix Singer, Nico Huber, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83504?usp=email
to look at the new patch set (#4).
Change subject: southbridge/intel: Use azalia_audio_init() instead of duplicating code
......................................................................
southbridge/intel: Use azalia_audio_init() instead of duplicating code
Change-Id: Ie174ba29c115e3a3419362602d3e3175c9a03708
Signed-off-by: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
---
M src/southbridge/intel/i82801gx/azalia.c
M src/southbridge/intel/i82801ix/azalia.c
M src/southbridge/intel/i82801jx/azalia.c
3 files changed, 3 insertions(+), 128 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/83504/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/83504?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie174ba29c115e3a3419362602d3e3175c9a03708
Gerrit-Change-Number: 83504
Gerrit-PatchSet: 4
Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Attention is currently required from: Nicholas Sudsgaard, Paul Menzel.
Nico Huber has posted comments on this change by Nicholas Sudsgaard. ( https://review.coreboot.org/c/coreboot/+/83504?usp=email )
Change subject: southbridge/intel: Use azalia_audio_init() instead of duplicating code
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83504/comment/77055219_e8ae068b?us… :
PS3, Line 12: The southbridge's codect_detect() was written a long time ago and
: mentions that it was "not working yet" in the commit message. Therefore,
: I believe that the differences was due to it being a rough
: implementation and did not follow the specification exactly in some
: places (e.g. only using 4 bits for codec_mask instead of 15 bits).
> This awfully sounds like you are making excuses for changing the […]
Just digged a little deeper. The BKDG references relate
to [1] (except the copy-pasta ones). And the procedure
was first corrected in commit 4505948f.
Just to add some background. I think this commit should
just go in (without a wrong text wall).
[1] https://www.amd.com/content/dam/amd/en/documents/archived-tech-docs/program…
--
To view, visit https://review.coreboot.org/c/coreboot/+/83504?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie174ba29c115e3a3419362602d3e3175c9a03708
Gerrit-Change-Number: 83504
Gerrit-PatchSet: 3
Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Comment-Date: Sat, 20 Jul 2024 09:55:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>