Arthur Heymans has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/69505?usp=email )
Change subject: arch/x86/Kconfig: Move AMD stages arch to common code
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> Note that this patch accidentally enabled ARCH_SUPPORTS_CLANG for all x86 boards (even for AMD boards with ARM verstage). I uploaded CB:83594 to fix it.
This is not an accident, but intentional.
--
To view, visit https://review.coreboot.org/c/coreboot/+/69505?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I126801a1f6f523435935bb300f3e2807db347f63
Gerrit-Change-Number: 69505
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Mon, 22 Jul 2024 09:27:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Attention is currently required from: Jérémy Compostella, Karthik Ramasubramanian, Martin L Roth, Yu-Ping Wu.
Arthur Heymans has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/83594?usp=email )
Change subject: arch/x86/Kconfig: Stop building ARM verstage with clang
......................................................................
Patch Set 1: Code-Review-2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83594/comment/3579c4b9_241bb1a9?us… :
PS1, Line 9: We have never intended to build ARM verstage with clang (see CB:69701).
That was my intention though. Why is building ARM verstage with clang a problem?
--
To view, visit https://review.coreboot.org/c/coreboot/+/83594?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I033458556986ade88fb8e68499b632deae4dd419
Gerrit-Change-Number: 83594
Gerrit-PatchSet: 1
Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Mon, 22 Jul 2024 09:22:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu.
Hello Hung-Te Lin, Yidi Lin, Yu-Ping Wu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83572?usp=email
to look at the new patch set (#9).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: soc/mediatek/mt8196: Add a stub implementation of the MT8196 SoC
......................................................................
soc/mediatek/mt8196: Add a stub implementation of the MT8196 SoC
Add new folder and basic drivers for Mediatek SoC 'MT8196'.
Refer to MT8196_Chromebook_Application_Processor_Datasheet_V1.0 for
MT8196 SPEC detail.
This patch also enables UART and ARM arch timer.
TEST=saw the coreboot uart log to bootblock
BUG=b:317009620
Change-Id: I8190253ed000db879b04a806ca0bdf29c14be806
Signed-off-by: Jarried Lin <jarried.lin(a)mediatek.corp-partner.google.com>
---
A src/soc/mediatek/mt8196/Kconfig
A src/soc/mediatek/mt8196/Makefile.mk
A src/soc/mediatek/mt8196/bootblock.c
A src/soc/mediatek/mt8196/emi.c
A src/soc/mediatek/mt8196/include/soc/addressmap.h
A src/soc/mediatek/mt8196/include/soc/emi.h
A src/soc/mediatek/mt8196/include/soc/memlayout.ld
A src/soc/mediatek/mt8196/include/soc/pll.h
A src/soc/mediatek/mt8196/include/soc/spi.h
A src/soc/mediatek/mt8196/include/soc/timer.h
A src/soc/mediatek/mt8196/soc.c
A src/soc/mediatek/mt8196/spi.c
A src/soc/mediatek/mt8196/timer.c
13 files changed, 334 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/83572/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/83572?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8190253ed000db879b04a806ca0bdf29c14be806
Gerrit-Change-Number: 83572
Gerrit-PatchSet: 9
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Yu-Ping Wu has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/83564?usp=email )
Change subject: soc/amd/cezanne: Give PSP verstage 4K more space
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/cezanne/include/soc/psp_verstage_addr.h:
https://review.coreboot.org/c/coreboot/+/83564/comment/402b9251_6e38aa75?us… :
PS2, Line 20: #define PSP_VERSTAGE_STACK_START 0x42000
: #define PSP_VERSTAGE_STACK_SIZE (36K)
> The stack size and start address is a contract between PSP Bootloader and Verstage. […]
Thanks.
I don't think ARM verstage should be built with clang, which seems to be a mistake. Uploaded CB:83594.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83564?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9f53a45d67782d3e425f423d0715a45482b2edea
Gerrit-Change-Number: 83564
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 22 Jul 2024 09:01:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>
Yu-Ping Wu has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/69505?usp=email )
Change subject: arch/x86/Kconfig: Move AMD stages arch to common code
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Note that this patch accidentally enabled ARCH_SUPPORTS_CLANG for all x86 boards (even for AMD boards with ARM verstage). I uploaded CB:83594 to fix it.
--
To view, visit https://review.coreboot.org/c/coreboot/+/69505?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I126801a1f6f523435935bb300f3e2807db347f63
Gerrit-Change-Number: 69505
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Mon, 22 Jul 2024 09:00:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Yu-Ping Wu has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/83564?usp=email )
Change subject: soc/amd/cezanne: Give PSP verstage 4K more space
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/coreboot/+/83564?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: abandon
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9f53a45d67782d3e425f423d0715a45482b2edea
Gerrit-Change-Number: 83564
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Yu-Ping Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83594?usp=email )
Change subject: arch/x86/Kconfig: Stop building ARM verstage with clang
......................................................................
arch/x86/Kconfig: Stop building ARM verstage with clang
We have never intended to build ARM verstage with clang (see CB:69701).
In CB:69505, we accidentally enabled ARCH_SUPPORTS_CLANG for all
platforms with ARCH_X86 (even if VBOOT_STARTS_BEFORE_BOOTBLOCK). That
patch implicitly changed the definition of ARCH_ALL_STAGES_X86_* from
"all stages are x86" to "all stages are x86, except verstage might be
ARM". As a result, boards such as guybrush started to have
ARCH_ALL_STAGES_X86_* selected, causing ARCH_SUPPORTS_CLANG to be
selected as well.
Assume we don't want to revert CB:69505 by moving those
ARCH_*_X86_* selection back to SoC's Kconfigs. Then, in x86's Kconfig,
ARCH_SUPPORTS_CLANG should be selected only if
!VBOOT_STARTS_BEFORE_BOOTBLOCK.
Change-Id: I033458556986ade88fb8e68499b632deae4dd419
Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org>
---
M src/arch/x86/Kconfig
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/83594/1
diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig
index c0fe6dc..e23a34f 100644
--- a/src/arch/x86/Kconfig
+++ b/src/arch/x86/Kconfig
@@ -5,7 +5,7 @@
select PCI
select RELOCATABLE_MODULES
select HAVE_ASAN_IN_RAMSTAGE
- select ARCH_SUPPORTS_CLANG
+ select ARCH_SUPPORTS_CLANG if !VBOOT_STARTS_BEFORE_BOOTBLOCK
if ARCH_X86
--
To view, visit https://review.coreboot.org/c/coreboot/+/83594?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I033458556986ade88fb8e68499b632deae4dd419
Gerrit-Change-Number: 83594
Gerrit-PatchSet: 1
Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>
Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu.
Hello Hung-Te Lin, Yidi Lin, Yu-Ping Wu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83572?usp=email
to look at the new patch set (#8).
The following approvals got outdated and were removed:
Code-Review+2 by Yidi Lin, Code-Review+2 by Yu-Ping Wu, Verified+1 by build bot (Jenkins)
The change is no longer submittable: Code-Review and Verified are unsatisfied now.
Change subject: soc/mediatek/mt8196: Add a stub implementation of the MT8196 SoC
......................................................................
soc/mediatek/mt8196: Add a stub implementation of the MT8196 SoC
Add new folder and basic drivers for Mediatek SoC 'MT8196'.
Refer to MT8196_Chromebook_Application_Processor_Datasheet_V1.0 for
MT8196 SPEC detail.
This patch also enables UART and ARM arch timer.
TEST=saw the coreboot uart log to bootblock
BUG=b:317009620
Change-Id: I8190253ed000db879b04a806ca0bdf29c14be806
Signed-off-by: Jarried Lin <jarried.lin(a)mediatek.corp-partner.google.com>
---
A src/soc/mediatek/mt8196/Kconfig
A src/soc/mediatek/mt8196/Makefile.mk
A src/soc/mediatek/mt8196/bootblock.c
A src/soc/mediatek/mt8196/emi.c
A src/soc/mediatek/mt8196/include/soc/addressmap.h
A src/soc/mediatek/mt8196/include/soc/emi.h
A src/soc/mediatek/mt8196/include/soc/memlayout.ld
A src/soc/mediatek/mt8196/include/soc/pll.h
A src/soc/mediatek/mt8196/include/soc/spi.h
A src/soc/mediatek/mt8196/include/soc/timer.h
A src/soc/mediatek/mt8196/soc.c
A src/soc/mediatek/mt8196/spi.c
A src/soc/mediatek/mt8196/timer.c
13 files changed, 339 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/83572/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/83572?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8190253ed000db879b04a806ca0bdf29c14be806
Gerrit-Change-Number: 83572
Gerrit-PatchSet: 8
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>