coreboot-gerrit July 2024

coreboot-gerrit@coreboot.org

1 participants
285 discussions

[XS] Change in coreboot[main]: mb/intel/mtlrvp: Set cnvi_wifi bluetooth companion device
by Cliff Huang (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Jérémy Compostella. Cliff Huang has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/83310?usp=email ) Change subject: mb/intel/mtlrvp: Set cnvi_wifi bluetooth companion device ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/83310?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I66c9b75d2aaa1b221313b037defcd2c579fd6b61 Gerrit-Change-Number: 83310 Gerrit-PatchSet: 2 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Comment-Date: Tue, 02 Jul 2024 22:19:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: Revert "Makefile.mk: Use Walloc-size GCC option"
by Felix Held (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Elyes Haouas, Felix Singer. Felix Held has posted comments on this change by Felix Held. ( https://review.coreboot.org/c/coreboot/+/83311?usp=email ) Change subject: Revert "Makefile.mk: Use Walloc-size GCC option" ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > please see https://review.coreboot. […] ah, that one looks good, but is still marked as work in progress. would be good to have the upstream fixed soon -- To view, visit https://review.coreboot.org/c/coreboot/+/83311?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0bdc909c0e53b5353743dca521c963bbec792f7e Gerrit-Change-Number: 83311 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Uwe Poeche <uwe.poeche(a)siemens.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Tue, 02 Jul 2024 21:58:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: Revert "Makefile.mk: Use Walloc-size GCC option"
by Elyes Haouas (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Felix Held, Felix Singer. Elyes Haouas has posted comments on this change by Felix Held. ( https://review.coreboot.org/c/coreboot/+/83311?usp=email ) Change subject: Revert "Makefile.mk: Use Walloc-size GCC option" ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: please see https://review.coreboot.org/c/coreboot/+/83306 -- To view, visit https://review.coreboot.org/c/coreboot/+/83311?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0bdc909c0e53b5353743dca521c963bbec792f7e Gerrit-Change-Number: 83311 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Uwe Poeche <uwe.poeche(a)siemens.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 02 Jul 2024 21:52:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: doc/tutorial/part1.md: Remove trailing whitespace
by Elyes Haouas (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Maximilian Brune. Elyes Haouas has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83312?usp=email ) Change subject: doc/tutorial/part1.md: Remove trailing whitespace ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83312?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ife87475d367c5491807215342536e3bb0fd15a45 Gerrit-Change-Number: 83312 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Tue, 02 Jul 2024 21:45:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: Makefile.mk: Remove bc dependency
by Maximilian Brune (Code Review) 02 Jul '24

02 Jul '24

Maximilian Brune has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83313?usp=email ) Change subject: Makefile.mk: Remove bc dependency ...................................................................... Makefile.mk: Remove bc dependency bc was added as dependency in commit: 229e021110: Makefile.inc: Add left shift macro bc is not stated as dependency in our docs (e.g. package installation). If you don't have bc installed you can easily get false positives on coreboot builds. For example you build a mainboard and coreboot tells you the build succeeded, even though you don't have bc installed. This patch is from julius comment on CB:21601. Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: I6ab4bc2bd7a45e84b923d4fe7ec473e6c7db2146 --- M Makefile.mk 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/83313/1 diff --git a/Makefile.mk b/Makefile.mk index a16089d..edd01ae 100644 --- a/Makefile.mk +++ b/Makefile.mk @@ -171,7 +171,7 @@ int-multiply=$(if $(filter 1,$(words $1)),$(strip $1),$(call int-multiply,$(call _int-multiply2,$(word 1,$1),$(word 2,$1)) $(wordlist 3,$(words $1),$1))) int-divide=$(if $(filter 1,$(words $1)),$(strip $1),$(shell expr $(call _toint,$(word 1,$1)) / $(call _toint,$(word 2,$1)))) int-remainder=$(if $(filter 1,$(words $1)),$(strip $1),$(shell expr $(call _toint,$(word 1,$1)) % $(call _toint,$(word 2,$1)))) -int-shift-left=$(shell echo "$(call _toint,$(word 1, $1)) * (2 ^ $(call _toint,$(word 2, $1)))" | bc) +int-shift-left=$(shell expr $(call _toint,$(word 1, $1)) << $(call _toint,$(word 2, $1))) int-lt=$(if $(filter 1,$(words $1)),$(strip $1),$(shell expr $(call _toint,$(word 1,$1)) \< $(call _toint,$(word 2,$1)))) int-gt=$(if $(filter 1,$(words $1)),$(strip $1),$(shell expr $(call _toint,$(word 1,$1)) \> $(call _toint,$(word 2,$1)))) int-eq=$(if $(filter 1,$(words $1)),$(strip $1),$(shell expr $(call _toint,$(word 1,$1)) = $(call _toint,$(word 2,$1)))) -- To view, visit https://review.coreboot.org/c/coreboot/+/83313?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6ab4bc2bd7a45e84b923d4fe7ec473e6c7db2146 Gerrit-Change-Number: 83313 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>

1 0

[XS] Change in coreboot[main]: doc/tutorial/part1.md: Remove trailing whitespace
by Maximilian Brune (Code Review) 02 Jul '24

02 Jul '24

Maximilian Brune has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83312?usp=email ) Change subject: doc/tutorial/part1.md: Remove trailing whitespace ...................................................................... doc/tutorial/part1.md: Remove trailing whitespace Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: Ife87475d367c5491807215342536e3bb0fd15a45 --- M Documentation/tutorial/part1.md 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/83312/1 diff --git a/Documentation/tutorial/part1.md b/Documentation/tutorial/part1.md index 0500742..eea2e17 100644 --- a/Documentation/tutorial/part1.md +++ b/Documentation/tutorial/part1.md @@ -149,7 +149,7 @@ Note that this may differ depending on the revision of the coreboot source you are building from and should not be taken as the required -contents of defconfig. +contents of defconfig. ### Step 6 - Build coreboot -- To view, visit https://review.coreboot.org/c/coreboot/+/83312?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ife87475d367c5491807215342536e3bb0fd15a45 Gerrit-Change-Number: 83312 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>

1 0

[XS] Change in coreboot[main]: Makefile.mk: Use Walloc-size GCC option
by Felix Held (Code Review) 02 Jul '24

02 Jul '24

Felix Held has created a revert of this change. ( https://review.coreboot.org/c/coreboot/+/82734?usp=email ) Change subject: Makefile.mk: Use Walloc-size GCC option ...................................................................... -- To view, visit https://review.coreboot.org/c/coreboot/+/82734?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: revert Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia26dcf097db125a5a734660d08d875459179241b Gerrit-Change-Number: 82734 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Uwe Poeche <uwe.poeche(a)siemens.com>

1 0

[XS] Change in coreboot[main]: Revert "Makefile.mk: Use Walloc-size GCC option"
by Felix Held (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Elyes Haouas, Felix Singer. Hello Felix Singer, build bot (Jenkins), Elyes Haouas, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/83311?usp=email to review the following change. Change subject: Revert "Makefile.mk: Use Walloc-size GCC option" ...................................................................... Revert "Makefile.mk: Use Walloc-size GCC option" This reverts commit 6ab188ee6c99b1d9924b607d7e939d91e35014ec. This breaks the build using a slightly older toolchain that doesn't know this option yet. Change-Id: I0bdc909c0e53b5353743dca521c963bbec792f7e --- M Makefile.mk 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/83311/1 diff --git a/Makefile.mk b/Makefile.mk index 7be4685..1b658b5 100644 --- a/Makefile.mk +++ b/Makefile.mk @@ -528,7 +528,6 @@ CFLAGS_common += -Wstring-compare ifeq ($(CONFIG_COMPILER_GCC),y) CFLAGS_common += -Wold-style-declaration -CFLAGS_common += -Walloc-size # Don't add these GCC specific flags when running scan-build ifeq ($(CCC_ANALYZER_OUTPUT_FORMAT),) CFLAGS_common += -Wno-packed-not-aligned -- To view, visit https://review.coreboot.org/c/coreboot/+/83311?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0bdc909c0e53b5353743dca521c963bbec792f7e Gerrit-Change-Number: 83311 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Uwe Poeche <uwe.poeche(a)siemens.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: Makefile.mk: Use Walloc-size GCC option
by Felix Held (Code Review) 02 Jul '24

02 Jul '24

Felix Held has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/82734?usp=email ) Change subject: Makefile.mk: Use Walloc-size GCC option ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: this breaks the build when using a slightly older toolchain version -- To view, visit https://review.coreboot.org/c/coreboot/+/82734?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia26dcf097db125a5a734660d08d875459179241b Gerrit-Change-Number: 82734 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Uwe Poeche <uwe.poeche(a)siemens.com> Gerrit-Comment-Date: Tue, 02 Jul 2024 20:47:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: soc/intel/common: Add fpt_support to override CSME and HECI disables
by Sean Rhodes (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Felix Singer, Paul Menzel. Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83265?usp=email ) Change subject: soc/intel/common: Add fpt_support to override CSME and HECI disables ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: > Wouldn't it be better to document what the ME and the HECI interface can be / is used for instead of […] If users read documentation sure. I was just thinking it should be one easy option - AFAIK, CMOS options can depend/control one another and having to change two options for one thing to work isn't user friendly -- To view, visit https://review.coreboot.org/c/coreboot/+/83265?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I695fa96c5057303730492139904dfcc1d989880b Gerrit-Change-Number: 83265 Gerrit-PatchSet: 5 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 02 Jul 2024 20:00:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2024