coreboot-gerrit June 2024

coreboot-gerrit@coreboot.org

1 participants
3527 discussions

[XS] Change in coreboot[main]: (RFC) mb: source site-local mainboard Kconfig.name and Kconfig files
by Martin L Roth (Code Review) 24 Jun '24

24 Jun '24

Martin L Roth has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/83119?usp=email ) Change subject: (RFC) mb: source site-local mainboard Kconfig.name and Kconfig files ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I was told offline to continue. Since there are no objections, I'm going to go ahead. -- To view, visit https://review.coreboot.org/c/coreboot/+/83119?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4106fea7197c979e6648ebbbbaa107070c916727 Gerrit-Change-Number: 83119 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Comment-Date: Mon, 24 Jun 2024 16:41:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: Kconfig: Update FW_CONFIG Kconfig options
by Martin L Roth (Code Review) 24 Jun '24

24 Jun '24

Attention is currently required from: Julius Werner, Martin Roth, Nico Huber. Martin L Roth has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/83118?usp=email ) Change subject: Kconfig: Update FW_CONFIG Kconfig options ...................................................................... Patch Set 1: (1 comment) File src/Kconfig: https://review.coreboot.org/c/coreboot/+/83118/comment/35749dbc_e425c0c7?us… : PS1, Line 509: bool "Firmware Configuration Probing" > Agreed. […] Done. -- To view, visit https://review.coreboot.org/c/coreboot/+/83118?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icf170dc2ef790d6f5a897a9c7c2ea64033bf1dc9 Gerrit-Change-Number: 83118 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Mon, 24 Jun 2024 16:40:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Martin Roth <martin.roth(a)amd.corp-partner.google.com>

1 0

[S] Change in coreboot[main]: Kconfig: Update FW_CONFIG Kconfig options
by Martin L Roth (Code Review) 24 Jun '24

24 Jun '24

Attention is currently required from: Julius Werner, Martin L Roth, Nico Huber. Hello Julius Werner, Nico Huber, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83118?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by Nico Huber, Verified+1 by build bot (Jenkins) Change subject: Kconfig: Update FW_CONFIG Kconfig options ...................................................................... Kconfig: Update FW_CONFIG Kconfig options If a board supports FW_CONFIG or ChromeEC CBI, the options should be selected by the mainboard. These are not something that need to be a choice to enable or disable in Kconfig. The defaults are pointless, so remove them. The symbols default to no. Correct the descriptions of FW_CONFIG_SOURCE_CBFS and FW_CONFIG_SOURCE_VPD. They come after CBI and do not override any other options. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Icf170dc2ef790d6f5a897a9c7c2ea64033bf1dc9 --- M src/Kconfig 1 file changed, 8 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/83118/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83118?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icf170dc2ef790d6f5a897a9c7c2ea64033bf1dc9 Gerrit-Change-Number: 83118 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>

1 0

[XL] Change in coreboot[main]: arch/x86: Reformat C files with clang-format v16
by Martin L Roth (Code Review) 24 Jun '24

24 Jun '24

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/80012?usp=email ) Change subject: arch/x86: Reformat C files with clang-format v16 ...................................................................... Abandoned clang-format isn't ready yet. :-/ -- To view, visit https://review.coreboot.org/c/coreboot/+/80012?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibbc17201e6e964083259d0e48bfab8f4c857e677 Gerrit-Change-Number: 80012 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[M] Change in coreboot[main]: arch/riscv: Reformat C files with clang-format v16
by Martin L Roth (Code Review) 24 Jun '24

24 Jun '24

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/80011?usp=email ) Change subject: arch/riscv: Reformat C files with clang-format v16 ...................................................................... Abandoned clang-format isn't ready yet. :-/ -- To view, visit https://review.coreboot.org/c/coreboot/+/80011?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic863ec7e56f86da7f1967ac4c566bb988071d127 Gerrit-Change-Number: 80011 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[M] Change in coreboot[main]: arch/arm64: Reformat C files with clang-format v16
by Martin L Roth (Code Review) 24 Jun '24

24 Jun '24

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/80009?usp=email ) Change subject: arch/arm64: Reformat C files with clang-format v16 ...................................................................... Abandoned clang-format isn't ready yet. :-/ -- To view, visit https://review.coreboot.org/c/coreboot/+/80009?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4543a416d16d2689d7962e9bc69de4ba703495fb Gerrit-Change-Number: 80009 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[M] Change in coreboot[main]: arch/arm: Reformat C files with clang-format v16
by Martin L Roth (Code Review) 24 Jun '24

24 Jun '24

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/80008?usp=email ) Change subject: arch/arm: Reformat C files with clang-format v16 ...................................................................... Abandoned clang-format isn't ready yet. :-/ -- To view, visit https://review.coreboot.org/c/coreboot/+/80008?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icace93f70f024f8690172e030d0922973beb2727 Gerrit-Change-Number: 80008 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XL] Change in coreboot[main]: acpi: Reformat C files with clang-format v16
by Martin L Roth (Code Review) 24 Jun '24

24 Jun '24

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/80007?usp=email ) Change subject: acpi: Reformat C files with clang-format v16 ...................................................................... Abandoned clang-format isn't ready yet. :-/ -- To view, visit https://review.coreboot.org/c/coreboot/+/80007?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5814fc7f04544a4968d3328e19cf67264a5f39d8 Gerrit-Change-Number: 80007 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org>

1 0

[S] Change in coreboot[main]: arch/ppc64: Reformat C files with clang-format v16
by Martin L Roth (Code Review) 24 Jun '24

24 Jun '24

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/80010?usp=email ) Change subject: arch/ppc64: Reformat C files with clang-format v16 ...................................................................... Abandoned clang-format isn't ready yet. :-/ -- To view, visit https://review.coreboot.org/c/coreboot/+/80010?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibf53ecae41689f48601a6b3d98a67853bf350d3e Gerrit-Change-Number: 80010 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: Makefile: Update symlink target
by Martin L Roth (Code Review) 24 Jun '24

24 Jun '24

Attention is currently required from: Christian Walter, Felix Held. Martin L Roth has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/83122?usp=email ) Change subject: Makefile: Update symlink target ...................................................................... Patch Set 3: (1 comment) File Makefile: https://review.coreboot.org/c/coreboot/+/83122/comment/f5cf4247_f5cbec4c?us… : PS3, Line 494: symlink: > To help review, let me explain what's going on below. […] Marking as resolved. -- To view, visit https://review.coreboot.org/c/coreboot/+/83122?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9b0d1b5bc19556bc41ca98519390e69ea104bd1b Gerrit-Change-Number: 83122 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 24 Jun 2024 16:09:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2024