coreboot-gerrit May 2024

coreboot-gerrit@coreboot.org

1 participants
3267 discussions

[XS] Change in coreboot[main]: soc/mediatek/mt8188: Decrease OP-TEE image size from 80 MB to 70 MB
by Yu-Ping Wu (Code Review) 27 May '24

27 May '24

Attention is currently required from: Gavin Liu, Hung-Te Lin, Paul Menzel. Yu-Ping Wu has posted comments on this change by Gavin Liu. ( https://review.coreboot.org/c/coreboot/+/82634?usp=email ) Change subject: soc/mediatek/mt8188: Decrease OP-TEE image size from 80 MB to 70 MB ...................................................................... Patch Set 4: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/82634/comment/64214761_2bca4ac2?us… : PS2, Line 12: TEST=emerge-geralt coreboot > We verify this change by SVP. Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/82634?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6729e65f83ef994fe59b5bd4ed098e6d3a847695 Gerrit-Change-Number: 82634 Gerrit-PatchSet: 4 Gerrit-Owner: Gavin Liu <gavin.liu(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Gavin Liu <gavin.liu(a)mediatek.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 28 May 2024 01:35:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Gavin Liu <gavin.liu(a)mediatek.corp-partner.google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[XL] Change in coreboot[main]: ec/dasharo/ec: add support for Dasharo EC
by Felix Singer (Code Review) 27 May '24

27 May '24

Attention is currently required from: Maciej Pijanowski, Michał Kopeć, Michał Żygowski, Paul Menzel. Felix Singer has posted comments on this change by Michał Kopeć. ( https://review.coreboot.org/c/coreboot/+/82671?usp=email ) Change subject: ec/dasharo/ec: add support for Dasharo EC ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/82671/comment/158b966c_e418bd36?us… : PS1, Line 10: Dasharo-specific features will be added in subsequent commits. Please mention the coreboot commit the copy is based on. https://review.coreboot.org/c/coreboot/+/82671/comment/09b8e544_17553289?us… : PS1, Line 10: Dasharo-specific features > I think we try here to follow the current consensus in the project that has been shown and discussed […] There are already other variants of EC firmware drivers forked from the same origin in the tree. I agree it would definitely be great if vendors collaborate on EC firmware like they do on coreboot, but this is the wrong place to discuss this. So if anything, this could be a long-term approach or goal, but let's not block it for this reason. I rather want to see NovaCustom support in our tree, which should be the big picture here. Marking it as resolved. Sorry Paul. -- To view, visit https://review.coreboot.org/c/coreboot/+/82671?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic7c3d9413488026548514963eb78accc28e41e06 Gerrit-Change-Number: 82671 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Comment-Date: Mon, 27 May 2024 20:09:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[L] Change in coreboot[main]: mainboard/emulation/qemu-sbsa: Add qemu-sbsa board
by David Milosevic (Code Review) 27 May '24

27 May '24

Attention is currently required from: Angel Pons, Arthur Heymans, Benjamin Doron, Christian Walter, David Milosevic, Lean Sheng Tan, Maximilian Brune, Naresh Solanki, Patrick Rudolph. Hello Arthur Heymans, Benjamin Doron, Christian Walter, Lean Sheng Tan, Maximilian Brune, Naresh Solanki, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79086?usp=email to look at the new patch set (#15). Change subject: mainboard/emulation/qemu-sbsa: Add qemu-sbsa board ...................................................................... mainboard/emulation/qemu-sbsa: Add qemu-sbsa board Add coreboot support for qemu's sbsa-ref (Server Base System Architecture) machine (-m sbsa-ref). The qemu-sbsa coreboot port runs on EL2 and is the payload of the EL3 firmware (Arm Trusted Firmware). Note that, coreboot expects a pointer to the FDT in x0. Make sure to configure TF-A to handoff the FDT pointer. Example qemu commandline: qemu-system-aarch64 -nographic -m 2048 -M sbsa-ref \ -pflash <path/to/TFA.fd> \ -pflash <path/to/coreboot.rom> The Documentation is still a work-in-progress. Change-Id: Iacc9aaf065e0d153336cbef9a9b5b46a9eb24a53 Signed-off-by: David Milosevic <David.Milosevic(a)9elements.com> --- A Documentation/mainboard/emulation/qemu-sbsa.md A src/mainboard/emulation/qemu-sbsa/Kconfig A src/mainboard/emulation/qemu-sbsa/Kconfig.name A src/mainboard/emulation/qemu-sbsa/Makefile.mk A src/mainboard/emulation/qemu-sbsa/acpi.c A src/mainboard/emulation/qemu-sbsa/board_info.txt A src/mainboard/emulation/qemu-sbsa/bootblock.c A src/mainboard/emulation/qemu-sbsa/bootblock_custom.S A src/mainboard/emulation/qemu-sbsa/cbmem.c A src/mainboard/emulation/qemu-sbsa/chip.h A src/mainboard/emulation/qemu-sbsa/devicetree.cb A src/mainboard/emulation/qemu-sbsa/dsdt.asl A src/mainboard/emulation/qemu-sbsa/flash.fmd A src/mainboard/emulation/qemu-sbsa/include/mainboard/addressmap.h A src/mainboard/emulation/qemu-sbsa/mainboard.c A src/mainboard/emulation/qemu-sbsa/media.c A src/mainboard/emulation/qemu-sbsa/memlayout.ld A src/mainboard/emulation/qemu-sbsa/mmio.c 18 files changed, 816 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/79086/15 -- To view, visit https://review.coreboot.org/c/coreboot/+/79086?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iacc9aaf065e0d153336cbef9a9b5b46a9eb24a53 Gerrit-Change-Number: 79086 Gerrit-PatchSet: 15 Gerrit-Owner: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Attention: Naresh Solanki <naresh.solanki(a)9elements.com>

1 0

[L] Change in coreboot[main]: mainboard/emulation/qemu-sbsa: Add qemu-sbsa board
by David Milosevic (Code Review) 27 May '24

27 May '24

Attention is currently required from: Angel Pons, Arthur Heymans, Benjamin Doron, Christian Walter, David Milosevic, Lean Sheng Tan, Maximilian Brune, Naresh Solanki, Patrick Rudolph. Hello Arthur Heymans, Benjamin Doron, Christian Walter, Lean Sheng Tan, Maximilian Brune, Naresh Solanki, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79086?usp=email to look at the new patch set (#14). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: mainboard/emulation/qemu-sbsa: Add qemu-sbsa board ...................................................................... mainboard/emulation/qemu-sbsa: Add qemu-sbsa board Add coreboot support for qemu's sbsa-ref (Server Base System Architecture) machine (-m sbsa-ref). The qemu-sbsa coreboot port runs on EL2 and is the payload of the EL3 firmware (Arm Trusted Firmware). Note that, coreboot expects a pointer to the FDT in x0. Make sure to configure TF-A to handoff the FDT pointer. Example qemu commandline: qemu-system-aarch64 -nographic -m 2048 -M sbsa-ref \ -pflash <path/to/TFA.fd> \ -pflash <path/to/coreboot.rom> The Documentation is still a work-in-progress. Change-Id: Iacc9aaf065e0d153336cbef9a9b5b46a9eb24a53 Signed-off-by: David Milosevic <David.Milosevic(a)9elements.com> --- A Documentation/mainboard/emulation/qemu-sbsa.md A src/mainboard/emulation/qemu-sbsa/Kconfig A src/mainboard/emulation/qemu-sbsa/Kconfig.name A src/mainboard/emulation/qemu-sbsa/acpi.c A src/mainboard/emulation/qemu-sbsa/board_info.txt A src/mainboard/emulation/qemu-sbsa/bootblock.c A src/mainboard/emulation/qemu-sbsa/bootblock_custom.S A src/mainboard/emulation/qemu-sbsa/cbmem.c A src/mainboard/emulation/qemu-sbsa/chip.h A src/mainboard/emulation/qemu-sbsa/devicetree.cb A src/mainboard/emulation/qemu-sbsa/dsdt.asl A src/mainboard/emulation/qemu-sbsa/flash.fmd A src/mainboard/emulation/qemu-sbsa/include/mainboard/addressmap.h A src/mainboard/emulation/qemu-sbsa/mainboard.c A src/mainboard/emulation/qemu-sbsa/media.c A src/mainboard/emulation/qemu-sbsa/memlayout.ld A src/mainboard/emulation/qemu-sbsa/mmio.c 17 files changed, 793 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/79086/14 -- To view, visit https://review.coreboot.org/c/coreboot/+/79086?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iacc9aaf065e0d153336cbef9a9b5b46a9eb24a53 Gerrit-Change-Number: 79086 Gerrit-PatchSet: 14 Gerrit-Owner: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Attention: Naresh Solanki <naresh.solanki(a)9elements.com>

1 0

[L] Change in coreboot[main]: mainboard/emulation/qemu-sbsa: Add qemu-sbsa board
by David Milosevic (Code Review) 27 May '24

27 May '24

Attention is currently required from: Angel Pons, Arthur Heymans, Benjamin Doron, Christian Walter, Lean Sheng Tan, Maximilian Brune, Naresh Solanki, Patrick Rudolph. David Milosevic has posted comments on this change by David Milosevic. ( https://review.coreboot.org/c/coreboot/+/79086?usp=email ) Change subject: mainboard/emulation/qemu-sbsa: Add qemu-sbsa board ...................................................................... Patch Set 12: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/79086/comment/57e1ffa4_30b054e9?us… : PS7, Line 8: > It's not clear that coreboot is build for pflash1 and that you need another firmware in pflash0 to a […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/79086?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iacc9aaf065e0d153336cbef9a9b5b46a9eb24a53 Gerrit-Change-Number: 79086 Gerrit-PatchSet: 12 Gerrit-Owner: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Comment-Date: Mon, 27 May 2024 19:37:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com>

1 0

[L] Change in coreboot[main]: mainboard/emulation/qemu-sbsa: Add qemu-sbsa board
by David Milosevic (Code Review) 27 May '24

27 May '24

Attention is currently required from: Angel Pons, Arthur Heymans, Benjamin Doron, Christian Walter, Lean Sheng Tan, Maximilian Brune, Naresh Solanki. Hello Arthur Heymans, Benjamin Doron, Christian Walter, Lean Sheng Tan, Maximilian Brune, Naresh Solanki, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79086?usp=email to look at the new patch set (#13). Change subject: mainboard/emulation/qemu-sbsa: Add qemu-sbsa board ...................................................................... mainboard/emulation/qemu-sbsa: Add qemu-sbsa board Add coreboot support for qemu's sbsa-ref (Server Base System Architecture) machine (-m sbsa-ref). The qemu-sbsa coreboot port runs on EL2 and is the payload of the EL3 firmware (Arm Trusted Firmware). Note that, coreboot expects a pointer to the FDT in x0. Make sure to configure TF-A to handoff the FDT pointer. Example qemu commandline: qemu-system-aarch64 -nographic -m 2048 -M sbsa-ref \ -pflash <path/to/TFA.fd> \ -pflash <path/to/coreboot.rom> The Documentation is still a work-in-progress. Change-Id: Iacc9aaf065e0d153336cbef9a9b5b46a9eb24a53 Signed-off-by: David Milosevic <David.Milosevic(a)9elements.com> --- A Documentation/mainboard/emulation/qemu-sbsa.md A src/mainboard/emulation/qemu-sbsa/Kconfig A src/mainboard/emulation/qemu-sbsa/Kconfig.name A src/mainboard/emulation/qemu-sbsa/Makefile.inc A src/mainboard/emulation/qemu-sbsa/acpi.c A src/mainboard/emulation/qemu-sbsa/board_info.txt A src/mainboard/emulation/qemu-sbsa/bootblock.c A src/mainboard/emulation/qemu-sbsa/bootblock_custom.S A src/mainboard/emulation/qemu-sbsa/cbmem.c A src/mainboard/emulation/qemu-sbsa/chip.h A src/mainboard/emulation/qemu-sbsa/devicetree.cb A src/mainboard/emulation/qemu-sbsa/dsdt.asl A src/mainboard/emulation/qemu-sbsa/flash.fmd A src/mainboard/emulation/qemu-sbsa/include/mainboard/addressmap.h A src/mainboard/emulation/qemu-sbsa/mainboard.c A src/mainboard/emulation/qemu-sbsa/media.c A src/mainboard/emulation/qemu-sbsa/memlayout.ld A src/mainboard/emulation/qemu-sbsa/mmio.c 18 files changed, 816 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/79086/13 -- To view, visit https://review.coreboot.org/c/coreboot/+/79086?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iacc9aaf065e0d153336cbef9a9b5b46a9eb24a53 Gerrit-Change-Number: 79086 Gerrit-PatchSet: 13 Gerrit-Owner: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Naresh Solanki <naresh.solanki(a)9elements.com>

1 0

[L] Change in coreboot[main]: mainboard/emulation/qemu-sbsa: Add qemu-sbsa board
by David Milosevic (Code Review) 27 May '24

27 May '24

Attention is currently required from: Angel Pons, Arthur Heymans, Benjamin Doron, Christian Walter, Lean Sheng Tan, Maximilian Brune, Naresh Solanki. David Milosevic has posted comments on this change by David Milosevic. ( https://review.coreboot.org/c/coreboot/+/79086?usp=email ) Change subject: mainboard/emulation/qemu-sbsa: Add qemu-sbsa board ...................................................................... Patch Set 12: (1 comment) File src/mainboard/emulation/qemu-sbsa/Kconfig: https://review.coreboot.org/c/coreboot/+/79086/comment/36f64a5d_caa77d7a?us… : PS1, Line 5: BOARD_SPECIFIC_OPTIONS > default to SEPARATE_ROMSTAGE false? Romstage does nothing but initializing cbmem. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/79086?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iacc9aaf065e0d153336cbef9a9b5b46a9eb24a53 Gerrit-Change-Number: 79086 Gerrit-PatchSet: 12 Gerrit-Owner: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Comment-Date: Mon, 27 May 2024 19:16:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

[L] Change in coreboot[main]: mainboard/emulation/qemu-sbsa: Add qemu-sbsa board
by David Milosevic (Code Review) 27 May '24

27 May '24

Attention is currently required from: Angel Pons, Benjamin Doron, Christian Walter, David Milosevic, Lean Sheng Tan, Maximilian Brune, Naresh Solanki. Hello Arthur Heymans, Benjamin Doron, Christian Walter, Lean Sheng Tan, Maximilian Brune, Naresh Solanki, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79086?usp=email to look at the new patch set (#12). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: mainboard/emulation/qemu-sbsa: Add qemu-sbsa board ...................................................................... mainboard/emulation/qemu-sbsa: Add qemu-sbsa board Add coreboot support for qemu's sbsa-ref (Server Base System Architecture) machine (-m sbsa-ref). The Documentation is still a work-in-progress. Change-Id: Iacc9aaf065e0d153336cbef9a9b5b46a9eb24a53 Signed-off-by: David Milosevic <David.Milosevic(a)9elements.com> --- A Documentation/mainboard/emulation/qemu-sbsa.md A src/mainboard/emulation/qemu-sbsa/Kconfig A src/mainboard/emulation/qemu-sbsa/Kconfig.name A src/mainboard/emulation/qemu-sbsa/Makefile.inc A src/mainboard/emulation/qemu-sbsa/acpi.c A src/mainboard/emulation/qemu-sbsa/board_info.txt A src/mainboard/emulation/qemu-sbsa/bootblock.c A src/mainboard/emulation/qemu-sbsa/bootblock_custom.S A src/mainboard/emulation/qemu-sbsa/cbmem.c A src/mainboard/emulation/qemu-sbsa/chip.h A src/mainboard/emulation/qemu-sbsa/devicetree.cb A src/mainboard/emulation/qemu-sbsa/dsdt.asl A src/mainboard/emulation/qemu-sbsa/flash.fmd A src/mainboard/emulation/qemu-sbsa/include/mainboard/addressmap.h A src/mainboard/emulation/qemu-sbsa/mainboard.c A src/mainboard/emulation/qemu-sbsa/media.c A src/mainboard/emulation/qemu-sbsa/memlayout.ld A src/mainboard/emulation/qemu-sbsa/mmio.c 18 files changed, 816 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/79086/12 -- To view, visit https://review.coreboot.org/c/coreboot/+/79086?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iacc9aaf065e0d153336cbef9a9b5b46a9eb24a53 Gerrit-Change-Number: 79086 Gerrit-PatchSet: 12 Gerrit-Owner: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Attention: Naresh Solanki <naresh.solanki(a)9elements.com>

1 0

[XL] Change in coreboot[main]: ec/dasharo/ec: add support for Dasharo EC
by Maciej Pijanowski (Code Review) 27 May '24

27 May '24

Attention is currently required from: Michał Kopeć, Michał Żygowski, Paul Menzel. Maciej Pijanowski has posted comments on this change by Michał Kopeć. ( https://review.coreboot.org/c/coreboot/+/82671?usp=email ) Change subject: ec/dasharo/ec: add support for Dasharo EC ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/82671/comment/3ff7699e_582cc3c1?us… : PS1, Line 10: Dasharo-specific features > Won’t it be possible to work on one code base? I think we try here to follow the current consensus in the project that has been shown and discussed e.g. here: https://review.coreboot.org/c/coreboot/+/43632 https://review.coreboot.org/c/coreboot/+/52390/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/82671?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic7c3d9413488026548514963eb78accc28e41e06 Gerrit-Change-Number: 82671 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Comment-Date: Mon, 27 May 2024 17:28:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[XS] Change in coreboot[main]: mb/google/brox: Add romstage early graphics
by Sowmya Aralguppe (Code Review) 27 May '24

27 May '24

Attention is currently required from: Ashish Kumar Mishra, Karthik Ramasubramanian, Krishna P Bhat D, Paul Menzel, Shelley Chen. Sowmya Aralguppe has posted comments on this change by Sowmya Aralguppe. ( https://review.coreboot.org/c/coreboot/+/81931?usp=email ) Change subject: mb/google/brox: Add romstage early graphics ...................................................................... Patch Set 12: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/81931/comment/848d6aee_36f5c195?us… : PS11, Line 35: > One left? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/81931?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1d4795825960bc58f8f7ef494b01aa975f3bc346 Gerrit-Change-Number: 81931 Gerrit-PatchSet: 12 Gerrit-Owner: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Gerrit-Reviewer: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 27 May 2024 16:56:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2024