coreboot-gerrit May 2024

coreboot-gerrit@coreboot.org

1 participants
3267 discussions

[S] Change in coreboot[main]: spd/lp5: Add SPD for MT62F1G32D2DS-023 WT:C and K3KL8L80DM-MGCU
by Eric Lai (Code Review) 28 May '24

28 May '24

Attention is currently required from: Kun Liu, Shelley Chen. Eric Lai has posted comments on this change by Kun Liu. ( https://review.coreboot.org/c/coreboot/+/82604?usp=email ) Change subject: spd/lp5: Add SPD for MT62F1G32D2DS-023 WT:C and K3KL8L80DM-MGCU ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/82604?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic5c3ed46829330f83e144cf8d18be6fa808431aa Gerrit-Change-Number: 82604 Gerrit-PatchSet: 2 Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jian Tong <tongjian(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Tue, 28 May 2024 06:18:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: tree: Remove unused <stdarg.h>
by Natela (Code Review) 28 May '24

28 May '24

Attention is currently required from: Elyes Haouas, Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Maximilian Brune. Natela has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/82664?usp=email ) Change subject: tree: Remove unused <stdarg.h> ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: add eroupa as a text -- To view, visit https://review.coreboot.org/c/coreboot/+/82664?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I07ffc65b7feefb8ec4ab8dd268113f9ed8d24685 Gerrit-Change-Number: 82664 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: David Jones <dgjonesy(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Natela <natela113natela(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: mail(a)ninjakoa.la Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 28 May 2024 05:09:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: util/nvidia: Use c11 dialect
by Elyes Haouas (Code Review) 28 May '24

28 May '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82679?usp=email ) Change subject: util/nvidia: Use c11 dialect ...................................................................... util/nvidia: Use c11 dialect Change-Id: I75909ce85eed549d9094ba6f62d93656621d9f0d Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M util/nvidia/Makefile.mk 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/82679/1 diff --git a/util/nvidia/Makefile.mk b/util/nvidia/Makefile.mk index 04199d0..08cdfc1 100644 --- a/util/nvidia/Makefile.mk +++ b/util/nvidia/Makefile.mk @@ -42,7 +42,7 @@ CBOOTIMAGE_SRCS:=$(addprefix util/nvidia/cbootimage/src/,$(filter %.c,$(CBOOTIMAGE_RAW_SRCS))) CBOOTIMAGE_OBJS:=$(addprefix $(objutil)/nvidia/cbootimage/,$(patsubst %.c,%.o,$(filter %.c,$(CBOOTIMAGE_RAW_SRCS)))) -CBOOTIMAGE_FLAGS:=-Wall -std=c99 -O2 +CBOOTIMAGE_FLAGS:=-Wall -std=c11 -O2 ifeq ($(OS_ARCH), FreeBSD) CBOOTIMAGE_FLAGS:=-DENODATA=ENOATTR -- To view, visit https://review.coreboot.org/c/coreboot/+/82679?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I75909ce85eed549d9094ba6f62d93656621d9f0d Gerrit-Change-Number: 82679 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: util/superiotool: Use c11 dialect
by Elyes Haouas (Code Review) 28 May '24

28 May '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82678?usp=email ) Change subject: util/superiotool: Use c11 dialect ...................................................................... util/superiotool: Use c11 dialect Change-Id: Ic03d9ac883a92d52467d563f048446871b928712 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M util/superiotool/Makefile 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/82678/1 diff --git a/util/superiotool/Makefile b/util/superiotool/Makefile index fe2a4cc..39839d9 100644 --- a/util/superiotool/Makefile +++ b/util/superiotool/Makefile @@ -12,7 +12,7 @@ VERSION := -D'SUPERIOTOOL_VERSION="$(shell git describe 2>/dev/null)"' CFLAGS += -O2 -Wall -Wstrict-prototypes -Wundef -Wstrict-aliasing \ - -Werror-implicit-function-declaration -std=c99 -pedantic $(VERSION) \ + -Werror-implicit-function-declaration -std=c11 -pedantic $(VERSION) \ -Wno-variadic-macros -I $(TOP)/src/commonlib/bsd/include LDFLAGS += -lz @@ -25,7 +25,7 @@ endif ifeq ($(OS_ARCH), FreeBSD) CFLAGS = -O2 -Wall -Werror -Wstrict-prototypes -Wundef -Wstrict-aliasing \ - -Werror-implicit-function-declaration -std=c99 $(VERSION) \ + -Werror-implicit-function-declaration -std=c11 $(VERSION) \ -I/usr/local/include LDFLAGS += -L/usr/local/lib LIBS = -lz -- To view, visit https://review.coreboot.org/c/coreboot/+/82678?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic03d9ac883a92d52467d563f048446871b928712 Gerrit-Change-Number: 82678 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[S] Change in coreboot[main]: [build test] test experimental C23 dialect
by Elyes Haouas (Code Review) 28 May '24

28 May '24

Hello Jakub Czapiga, Julius Werner, Martin L Roth, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81182?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: [build test] test experimental C23 dialect ...................................................................... [build test] test experimental C23 dialect Change-Id: I177fc638a3d34d9f069734e2ee97845d2a61fcc7 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M Makefile.mk M payloads/libpayload/Makefile M payloads/libpayload/tests/Makefile.mk M src/include/stdbool.h M tests/Makefile.common M util/cbfstool/Makefile.mk M util/kconfig/Makefile M util/kconfig/qconf-cfg.sh M util/nvidia/Makefile.mk M util/superiotool/Makefile 10 files changed, 19 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/81182/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/81182?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I177fc638a3d34d9f069734e2ee97845d2a61fcc7 Gerrit-Change-Number: 81182 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: [build test] test experimental C23 dialect
by Elyes Haouas (Code Review) 28 May '24

28 May '24

Elyes Haouas has restored this change. ( https://review.coreboot.org/c/coreboot/+/81182?usp=email ) Change subject: [build test] test experimental C23 dialect ...................................................................... Restored -- To view, visit https://review.coreboot.org/c/coreboot/+/81182?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: restore Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I177fc638a3d34d9f069734e2ee97845d2a61fcc7 Gerrit-Change-Number: 81182 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: tree: Use Wcalloc-transposed-args command option
by Elyes Haouas (Code Review) 28 May '24

28 May '24

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82658?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: tree: Use Wcalloc-transposed-args command option ...................................................................... tree: Use Wcalloc-transposed-args command option GCC-14 documentation says "The first argument to calloc is documented to be number of elements in array, while the second argument is size of each element, so calloc(n, sizeof (int)) is preferred over calloc(sizeof(int), n)." Change-Id: I77b6f4d2eda487b087ba5665b588999633c33e8d Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M Makefile.mk M src/southbridge/intel/common/rcba_pirq.c 2 files changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/82658/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82658?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I77b6f4d2eda487b087ba5665b588999633c33e8d Gerrit-Change-Number: 82658 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: tree: Use Wcalloc-transposed-args command option
by Elyes Haouas (Code Review) 28 May '24

28 May '24

Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/82658?usp=email ) Change subject: tree: Use Wcalloc-transposed-args command option ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/82658?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I77b6f4d2eda487b087ba5665b588999633c33e8d Gerrit-Change-Number: 82658 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 28 May 2024 04:00:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[L] Change in coreboot[main]: mainboard/emulation/qemu-sbsa: Add qemu-sbsa board
by Elyes Haouas (Code Review) 28 May '24

28 May '24

Attention is currently required from: Angel Pons, Arthur Heymans, Benjamin Doron, Christian Walter, David Milosevic, Lean Sheng Tan, Maximilian Brune, Naresh Solanki, Patrick Rudolph. Elyes Haouas has posted comments on this change by David Milosevic. ( https://review.coreboot.org/c/coreboot/+/79086?usp=email ) Change subject: mainboard/emulation/qemu-sbsa: Add qemu-sbsa board ...................................................................... Patch Set 16: (1 comment) File src/mainboard/emulation/qemu-sbsa/dsdt.asl: https://review.coreboot.org/c/coreboot/+/79086/comment/9066ccc7_ecc53e62?us… : PS16, Line 262: Store would you please use ASL 2.0 syntax -- To view, visit https://review.coreboot.org/c/coreboot/+/79086?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iacc9aaf065e0d153336cbef9a9b5b46a9eb24a53 Gerrit-Change-Number: 79086 Gerrit-PatchSet: 16 Gerrit-Owner: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Attention: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Comment-Date: Tue, 28 May 2024 03:30:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: tree: Remove unused <stdarg.h>
by Elyes Haouas (Code Review) 28 May '24

28 May '24

Elyes Haouas has submitted this change. ( https://review.coreboot.org/c/coreboot/+/82664?usp=email ) Change subject: tree: Remove unused <stdarg.h> ...................................................................... tree: Remove unused <stdarg.h> <stdarg.h> header is used to define macros for handling variable argument lists in functions like printf. It does not depend on the string or memory manipulation functions provided by <string.h>. So let follow conventions and include only the necessary headers in each header file. Change-Id: I07ffc65b7feefb8ec4ab8dd268113f9ed8d24685 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/82664 Reviewed-by: Maximilian Brune <maximilian.brune(a)9elements.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/include/stdarg.h M src/include/string.h M src/soc/amd/common/psp_verstage/psp_verstage.c 3 files changed, 1 insertion(+), 4 deletions(-) Approvals: Maximilian Brune: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/include/stdarg.h b/src/include/stdarg.h index c5a8cd8..f55fcc3 100644 --- a/src/include/stdarg.h +++ b/src/include/stdarg.h @@ -1,8 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ /** - * Note: This file is only for POSIX compatibility, and is meant to be - * chain-included via string.h. + * Note: This file is only for POSIX compatibility. */ #ifndef STDARG_H diff --git a/src/include/string.h b/src/include/string.h index 92ea5e5..4a06556 100644 --- a/src/include/string.h +++ b/src/include/string.h @@ -3,7 +3,6 @@ #ifndef STRING_H #define STRING_H -#include <stdarg.h> /* IWYU pragma: export */ #include <stddef.h> #include <stdio.h> /* IWYU pragma: export */ diff --git a/src/soc/amd/common/psp_verstage/psp_verstage.c b/src/soc/amd/common/psp_verstage/psp_verstage.c index e71d75a..54945b9 100644 --- a/src/soc/amd/common/psp_verstage/psp_verstage.c +++ b/src/soc/amd/common/psp_verstage/psp_verstage.c @@ -21,7 +21,6 @@ #include <security/vboot/symbols.h> #include <security/vboot/vboot_common.h> #include <arch/stages.h> -#include <stdarg.h> #include <timestamp.h> extern char _bss_start, _bss_end; -- To view, visit https://review.coreboot.org/c/coreboot/+/82664?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I07ffc65b7feefb8ec4ab8dd268113f9ed8d24685 Gerrit-Change-Number: 82664 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2024